From nobody Wed Apr 8 02:53:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1773202381; cv=none; d=zohomail.com; s=zohoarc; b=Qugw1fil6UgHBeMWU7nqsARPLOR+hWjHqYIhQei6bzqrxPmYyh4ZGKjcnLBi/4hrSulJ+uYAeK6nRUBBkWLqBtwT/SZI8gK6vSEtlGxAaiKV7OUuifCgSlzxwoZmry0GM2DxNJ7Y3HVR0QsKi7WjsEN9gr4hWx8roDW3C5Ofq6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773202381; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O+dN2kXGoqOjKdDS99ZaXiN2+W4RtMQds+MjbkmGJ74=; b=l+ne+W2ld1HP/pVu7CrnZ3fc18NklLnecSFwwKbvKjwg0COWNSIjAeKFmtzXu/JiZnoiWHqulHsfaeo6lm/vDIlPmVrYIq5IH909jmAQb3Rn+MV2K0RWU34OSkaSsbLCzKWnCAyaE1/+I+UtRXUSx9zPinbRrE/8JVzbqZlYx6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773202381713952.6356620182626; Tue, 10 Mar 2026 21:13:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0AsL-0000tl-8s; Wed, 11 Mar 2026 00:08:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0AsI-0000s0-NO for qemu-devel@nongnu.org; Wed, 11 Mar 2026 00:08:46 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0AsH-000070-2Q for qemu-devel@nongnu.org; Wed, 11 Mar 2026 00:08:46 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B3Ewii248694 for ; Wed, 11 Mar 2026 04:08:44 GMT Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctqv11swx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 04:08:44 +0000 (GMT) Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-466fca9c6ebso26154691b6e.3 for ; Tue, 10 Mar 2026 21:08:44 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e5ea30asm998656fac.10.2026.03.10.21.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 21:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O+dN2kXGoqOjKdDS99ZaXiN2+W4RtMQds+MjbkmGJ74=; b=CBuqDjKwp9Ym5VG9 LAgXBS7dPftF4r1UrpcAnGZRMoAyivyzXfSjPpncrTW6a+YXKSLoFYFkW02CU/Pb QDOJxp6PfKJyT4f4Mo38GsrwdlbhpX1gdk4tfiMZ9rx6uMohOecg8ADS+76YELwR rWAwf6L+y8wNh8ThW42oUjeB+grVvjEWD+Xy1lfzjWKTFEMK8kAf+KxSpIx1UfiQ h8eZEhDiZ95Mv7bXzMeocS/O9vcHAI2otWWZMfYg48kyZK8Bxskn6B1mSXQj4C2D 8+nOdiOP8Asq4xYzZEb+/LgmStuj0IR7qqLFiJlPRGq6UY3csdaH0UhTiQnn2rQz 3wrX8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773202123; x=1773806923; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O+dN2kXGoqOjKdDS99ZaXiN2+W4RtMQds+MjbkmGJ74=; b=hKb5FB8X1cODQ0fAMJKWi0JbSwB9LQkWtkKclM0AyoXk9K+5i+9Q97mhzs5fQmBhg7 yISdj2YFAuS4mLGr4gASCfeUaQRZlyWR/KyBaG6W/Xbequ7l6F7BlNwimjuZDsxtOa6r 0CrBgqk731JDlxdE6B87Ou/1WRHrhs4WMtqHg2L4dsu0pT4jCvF90C7BtwZnRSdQtz/Q SgE1+wZiVF75/bnEoRsI93UXeZS6PcAP5sekYNamX+3P70H02v29EpGNKaeY/1mw2/B2 Nx4lEsD0t3p0bL50diFSTnCEj0eZZUN1XkwAheUVCsyCmi2+68x/bL8cOxa8YHyUY92N A8gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773202123; x=1773806923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O+dN2kXGoqOjKdDS99ZaXiN2+W4RtMQds+MjbkmGJ74=; b=avZFcby9LNZrLL83n7xC1h66YsIeNl8qgPCdIiaan29p+xBVAATrMvJDq2QNEBCJCp nQwTbom855VtgT+uLYwnHGI9ImLdPV4exNfn33IpU46dhi3Wxk/pTxbH3sbRrbyAr8ys ZTPS3GNOv1g6YlJjUDNYs1sWPjSmdLIBKqKnV+brTIM90meBtHycY2g9cyjwBDR8kRD3 6vxQR7rO5Zbb/x0QoLL9DszaLUuM4LU72fL1pC9W4J3nR+SDMCDYT1T1R2Q7HWGTw4gw lBqkVC4uCqOBQJpUv3ByBqveynnNJsGhVEcB/RWq43swkA3b7V2W0hN0VNNWfbvjgUFu 9tcg== X-Gm-Message-State: AOJu0Yy3137MqA8bzKTdiiLDt+iJ6lrKGI9XaQK1AKheDuZHTYLoaT9D x19+baiFDBYDsz5pwwUA4kj3fkqZNQjqvPNLzEBndKdMh8nGI9AUH+lEmpLDW7FNtLwKl+gWaEV KyObLw4ewh9cuJOaR23Ez9e57jXPXU9ONzKNPwaAONd3sNOVpthFBWiFCu03RxGhB8g== X-Gm-Gg: ATEYQzybXVn1DQnH7IkV4gaVZDs1EFRV91VUcfikBeDPU8Ckqy6HRQ5fwcmfSewQp66 NrNgTtbLk27kUaXyXvSP0EbnIwECxJyHQzf8cqIkNHmja1SSbrHrySeEsQdUd517koGzOzPpVE9 8JHWpJTDHtoUuWQ4d7/afwTdSUujxYqykyuj4YjkEfiHB7FiEmT6MDvr7G+BoHs2RFMhGLqpGHr cCkZz/khM45Ddg0pxmqTuI7KobQR9Wim+CGZ7cFVmPU5OcGjoSVsw4vzUkZV+3MIWmhgU2J0Qxo ptEV1IEOU3vRyBNaA4MKN+jgxezXsb3kBxZj09g8uPvnyZja81bxvoBBmbS4CKGJ2/b2vw4h7I1 qohp5QdsnpV38MQPIrHn+6Y1+qUs04QgU9lseFRWznHbPt1ntbh2cTJR0FCprysMJmxAA1Q== X-Received: by 2002:a05:6808:1815:b0:45e:dbf9:61c7 with SMTP id 5614622812f47-467335b64c5mr875816b6e.46.1773202123348; Tue, 10 Mar 2026 21:08:43 -0700 (PDT) X-Received: by 2002:a05:6808:1815:b0:45e:dbf9:61c7 with SMTP id 5614622812f47-467335b64c5mr875804b6e.46.1773202122931; Tue, 10 Mar 2026 21:08:42 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, philmd@linaro.org, ltaylorsimpson@gmail.com, matheus.bernardino@oss.qualcomm.com, marco.liebel@oss.qualcomm.com, quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, Brian Cain Subject: [PATCH v3 27/32] target/hexagon: Add TLB, k0 {un,}lock Date: Tue, 10 Mar 2026 21:07:53 -0700 Message-Id: <20260311040758.1068731-28-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260311040758.1068731-1-brian.cain@oss.qualcomm.com> References: <20260311040758.1068731-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAzMiBTYWx0ZWRfX0RpdmOHGkhCp Y0uhWEhgIf/f0GbdwPXYtxMCVxGJgX9Mw97FJHQrwSwjEY9UhNT308+1YpcJpPA2fEvLVWLnh5l WI+DX4eu2VTt6ZJX34Gays2i3MpxS95Yk1eZ4K9vLfuhJaasovjOVTdV2DUVprHhWD+n7IBJWnZ yhvM6yAO+5sSkX6Itx3IHX4faI0jBVXLorAAbSWcqw+4JvgLHCPwPjHUVS2QDIZqCqZMKViZsgS o3PyVY5UEncpE5875DVHb97FLP2kn7uwUg5YH7sfLiaxLfEzXSBaRg/ZQinELSNZolyxWAtGnko qxIJopcc0lkAHBaM/lhEYW4rspdGFdoCWllzXisPDfw7K3zTo8xgy1mPhMlIPWkY3oV4YXAGUtY sB+rODC4sqX3WENo4TGmqx5XRgW04u9n3oJLCtRFxSQk1Gp+vp/eztW7UTbXkpaW5Y3G/Lheq3x boMVknHCgI7cSt01tUQ== X-Proofpoint-GUID: RCo4sQYzzORK1RoJAoBcobwUcOwveq2w X-Authority-Analysis: v=2.4 cv=S5vUAYsP c=1 sm=1 tr=0 ts=69b0eacc cx=c_pps a=AKZTfHrQPB8q3CcvmcIuDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=5qM_0fsqfvQKBOMFAjMA:9 a=QEXdDO2ut3YA:10 a=pF_qn-MSjDawc0seGVz6:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: RCo4sQYzzORK1RoJAoBcobwUcOwveq2w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110032 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1773202383151154100 From: Brian Cain Signed-off-by: Brian Cain Reviewed-by: Taylor Simpson --- target/hexagon/sys_macros.h | 3 + target/hexagon/op_helper.c | 117 ++++++++++++++++++++++++++++++++++++ 2 files changed, 120 insertions(+) diff --git a/target/hexagon/sys_macros.h b/target/hexagon/sys_macros.h index cbc857fa2f5..37aae71adce 100644 --- a/target/hexagon/sys_macros.h +++ b/target/hexagon/sys_macros.h @@ -146,6 +146,9 @@ #define fSET_TLB_LOCK() hex_tlb_lock(env); #define fCLEAR_TLB_LOCK() hex_tlb_unlock(env); =20 +#define fSET_K0_LOCK() hex_k0_lock(env); +#define fCLEAR_K0_LOCK() hex_k0_unlock(env); + #define fTLB_IDXMASK(INDEX) \ ((INDEX) & (fPOW2_ROUNDUP( \ fCAST4u(hexagon_tlb_get_num_entries(env_archcpu(env)->tlb))) - 1)) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 1ade66df9d4..89712bf8e09 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -36,6 +36,9 @@ #include "cpu_helper.h" #include "translate.h" #ifndef CONFIG_USER_ONLY +#include "hw/hexagon/hexagon_globalreg.h" +#include "hex_mmu.h" +#include "hw/hexagon/hexagon_tlb.h" #include "hex_interrupts.h" #include "hexswi.h" #endif @@ -1232,6 +1235,120 @@ void HELPER(modify_ssr)(CPUHexagonState *env, uint3= 2_t new, uint32_t old) BQL_LOCK_GUARD(); hexagon_modify_ssr(env, new, old); } + +static void hex_k0_lock(CPUHexagonState *env) +{ + HexagonCPU *cpu =3D env_archcpu(env); + CPUState *cs =3D env_cpu(env); + target_ulong syscfg; + + BQL_LOCK_GUARD(); + g_assert((env->k0_lock_count =3D=3D 0) || (env->k0_lock_count =3D=3D 1= )); + + syscfg =3D cpu->globalregs ? + hexagon_globalreg_read(cpu->globalregs, HEX_SREG_SYSCFG, + env->threadId) : 0; + if (GET_SYSCFG_FIELD(SYSCFG_K0LOCK, syscfg)) { + if (env->k0_lock_state =3D=3D HEX_LOCK_QUEUED) { + env->next_PC +=3D 4; + env->k0_lock_count++; + env->k0_lock_state =3D HEX_LOCK_OWNER; + SET_SYSCFG_FIELD(env, SYSCFG_K0LOCK, 1); + return; + } + if (env->k0_lock_state =3D=3D HEX_LOCK_OWNER) { + qemu_log_mask(LOG_GUEST_ERROR, + "Double k0lock at PC: 0x%x, thread may hang\n", + env->next_PC); + env->next_PC +=3D 4; + cpu_interrupt(cs, CPU_INTERRUPT_HALT); + cpu_loop_exit(cs); + return; + } + env->k0_lock_state =3D HEX_LOCK_WAITING; + cpu_interrupt(cs, CPU_INTERRUPT_HALT); + cpu_loop_exit(cs); + } else { + env->next_PC +=3D 4; + env->k0_lock_count++; + env->k0_lock_state =3D HEX_LOCK_OWNER; + SET_SYSCFG_FIELD(env, SYSCFG_K0LOCK, 1); + } +} + +static void hex_k0_unlock(CPUHexagonState *env) +{ + HexagonCPU *cpu =3D env_archcpu(env); + unsigned int this_threadId =3D env->threadId; + CPUHexagonState *unlock_thread =3D NULL; + CPUState *cs; + target_ulong syscfg; + + BQL_LOCK_GUARD(); + g_assert((env->k0_lock_count =3D=3D 0) || (env->k0_lock_count =3D=3D 1= )); + + /* Nothing to do if the k0 isn't locked by this thread */ + syscfg =3D cpu->globalregs ? + hexagon_globalreg_read(cpu->globalregs, HEX_SREG_SYSCFG, + env->threadId) : 0; + if ((GET_SYSCFG_FIELD(SYSCFG_K0LOCK, syscfg) =3D=3D 0) || + (env->k0_lock_state !=3D HEX_LOCK_OWNER)) { + qemu_log_mask(LOG_GUEST_ERROR, + "thread %d attempted to unlock k0 without having the= " + "lock, k0_lock state =3D %d, syscfg:k0 =3D %d\n", + env->threadId, env->k0_lock_state, + GET_SYSCFG_FIELD(SYSCFG_K0LOCK, syscfg)); + g_assert(env->k0_lock_state !=3D HEX_LOCK_WAITING); + return; + } + + env->k0_lock_count--; + env->k0_lock_state =3D HEX_LOCK_UNLOCKED; + SET_SYSCFG_FIELD(env, SYSCFG_K0LOCK, 0); + + /* Look for a thread to unlock */ + CPU_FOREACH(cs) { + CPUHexagonState *thread =3D cpu_env(cs); + + /* + * The hardware implements round-robin fairness, so we look for th= reads + * starting at env->threadId + 1 and incrementing modulo the numbe= r of + * threads. + * + * To implement this, we check if thread is a earlier in the modulo + * sequence than unlock_thread. + * if unlock thread is higher than this thread + * thread must be between this thread and unlock_thread + * else + * thread higher than this thread is ahead of unlock_thread + * thread must be lower then unlock thread + */ + if (thread->k0_lock_state =3D=3D HEX_LOCK_WAITING) { + if (!unlock_thread) { + unlock_thread =3D thread; + } else if (unlock_thread->threadId > this_threadId) { + if (this_threadId < thread->threadId && + thread->threadId < unlock_thread->threadId) { + unlock_thread =3D thread; + } + } else { + if (thread->threadId > this_threadId) { + unlock_thread =3D thread; + } + if (thread->threadId < unlock_thread->threadId) { + unlock_thread =3D thread; + } + } + } + } + if (unlock_thread) { + cs =3D env_cpu(unlock_thread); + unlock_thread->k0_lock_state =3D HEX_LOCK_QUEUED; + SET_SYSCFG_FIELD(unlock_thread, SYSCFG_K0LOCK, 1); + cpu_interrupt(cs, CPU_INTERRUPT_K0_UNLOCK); + } + +} #endif =20 =20 --=20 2.34.1