From nobody Wed Apr 8 04:39:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1773167572; cv=none; d=zohomail.com; s=zohoarc; b=Q7tqAHj/TXaTicd/180jZ6j0zuMgPbsRE5sJHh/jlmlWwOSL5wE6szgxLRYVXn2zvrVQEETLsAs8ztzBruNO9ZIyFLitT0cJa2xZJ+WLQNyQjnn8eD25E+FI+4IfHqKcPsPHFnJaL9uRBX9G2giXDPhefMRk4if5eACma+KYb2I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773167572; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ij/BbbSlxGP9JNf8FSJsHo5Km+Y3EWVXNZBcQXu31hs=; b=HKXQiEl8PwesqhA12i6dpMnWrP4nj3pT3NBfm6O7/eRWW48YAgzDSb56OmNWSFOTKKKy1YWzyJ687vP16mH4EJP4/gCUp18dUhC9vLf0iGXyC3oF8EGO3zE5yPVdTUEqMEvlF8BL0cRdcALZ5ofq3QwsSCJWxz/5xcYDfYfca1s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773167572310456.6619910023052; Tue, 10 Mar 2026 11:32:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w01sD-00022n-4Q; Tue, 10 Mar 2026 14:32:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w01sA-00022Q-Vi for qemu-devel@nongnu.org; Tue, 10 Mar 2026 14:32:02 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w01s9-0007hC-8V for qemu-devel@nongnu.org; Tue, 10 Mar 2026 14:32:02 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2a871daa98fso98608945ad.1 for ; Tue, 10 Mar 2026 11:32:00 -0700 (PDT) Received: from localhost.localdomain ([123.19.166.13]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840b2e9dsm209437015ad.85.2026.03.10.11.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 11:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773167519; x=1773772319; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ij/BbbSlxGP9JNf8FSJsHo5Km+Y3EWVXNZBcQXu31hs=; b=EJZ5iaJPgdmN4JAD1GuCgzLesnw0EvZnXfYT6XoHE49w/y4RcxhrbFqEGDbkhjmxY3 a03c4clUNKQL5+G8EnhHc+jD2/oeMNHYiiHyAwGsctgUWtHJEc8y0SSEXb6alw/ydmNh tABS3GIcKLXyhcTIMQM17GqIw5o/P+S8TSNPA/7AchwULFDi5R1Mb69UXM0s4NdBqTZU BsjjQYFiSKaAU2Uc0moEidAZzNPi4AaIrdgh7MXq0HHEXswJC2DEvcMiiFi5ZOOUglTx /phCDBDOMd/VTfIK+awKOCkxDLT4RK/9Bc08FiTS24SYXjTcXpELoY8cGaVTCBzf8Dyp S5wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773167519; x=1773772319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ij/BbbSlxGP9JNf8FSJsHo5Km+Y3EWVXNZBcQXu31hs=; b=lxSixEmSU1e0LLkajU3h+/8bQJdaLn3mm+IWp1I2qpc9bFli0VejOA0axA5wIQj03S /wJ+dmxD0Iq8NiwV43l4T69hnn/Em3BzoRRlkytQkbFWgWTVesUSZLL7L0btkFQrbQTu BEm/4p6XHxECsHZdO4EfuN1jKaHx6rlKhXuEcB5G2ZO2krPv5HuAlQSd8h0l8vNuw5uI lzUifPi5KafH4EGPWCRNUG4HwEUy2gPe20Prwq34lGBr/x/WGuTXA7+V+WmPgBrydUJ9 AhpfOIzXU/8VOAquWQzNb0wKxIT9D9HTDY6zB9owDRt8RikKX0mqdwmVfHHKrHWPagBn wSpw== X-Gm-Message-State: AOJu0Yz/p+dD3WZ00IHSrUQlEJdHDUMOp7i4AUP+0kG+eaZ9b0SOvruj 9lnH+49HbEJAh/jxsjWZ8Hiny5KSVbR457uZ1ck1lBEzxvuoED0XRS2mE30VoLIAFOvsVQ== X-Gm-Gg: ATEYQzzxVXGHzqtAGC085GLcO5mxjVpIxWlKs1bh8BjOMiJML/yrZiNQKTXgljeW9T7 /DtBWtdmueV+3NUs9YG9iAf1qlUxCBEqKHwpWMrbC7KUTzbnQrgCyYCjia/WCK3zOb18ZeiYY7L clnMAs7p/y28V2QZMEiTXMQmEQ7cQ40B9T9woFIkhZ+UyWPnivTBlZX3bFzODTvr4kzeH94PdjW HL2z+DkxLm32dHr9D8eaBtoOOJ5fy249/5B60d9frV+oAmbgnTvbe0VhIardt9N3CAHJVPSyyEa NprqavM21LiImS6IOyKjNnnu/R2ykDD1PuK+faLp4MFn1Hn1I9+BuUkOXnEyB3XsacQZSKI9PeG SzRNzsmFeTcIbJE0D4udHImobxOd/ookSKSO318uaJOBJs95GGChcnWaQu6+f/s5ilrgfEnolyP fK/C8wd3/E2LN+ypIhB/R/avLZRUFaoI5IxJFz3MMephxZvQ== X-Received: by 2002:a17:902:ce88:b0:2ae:593c:48fe with SMTP id d9443c01a7336-2ae823cb7d1mr159888145ad.13.1773167519401; Tue, 10 Mar 2026 11:31:59 -0700 (PDT) From: Trieu Huynh X-Google-Original-From: Trieu Huynh To: qemu-devel@nongnu.org Cc: Trieu Huynh , Corey Minyard , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Frederic Konrad , Mark Cave-Ayland , Artyom Tarasenko Subject: [PATCH 2/4] hw/core/loader: fix error handling for get_image_size callers Date: Wed, 11 Mar 2026 01:27:58 +0700 Message-ID: <20260310182801.196443-3-viking4@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260310182801.196443-1-viking4@gmail.com> References: <20260310182801.196443-1-viking4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=vikingtc4@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: 15 X-Spam_score: 1.5 X-Spam_bar: + X-Spam_report: (1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1773167574721154100 Content-Type: text/plain; charset="utf-8" From: Trieu Huynh Check return value of get_image_size() and return early on failure instead of continuing with invalid state. - Use ret < 0 to handle negative return value. - No functional changes. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/413 Signed-off-by: Trieu Huynh --- hw/ipmi/ipmi_bmc_sim.c | 2 ++ hw/sparc/leon3.c | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 012e2ee4fe..fd875491f5 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -2561,6 +2561,8 @@ static void ipmi_fru_init(IPMIFru *fru) g_free(fru->data); fru->data =3D NULL; } + } else { + error_report("Could not get file size '%s'", fru->filename); } =20 out: diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 9147d56bd4..c821dfd3bb 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -354,6 +354,11 @@ static void leon3_generic_hw_init(MachineState *machin= e) } else { bios_size =3D -1; } + if (bios_size < 0) { + error_report("could not found or failed to get file size: '%s'", + filename); + exit(1); + } =20 if (bios_size > prom_size) { error_report("could not load prom '%s': file too big", filename); --=20 2.43.0