From nobody Wed Apr 8 04:25:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773160075; cv=none; d=zohomail.com; s=zohoarc; b=KZ5aKbXoY7HbyEF/15UxeF974/TK+OYTOPRdNb22m45U5T6tFiuRxK9zzaJvu+Qr0UAK2o38FrDhms6U4dk+BuhGotheaMdxOF1ur/yHNpFC0Dd9JprmBAR372oudsiqehf7T6uT5drDvDrCLBUCMd0xAZ7wYQouqvdqy47z2QQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773160075; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mhdlKPgh17Z3o9lLJY65BTZtmBO2Ej1Xu+1oTHM+Z/4=; b=K77lYPyfx6e9DNRRD5QxBB2i2tw8vo/A0wAEABeSHvg28arE1a5jnhrG0fcSLBsjpYQBgUOD/vQYERjLu78iepnQcagR8TV17nUjR+BiqjhHYIWli6i7M21uZpw/kr3Sfc8tqL1oXRw62jTpk4UlIRQdq3I/f1WUIcDbQgpLNvs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177316007503571.19308311756981; Tue, 10 Mar 2026 09:27:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzzvS-0003Wa-Lv; Tue, 10 Mar 2026 12:27:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzzvC-0003Nk-Fw for qemu-devel@nongnu.org; Tue, 10 Mar 2026 12:27:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzzvB-0000vX-4M for qemu-devel@nongnu.org; Tue, 10 Mar 2026 12:27:02 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-gRkn4m2FNGCUZcVOotNsPg-1; Tue, 10 Mar 2026 12:26:57 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5097A18002DD; Tue, 10 Mar 2026 16:26:56 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.45.224.112]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2B3A419560A6; Tue, 10 Mar 2026 16:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773160020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mhdlKPgh17Z3o9lLJY65BTZtmBO2Ej1Xu+1oTHM+Z/4=; b=gPZcYYB/BYN0BqBjbqYJF2r0ovaMq4sVRsILmpp+Tg6isG1ICtcL0SA54WMppkyuQz6t1u BwSZYYkb4L5/L8a3Llr3IenBfsLPpLOIPwUVOcSMNaXxrCp4wJfvEz9rKR0RKRSAqNd+LC Pc3FkIRAyDlE5BGRizfa9eoTOOd80Ao= X-MC-Unique: gRkn4m2FNGCUZcVOotNsPg-1 X-Mimecast-MFC-AGG-ID: gRkn4m2FNGCUZcVOotNsPg_1773160016 From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org Subject: [PULL 16/28] fuse: Drop permission changes in fuse_do_truncate Date: Tue, 10 Mar 2026 17:26:10 +0100 Message-ID: <20260310162622.333137-17-kwolf@redhat.com> In-Reply-To: <20260310162622.333137-1-kwolf@redhat.com> References: <20260310162622.333137-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773160076693154100 Content-Type: text/plain; charset="utf-8" From: Hanna Czenczek This function is always called with writable =3D=3D true. This makes add_resize_perm always false, and thus we can drop the quite ugly permission-changing code. Signed-off-by: Hanna Czenczek Message-ID: <20260309150856.26800-17-hreitz@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/export/fuse.c | 34 ++-------------------------------- 1 file changed, 2 insertions(+), 32 deletions(-) diff --git a/block/export/fuse.c b/block/export/fuse.c index af0a8de17b1..b7a710c29f8 100644 --- a/block/export/fuse.c +++ b/block/export/fuse.c @@ -503,44 +503,14 @@ static void fuse_getattr(fuse_req_t req, fuse_ino_t i= node, static int fuse_do_truncate(const FuseExport *exp, int64_t size, bool req_zero_write, PreallocMode prealloc) { - uint64_t blk_perm, blk_shared_perm; BdrvRequestFlags truncate_flags =3D 0; - bool add_resize_perm; - int ret, ret_check; - - /* Growable and writable exports have a permanent RESIZE permission */ - add_resize_perm =3D !exp->growable && !exp->writable; =20 if (req_zero_write) { truncate_flags |=3D BDRV_REQ_ZERO_WRITE; } =20 - if (add_resize_perm) { - if (!qemu_in_main_thread()) { - /* Changing permissions like below only works in the main thre= ad */ - return -EPERM; - } - - blk_get_perm(exp->common.blk, &blk_perm, &blk_shared_perm); - - ret =3D blk_set_perm(exp->common.blk, blk_perm | BLK_PERM_RESIZE, - blk_shared_perm, NULL); - if (ret < 0) { - return ret; - } - } - - ret =3D blk_truncate(exp->common.blk, size, true, prealloc, - truncate_flags, NULL); - - if (add_resize_perm) { - /* Must succeed, because we are only giving up the RESIZE permissi= on */ - ret_check =3D blk_set_perm(exp->common.blk, blk_perm, - blk_shared_perm, &error_abort); - assert(ret_check =3D=3D 0); - } - - return ret; + return blk_truncate(exp->common.blk, size, true, prealloc, + truncate_flags, NULL); } =20 /** --=20 2.53.0