From nobody Wed Apr 8 04:42:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773156891; cv=none; d=zohomail.com; s=zohoarc; b=JBJPAOmGV67+x+zCOZ+Bk5u480dtJy0fTIWIF77scrwtX/+3aXMeIc+W2aI2LMsxJc0JFBKIB+1GOP7BHGnyUwfdooWqjaUlN3aYNnn2iWJle5h7XoJBQkT4qnwgdBm1kOlBJ0ZmmJ/wcdf7IYqu2WFchcOCNvm29BIHwUEQwv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773156891; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DgItLWleYDMgqjfqaZWlaJdobsVkFs5LpuLzkjcWcM8=; b=oFwg/OhprdLLWdHFqd1KficVOuh7qiPgEl6DQXQKWE41h3ZLKFRepg4rTekHpItYJ6zg2Aj9NubUOhp/ayDLVtliBcS8EwDkdT/3D03BOhhB4MPHaFBEOmErwkyG6KfXf/5W3Ombcm7owoW6ui8WQ/ae3+qZ0da3EcZ9+4xHWtQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773156891742471.9908951168617; Tue, 10 Mar 2026 08:34:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzz5x-0002v6-BB; Tue, 10 Mar 2026 11:34:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzz5i-0002rQ-CL for qemu-devel@nongnu.org; Tue, 10 Mar 2026 11:33:52 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzz5f-0007rr-IZ for qemu-devel@nongnu.org; Tue, 10 Mar 2026 11:33:49 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-439bcec8613so7106387f8f.3 for ; Tue, 10 Mar 2026 08:33:44 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae45786sm41709388f8f.32.2026.03.10.08.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 08:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773156823; x=1773761623; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DgItLWleYDMgqjfqaZWlaJdobsVkFs5LpuLzkjcWcM8=; b=eTRSOYVS2fJnyXW0xksorvmbOlrooahpJj34AQpXvHnykDJ5EXBF6GlJUMHdzO7xbx okOhq618LNUNlBRrtUiforjbKL9PZ3slLVZCMEx+FmZxo27CBMI5Cuqw7UxqTdAB+hmP eVkm6Vt5cM+ZG1pFf753D5FvLjptmED/e791QPvOtDHYBreimBB42Mp2wgfVF6OfX2WG 86eREbKcrPL88LiesO8/QBVsVZgh0F9OadqEwmOWdqCyHtCK+VPuaPLWe2xKMToHDuZn gHJninR8Bwa7dIrPbP0fpvQYp/gIWajxDPfisaCFmAxG61DRj6OBxM5Ejc5daIO5IXSf bk+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773156823; x=1773761623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DgItLWleYDMgqjfqaZWlaJdobsVkFs5LpuLzkjcWcM8=; b=nTMcppYHDyZnCMCb0oeawe3KhJiCoZ2fMAiBsuoP7blhmwfKy7xoQ2V+1hPhP+NTj0 pzjPl6FWiAcNy3xeWoKbKgSsZVkhmbzkxJTJe9yRGcfpT25ZyewgoDtGIrPJ82eE5DAf M3uTJ/RJdSpdrKp2lKw9mIj1+AYt16xT6LN98p4h4yJEkL/+XX+f9izzFpmPk+Ilu+hf r6Pzafmsbk5NQlJco5VbyCRq0WT6xE4IS0KuDDSwCAAw7dNF4TQbr64WkvJ6xCZSx8Ud QEVGaMiCt5bcP9HbT3sLYaqqoITySojL7g/68kASq06sK5T2po+vUB5l3WIcOLKVbGxL a5KA== X-Forwarded-Encrypted: i=1; AJvYcCWvzknIM+Gu2cue7pPGnUqboEYPLkC9MyAoh06mCpYiUYbWbXGyUM77dBvcYNDufEECZEKP4Mwd8zmn@nongnu.org X-Gm-Message-State: AOJu0YyCgZtTmr+VtP6ztT3NmvRZiRDUZMDa20zsmNF7Uqxf0lFJjOQ/ 5qNhIRoPQotOSynKu+A7kK0fTxzGfUER6g2y10l1fSJRRWKA60xu0+akXLwxHTaAPwfyXwlcFRL w2En1 X-Gm-Gg: ATEYQzxS0CcPxMliA8W1B5wqi7loC2I0ldSylBAkO0SahDqB7zJZ+NiEeQqaCoee2PQ 34ISOZwt7Ria95X32i3Dl7QpSTsfa2jqD3iM73idiTR+RSiVu1CyCFREgDk45Vv8YXPRPCz0B8G hjKc06y66kqH61CA5drR4AVhNelaUxObcVdU2b6/g2C1exb7V3T5jGC5XjBJaO4q/RNwmY0A+SN kY5Y0x4jkKZXpkeDv62lg0nINLXC7Uj9jTgwtUHsZJRFeLMyKSrzjPv5PCKGgPCcBuG9IEczYsx NBb7ZKNAbr3DhYmLgT2ISXpIl3J53wPuyasoQFc2D/078gjI2bMyoyeu7B9RogzAkHsWia5hmPH rFE9OtmPeGTw8f2rEQ+UMz28y7+nRElL9rJYlgM1VNxfWqNKOKvqw3/1w+2FCS2YPfFzrgYp61T PJtdhS3+7tWmwop4a//QOOiNEjpEV1aU4whDRbtWTypIQQO9jIRTIqJXiTLCiFXzWiT7H6NMQd4 u2reSmOB8bjJ3yotqpOdW2+7r4tdo0= X-Received: by 2002:a05:6000:26c7:b0:439:b79d:b9ac with SMTP id ffacd0b85a97d-439da67c237mr25995069f8f.45.1773156822857; Tue, 10 Mar 2026 08:33:42 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley Subject: [PATCH 2/2] tests/qtest/aspeed_gpio-test: Use g_strdup_printf() instead of char arrays Date: Tue, 10 Mar 2026 15:33:34 +0000 Message-ID: <20260310153334.3063224-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260310153334.3063224-1-peter.maydell@linaro.org> References: <20260310153334.3063224-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773156894044158500 Older versions of gcc with -Wformat-overflow=3D2 don't like the usage of fixed size char arrays in this test; gcc 7.5.0 (SUSE Linux) says: ../tests/qtest/aspeed_gpio-test.c: In function =E2=80=98test_set_input_pins= =E2=80=99: ../tests/qtest/aspeed_gpio-test.c:149:36: error: =E2=80=98sprintf=E2=80=99 = may write a terminating nul past the end of the destination [-Werror=3Dform= at-overflow=3D] sprintf(name, "gpio%c%d", c, i); ^ ../tests/qtest/aspeed_gpio-test.c:149:13: note: =E2=80=98sprintf=E2=80=99 o= utput between 7 and 17 bytes into a destination of size 16 sprintf(name, "gpio%c%d", c, i); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This can't actually happen because of the limited size of the values being substituted in. However rather than require readers to check whether the arrays really have been declared large enough, we prefer to use g_strdup_printf() for this kind of string work. Reported-by: Fabiano Rosas Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/aspeed_gpio-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/aspeed_gpio-test.c b/tests/qtest/aspeed_gpio-test.c index decbba23c8..029b3731d1 100644 --- a/tests/qtest/aspeed_gpio-test.c +++ b/tests/qtest/aspeed_gpio-test.c @@ -140,13 +140,13 @@ static void test_set_colocated_pins(const void *data) static void test_set_input_pins(const void *data) { QTestState *s =3D (QTestState *)data; - char name[16]; uint32_t value; =20 qtest_writel(s, AST2600_GPIO_BASE + GPIO_ABCD_DIRECTION, 0x00000000); for (char c =3D 'A'; c <=3D 'D'; c++) { for (int i =3D 0; i < 8; i++) { - sprintf(name, "gpio%c%d", c, i); + g_autofree const char *name =3D g_strdup_printf("gpio%c%d", c,= i); + qtest_qom_set_bool(s, "/machine/soc/gpio", name, true); } } --=20 2.43.0