From nobody Wed Apr 8 04:34:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773155794; cv=none; d=zohomail.com; s=zohoarc; b=T5JnT8w7cwl/OvfB/ga/Af53SoQ0enlNojEGwEWgYWpceBqlCgRFg6P64owbj1+lV9aQ3nmTollNEXvamAgpvtWHNtFMA2Laa4zdqP81Qh094OKnpE6MOWA1MWSupBZ/pVWQ/B5JomMm+VKho4pCs1i7TH5FHLydIbfM/fE8dGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773155794; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O+WVwlwWedTKo5OWofmUZp1jp/fRrcugU2rLEnPb50c=; b=Zj4GQbR6rWKxXGAv8Dr/lxR9SlbmmtIlNL9cSjpfb63GC0zxr++d7ToxvC90PZKxKrFG4seVVzkUN5mRJgGlAkx0ao7v8sHLUhGLUby4qLW3QTnjcbDy8L3r4ZJBYsCjWL0At/ViubhnrEkYNkxC8OSNpztEFXA8dSfs9LVEQ1Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773155794817947.5979404343158; Tue, 10 Mar 2026 08:16:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzyns-00088A-LK; Tue, 10 Mar 2026 11:15:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzynk-0007PQ-IX for qemu-devel@nongnu.org; Tue, 10 Mar 2026 11:15:16 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzyni-0000Tk-5W for qemu-devel@nongnu.org; Tue, 10 Mar 2026 11:15:16 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-439b9cf8cb5so8605264f8f.0 for ; Tue, 10 Mar 2026 08:15:13 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4853588758fsm127303185e9.4.2026.03.10.08.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 08:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773155712; x=1773760512; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O+WVwlwWedTKo5OWofmUZp1jp/fRrcugU2rLEnPb50c=; b=XwxNeBlapUzZ6KykvqRNxbIIVRFMsMaz606xBwe23FcUFsWA9I1d8Ff8JGRaK17l07 qNwrgi/bUCiGyEYKanTiVP5ca6kjOXtLTB0gGzvR5vDVlx/ov8kP2kzKulGVNAXICdNY rAT4BpDKHQ+zOVK3bFOCu3kxkgWKUVXySF+MRW2YpZvGj2+7K+5SKSpGpCOsQKpzBFt2 bHLaNXe/nt5uyQbLMDadqv4hnG3/sQfRcWhBD1HJporxUsz3eO4xQtH4sDP7eVDkli8P /mViPztEsOqiDk1zlt6/aSdBXLGS5B9FkwuaorAbx2OzOLPV9GA+s0z85CdxsDplfx8C xIQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773155712; x=1773760512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O+WVwlwWedTKo5OWofmUZp1jp/fRrcugU2rLEnPb50c=; b=OwBE5fUl8V1JPBQhZD/R5/P6Hcvrv6nytQFCALKq2/CtRQR8fGwafqe8xB5NpmClwE 7Zzh4SSdLBVaHzHPBAj1F0K3n1D0BLssvaHOBoI+ktrJCuUYkAoVAwiJ8Irrmt3INWM4 rFZRp+BiQGmkvWIU1a0abbg3iE0T1+rHF++3yWZ4gX8jk6KyhB6xw38H3+M0SlIlm0wD OzmLmBlD36ZaG3JVM8glkxnn0igKZBWBsclskbY24dZa78EisBLoO0dBKoy/tlG0gqQ8 Cc5BiNIipYvNB2rUOapEoOJ92MCa1cp/0TEDjj1Hcd5Btn2sBWEIj4lxrtfjKlW2E1IW H6Yw== X-Forwarded-Encrypted: i=1; AJvYcCV7ww/YNZtsb1BfCugW8CpjY8RzpZu+2dZ8/2O0Pf0ZVe4neKJ2NxITJCHzZwwKmzH9uaGSfgQGYSxt@nongnu.org X-Gm-Message-State: AOJu0Yy5WlOoZJzF1aZ+x0OJnGmSCEaa6iws7f3yh6cLrNHTgjVOXBLW NzC0UkmEWkDKCuBkbkSw8f5+rC4cA/lXj6Fjo/TG1Yd9dVJnEigqRbcKS4M6xnG0Foo= X-Gm-Gg: ATEYQzwe6OI8UNJn/mD1m8StQu2iQAXBJoqiRdGhHl5FTwOWnkTMh7a4Nx6buwLo3dh Hlml3xwpHuAGWT+V74UpfKwdevoa8S0MiCYtHfxtkoplOLx9K3E+5xleifqqhAGCSphx/fSkuZS esLuDAGFVPJ9GnnufgWpq2As60uPLYZbbvISko1AULcKJmfrJZhDjUX9plTZUoEt64e/4D0Yjmm TFaaxCw6lA0eDPnMv41W1XxKTXrYRwZMFMh1JyoVFAxLSuSohLFOxLYHk9BdsG5B+6bciSL1ITi eC0TO5m/M9RzjH+FKld0G1od2pu3sVBVCYlSYxkFD5K8jKIf7jU2H5sDaXILdvg7hrW+h8HyhAw 7XSqP1UPCWOmgbdMxItofNkmaOH5ojL6L3bvDu0Quew1bafKh1TS0TwhcRL0EQ9O5E5YgV9reIs hPYn5Qp2yEnf6c70Q1xhhHN9nHOlJbt0vu76ZcaDepXbCyY8xaJeXjyVFB0r0pTHHuFyec4NrYM YIwIRRF0B4/Y9u7UbEhQkMg/5TGr9+RL0twTAQ6Fg== X-Received: by 2002:a05:600c:4e45:b0:485:4100:1eee with SMTP id 5b1f17b1804b1-485410020ffmr75077065e9.24.1773155711470; Tue, 10 Mar 2026 08:15:11 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley Subject: [PATCH 2/2] tests/qtest/arm-cpu-features: Use g_strdup_printf() instead of char arrays Date: Tue, 10 Mar 2026 15:15:07 +0000 Message-ID: <20260310151507.2973843-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260310151507.2973843-1-peter.maydell@linaro.org> References: <20260310151507.2973843-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773155797087154100 Older versions of gcc with -Wformat-overflow=3D2 don't like the usage of fixed size char arrays in this test; gcc 7.5.0 (SUSE Linux) says: ../tests/qtest/arm-cpu-features.c: In function =E2=80=98test_query_cpu_mode= l_expansion_kvm=E2=80=99: ../tests/qtest/arm-cpu-features.c:578:35: error: =E2=80=98%u=E2=80=99 direc= tive writing between 1 and 10 bytes into a region of size 5 [-Werror=3Dformat-overflow=3D] These can't actually happen because of the limited size of the values being substituted in. However rather than require readers to check whether the arrays really have been declared large enough, we prefer to use g_strdup_printf() for this kind of string work. Reported-by: Fabiano Rosas Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/arm-cpu-features.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c index eb8ddebffb..5444e4d40b 100644 --- a/tests/qtest/arm-cpu-features.c +++ b/tests/qtest/arm-cpu-features.c @@ -519,7 +519,6 @@ static void test_query_cpu_model_expansion_kvm(const vo= id *data) bool kvm_supports_pmu; bool kvm_supports_steal_time; bool kvm_supports_sve; - char max_name[8], name[8]; uint32_t max_vq, vq; uint64_t vls; QDict *resp; @@ -573,9 +572,12 @@ static void test_query_cpu_model_expansion_kvm(const v= oid *data) } =20 if (kvm_supports_sve) { + g_autofree const char *max_name =3D NULL; + g_autofree const char *name =3D NULL; + g_assert(vls !=3D 0); max_vq =3D 64 - __builtin_clzll(vls); - sprintf(max_name, "sve%u", max_vq * 128); + max_name =3D g_strdup_printf("sve%u", max_vq * 128); =20 /* Enabling a supported length is of course fine. */ assert_sve_vls(qts, "host", vls, "{ %s: true }", max_name); @@ -583,6 +585,9 @@ static void test_query_cpu_model_expansion_kvm(const vo= id *data) /* Get the next supported length smaller than max-vq. */ vq =3D 64 - __builtin_clzll(vls & ~BIT_ULL(max_vq - 1)); if (vq) { + g_autofree const char *name2 =3D + g_strdup_printf("sve%u", vq * 128); + /* * We have at least one length smaller than max-vq, * so we can disable max-vq. @@ -595,11 +600,10 @@ static void test_query_cpu_model_expansion_kvm(const = void *data) * unless all larger, supported vector lengths are also * disabled. */ - sprintf(name, "sve%u", vq * 128); - error =3D g_strdup_printf("cannot disable %s", name); + error =3D g_strdup_printf("cannot disable %s", name2); assert_error(qts, "host", error, "{ %s: true, %s: false }", - max_name, name); + max_name, name2); g_free(error); } =20 @@ -608,7 +612,7 @@ static void test_query_cpu_model_expansion_kvm(const vo= id *data) * we need at least one vector length enabled. */ vq =3D __builtin_ffsll(vls); - sprintf(name, "sve%u", vq * 128); + name =3D g_strdup_printf(name, "sve%u", vq * 128); error =3D g_strdup_printf("cannot disable %s", name); assert_error(qts, "host", error, "{ %s: false }", name); g_free(error); @@ -620,9 +624,11 @@ static void test_query_cpu_model_expansion_kvm(const v= oid *data) } } if (vq <=3D SVE_MAX_VQ) { - sprintf(name, "sve%u", vq * 128); - error =3D g_strdup_printf("cannot enable %s", name); - assert_error(qts, "host", error, "{ %s: true }", name); + g_autofree const char *name2 =3D + g_strdup_printf("sve%u", vq * 128); + + error =3D g_strdup_printf("cannot enable %s", name2); + assert_error(qts, "host", error, "{ %s: true }", name2); g_free(error); } } else { --=20 2.43.0