From nobody Sat Apr 11 20:14:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773148958; cv=none; d=zohomail.com; s=zohoarc; b=W48o95WvAFkVY3Y8dP8wtshBRXO1+1btJdPmNGInRW90afKXSWlXm59zxoB+OE2pYDjPLpJQx/k0bVdw+Qsdr1lBNRygA3wYJ7wDIP7jR0B+wxU8KwMIfzI1Pqs31Fi0IZp+AB9gs5cJUVrMY5PI44OHEkwH82qKKmoIsHrDcyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773148958; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9ofQ4nmwEu3wL7Z0Aby5YaVlITUvrkllN4FHvtGxenI=; b=ldDogUtDurbXYipdMTJrYvF3TdzoHhaaFoubD1lNg/rbMlshqRj3nAmtNjZPdE/f8jC+kRtmnhbR0v+F58/dxzBAxfeKNy+P4sgz1KYs+XUPDEqNyxD1aK59ax20bsA+HVGlly1Tvt6tP7dPSZOf31YmSM/USWChP8YTiiYY6nM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773148958087881.4836908759419; Tue, 10 Mar 2026 06:22:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzx2G-00089X-KX; Tue, 10 Mar 2026 09:22:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzx2E-00088i-Ep for qemu-devel@nongnu.org; Tue, 10 Mar 2026 09:22:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzx2C-0006Uf-Ct for qemu-devel@nongnu.org; Tue, 10 Mar 2026 09:22:06 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-GtC0Yw3fMlOGmRVcTOWRpQ-1; Tue, 10 Mar 2026 09:21:59 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A194E1956050; Tue, 10 Mar 2026 13:21:57 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.225.19]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0A0811800351; Tue, 10 Mar 2026 13:21:56 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DB1CD1800850; Tue, 10 Mar 2026 14:21:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773148922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ofQ4nmwEu3wL7Z0Aby5YaVlITUvrkllN4FHvtGxenI=; b=FmhneHyOsnui8f8YqvpRuYfEg82z2ULEwMS4LkZXk39FXTacZs7ArePRAdpp66btkdLdVv TfSI+U6/fwcU6GgEo6/f1CblQupnctVQPkcYsssvzC7qQJTx9NvhbcYCHXEnth6m6vonQi zM0GEoK3lKwz/DGym1HmP32XqB+kfAg= X-MC-Unique: GtC0Yw3fMlOGmRVcTOWRpQ-1 X-Mimecast-MFC-AGG-ID: GtC0Yw3fMlOGmRVcTOWRpQ_1773148918 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Pierrick Bouvier , Stefano Garzarella , Zhao Liu , Gerd Hoffmann , Paolo Bonzini , Ani Sinha , Marcelo Tosatti , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kashyap Chamarthy , Oliver Steffen Subject: [PULL 1/3] docs/interop: Add AMD SEV-SNP SVSM interface to firmware.json Date: Tue, 10 Mar 2026 14:21:52 +0100 Message-ID: <20260310132154.2783257-2-kraxel@redhat.com> In-Reply-To: <20260310132154.2783257-1-kraxel@redhat.com> References: <20260310132154.2783257-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773148959727158500 Content-Type: text/plain; charset="utf-8" From: Oliver Steffen AMD SEV-SNP defines a guest to Secure VM Service Module (SVSM) firmware [1] interface. Add a corresponding item to the FirmwareOSInterface enum. [1] https://docs.amd.com/api/khub/documents/Al5Q~fSl~kWKkJ3zC0vk_g/content Signed-off-by: Oliver Steffen Message-ID: <20260123083204.999920-3-osteffen@redhat.com> Signed-off-by: Gerd Hoffmann --- docs/interop/firmware.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json index 3c71914a526c..421bee0e5ed4 100644 --- a/docs/interop/firmware.json +++ b/docs/interop/firmware.json @@ -40,10 +40,12 @@ # example, firmware built from the edk2 (EFI Development Kit II) # project usually provides this interface. # +# @svsm: AMD SEV-SNP Secure VM Service Module (SVSM) guest protocol. +# # Since: 3.0 ## { 'enum' : 'FirmwareOSInterface', - 'data' : [ 'bios', 'openfirmware', 'uboot', 'uefi' ] } + 'data' : [ 'bios', 'openfirmware', 'svsm', 'uboot', 'uefi' ] } =20 ## # @FirmwareDevice: --=20 2.53.0 From nobody Sat Apr 11 20:14:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773148966; cv=none; d=zohomail.com; s=zohoarc; b=X2wJtYno2rnpM7uYsQg16tmMpRwr3JH+pdsjRjZzvjhjrhrGqzcm4loU0XwzSF/635fxL+xsFb7/xxwPLvktOtxo+mZBNAEcK5y9bhcS4jKFVQzw9S/78ORtsPm9Xwo3a+dCDlL1jIXbRJh0s7PcjmEx+MiV8BAESvAiUS3VYQk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773148966; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bWghBUkeSE3zI2cdCfl1UKaHfHhMgE7oEA7r9bNf++E=; b=T2zF3UlvhBDl/TC+6lqM2mUqA6ojkCU5C5EA2juTQm0uW9oAI03frwaYDrLrZkRDcF1z0nuY6yy7hwc7FWXrvXW/52tEvKs+RDR6BQO7egUxwnjUjmnaX9JmysRxesJsvPFyl455Y7h0gCI/vi3V37zQZdF68wrGOmnQwHoZGIk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773148966677134.64556696443083; Tue, 10 Mar 2026 06:22:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzx2H-00089r-MC; Tue, 10 Mar 2026 09:22:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzx2F-000890-2E for qemu-devel@nongnu.org; Tue, 10 Mar 2026 09:22:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzx2D-0006VG-KO for qemu-devel@nongnu.org; Tue, 10 Mar 2026 09:22:06 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-7si1zSQGNJiQhW1BCcNKQg-1; Tue, 10 Mar 2026 09:22:01 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3A499180056E; Tue, 10 Mar 2026 13:22:00 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.225.19]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CE5DA180035F; Tue, 10 Mar 2026 13:21:59 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id F3F681800865; Tue, 10 Mar 2026 14:21:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773148924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bWghBUkeSE3zI2cdCfl1UKaHfHhMgE7oEA7r9bNf++E=; b=Vg+WTWpzwYwJGhUuib/3Vbkn/07HMV8CpUArkcAMVrDX1neG7aqte+xyaQRQ1y8Xq5DRCw oqMVy3fLqvKwFNKfQxWQmQhsLvhEkVVI3Phhfn+qqukRYPzPMUBHIZ+m+WGD8QmH4XOPRp uYy6IoWxMjojIKHxNYFbl9b4A5i1gU0= X-MC-Unique: 7si1zSQGNJiQhW1BCcNKQg-1 X-Mimecast-MFC-AGG-ID: 7si1zSQGNJiQhW1BCcNKQg_1773148920 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Pierrick Bouvier , Stefano Garzarella , Zhao Liu , Gerd Hoffmann , Paolo Bonzini , Ani Sinha , Marcelo Tosatti , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kashyap Chamarthy , Luigi Leonardi Subject: [PULL 2/3] igvm: fix build when igvm is not installed in a well known path Date: Tue, 10 Mar 2026 14:21:53 +0100 Message-ID: <20260310132154.2783257-3-kraxel@redhat.com> In-Reply-To: <20260310132154.2783257-1-kraxel@redhat.com> References: <20260310132154.2783257-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773148967151158500 Content-Type: text/plain; charset="utf-8" From: Luigi Leonardi `stubs/igvm.c` includes `igvm-internal.h`, that in turn includes the igvm l= ibrary. This is required just for the QIgvm declaration and creates an unnecessary dependency on the library. Since igvm is not listed as a dependency of stubs, this results in build failing when the library is not installed in a "well known" path of the system. Add a forward declaration for QIgvm and move the definition of `qigvm_directive_madt` to `igvm.h` so that we can drop `igvm-internal.h` fr= om `stubs/igvm.c`. Fixes: dea1f68a5c ("igvm: Fill MADT IGVM parameter field on x86_64") Suggested-by: Stefano Garzarella Signed-off-by: Luigi Leonardi Message-ID: <20260309-master-v2-1-7e02f07a1096@redhat.com> Signed-off-by: Gerd Hoffmann --- include/qemu/typedefs.h | 1 + include/system/igvm-internal.h | 9 ++------- include/system/igvm.h | 5 +++++ stubs/igvm.c | 1 - 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index 416a8c9acead..cbe6f7f4c7c1 100644 --- a/include/qemu/typedefs.h +++ b/include/qemu/typedefs.h @@ -102,6 +102,7 @@ typedef struct QEMUSGList QEMUSGList; typedef struct QemuSpin QemuSpin; typedef struct QEMUTimer QEMUTimer; typedef struct QEMUTimerListGroup QEMUTimerListGroup; +typedef struct QIgvm QIgvm; typedef struct QList QList; typedef struct QNull QNull; typedef struct QNum QNum; diff --git a/include/system/igvm-internal.h b/include/system/igvm-internal.h index 38004bd908e7..76ae1bc3be92 100644 --- a/include/system/igvm-internal.h +++ b/include/system/igvm-internal.h @@ -42,7 +42,7 @@ typedef struct QIgvmParameterData { * QIgvm contains the information required during processing of a single I= GVM * file. */ -typedef struct QIgvm { +struct QIgvm { IgvmHandle file; MachineState *machine_state; ConfidentialGuestSupportClass *cgsc; @@ -67,16 +67,11 @@ typedef struct QIgvm { unsigned region_start_index; unsigned region_last_index; unsigned region_page_count; -} QIgvm; +}; =20 IgvmHandle qigvm_file_init(char *filename, Error **errp); =20 QIgvmParameterData* qigvm_find_param_entry(QIgvm *igvm, uint32_t parameter_area_index); =20 -/* - * IGVM parameter handlers - */ -int qigvm_directive_madt(QIgvm *ctx, const uint8_t *header_data, Error **e= rrp); - #endif diff --git a/include/system/igvm.h b/include/system/igvm.h index 5573a6111ae7..f9231f03ec80 100644 --- a/include/system/igvm.h +++ b/include/system/igvm.h @@ -27,4 +27,9 @@ int qigvm_x86_get_mem_map_entry(int index, int qigvm_x86_set_vp_context(void *data, int index, Error **errp); =20 +/* + * IGVM parameter handlers + */ +int qigvm_directive_madt(QIgvm *ctx, const uint8_t *header_data, Error **e= rrp); + #endif diff --git a/stubs/igvm.c b/stubs/igvm.c index 47d5130d9d74..9e9f683fc960 100644 --- a/stubs/igvm.c +++ b/stubs/igvm.c @@ -12,7 +12,6 @@ #include "qemu/osdep.h" =20 #include "system/igvm.h" -#include "system/igvm-internal.h" =20 int qigvm_x86_get_mem_map_entry(int index, ConfidentialGuestMemoryMapEntry *entry, --=20 2.53.0 From nobody Sat Apr 11 20:14:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773148968; cv=none; d=zohomail.com; s=zohoarc; b=E/epWUeXYXHB74/0u/kUMDNnhnPkBO/q3VJrrTdkSnO1BR4oql7DpzpKMrA75rTObXGwNtKbxHvYu6ZuNpjjuwS+AGjThLFIiF+hbeVL6c+mYCmvQuoKoyRN1Fj/yUeFUnVp6fTazGXBOpdJNMfY1Zc3rrPHheMDA1aTvu7fKBs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773148968; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ky5o/xVx4bApMfBKfTqTU1xt2VCFg4tZ5G+RNDJxoJ8=; b=ij+yEpXUEODCH9r6C333qjMbNskwWS7V2L/rfTe47Zj3f8S+ROVXi1MGJ7Z6eFTwclZbj5z3HWOPp0WN66DskuKMouARWpAbBzZFt7sT9/ep4crR6LtriFq6PCnbLA1gabiWP+8gDLbeKbebgl45HeDF/+MBzmTdV5/r5jM2OHc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773148968723853.3489666281728; Tue, 10 Mar 2026 06:22:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzx2I-0008A8-1p; Tue, 10 Mar 2026 09:22:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzx2F-000897-F3 for qemu-devel@nongnu.org; Tue, 10 Mar 2026 09:22:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzx2D-0006VJ-R9 for qemu-devel@nongnu.org; Tue, 10 Mar 2026 09:22:07 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-mgfye2-fMTSCbheSipR3Kw-1; Tue, 10 Mar 2026 09:22:01 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6BFB118002D6; Tue, 10 Mar 2026 13:22:00 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.225.19]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFEDB1955D87; Tue, 10 Mar 2026 13:21:59 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0FECA1801A8F; Tue, 10 Mar 2026 14:21:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773148925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ky5o/xVx4bApMfBKfTqTU1xt2VCFg4tZ5G+RNDJxoJ8=; b=Fvrvjpx2F29accEgMV2ocilZwgS72b4YHShHIEi0cxtyX7VFtlRaZrkBkymwA5QR+urZuK KKUYQBLSz12eeKoUfYeIBZ3TK3Fetfdn0OyM3sZjraWuTsBD3XXfWzfz2BRpsEW2zd3569 RDJ3b2DQRphfhpRswRiQ+k4CCzeBFpo= X-MC-Unique: mgfye2-fMTSCbheSipR3Kw-1 X-Mimecast-MFC-AGG-ID: mgfye2-fMTSCbheSipR3Kw_1773148920 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Pierrick Bouvier , Stefano Garzarella , Zhao Liu , Gerd Hoffmann , Paolo Bonzini , Ani Sinha , Marcelo Tosatti , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kashyap Chamarthy Subject: [PULL 3/3] i386/sev/igvm: do not reset guest policy if IGVM does not set it Date: Tue, 10 Mar 2026 14:21:54 +0100 Message-ID: <20260310132154.2783257-4-kraxel@redhat.com> In-Reply-To: <20260310132154.2783257-1-kraxel@redhat.com> References: <20260310132154.2783257-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773148971712154100 Content-Type: text/plain; charset="utf-8" From: Ani Sinha The guest policy is set either through command-line or through IGVM. If non= e of the above applies, default guest policy applies. However, if IGVM does not = set the guest policy, currently the policy gets set to 0 regardless of whether = it was previously set to default value or command line. This change fixes this= by checking if IGVM indeed has set a policy value. If not, do not reset existi= ng value. This avoids guest crashes such as the following during reset when the IGVM has not explicitly set any guest policies: qemu-system-x86_64: sev_snp_launch_start: SNP_LAUNCH_START ret=3D-22 fw_err= or=3D0 '' qemu-system-x86_64: sev_common_kvm_init: failed to create encryption context qemu-system-x86_64: unable to rebuild guest: Operation not permitted(-1) Reported-by: Gerd Hoffmann Signed-off-by: Ani Sinha Message-ID: <20260310094450.35861-3-anisinha@redhat.com> Signed-off-by: Gerd Hoffmann --- target/i386/sev.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index 549e6241769b..cddffe0da8dd 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -2760,7 +2760,11 @@ static int cgs_set_guest_policy(ConfidentialGuestPol= icyType policy_type, id_auth->author_key[0] ? 1 : 0; finish->id_block_en =3D 1; } - sev_snp_guest->kvm_start_conf.policy =3D policy; + + /* do not reset existing policy if policy was not set in IGVM */ + if (policy !=3D 0) { + sev_snp_guest->kvm_start_conf.policy =3D policy; + } } else { SevGuestState *sev_guest =3D SEV_GUEST(MACHINE(qdev_get_machine())= ->cgs); /* Only the policy flags are supported for SEV and SEV-ES */ @@ -2769,7 +2773,11 @@ static int cgs_set_guest_policy(ConfidentialGuestPol= icyType policy_type, "but SEV-SNP is not enabled", __func__); return -1; } - sev_guest->policy =3D policy; + + /* do not reset existing policy if policy was not set in IGVM */ + if (policy !=3D 0) { + sev_guest->policy =3D policy; + } } return 0; } --=20 2.53.0