From nobody Sat Apr 11 21:51:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773139649; cv=none; d=zohomail.com; s=zohoarc; b=HkTUDkl0nwNoBd5E1MJve4NuqMczL2/Mgrhbf6livoc7/K5LExitpXFbUi10tYdDJmu2zD7mI1pql1SrEpUINdmQUmVcaoXVIcE9H7v8SgccOqRyiORrhZ3869/DYMBGsIFmrd8OXDE7xRojQmBF/Ev+VS+7/Y9icOc2SbZt5dU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773139649; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=q7Z/vQB+lFLKsxa63Yt8nB8oPVKn+DTUu+uQwmHZnEY=; b=khKWzGQKL3FE1vJJeYwFv4zt2KMeqHgVbMB2pPqsq30uKSPOSsQ9asSUKt++TiStZWupiznsvkOT0+nnP5OpHcL27B8zhhYcBua/P8vCZNagywvk+SwjIzoIDuoO/NwTSqqFvw2JuWVNU9EobzAn0Mzy7Ksjbwr0V3gf21rl7Mk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773139649537839.134259733087; Tue, 10 Mar 2026 03:47:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzubH-0007JT-FO; Tue, 10 Mar 2026 06:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzubF-0007GC-Hg for qemu-devel@nongnu.org; Tue, 10 Mar 2026 06:46:05 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzubD-0005qN-3N for qemu-devel@nongnu.org; Tue, 10 Mar 2026 06:46:05 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-48535a0ef86so19960645e9.1 for ; Tue, 10 Mar 2026 03:46:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485246ece8bsm171964975e9.4.2026.03.10.03.45.59 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 10 Mar 2026 03:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773139561; x=1773744361; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=q7Z/vQB+lFLKsxa63Yt8nB8oPVKn+DTUu+uQwmHZnEY=; b=vqiOwgGrzJV4bqYmYaQLZLa+SyHLTAyqLvrK1kNOSWfspYc3bFm5jzWNuh6ExtPPnh TXKf/uZ3L//q/u4ISJyiKwoxyuZ0atyi8t1UjBxZFq1KINYDcOo1JIFgvF7s2qg42LlJ 5oyxwDKq33VdM/uJvGFNvaXwCX+FVTH2yj95gplP4Snar8n9gjO2jyQe83sOLUIZKOaG HWxhntt0gj2Hs0mQBi1pXggFZTojV5fIJXrDI5QGQFn27C/LnMG7zmr8SzURvK7oVdz7 27uFyWNx780T1qbK4ChTeo03rMAy6jksll9nkgnFWAY3onT3wPGqlzXIh/z7u+rGSTBS lubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773139561; x=1773744361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=q7Z/vQB+lFLKsxa63Yt8nB8oPVKn+DTUu+uQwmHZnEY=; b=k+PaqdA1F8ai7cI3uvEA8VrFbhQ7bdkIy0me8AcVmUYFfGIBeNBdu/GrQOITmLxu4g yyvWZz3kt9TgY5UUUmLJxGoq6eMjh/91Z0VQXiEzeVO7rP9CZa4/8uZc0dMqpiG8e6nG rLsvNNnptF7fvjoFroCu859042gmYkKi6/p3hZ4zR/DPUYLcibcirGpoqyCFrvjZp/JU KOlvJPPKJTPAAXMDMyYIxL+xfEh5GZhYC/0+lKnr2zhaioslq4SCJS4W+EGThMoRFafJ Nc09Hda17nT6rVdL3TCBE0cxK3XzKa8j4/hQaRX7Y37VqD28DAObtV1YenglEu/0/gEX zB4w== X-Gm-Message-State: AOJu0Yxc/f9fUQYzp5k1UINQwWfyH+SGypCi9RjFrUeTf67/CpnqNAXB 9RX3bMkc3VNr54pChBYOgszofVKF3pG8KxgQjTlMRZYMgnHkDkRQpL0P37nANWmtLUm3QJFffRH 5KYakl8s= X-Gm-Gg: ATEYQzxzG0sKNqCiydd9zF854fqUmXXfhUvNKGlMPz2tavZVFvUu87guCaoDnq+eXzS 6upoYW+R0KwBsw9eeit456S4ZBKAIlryICRD50x0fCm3ES5iMSYJCSQUpzDmDFBrHqIlYbwHjgO ynd6O8E9KCxG8gnj8pA4hteWkl3k8mlqSz8D3/k9Z6ODzyZqhzP4aA5vKvIzpcMI9UOM/E1Jjwq QspOOK6zpgJ3fcKP8UMbUdBtCYgsF0dt7VJZj64PX6zdtllabie7/EWcLrK3vfuDqRshqeVTfs8 rSuSKhe5lA1/zTKEeC55YANMzfEjd5yjRkjCu1YETMCqdWTKqVJzmCMEf39lYjewg9u3qk7+v79 Yb7rofiC37EytzQ0dplTijcVjXgTeIKBaxphhkDbIbkuFXxDnzP2AO6zWhJrmE0YcmjVq2tBwSh P/2n0Se28jZYyunbYor37YINN0d9anq+CHuqVWqkC3J0Ji9U0W30eKYXF4E0oYaRab8opMUod26 C02rYsVFFs= X-Received: by 2002:a05:600c:1c25:b0:485:3e6c:aacb with SMTP id 5b1f17b1804b1-4853e6cae44mr95993085e9.4.1773139560818; Tue, 10 Mar 2026 03:46:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/16] tcg/optimize: possibly expand deposit into zero with shifts Date: Tue, 10 Mar 2026 11:45:02 +0100 Message-ID: <20260310104511.12670-8-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260310104511.12670-1-philmd@linaro.org> References: <20260310104511.12670-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773139650964154100 From: Richard Henderson Use tcg_op_imm_match to choose between expanding with AND+SHL vs SHL+SHR. Suggested-by: Paolo Bonzini Signed-off-by: Richard Henderson Message-ID: <20260303010833.1115741-8-richard.henderson@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tcg/optimize.c | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 59761c2c844..b1abec69a5d 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1743,14 +1743,38 @@ static bool fold_deposit(OptContext *ctx, TCGOp *op) goto done; } =20 - /* Lower invalid deposit into zero as AND + SHL. */ + /* Lower invalid deposit into zero as AND + SHL or SHL + SHR. */ if (!valid) { - op2 =3D opt_insert_before(ctx, op, INDEX_op_and, 3); - op2->args[0] =3D ret; - op2->args[1] =3D arg2; - op2->args[2] =3D arg_new_constant(ctx, len_mask); - fold_and(ctx, op2); + if (TCG_TARGET_extract_valid(ctx->type, 0, len)) { + /* EXTRACT (at 0) + SHL */ + op2 =3D opt_insert_before(ctx, op, INDEX_op_extract, 4); + op2->args[0] =3D ret; + op2->args[1] =3D arg2; + op2->args[2] =3D 0; + op2->args[3] =3D len; + } else if (tcg_op_imm_match(INDEX_op_and, ctx->type, len_mask)= ) { + /* AND + SHL */ + op2 =3D opt_insert_before(ctx, op, INDEX_op_and, 3); + op2->args[0] =3D ret; + op2->args[1] =3D arg2; + op2->args[2] =3D arg_new_constant(ctx, len_mask); + } else { + /* SHL + SHR */ + int shl =3D width - len; + int shr =3D width - len - ofs; =20 + op2 =3D opt_insert_before(ctx, op, INDEX_op_shl, 3); + op2->args[0] =3D ret; + op2->args[1] =3D arg2; + op2->args[2] =3D arg_new_constant(ctx, shl); + + op->opc =3D INDEX_op_shr; + op->args[1] =3D ret; + op->args[2] =3D arg_new_constant(ctx, shr); + goto done; + } + + /* Finish the (EXTRACT|AND) + SHL cases. */ op->opc =3D INDEX_op_shl; op->args[1] =3D ret; op->args[2] =3D arg_new_constant(ctx, ofs); --=20 2.53.0