From nobody Sat Apr 11 23:02:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082740; cv=none; d=zohomail.com; s=zohoarc; b=DOQ/RnjRn3itTa147vvfEqAp4Ivpkp4zfVBQieBAdPo6MNGan5YdyJXWh3xMBYyOpHL/hwMYDGcpDk3LHP4mEPHsSZiTl8K/GSaRiWUGL+h7AjXgejeyxGSPQpnRfVpRV6aPJTnbqo4G1dyzkS7kBJMrJYZrXnUW/0EulabdHVk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082740; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=lGKtW7RtVIFKz2s2sq9g68s/aW5ErCpi1qGuVteQ3QggQ//+pe+UTjyAfI+0oEJWl98UR3Ox6lOjbRIeR79MA9kA/fxqYsdqK+f/h8qOilcAG4gJRafbSIlHCYZlxYZawShXgQIt71ZpAEFtg9VQiS/yognkb9GHZ3tkTIGvggQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082740700360.3366350943279; Mon, 9 Mar 2026 11:59:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfoB-00044J-CG; Mon, 09 Mar 2026 14:58:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfoA-00043n-7f for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo8-0007r6-On for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:25 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-1yWuiaJoOVSXmA7tQnwsFQ-1; Mon, 09 Mar 2026 14:58:03 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-485397788b3so17411025e9.2 for ; Mon, 09 Mar 2026 11:58:01 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4852f369118sm82234845e9.20.2026.03.09.11.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=MEbjlXmxC7lHQ2R6ZE6k40ajhqgoLSuDKaPyUlV49TtsN2oG84IXobaFYCOKW2BvF/7kPJ PshhanSksAvvUBXOA4U2VcVkQxvtx+UOPVGN12dShWaBYZhYwQVb2vRDAlOdPhLphopCq6 XuBDWeJYQOjjwEClvZxEvrK8vl2IeRw= X-MC-Unique: 1yWuiaJoOVSXmA7tQnwsFQ-1 X-Mimecast-MFC-AGG-ID: 1yWuiaJoOVSXmA7tQnwsFQ_1773082677 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082676; x=1773687476; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=mWQibCxC7O63YHQ86ljUisKsz4oRqFOhFSlOMQCskVMgQdpIe2NsaQH+J4qI6/M4sb ej0L4jT1oQ0q/fod0YKGVXKR1Nm+2xhlu2GFiuOiCzFIlisd6ESaWwEsQYidDGC/9hCs LiJGtXJ/WjT3xBnE+udY8zHWOlmLzp0JOFGNxQFcS+0EbvQzl5PTmohzOqMxbeIOCtWG TCaJDaCQEHbY+hVF0IFe87EaxSifk2vqm5+ZowypR1+1K0MxQtNjVB5f4L3LOu+Kkjo4 cp7MpcmfxfU9/EUOulgiE3dEAwENfdnPNPwXFgxwZykB1skrP5WI6DEsgkDiqCkqRm8w TgBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082676; x=1773687476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=fIac4CjJzxMf2GtDq/2uoWdvpPk6mfjg9bVeBt9zbwDyNT2+8muGWR26WEEVJnkBbk IlsdwbZxFOFsVsDKNp2tRkJ9rA0YQSpcaSi7Pnw9HQjs7vRYDcun1c5wg2G6JnDhWfLD OrexlxZuNqwtUtKz0qY7Kw2ZxRxdqaEWu2KbJhms71gdDQJYcITwh4rLm8cgK1cH18WA FtzY26FtBvUCdda6MWjt7fEv6LpFaoWlQwMCTsmsSVIDhJ+HwUul6x2oSruPQt6HqAUB 6UqDHDXN3cLmvtI1hP0B8OwDTUAh+XWLkGNa0ZCz7VqiTb2/iB6uNLWOH9LB6cDLHkmh c1Nw== X-Gm-Message-State: AOJu0YzUoZLq0IgePb0ZbQ6GAVU1Rrw1nwBt9i5ZhPJzc6uLQ1dMxOB0 eY2WCCKxZh5oO9rmsTWTBlEBNuj3ctgCg0Ka+9Q+GGZJno05OR8Zco8J2UVA6C3FzfXqhye8RAv 3aUviCSZthEm8m1HeSWJ4SSg6VnEueDWbdo65Er3gvbJbkEv3wRRz9RE8DpAHx1UGJO1icfend3 94Wj+/Z7m45aOsVqqfdxksrYIAwLgJq52uJg+UxDC3 X-Gm-Gg: ATEYQzxr8xZcbNpxSx1yJXCASbbiC4B6Ja2RW9TSrv2uus0AuCRCXxfpVaVxDoY5MvJ QISVpqIG5T3v53SwjKodACxWOYeXTaVfnz7eIUY/rTh606bDxnuHaQG55zKUaKfaS0rDgwF4iuC SwJfGWzDWfsjKyU0gqA00AeksZT1+dNH2uEiz4DXVkuRhNU4ss5wFqVVJudHzc5qIHyeupbcc+4 fS7iGSixI+qIIorCN9PRlPqfsWrSYhH1IUCfhgrqLr08Y9fuuatejfd1kKf6CqdKmjlCKLLKpiT B68IAAyfQx8o85BFUCcWnLQKc+Bc5U6SH1rWUc/OePcEv+NZMaLSmM/44j1RqgPRf7Mh2WLLnaw z/hZmLI8oKRyj3NXxFdNsyurkh4Yv0Zbvq27vzCeRskAcD5Z10stluAMrXeBOMaL7J7xUZ+JEGP eU0NFbxeTrxuJe9WK5SYa+8vQszOc= X-Received: by 2002:a05:600d:6452:10b0:485:299d:546d with SMTP id 5b1f17b1804b1-485299d558fmr133143375e9.8.1773082676071; Mon, 09 Mar 2026 11:57:56 -0700 (PDT) X-Received: by 2002:a05:600d:6452:10b0:485:299d:546d with SMTP id 5b1f17b1804b1-485299d558fmr133143125e9.8.1773082675637; Mon, 09 Mar 2026 11:57:55 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Siteshwar Vashisht Subject: [PULL 01/10] xen-block: remove NULL pointer dereference Date: Mon, 9 Mar 2026 19:57:43 +0100 Message-ID: <20260309185752.76865-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082742616154100 Content-Type: text/plain; charset="utf-8" If params is NULL, xen_block_drive_create calls xen_block_drive_destroy with drive =3D=3D NULL. Reported-by: Siteshwar Vashisht Signed-off-by: Paolo Bonzini --- hw/block/xen-block.c | 41 +++++++++++++++++++---------------------- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 5dc4ba9d076..474c12fe4ac 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -883,32 +883,29 @@ static XenBlockDrive *xen_block_drive_create(const ch= ar *id, QDict *driver_layer; struct stat st; int rc; + char **v; =20 - if (params) { - char **v =3D g_strsplit(params, ":", 2); - - if (v[1] =3D=3D NULL) { - filename =3D g_strdup(v[0]); - driver =3D g_strdup("raw"); - } else { - if (strcmp(v[0], "aio") =3D=3D 0) { - driver =3D g_strdup("raw"); - } else if (strcmp(v[0], "vhd") =3D=3D 0) { - driver =3D g_strdup("vpc"); - } else { - driver =3D g_strdup(v[0]); - } - filename =3D g_strdup(v[1]); - } - - g_strfreev(v); - } else { + if (!params) { error_setg(errp, "no params"); - goto done; + return NULL; } =20 - assert(filename); - assert(driver); + v =3D g_strsplit(params, ":", 2); + if (v[1] =3D=3D NULL) { + filename =3D g_strdup(v[0]); + driver =3D g_strdup("raw"); + } else { + if (strcmp(v[0], "aio") =3D=3D 0) { + driver =3D g_strdup("raw"); + } else if (strcmp(v[0], "vhd") =3D=3D 0) { + driver =3D g_strdup("vpc"); + } else { + driver =3D g_strdup(v[0]); + } + filename =3D g_strdup(v[1]); + } + + g_strfreev(v); =20 drive =3D g_new0(XenBlockDrive, 1); drive->id =3D g_strdup(id); --=20 2.53.0