From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082740; cv=none; d=zohomail.com; s=zohoarc; b=DOQ/RnjRn3itTa147vvfEqAp4Ivpkp4zfVBQieBAdPo6MNGan5YdyJXWh3xMBYyOpHL/hwMYDGcpDk3LHP4mEPHsSZiTl8K/GSaRiWUGL+h7AjXgejeyxGSPQpnRfVpRV6aPJTnbqo4G1dyzkS7kBJMrJYZrXnUW/0EulabdHVk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082740; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=lGKtW7RtVIFKz2s2sq9g68s/aW5ErCpi1qGuVteQ3QggQ//+pe+UTjyAfI+0oEJWl98UR3Ox6lOjbRIeR79MA9kA/fxqYsdqK+f/h8qOilcAG4gJRafbSIlHCYZlxYZawShXgQIt71ZpAEFtg9VQiS/yognkb9GHZ3tkTIGvggQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082740700360.3366350943279; Mon, 9 Mar 2026 11:59:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfoB-00044J-CG; Mon, 09 Mar 2026 14:58:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfoA-00043n-7f for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo8-0007r6-On for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:25 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-1yWuiaJoOVSXmA7tQnwsFQ-1; Mon, 09 Mar 2026 14:58:03 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-485397788b3so17411025e9.2 for ; Mon, 09 Mar 2026 11:58:01 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4852f369118sm82234845e9.20.2026.03.09.11.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=MEbjlXmxC7lHQ2R6ZE6k40ajhqgoLSuDKaPyUlV49TtsN2oG84IXobaFYCOKW2BvF/7kPJ PshhanSksAvvUBXOA4U2VcVkQxvtx+UOPVGN12dShWaBYZhYwQVb2vRDAlOdPhLphopCq6 XuBDWeJYQOjjwEClvZxEvrK8vl2IeRw= X-MC-Unique: 1yWuiaJoOVSXmA7tQnwsFQ-1 X-Mimecast-MFC-AGG-ID: 1yWuiaJoOVSXmA7tQnwsFQ_1773082677 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082676; x=1773687476; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=mWQibCxC7O63YHQ86ljUisKsz4oRqFOhFSlOMQCskVMgQdpIe2NsaQH+J4qI6/M4sb ej0L4jT1oQ0q/fod0YKGVXKR1Nm+2xhlu2GFiuOiCzFIlisd6ESaWwEsQYidDGC/9hCs LiJGtXJ/WjT3xBnE+udY8zHWOlmLzp0JOFGNxQFcS+0EbvQzl5PTmohzOqMxbeIOCtWG TCaJDaCQEHbY+hVF0IFe87EaxSifk2vqm5+ZowypR1+1K0MxQtNjVB5f4L3LOu+Kkjo4 cp7MpcmfxfU9/EUOulgiE3dEAwENfdnPNPwXFgxwZykB1skrP5WI6DEsgkDiqCkqRm8w TgBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082676; x=1773687476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=fIac4CjJzxMf2GtDq/2uoWdvpPk6mfjg9bVeBt9zbwDyNT2+8muGWR26WEEVJnkBbk IlsdwbZxFOFsVsDKNp2tRkJ9rA0YQSpcaSi7Pnw9HQjs7vRYDcun1c5wg2G6JnDhWfLD OrexlxZuNqwtUtKz0qY7Kw2ZxRxdqaEWu2KbJhms71gdDQJYcITwh4rLm8cgK1cH18WA FtzY26FtBvUCdda6MWjt7fEv6LpFaoWlQwMCTsmsSVIDhJ+HwUul6x2oSruPQt6HqAUB 6UqDHDXN3cLmvtI1hP0B8OwDTUAh+XWLkGNa0ZCz7VqiTb2/iB6uNLWOH9LB6cDLHkmh c1Nw== X-Gm-Message-State: AOJu0YzUoZLq0IgePb0ZbQ6GAVU1Rrw1nwBt9i5ZhPJzc6uLQ1dMxOB0 eY2WCCKxZh5oO9rmsTWTBlEBNuj3ctgCg0Ka+9Q+GGZJno05OR8Zco8J2UVA6C3FzfXqhye8RAv 3aUviCSZthEm8m1HeSWJ4SSg6VnEueDWbdo65Er3gvbJbkEv3wRRz9RE8DpAHx1UGJO1icfend3 94Wj+/Z7m45aOsVqqfdxksrYIAwLgJq52uJg+UxDC3 X-Gm-Gg: ATEYQzxr8xZcbNpxSx1yJXCASbbiC4B6Ja2RW9TSrv2uus0AuCRCXxfpVaVxDoY5MvJ QISVpqIG5T3v53SwjKodACxWOYeXTaVfnz7eIUY/rTh606bDxnuHaQG55zKUaKfaS0rDgwF4iuC SwJfGWzDWfsjKyU0gqA00AeksZT1+dNH2uEiz4DXVkuRhNU4ss5wFqVVJudHzc5qIHyeupbcc+4 fS7iGSixI+qIIorCN9PRlPqfsWrSYhH1IUCfhgrqLr08Y9fuuatejfd1kKf6CqdKmjlCKLLKpiT B68IAAyfQx8o85BFUCcWnLQKc+Bc5U6SH1rWUc/OePcEv+NZMaLSmM/44j1RqgPRf7Mh2WLLnaw z/hZmLI8oKRyj3NXxFdNsyurkh4Yv0Zbvq27vzCeRskAcD5Z10stluAMrXeBOMaL7J7xUZ+JEGP eU0NFbxeTrxuJe9WK5SYa+8vQszOc= X-Received: by 2002:a05:600d:6452:10b0:485:299d:546d with SMTP id 5b1f17b1804b1-485299d558fmr133143375e9.8.1773082676071; Mon, 09 Mar 2026 11:57:56 -0700 (PDT) X-Received: by 2002:a05:600d:6452:10b0:485:299d:546d with SMTP id 5b1f17b1804b1-485299d558fmr133143125e9.8.1773082675637; Mon, 09 Mar 2026 11:57:55 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Siteshwar Vashisht Subject: [PULL 01/10] xen-block: remove NULL pointer dereference Date: Mon, 9 Mar 2026 19:57:43 +0100 Message-ID: <20260309185752.76865-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082742616154100 Content-Type: text/plain; charset="utf-8" If params is NULL, xen_block_drive_create calls xen_block_drive_destroy with drive =3D=3D NULL. Reported-by: Siteshwar Vashisht Signed-off-by: Paolo Bonzini --- hw/block/xen-block.c | 41 +++++++++++++++++++---------------------- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 5dc4ba9d076..474c12fe4ac 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -883,32 +883,29 @@ static XenBlockDrive *xen_block_drive_create(const ch= ar *id, QDict *driver_layer; struct stat st; int rc; + char **v; =20 - if (params) { - char **v =3D g_strsplit(params, ":", 2); - - if (v[1] =3D=3D NULL) { - filename =3D g_strdup(v[0]); - driver =3D g_strdup("raw"); - } else { - if (strcmp(v[0], "aio") =3D=3D 0) { - driver =3D g_strdup("raw"); - } else if (strcmp(v[0], "vhd") =3D=3D 0) { - driver =3D g_strdup("vpc"); - } else { - driver =3D g_strdup(v[0]); - } - filename =3D g_strdup(v[1]); - } - - g_strfreev(v); - } else { + if (!params) { error_setg(errp, "no params"); - goto done; + return NULL; } =20 - assert(filename); - assert(driver); + v =3D g_strsplit(params, ":", 2); + if (v[1] =3D=3D NULL) { + filename =3D g_strdup(v[0]); + driver =3D g_strdup("raw"); + } else { + if (strcmp(v[0], "aio") =3D=3D 0) { + driver =3D g_strdup("raw"); + } else if (strcmp(v[0], "vhd") =3D=3D 0) { + driver =3D g_strdup("vpc"); + } else { + driver =3D g_strdup(v[0]); + } + filename =3D g_strdup(v[1]); + } + + g_strfreev(v); =20 drive =3D g_new0(XenBlockDrive, 1); drive->id =3D g_strdup(id); --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082734; cv=none; d=zohomail.com; s=zohoarc; b=cagfyosRbChZO6UNpsKTSPhr5XYCxuvpmEkJenfoD/J837GodWQ6vSip6Q5ZtZdecazT5WC3CvQufdcc3q/K1fNX+1LpCiI1IXT/91KbKyyp7cFUb0NwYBdhZycEaoIl40WCwme3vKEsahduBsEcslXUTplltE88JgCZm6tc3ek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082734; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=DauJu0T3QwrbwnjeDgxpU9MPnIqARFD3G6zWCmX6oUWJvk6ex6X8vQSSqUnjD2UVwQT0d/fXnF6WBPLWHZ1Sf3BRJmtMUwkCeH/tlxteGVGhX0OlnjmW/yF15dZJTMoOXMqt91AbToWu9p84Rqv337lNuRw8rXEnP87NNBAD8a0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082734901742.0296007590174; Mon, 9 Mar 2026 11:58:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfnr-0003pd-1h; Mon, 09 Mar 2026 14:58:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnp-0003mB-R0 for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnn-0007nK-Sr for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:05 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-I6eY4XALNaW5mm2rnOAmrA-1; Mon, 09 Mar 2026 14:58:01 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48532df52c5so21122095e9.1 for ; Mon, 09 Mar 2026 11:58:01 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541a6bc3bsm11259015e9.2.2026.03.09.11.57.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=gSFIY/a5+sOoH5S0gQiebtea0XRoX0BEx/vjGNG4H4H32nD/HwF7S5JC4YBr9NfhSqqoYV i3bOBfou3ebEOUXY4YIn/17fWaL0hpdyV8bog94Zb8fIiU6+q87Bds0+AAhHE/Gwt413Uw s1uPLrSBEB3cENiRGLcM+oy/XgSnWw0= X-MC-Unique: I6eY4XALNaW5mm2rnOAmrA-1 X-Mimecast-MFC-AGG-ID: I6eY4XALNaW5mm2rnOAmrA_1773082680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082680; x=1773687480; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=Xti5+MYActk/jT532C8kQFQnY0WhlsjKMTq57dRIYb8n62axjpaeQad9KUImSF4Xi+ i9wGonuXQb3yWM1Qeee9Cz8ZpVhLlkBFOGrQAdTX4y8WLxFqL17fDUWUNuG3cWZkTHVf rfwyuz/tarOo9qjJFe5aNVNa+lBtv0KRrqaaHBOH2t2YLFhrUOgRtUC9htTCEuqqQdJT M5UFY0stOWfMKd6Uwm8weQle7gf/rhDqbuj6ScsvoLbXKlsV4xVmQbIm9uDAfRj8Nil5 3wMhaDYXr4LFIATWV8RhOvGpJI6svTwx1RHa23w4SipJmZXsERGq/ArwMRikOB5yy/VS b1LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082680; x=1773687480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=RJtNfh92v+hnS8ZHVuBtphOM9RW9PdTFkumIzOityFR6vQzFQqNiuOi/PW7+vniYCK U7Xh+HRCxlCvoQsADDOPKFNw6f89Rhwu7EXW3OTo98BA6PCjoy3JwrTXE5WsrvSQ7oP1 5lEQnOAFZBzbUrGlsotfFk7eL3BNR2NPswvMTCC8Pr62z3KCeXFS3NzDWq7sYt62HDlh gTVozAK8q1EzRk4LScpFHeSfZyGewu+DfDTXmPIWIYLWWB9PM2whMOrMhjD4A6Kz8JeN nLlWQUifTZxBE2jCd8TFuqWYsMMUvTYBEKVS20xS3LPknCnPNdOOqcs1jIxhjE00kZ5n M4JQ== X-Gm-Message-State: AOJu0YyW2AHcFuR3X/U4dMLxu/lNF4Nqvv7rkEIMTk2NGZmH48QOz3qE kC27WOgP+WwhOk0CsvGlZ4C7QgasU7Bog1w8WhuhBzOg7/dRzvBQ4Ou70T4YgCvtcW6XyK6sRbW Nh6w9mHTv3f+wFjvZwNsujqdBt9Gd3u11hvtlB5ARLipWu71r63g4GccalfZkJkvb9hGxHhtqsz m4PxtGmrfpcq0TCMvwVlSb9GQhTCPO9eWbdvlcO79A X-Gm-Gg: ATEYQzyGDEeeS0Gjrs/spADlJUiip74+jqKGyaknH04tX3VaUJliB7qopBmbq9YhxQ5 xmxVbL2uFl0xU1GEUeajrVLX2J6PnBJM4KgiQEFhfAg0iMoJFXW7ZunDUGNcs94umKqYmyDa1Fp SVB7yypbHgZl1m4xRzz7rs6O5TjwQe64+T/A6ow+PQYr/b/z7p+ECTihEOkzXsMXlYTc7/WjK+Q UWJIA4fUJkiptLD8qkIbA/uGwm+pR1445+veMD6O184RZUpDqbGH/ZgrEubrUvt1KBe7px9FO2Z w6Rz4MUqvbk1ZB8d7SmSs2xz6j2BBAk7ty4lm38nSultw3SMLqIh6we5SxacYyDiUIm61R5TYyT IHrIXVGhjAwkTXdIhktC6Z/HE7q1R76eysEIrkqD2KcgV11O6DQNjeoXN+iR2nYL/KNj0kObdb+ /LNfzlivZBgQxbUl+plUr8L/pXjFY= X-Received: by 2002:a05:600c:8b84:b0:485:3ca4:4ee5 with SMTP id 5b1f17b1804b1-4853ca45149mr54933835e9.8.1773082679599; Mon, 09 Mar 2026 11:57:59 -0700 (PDT) X-Received: by 2002:a05:600c:8b84:b0:485:3ca4:4ee5 with SMTP id 5b1f17b1804b1-4853ca45149mr54933455e9.8.1773082679112; Mon, 09 Mar 2026 11:57:59 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Siteshwar Vashisht Subject: [PULL 02/10] qemu-coroutine-lock: fix has_waiters() Date: Mon, 9 Mar 2026 19:57:44 +0100 Message-ID: <20260309185752.76865-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082736439154100 Content-Type: text/plain; charset="utf-8" has_waiters() is testing a reversed condition. The logic is that has_waiters() must return true if a qemu_co_mutex_lock_slowpath() happened: qemu_co_mutex_unlock qemu_co_mutex_lock_slowpath ------------------------- ------------------------------- set handoff push to from_push memory barrier memory barrier check has_waiters() check handoff which requires it to return true if from_push (or to_pop from a previous call) are *not* empty. This was unlikely to cause trouble because it can only happen when the same CoMutex is used across multiple threads, but it is nevertheless completely wrong. The bug would show up as either a NULL-pointer dereference inside qemu_co_mutex_lock_slowpath(), or a missed wait in qemu_co_mutex_unlock(). Reported-by: Siteshwar Vashisht Signed-off-by: Paolo Bonzini --- util/qemu-coroutine-lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-coroutine-lock.c b/util/qemu-coroutine-lock.c index fac91582b5f..c82ee754beb 100644 --- a/util/qemu-coroutine-lock.c +++ b/util/qemu-coroutine-lock.c @@ -173,7 +173,7 @@ static CoWaitRecord *pop_waiter(CoMutex *mutex) =20 static bool has_waiters(CoMutex *mutex) { - return QSLIST_EMPTY(&mutex->to_pop) || QSLIST_EMPTY(&mutex->from_push); + return !QSLIST_EMPTY(&mutex->to_pop) || !QSLIST_EMPTY(&mutex->from_pus= h); } =20 void qemu_co_mutex_init(CoMutex *mutex) --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082696; cv=none; d=zohomail.com; s=zohoarc; b=PV5vu/Xb8o68RCV/ZL+AbWRdFi4tq5BukxATRMvXGM+d/bM4RaPYbvAi7nG17IkT6gnvleQyiaHdxLJwr9QCRV3BNucXx5Oy/eAcpwO1YkbVytjeKs4RyTImUPXi9s4VPb+NSAYemyiIK8ALs+ZBUVhlfgEi5Lirlo2eL4YZkQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082696; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=PX5IAKrivwaq5leb7bKhIWa0CSEO/4HPrMLXvy1+VccPKPrTgVchT6VRFDfayXpAscQX/o/O5IIf5Istyz7Ph4gxEn17ftFeZ3vEsMNAKgXu6iaU+iRgLN+6SPWpRiNtV334GjJBzkQ/jZzElLGSlHICIZ6Fq0iP+29/1777zbg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082696101398.40616108342226; Mon, 9 Mar 2026 11:58:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfns-0003sE-Jq; Mon, 09 Mar 2026 14:58:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnr-0003po-7o for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnp-0007nj-Jt for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:06 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-FX6sVXBhPA-Kw0fiatIXEw-1; Mon, 09 Mar 2026 14:58:03 -0400 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-439af7ba802so8110918f8f.2 for ; Mon, 09 Mar 2026 11:58:03 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dada9116sm26047682f8f.14.2026.03.09.11.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=UEsx/K9uaQo7XzA37wGqaTPKxMnFLQDnf0Gbiw+5a8L3yXmj6FeLwQcqQcTrkGJHi/xDos y5cXskyg0CwbZqtc1GOA+KgbLdSf+vEjrePWYzd1/cpWDu9DTSQfF2mDOyg/oXyFmEnNaS +XxB8sEBoXt/mRFeA4hEJKv1LdFSdzU= X-MC-Unique: FX6sVXBhPA-Kw0fiatIXEw-1 X-Mimecast-MFC-AGG-ID: FX6sVXBhPA-Kw0fiatIXEw_1773082682 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082682; x=1773687482; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=Y1+GYNBoA21LExqm0Zfz3Wm8SbKpCGAbN8UVVDXfArWGbmWjtHAQFHA6ypGlMeDHQC A6T0KkZ2HSWP2RHalqaRa6tbpUc//L1qlO4ap5TSXjF6fLYGr2MspCf8CyPXOQKUaV9g TkAX52+iz6irrakHKJ5HSOi2ww4EETz7KsWKuGlp4IOrMrjZdATYiakHtA3Tysu1hgRT 6WoRIj+eGcw3S6MspSVCtOaGSsZbnNRxJWc9gXDEAiZWHrt7TnAv81mRPBsF0oSmnt1g Zid66F9DV4jFBWScoLdO2scjN24lxeTgZo/XQEp/4K5zLL/6Jx10vQKSjqc5/glUfHkO gHvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082682; x=1773687482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=UfrBVvaE5WLysMyIo8FU5MoZwGqVMqbrD2o/hOeLw/UIr2IAiuvWTJoAv7HuvpGrqd tWw7kF2NcdqdSXq6qlRoM+7gLtda0mP6LJTPqlg55XlmJNxUB2+LyjNaOC8QlCgpk8Cq 8yEgcCZtOMdZ6DvoBn1IYDNPY/ROYJocYITHv6sqIqbMMiCF9lHgKnbB+iwVnj2elnPC nGaCPkGor2mxxfXFTK/ESh29ta4JF9w+upUHyDCBaAIPJlbUIoPLEHIITvIPN6uwO3JP 7lEzYg0b0Luu88m80rsHJbUWM0CfCotBWUjpRWaQ8G9jaND1Gjs6bYZ342BY+1cw0krg xwBA== X-Gm-Message-State: AOJu0YwN9S9+WP00H1RfSRXigsxFf+ELTHyzh0Yt8ABzP5t2/3LABNpT UEre9zKrM7sM/orpB7rmz9qIY+oNsnlFHeIt9nvc9pZb6pPNRqQPznIrZlYEZHoEH7D2OegjHqp 32ht6lOS8O94BuqB92zEvK30prULN3gOPMCSwljo5T7+2umxS7LJOuuz+zales5F7XHMxZ2KO/D S2D1Q16/whY2X5dvO+ZnFFM7oBFRpVmoApYOyHj9e2 X-Gm-Gg: ATEYQzw7MGL/PI9TZg/CSLxnmpFUxKCF9kO1EL0Q18CTQbFZttEJZlK+i2qxqAubIvB y5dy2uAIztfi9DieSqYPfsnOpElcXCha29FZ8PLR61T7BINPBaqmXCXpvnut6kzu1jg3aJqdiBE Y60iNJXgOQOW1cCnbeeaL/SPplxvU3fn6vkuHuvB5l77YnT7Jlf2WqebWRwxag3chjDMecThpJZ 6XIL9/uR2HNfHDTEfHnu2Y4FScIX5/jfX+KGJc2ftGviTuPwVTLvr7gYJUk3kivTG6j+19MLLvJ Zc3KB6ch7iw8E+Pz9/sCb8VEQmztbbhtFqRGR1Jz4ZgN9YSILqs3gObIy7IkbGK7TVJxZit1l9s zW7AHqfio5iIXlYJnuqJd9m+5hrTOprmpCiBOEru+bshOg6jfUXbwWxtxz70qxd0ZUN0WRDQEqT 7LGXg2oLD9r7uLfV+LholjKrSXTEI= X-Received: by 2002:a05:600c:34d0:b0:477:5cc6:7e44 with SMTP id 5b1f17b1804b1-48526923c5cmr199475015e9.11.1773082682014; Mon, 09 Mar 2026 11:58:02 -0700 (PDT) X-Received: by 2002:a05:600c:34d0:b0:477:5cc6:7e44 with SMTP id 5b1f17b1804b1-48526923c5cmr199474495e9.11.1773082681497; Mon, 09 Mar 2026 11:58:01 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Mohamed Mediouni Subject: [PULL 03/10] target/i386/hvf/hvf.c: fix compilation Date: Mon, 9 Mar 2026 19:57:45 +0100 Message-ID: <20260309185752.76865-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082698533154100 Content-Type: text/plain; charset="utf-8" From: Pierrick Bouvier ../target/i386/hvf/hvf.c:476:31: error: use of undeclared identifier 'cpu' 476 | X86CPU *x86_cpu =3D X86_CPU(cpu); | ^ ../target/i386/hvf/hvf.c:479:24: error: use of undeclared identifier 'cpu' 479 | env->cr[0] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR0); | ^ ../target/i386/hvf/hvf.c:480:24: error: use of undeclared identifier 'cpu' 480 | env->cr[3] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR3); | ^ ../target/i386/hvf/hvf.c:481:23: error: use of undeclared identifier 'cpu' 481 | env->cr[2] =3D rreg(cpu->accel->fd, HV_X86_CR2); | ^ ../target/i386/hvf/hvf.c:486:31: error: use of undeclared identifier 'cpu' 486 | X86CPU *x86_cpu =3D X86_CPU(cpu); | ^ ../target/i386/hvf/hvf.c:489:11: error: use of undeclared identifier 'cpu' 489 | wvmcs(cpu->accel->fd, VMCS_GUEST_CR0, env->cr[0]); | ^ ../target/i386/hvf/hvf.c:490:11: error: use of undeclared identifier 'cpu' 490 | wvmcs(cpu->accel->fd, VMCS_GUEST_CR3, env->cr[3]); | ^ 7 errors generated. Signed-off-by: Pierrick Bouvier Reviewed-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-2-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/hvf/hvf.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index a70f8461b04..c0d028b1473 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -472,21 +472,21 @@ static void hvf_cpu_x86_cpuid(CPUX86State *env, uint3= 2_t index, uint32_t count, =20 static void hvf_load_crs(CPUState *cs) { - X86CPU *x86_cpu =3D X86_CPU(cpu); + X86CPU *x86_cpu =3D X86_CPU(cs); CPUX86State *env =3D &x86_cpu->env; =20 - env->cr[0] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR0); - env->cr[3] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR3); - env->cr[2] =3D rreg(cpu->accel->fd, HV_X86_CR2); + env->cr[0] =3D rvmcs(cs->accel->fd, VMCS_GUEST_CR0); + env->cr[3] =3D rvmcs(cs->accel->fd, VMCS_GUEST_CR3); + env->cr[2] =3D rreg(cs->accel->fd, HV_X86_CR2); } =20 static void hvf_save_crs(CPUState *cs) { - X86CPU *x86_cpu =3D X86_CPU(cpu); + X86CPU *x86_cpu =3D X86_CPU(cs); CPUX86State *env =3D &x86_cpu->env; =20 - wvmcs(cpu->accel->fd, VMCS_GUEST_CR0, env->cr[0]); - wvmcs(cpu->accel->fd, VMCS_GUEST_CR3, env->cr[3]); + wvmcs(cs->accel->fd, VMCS_GUEST_CR0, env->cr[0]); + wvmcs(cs->accel->fd, VMCS_GUEST_CR3, env->cr[3]); wreg(cs->accel->fd, HV_X86_CR2, env->cr[2]); } =20 --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082749; cv=none; d=zohomail.com; s=zohoarc; b=WWd1ohQxydJ8wvqC35wW7tezENoxSC0i1fJP0iew4vOBC7ua4U3YyQPNNvP1KX+LF4KI4Ly9bATH3Qqt1HvYVIsrbeA+5CVs7apifc1QUdGtz1gjO7uPabonf7kV/F8fYgj+7byW99NCXYEjIHJAmfwc26POpIpRy0cZQ9vCO70= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082749; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=c84//JODN508t/s8h3FVQ2p0nLeQG1lrmiz0WmCZ2zQLeaFJjtCCYntwp15HXwY+93NBBzxaPpX3UHXd1SSd8AmXtdR3O1xO6MWwGx9stZmfdG7ePC+PSvVUkwSlx1Rjnm+JBf4Q9SSBAdID3p+vI4AES8FJrpoxlpEcfRjgJT8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082749782206.1247811473661; Mon, 9 Mar 2026 11:59:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfnu-0003ss-TB; Mon, 09 Mar 2026 14:58:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnt-0003sW-4W for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnr-0007oG-Ml for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:08 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-Jc2cLk5LOmOS9CgZCdhfow-1; Mon, 09 Mar 2026 14:58:05 -0400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-485375aa56eso12879265e9.1 for ; Mon, 09 Mar 2026 11:58:05 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485359bf807sm74317815e9.2.2026.03.09.11.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=b4hTT+ehflgyV4kO5eNLQth8dR4LruYxF/TIplBbWK6rqgVovuwjPG9yRh8ki4tp3Q8nuQ lTfdA6xb68EcpBm6MxsaHVHcfWl9DeTFagkdMx0iJ9NjLAWHSchwEB3pGn5UdqZDeinkML ahWoWWH6Q4Bh8l/v6W3YUI85KtipOL4= X-MC-Unique: Jc2cLk5LOmOS9CgZCdhfow-1 X-Mimecast-MFC-AGG-ID: Jc2cLk5LOmOS9CgZCdhfow_1773082684 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082684; x=1773687484; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=Zfzm4J9K+D3bASwv0Qf0nyndSj03QRF02zX0NWmR5GOJkVFjTS+8Xp/c9B1cOISsrp ccWVvV/L7gTAsTup64J8f854JOtlGrdyg83QpGTsno0ivmMauxJMFrDN3Nv+5adUqAjh B3ourxrUsdbpqg5lPnZBcL2sl58ex7JNNj8Md/fVukHQdi3mmBiC44Uj54TbMinMY/sB 0D8YDFbYmRtrAuI9XJi0IuXDAADpZzMSf8npuBXfMHq4hgXV3zFn+DO0FMoO7SNMQDZU /m3/FI39d5I9LjYnVAExjSzdM05aAcG9JqIz9hAcgZKIC8sO8TuvC3CFvL9KfUrhVonB r8JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082684; x=1773687484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=It0uGfUKAyP1AEew3D0gQGE+Qr1H5FoSTlbFgODhWcUmYG6xQLnoFM09wQjWR+QfAL 4IJ0Ih1XgrkOQA99KXLtXZckT4XfBoGxPxWPr4g+zU8l/1/0mWPYUfVDzZ0DFWiI2hy2 GQyiLfmRwdw9wfdVQkzxKQUwO5tR/wSFw6KBEvZIdnDdu7f8T05eT1KZ/B9gm970mc8S RIM2nxj7X7U6VVG+RB+1xLoibCfzjrmNOq+9qxnYVmbswd6Xv9FnNQxUMdv8alleKZnC N/bAu3YiYqjqrZvEy9AoL0Is1CX6HOhCp1AUSmM1T1Ok9ZSz79pSlNoNG/LtBXzgYJ8p JR2Q== X-Gm-Message-State: AOJu0YwR/SFpWBS0yXLx+mQPE3Op1VMVtTkGRS4F1EpI20nZ9rr05nyG xmHOfhVLtP70XwqyGc2VJVFBgVAj6hBqPjiSqJgpg01Ad6UXiPuxw0rSML+Eo6pJ0cO5HxP8LOJ 75LUdkKwpBjbE6xfnqxsxvNjYUQkEw8iuCbi5EmCrJbCIEP2230xBpHe5Mw6+rWWqDH5o9StwVo 6nSTF1XAuxWd0L+8WwecObNMCAc992Id7JSsDOnZ9I X-Gm-Gg: ATEYQzxTdvWx/4VDc9eVwAjjG8RSQne5FSZFRY0HKTHMv344YI8isf/2xX2XfoVfp8F Bk93DgF/FyVHFBGMQpVJrQliMk20YgE18MLj2aJXTomkFkxxjPNAjUthOMMSMCrcSEnGF0nzdSK pxNcTGrL5K5ZOD19CMcvVJjHbADxAuBEX9UryvuyradzZRlkFxySdOXYc9gPhxzHra0BPH+CYlP 8f7GaD0KiAK5SS+1cRut8ANaBtNg7fw77DIdlMKZlJ9uG7GN1ZpJ9t5nDacea68sHzQze4vcmus MVkpd3ZVrfWNHwz67vk5unQBQju8C5Oq87lLw1VTW4j9RqMsbc+uCl9TrFUT6NkqJjYiMVBX1ye dxmGgJMujhzlmkIiXx4cNKOXxVVx8zhlDZheZVVzdZ8wRPh58dbjD67gJypGtf2D/GacybvpGjP AXgnwSmij2+oHZvZ9eUUZo2vDxYnA= X-Received: by 2002:a05:600c:1d0b:b0:485:4136:99a8 with SMTP id 5b1f17b1804b1-48541369c0cmr22242875e9.22.1773082683981; Mon, 09 Mar 2026 11:58:03 -0700 (PDT) X-Received: by 2002:a05:600c:1d0b:b0:485:4136:99a8 with SMTP id 5b1f17b1804b1-48541369c0cmr22242455e9.22.1773082683510; Mon, 09 Mar 2026 11:58:03 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 04/10] hvf: arm: unbreak the x86 build Date: Mon, 9 Mar 2026 19:57:46 +0100 Message-ID: <20260309185752.76865-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082751665158500 From: Mohamed Mediouni We don't really have any great choices here, so use the __aarch64__ define = to unbreak the x86 build. Once the CI moves away from macOS 15.1 SDK to... 15.2 even we can get rid o= f these SME stubs horrible hacks. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-4-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/arm/hvf_arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/hvf_arm.h b/target/arm/hvf_arm.h index 6b1c3b9792d..8029d48caf5 100644 --- a/target/arm/hvf_arm.h +++ b/target/arm/hvf_arm.h @@ -27,7 +27,7 @@ void hvf_arm_set_cpu_features_from_host(ARMCPU *cpu); * headers are not available until we raise our minimum macOS version. */ #ifdef __MAC_OS_X_VERSION_MAX_ALLOWED - #if (__MAC_OS_X_VERSION_MAX_ALLOWED >=3D 150200) + #if (__MAC_OS_X_VERSION_MAX_ALLOWED >=3D 150200) && defined(__aarch64__) #include "system/hvf_int.h" =20 static inline bool hvf_arm_sme2_supported(void) --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082779; cv=none; d=zohomail.com; s=zohoarc; b=dqU8NmXMpqc34k1ChLJ2iZZRVWZHlkr8+f1Xop2WMUi1eKwQSAN/JJO8YUyWPCMYQLlcW+fdRcYG4NfvUpWbWixjv0obaus3Q0rRLqYPC5/GeYKrbFGJR8ybZeyWy4CU4meg0qjyUJzVWXoPKHo1YXfWgWoRZL/vbwrbne/Jzkk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082779; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=Yhdt3T5uAa22pKZgujiD5CG+akbgAW9aaYuktIL8V1EFKmm7dKuQdVnOjhzt81iNaTu4LKazumSAPDNUgV7YfhNGbRaoYSkoO/6GmNTuZ0oZlcFFLPweJL+FqKyFiIxs0OD0MWxtvxjT9ztdV/6Ad2hoYeBrj2WuIsFTTR6kGqo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082779415252.64802235315562; Mon, 9 Mar 2026 11:59:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfnx-0003tK-33; Mon, 09 Mar 2026 14:58:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnv-0003t3-Ne for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnu-0007ol-C1 for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:11 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-GFuDroE0OymMmjN8xL9U3A-1; Mon, 09 Mar 2026 14:58:08 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-439ae2cba40so7126589f8f.1 for ; Mon, 09 Mar 2026 11:58:08 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae35cf7sm27245539f8f.26.2026.03.09.11.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=HNEy3Ouc9hXUXQtHxvDtRvDQ0M/YgOah5FkfwZq3b075+actH/hSyT4zFhzJc+x9+6XLlQ 8VRVD3tI0D8IXGyRwhO0tHpXhSn08S4b6xb8SK4iqYgd5JRyUP57cQFn362J/jyC1ALG3t e48p8Xi+UhnC1Bx5AJmbW5JBE4Nq/AM= X-MC-Unique: GFuDroE0OymMmjN8xL9U3A-1 X-Mimecast-MFC-AGG-ID: GFuDroE0OymMmjN8xL9U3A_1773082687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082686; x=1773687486; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=i6W0ECcyemJC4AtnkGGHgPX3ozjfj5Isn+OF2WSuKkexhN2zH1rR5lnxkL1xohJEbn YtngrInfQm8coyY3N2+v3uF1GMS8WBz3QRflQhV4ZtYATFSv4MNeanwpb27+le8v9912 KdWdNYED5ctEQbUYum7lIagdahY93n2CDlJt4ABjT8T+h9bs6fqyvMFtvFJlBVyc9zzK ZlCpXjLg06RjJykwi2sjjd18gmakSmkhtrqYTDEUCjLuSBkGcCPOrH2rsu0jgKY0aL9Q 9bh1yPFd3fH51+TcOczTly9a8H2YMVV19OaKaeQzd/iFitTIAA7gmWFelOfE9+4b5Lqj yh3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082686; x=1773687486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=tobHTkFJBfh9ZTz4LVysVt4Z3X6nQhdgj5aPhx1HT47MwwGB4cBPk3tB6chenmTB4k jw70dJU5Y1RPZxhwg06BhS9agPFTPjoMU253dBjZSZ4waai0YShq2/vshmbcEnZmcC04 DRuH/2ZhIQAsVW/WMmyNHWJ+mH3Sp1jqwzLdhaaU3lmK33UVf8/AuxY2nVyKwGqOtTq7 LJeyOvFu50w6FP9jpSJ70iOG8TBP9RNUZlZLw6v1ohNE+RBvNrWmZ50x9Vkjnoe4Rngt ZXLMA1t7zseJV3PMnqSgpxO4miDzEHMOmAfPZz5XBYzoksIY8sUwKxvgVAsXaCPMEgYU CVRA== X-Gm-Message-State: AOJu0YwnfYpiiyjSK3LrHjuMXtG6wF9PGUdfbmc76Oc9ano2wKw6lKms R9Te0f3BmgeaGkT/u57yJDIPMR1wIQw8T95rS1/ZaqzPRRBwjvLMFlUFQBuYuwghbVo0vSS7OyP pwe3gVUsLUIExHMqs1BIMxJ/JtLs2v37QqyoWBwKGBzKX5/TOrx4bz1o1sR9ixqRqGYGc18YHxp iFKVRpbuf6tFf0zGjaF/LBTjIVxA03JEiwGTDv7R0A X-Gm-Gg: ATEYQzxs0y4ZTtaU4X8HnSHWNboC5g9BCILUlgbEnRXSJSPyjjhirygTtqgxWOzRbz3 pMVZusDdnm8FvxgPYan5kwbanEYRNutjm1u1ijMLiE+jvddBprmpge7Ud87HdM0iButUR8OZqbO OoFG5M9QiEkINWsfQAW8S0jjtDUun5LxQe90ta/cwdHIfKvE+oIlsdtEQ3z4fiOYMAUxelecfan MU6kKuLT6i9gofsgbVreFQcb7FagLcjowKsMC2YMTMZHczxT9TD9ST/XsWpkawwvDA1xl0u0/je +kulZEZolqzNzBnCA4MHZnvg0Xay3s6Zf5I6rmKyoAxDA3lfpz2P+E588E4/JHRlsGli3+I4/Is 0DTBD1OTaRm9X+UJ6Ieo+tNS5JD59dIUyDNqwolSZfmmiPiJHQnYoLpCfTveeyu6tbxWqiTa/79 35B67hz74VnvsEcaP+o1fJyATtNAE= X-Received: by 2002:a05:6000:310c:b0:439:b28c:d47c with SMTP id ffacd0b85a97d-439da8820eamr22385321f8f.37.1773082686383; Mon, 09 Mar 2026 11:58:06 -0700 (PDT) X-Received: by 2002:a05:6000:310c:b0:439:b28c:d47c with SMTP id ffacd0b85a97d-439da8820eamr22385294f8f.37.1773082685873; Mon, 09 Mar 2026 11:58:05 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 05/10] whpx: i386: do not enable nested virt when kernel-irqchip=off Date: Mon, 9 Mar 2026 19:57:47 +0100 Message-ID: <20260309185752.76865-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082781129154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni This combination is not allowed as of build 26300.7939 and results in: qemu-system-x86_64.exe: WHPX: Failed to setup partition, hr=3Dc0350005 qemu-system-x86_64.exe: failed to initialize whpx: Invalid argument Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-5-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/whpx/whpx-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index c172e86886b..9c60295d553 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2160,7 +2160,7 @@ int whpx_accel_init(AccelState *as, MachineState *ms) goto error; } =20 - if (processor_features.Bank1.NestedVirtSupport) { + if (whpx_irqchip_in_kernel() && processor_features.Bank1.NestedVirtSup= port) { memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY)); prop.NestedVirtualization =3D 1; hr =3D whp_dispatch.WHvSetPartitionProperty( --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082754; cv=none; d=zohomail.com; s=zohoarc; b=lIJCee0oLvCS3lcnovOK1WUAreym4FTt4NN4p6gyU2kdzTgtvTpQwMR58SxPX8FkzidJTtzWtr29aDEYfMI1JelPh3jFExvbb+Pmfm0AVogyt0drMrYQAFIzNpQAXblW6iLGQ9EG6HIfIjajU4QQFtxt006sd+9fCFNeaqLM4iA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082754; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=WpzFH/EEs9xYsPxb/IzL3LSDM4U/17OOZQ/3eGeD5V8L+m3OUie50NyFR/vTnckh7VPoWBbokKVfTGHrE1/2pOGeYY2sb5CnqI6mjdMldd+AyvsB0uSQPlcYdHwEpdfHHl1tVxXPKcNgpB39Dwqvrzh/JbjQOGk1VyxxKeJv55U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082754049225.11260808965392; Mon, 9 Mar 2026 11:59:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfny-0003tl-B0; Mon, 09 Mar 2026 14:58:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnx-0003tL-Ap for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfnw-0007p4-1x for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:13 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-94Npf8jjPyelXov-udQEeg-1; Mon, 09 Mar 2026 14:58:10 -0400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4853ab1cae0so14500785e9.2 for ; Mon, 09 Mar 2026 11:58:10 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485246fd127sm142997255e9.6.2026.03.09.11.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=EiG0HoTtgUvdNgMpqZpKUlo476o0rlF7I0NK6seSfTcy4yVzF7pWnJHtAsFmydE8E3jCqu 85iu03U402bqbDZo+GwYsxNx8LeuYgU88cMkSZUk8ICqFmxdm1wDwLf8ylkHCX/6/uPv2R CyRI2M/lWuGm6sRnbISpA3hyXGgWgsg= X-MC-Unique: 94Npf8jjPyelXov-udQEeg-1 X-Mimecast-MFC-AGG-ID: 94Npf8jjPyelXov-udQEeg_1773082689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082687; x=1773687487; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=qfJ+uE6PMDriTtSl/1cNllAc4EouK0jlPo9dwmf5y55eRh4pPUxk2+6cicytg2jQKw WENDIhs40pL4eJ8Zx4zshFqFhU3t6CUqszAenJBGIzpnVyV4JxDNInzTKMnmxGdIpudD IGQVEvmiccIqY8e/CebrGarnCKgvlcEd0aaxqR7yS3Yvm9SMcJ/gA3DHBw73iXEBUPcs g0lNTiTLD7eyHvIrpY4XjhiW2ZPKpvziglRCf9OColI4U6O7VJSBYeRUySpXCmaEjw1S Up1gXmsT/45tsrxCTrvdn3Mpuxe6iUvwNxdwdzdus0+mBKQ4LirpKww/1Dsq8HrqvoEU qwWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082687; x=1773687487; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=js/EkOh1E3gws9O4lgb+FU5OJ2euCcomF7w5UqScxBJc4acEOWZMcQU3fpTI+KhaSD 5Eoiccx7BOuthihn1irlgNoWhINZY9CNuVGnIRSNlYN+BH3lTNdWjbP3aeUMPXqmA542 hap4cH+AwUQlB4iqyRO0cPPfO9nzkQtDd1QQCmZVm7SiJhAup3ye87ZilM6vpBOpd2oT giz14FL7mhn5lOlC5NVOPOmDtA/318gaNaorNwlf06LlxsJ8XoI9IocwczxjYGIC+4wD dSg1NuuK/mFF7c3vF3dUG1Y9SRk9lhj1Eeo5mRz51k85huRWOwRLMb8lF+gdhPn5mdcN mIog== X-Gm-Message-State: AOJu0Ywuf5jwVj1DwII4YfC7L+p0J9mMggA8Hrh+lQIGjFNmd7zzP4VL acTR7cYze/0zKoqkh9Q6NcjAgjtAdaZL/DyKOaHD7mDTqgNqmW9HBSeWgIhFxlPupqO7FckfK1L CaW1WbAFxWkcZUjdizAburky4OPsOzASvKxlFZX2cyfQfgqD9JVzDT0V9KQZmgTnzOshN/N6yNd 4fbom+SfODvUa0ujrk/udJ/Rx0oJ9LcwPSB5Jhoodr X-Gm-Gg: ATEYQzygKP7WHgmhx1BPKHWO/iOqT01OmT0pknmftK2JNkJHR3IkqRc5hTcqdqj+U1M eT4vGr7SCnrMVL1JVw8wJHLKfc0xV75ABpK/BcNr9C4H4s4gmhDR7fzLluLL3Rh38LrRgzpmLb5 bvkj7YlTqxpvOlqDcoUGIsfxFmeykIB4Uzey1Oa8WVbKLwwWBgWdxd0uYhJHKuZ3pKCXvOdSeWM He9EYVmvB7BCxoNhcRpqTxf477BQQJNDLQ+0MhNaweOc3/3fQJA/XaEIFGG2TD2A+RNddJU9GS7 e27zVLEYkoB59zP957uQvJKzS9q8hAwbpUESrFUHPK/P8bpJPNHJcIBwqoE/7Aq33kz02lU+Gzs 5KWbnMvU/3HcOEZ2JQnIfEPZJZqiFwcK8n/xLEcrkPaOzDfWTE6XGroF2Rf0OwSnNhDwPc/M8qT sdVRlM4myVnawcQMFbRNhIFrrRCIE= X-Received: by 2002:a05:600c:6384:b0:485:3026:2b8b with SMTP id 5b1f17b1804b1-48530262d83mr122865425e9.29.1773082687483; Mon, 09 Mar 2026 11:58:07 -0700 (PDT) X-Received: by 2002:a05:600c:6384:b0:485:3026:2b8b with SMTP id 5b1f17b1804b1-48530262d83mr122865125e9.29.1773082687008; Mon, 09 Mar 2026 11:58:07 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 06/10] target/i386: emulate: LA57 fix Date: Mon, 9 Mar 2026 19:57:48 +0100 Message-ID: <20260309185752.76865-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082756735154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Seen on a Sapphire Rapids box with LA57. The top level of the pte array is taken for CR3, so there was one entry too little for 5-level paging. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-6-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/emulate/x86_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/emulate/x86_mmu.c b/target/i386/emulate/x86_mmu.c index 8261ca16351..4e39bae025e 100644 --- a/target/i386/emulate/x86_mmu.c +++ b/target/i386/emulate/x86_mmu.c @@ -56,7 +56,7 @@ static bool is_user(CPUState *cpu) struct gpt_translation { target_ulong gva; uint64_t gpa; - uint64_t pte[5]; + uint64_t pte[6]; }; =20 static int gpt_top_level(CPUState *cpu, bool pae) --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082729; cv=none; d=zohomail.com; s=zohoarc; b=ANlQlejdUtpz6HQQ0YuSQhRmOoRa/qtBhp/TvPoA7YXWzwCIsTfjkH3D3qcSHQ607F8eQ7x/vE/XzOXOWsYnzWuqKH2R28eUqqkXieOUkMj/k9GfLGiW2bmgSRlYkHqneZaiyduzWtsJIZFs61OtgvWfQfCLTXHRzkfauOvpYLA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082729; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=OeJ4V4ah9GotbQRi1zyftvkOZbZarvHArz6PdzS4qsyQt/e4a+WXDPH2g6QbOkNSnWuO7eAYUahW7fv2U10osrZvSL/zNa3tpcM04CVV+3TlEmwL/rGKdHMIyf3wUglLOIDCUMKfkA2BGSMtiSTA70yr/T91Ei7o03jwlGIEDFI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082729397760.8433431816968; Mon, 9 Mar 2026 11:58:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfo2-0003y8-TA; Mon, 09 Mar 2026 14:58:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo0-0003vx-Be for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfny-0007pK-W1 for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:16 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-Ma4PJE9NM4OKSpSiHFa5PQ-1; Mon, 09 Mar 2026 14:58:12 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4853b0af42aso13128125e9.0 for ; Mon, 09 Mar 2026 11:58:12 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48531818b5asm96086905e9.3.2026.03.09.11.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=GoHm8IZepdFKCVMI/vePCzfyZ+hx5ANSZMJNbIsjneiJNS+HTqIjJr7McpJcyN3d00IU81 FUxSND+j+9djFzF1PbXmrnEA4ssrsesmFpsL7kyjUdI3bn5BCI3ui3FFoTrjRI6MpuX3Df Tq9wmPoYNh7OZLzbCk1nunXSGx8YmlE= X-MC-Unique: Ma4PJE9NM4OKSpSiHFa5PQ-1 X-Mimecast-MFC-AGG-ID: Ma4PJE9NM4OKSpSiHFa5PQ_1773082692 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082691; x=1773687491; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=osvfLWdvhwdyMFg7M0yx0Pp3556jOZmT7CEgk9cfuMeYR2QIWFbrnrp7OjPfeYs1mM xRAyJTyFfO+DN51G61xdkR8PUvUjgGGrjHLblA5TX8UYYP/XyBbWaJgWDbgJ6idlPbZT NrRLPA/xUdQ3O5gkp07tD1TD++tidn9ghd8GBoeUm/hH+H6PNGJ654zstSuYPv1epPb4 1P3fIBmyRnVbNs7z16ubmZKg6urLBBWvESaoVdUDvGC1v6PEU5qgmYHGI4/XWleSO+N+ QemG7bqW3HUz9R6yZZzFT3GKXpyd32y+BHrk8mu8xRZbTtczKV0/wr1kHW1GH0VpgcS6 +dhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082691; x=1773687491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=ouOUy2JFj8d9A9xQ2GvcYrrDC2mZlPYsoWURcjggLIHer+1j7XcfHXp0DirRO4YzaJ tJg84KugWex/DY4Zib1/6cVHYqMC0cerSNDCT9EOvEtWkIgBBCPt4+SFrBesFsiowEfp jxF3AywpHJhQ0i6XFhANVudwUlktG6DSHf3/w6AUEfm+dxfLj7IXC6FdWPPMaoTAT6p3 CnbvG3ATRmRQWd+wzO+VyX85nGcB65oiIM32x/2l69SLnoWyEo52ldbcc4+ntzZAloWO lw+FmG+ZmdUMLy2V6Z6ObG1HGFINgDQzwbLXfUyqEVzyJEPly2wWlWnlKlMH+FMfAUrw T7AQ== X-Gm-Message-State: AOJu0Yyn1lRhPnv8IPCxcIr1tUDKeV72C1bV8BgnQU8wokAdTLTGvYPC srMEqMmKRydao7+Xdw65ZN7E/onTyQULzvTZqg2y4SWfW/UVxvCQ//gI85STCZwNe1vvvNb4H1B aqnebPkmjBHmGSBqichkWuc1quSvSing8YH2wKYineRT95Sk1qb4leRzMi9DCbEqx/MuQwWNGOu BBY8++hyLNCXLQqQTBVGezdEKohIQQhfY7EPRUHx8P X-Gm-Gg: ATEYQzzK7MnwW6UAcbFR7F4bPe6Uph6qOsQUuOXQsGfKu7JH5l7YqbOlbapzPbkzcWZ T9mOW+WtOQ97yVPwzsp5zDUTIzy5f215zGBaLObcR0+9FkiUil03RB8LhKwi5QAQT0VyY/LRNzy kPjRrLmg6/abJAxuyni8NzXbX1BhKetXJHHYo1rVK+Cr+XVGeEFw0FNWHF7+7O912gqOd+nhjB+ 9sdO+Odo9GQ4EfGr2egOkKJ5eAF6to83RfhTUryEUNu88JO7J1I41gZywjCO7xS/iNAq3Tjiljy JPG2/PY4YapoVl4weTCF86/MA9sCLScNrfXuQJPQz+E0M4AVKufI8BoWZktR8CuE3OxPQxgbLMR vHMzt1F9ig8+QcqgK060i7S/LcoNMsFEj955Wwj+XWfTRcpHH0a/sr85iENdNUqodUPVFB7aERp Ax0LydikhULjM3G/BBpw7kIkgP+ck= X-Received: by 2002:a05:600c:3f06:b0:485:3c66:e21d with SMTP id 5b1f17b1804b1-4853c66e362mr59859135e9.2.1773082690737; Mon, 09 Mar 2026 11:58:10 -0700 (PDT) X-Received: by 2002:a05:600c:3f06:b0:485:3c66:e21d with SMTP id 5b1f17b1804b1-4853c66e362mr59858705e9.2.1773082690241; Mon, 09 Mar 2026 11:58:10 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 07/10] whpx: i386: enable some more enlightenments Date: Mon, 9 Mar 2026 19:57:49 +0100 Message-ID: <20260309185752.76865-8-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082730694154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-7-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/whpx/whpx-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 9c60295d553..bc82995b33e 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2214,9 +2214,12 @@ int whpx_accel_init(AccelState *as, MachineState *ms) =20 synthetic_features.Bank0.HypervisorPresent =3D 1; synthetic_features.Bank0.Hv1 =3D 1; + synthetic_features.Bank0.AccessVpRunTimeReg =3D 1; synthetic_features.Bank0.AccessPartitionReferenceCounter =3D 1; synthetic_features.Bank0.AccessPartitionReferenceTsc =3D 1; + synthetic_features.Bank0.AccessHypercallRegs =3D 1; synthetic_features.Bank0.AccessFrequencyRegs =3D 1; + synthetic_features.Bank0.EnableExtendedGvaRangesForFlushVirtualAddress= List =3D 1; synthetic_features.Bank0.AccessVpIndex =3D 1; synthetic_features.Bank0.AccessHypercallRegs =3D 1; synthetic_features.Bank0.TbFlushHypercalls =3D 1; --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082777; cv=none; d=zohomail.com; s=zohoarc; b=ny7PDZzYVeSNw+IxgzaWRLeIQiqGPjNZVq+CxRCKKz+QhvKybqDFRjVVz5Kn5szz0H3Uhs9NLAbWBLt777ReLniz3+3MyWLhcnuThiYO3R/C5cqLdrvMcLrTPEOy9lc6mjvnuqzZmmNoBq/pnHP2o6HgncCEluvFGkVaorBrU5s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082777; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=m8nrO5E1N3acQhluQBcv99yuK2P3lgwMeh1sxDyGh8rQChUBi6qb9m5wo7unCqb0gN7SgH8yJFfVQ52wJVxWOqcOqVmsmTmKSqpzxZ1BpSbCqlU3DmgzCERzvwk9Rpu8/Z6+3yTuEsFNGaAyAKZEUc3sp7+F1ZM8i+j6y649eJM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177308277760863.388407245108965; Mon, 9 Mar 2026 11:59:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfo5-0003zf-3p; Mon, 09 Mar 2026 14:58:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo3-0003yp-Es for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo1-0007pw-Fq for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:19 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-PI71__xoP-qvVxKwKTJOyQ-1; Mon, 09 Mar 2026 14:58:15 -0400 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-439c794edd9so6108939f8f.3 for ; Mon, 09 Mar 2026 11:58:15 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae49177sm27632397f8f.35.2026.03.09.11.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=ERxDdSblX3/mV6AMpPRwqgDSE8DxvOFctZ2w54Dr1s86sTkmgXByX7stwG2h2tDQ869rxP WRMyQIhUwITGpK2T1UU9KxFM9HXCK3bkGg/Rq935qFJMbcDwDcERhk0sFihGA8cwZENeSh F8pwfdQ+CM/iP1pCZMOGNT95UWjrnjM= X-MC-Unique: PI71__xoP-qvVxKwKTJOyQ-1 X-Mimecast-MFC-AGG-ID: PI71__xoP-qvVxKwKTJOyQ_1773082694 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082693; x=1773687493; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=EfUXVLsl1FST+4jlRiQw6fgUdbiPHxOVQYIFR0/CRiG+y4M3Xc1wIzT4kEfZ/QeW2m UZTIc80sF4CBzU9PTr5/7mizCs0Si18ywcPt2zg+6kX8+FkrO56T/16x8+U4Au0O4v9y fS4LEku63VMyYZJj1q2BB4Cab8d1RI3li7Xc06KkH2ZpjNfcbieXzuH0tI4bej/ad0j/ FdWo6v25y/AcKruzSpZ0liVIob9B79EFd3STjPcwX+qepzwiSMJE5cl5dY25vR28iW5n hbBtG3pJlkK6Gv5/fzc8/4yjjfYcOTYmA+QHHCt6yRW59UFX7cw7UlxV9uUdVb7BVzog CphQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082693; x=1773687493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=hdaCxv76zli2AXU2/qnDyYvbeBoBWniuI0sEnEwiZUgRSX0jfqcJ1CAtVbUmMQmSWX fZtXm/7em4dKoaJYrGPiowv4x2joB9isSssfoVW59nGahYVVFY0VZFxe/iPuYgDYEput JNxryacNZ9rkgn5eAEn6Gk6bunZR2dvFfvzxBtc6jTUJZJ3elvBpg8ZDcUyFYhzICkqw dqpYQnvo7Xv4l17yohO33EvksVyzET7BSPHF28nOf3yHzWSmQUXmrlNDf9eDe8ETUlDh 26N144ccOBB0FcuKgBrrbi+7hHSdLl0Wu+l9aPBd3XvvTMUUMCTYXTS5vQcghKJP+sSa aNVA== X-Gm-Message-State: AOJu0YzgAz2Gp8i9J+V/nTISqpfB6nEIDYtR1l4fx8Crjug7licA+FCK 21hub7JpHk0TtNJmPGOqZ+1u4vRAZvb92dXTO/BVuYalzoi9Kks66RCwHpAEtXgbnAAARSWuqJd 7DQEtuZfewly9F4iEDd8XE47rgTlK2a0wa93RdwfL6Z/obh3rS/ObwHuIkkEJdpFlk9hcCPs4pH r3AEmSnX9jTg9VAtwa8C0NDCfO8ok/Ghx+GBFFWZJQ X-Gm-Gg: ATEYQzw+JWvmtSSi+3F4dgtexRguxIf3GPqgENF/yKcnwTI/ule74kz85tTgD1fLL+O YQUYCm/slGLYyX5kkhXpYevpuZveuW21RamW0rDKYzggvQeygTVuC/gopzghcQzrDZ5B2rK/q8b ouKhSbXXKj/DafT10Zpt0HlA92uF9b8yJZfqvH2tIfdRseDT8XQGOh4FSqLx0Ux9DzebhoGybHF +JkvV3gwnx23mArkn1o2tKAneI69hEtgfZqzLQHocqIUo20/9c68LGZSJpcE1KyLyvxtPhvVR0w PaORCavL7t2x4KpcX5HBJIHc923IJeseWD4pZ8ts5d5WlocKjl6WrzlLHbRyhp7zK1Pl0rlTDpw HYY5XvckOZV1MssxGfwrfD53vU1d3beo05u/gyWF93626Z5ApWOyVtlMVCDNhQvkBWIadK5A9R/ Vh3hs1pISn17V6BWy8XbEbnGZUQag= X-Received: by 2002:a05:6000:40dc:b0:439:c9d0:5fc2 with SMTP id ffacd0b85a97d-439da891b2cmr20700000f8f.39.1773082693092; Mon, 09 Mar 2026 11:58:13 -0700 (PDT) X-Received: by 2002:a05:6000:40dc:b0:439:c9d0:5fc2 with SMTP id ffacd0b85a97d-439da891b2cmr20699941f8f.39.1773082692510; Mon, 09 Mar 2026 11:58:12 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 08/10] whpx: make Hyper-V enlightenments configurable Date: Mon, 9 Mar 2026 19:57:50 +0100 Message-ID: <20260309185752.76865-9-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082779161154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Have them be a machine option instead of a CPU one, to have something avail= able, even if not ideal... The existing Hyper-V enlightenments configuration mechanism is part of per-= CPU configuration, which happens too late for this. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-8-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- include/system/whpx-internal.h | 4 ++++ accel/whpx/whpx-common.c | 43 ++++++++++++++++++++++++++++++++++ target/i386/whpx/whpx-all.c | 20 +++++++++------- 3 files changed, 58 insertions(+), 9 deletions(-) diff --git a/include/system/whpx-internal.h b/include/system/whpx-internal.h index 7a1c9871f18..8482901f714 100644 --- a/include/system/whpx-internal.h +++ b/include/system/whpx-internal.h @@ -42,6 +42,10 @@ struct whpx_state { =20 bool kernel_irqchip_allowed; bool kernel_irqchip_required; + + bool hyperv_enlightenments_allowed; + bool hyperv_enlightenments_required; + }; =20 extern struct whpx_state whpx_global; diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 4863fc86631..b813a5d9d25 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -470,6 +470,41 @@ static void whpx_set_kernel_irqchip(Object *obj, Visit= or *v, } } =20 +static void whpx_set_hyperv(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + struct whpx_state *whpx =3D &whpx_global; + OnOffAuto mode; + + if (!visit_type_OnOffAuto(v, name, &mode, errp)) { + return; + } + + switch (mode) { + case ON_OFF_AUTO_ON: + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D true; + break; + + case ON_OFF_AUTO_OFF: + whpx->hyperv_enlightenments_allowed =3D false; + whpx->hyperv_enlightenments_required =3D false; + break; + + case ON_OFF_AUTO_AUTO: + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D false; + break; + default: + /* + * The value was checked in visit_type_OnOffAuto() above. If + * we get here, then something is wrong in QEMU. + */ + abort(); + } +} + static void whpx_cpu_accel_class_init(ObjectClass *oc, const void *data) { AccelCPUClass *acc =3D ACCEL_CPU_CLASS(oc); @@ -498,6 +533,11 @@ static void whpx_accel_class_init(ObjectClass *oc, con= st void *data) NULL, NULL); object_class_property_set_description(oc, "kernel-irqchip", "Configure WHPX in-kernel irqchip"); + object_class_property_add(oc, "hyperv", "OnOffAuto", + NULL, whpx_set_hyperv, + NULL, NULL); + object_class_property_set_description(oc, "hyperv", + "Configure Hyper-V enlightenments"); } =20 static void whpx_accel_instance_init(Object *obj) @@ -507,6 +547,9 @@ static void whpx_accel_instance_init(Object *obj) memset(whpx, 0, sizeof(struct whpx_state)); /* Turn on kernel-irqchip, by default */ whpx->kernel_irqchip_allowed =3D true; + + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D false; } =20 static const TypeInfo whpx_accel_type =3D { diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index bc82995b33e..b095c96962d 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2232,15 +2232,17 @@ int whpx_accel_init(AccelState *as, MachineState *m= s) synthetic_features.Bank0.DirectSyntheticTimers =3D 1; } =20 - hr =3D whp_dispatch.WHvSetPartitionProperty( - whpx->partition, - WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, - &synthetic_features, - sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); - if (FAILED(hr)) { - error_report("WHPX: Failed to set synthetic features, hr=3D%08lx",= hr); - ret =3D -EINVAL; - goto error; + if (whpx->hyperv_enlightenments_allowed) { + hr =3D whp_dispatch.WHvSetPartitionProperty( + whpx->partition, + WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, + &synthetic_features, + sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); + if (FAILED(hr)) { + error_report("WHPX: Failed to set synthetic features, hr=3D%08= lx", hr); + ret =3D -EINVAL; + goto error; + } } =20 /* Register for MSR and CPUID exits */ --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082754; cv=none; d=zohomail.com; s=zohoarc; b=EUhYosRIXPn44M8fzZVsuGR77kYyJmltAXrK09U3J07WMKXgE2D4AFft7uaT5w8NEs8l6T/JUjuaA6+FtgYuYsDkTYxa56AZ9Q/hjxCOV1ciJN/L2cUQ+mrib1vdQUlsC3xdBPdkdzXIoIk3huJ8RSfrrDWqkWz0tzPJRueLKGw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082754; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=TWAHEvQnPkofCoTBs643IhPKM8LQzeF2/IWg40Ytu3qQjnMCsXXf5nf/FBl3ReaukwEQe/2lr9epemh1Ag1YT7UgbeTNWEUTeV5rhNVcoCyehDQ4JO+yzCnz/qv98z8dKqmTYPf5dSeNY1hcx4bcnlobkdIttSZI6me/qQ2ij0I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082754337624.763700267765; Mon, 9 Mar 2026 11:59:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfo5-0003zy-TA; Mon, 09 Mar 2026 14:58:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo4-0003zR-Lc for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo3-0007qH-2N for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:20 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-_duFqRcuOF66UxFdarkZ7w-1; Mon, 09 Mar 2026 14:58:17 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4852ccff333so28564285e9.2 for ; Mon, 09 Mar 2026 11:58:16 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48529f019a4sm85009545e9.12.2026.03.09.11.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=Tx652R50KTLLXlV5wbFk1KnqFatA6C3e7Q1tjBjDouItw7UEBgWZachWha3htOdp1fn7MG BregSfh8Ps+AZ+MPZiNS1STzWK3kj0oRSuCe3ZKTW+UOmuEmyiU2QLOPb1/OnPZm7Kmxce 50HZS8UVvR9sROqr1XyE6J1/Ly2cDGc= X-MC-Unique: _duFqRcuOF66UxFdarkZ7w-1 X-Mimecast-MFC-AGG-ID: _duFqRcuOF66UxFdarkZ7w_1773082696 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082694; x=1773687494; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=p2w2Lp9T14M8Jm/kQT+a3DoM1aEVeGfGGNSM7prDIO2/Sm2S71CGELg3/yZ/RP15BU 1xIC+eCb4UHtrCCl69Unb6bkkwqUNYHqya6AOQixIeDKtMBvWm0NmGCD3Dy4qHncEZnJ aGN04V9yusQHk4iXoaOfqRR1rd3bNGKgUET2rwIvlVGaMGkIj907Dgn4WY/onrwny1X7 HjtlJkd3F/f3iwf4M9wF/m5UhzC0BJm6jI2LGtflc7+5YP4PKXvKr5o6iLUbfCNO9AO8 7s5N8XMSdFdt2MpOdvgcbDn+Uv6fg8QrapUQeDeW8Bo/mdD+6iSCiWK0O+7SVvdAMu9L oyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082694; x=1773687494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=Paq49JipKy68sxLU6mmTMkxfGVBRN+NragFNfNFp8afiBE+NTDUPFyul2raccvsVUy 0EAZpJHWSMncqXRDzTSrCwItEKptSnI6JhjGiK2nWe4lT8XY+mef2+DVVvQon0su1b9k eorzh0ZAwY4ZsHP15neXb0Bv/bNDcpNkgn4NHF3Y50Y+9j8sRo23DRvF4POL39QMX8WS Mt+K6ZecFO0uDKvPhqKarDaPyLpieAmZ0fdVmVcCmS76Tqd/RnB3orvvybzxCgsEAoSh 2Zzn37DvZfM6GxcArGt5SENDOKoE74QmbE5Rj/BI6Iyd8Y58lyQZXv6hvGN2Q8ujtu1w ML3A== X-Gm-Message-State: AOJu0YyPbwPbNuQpbs9EsNWS0Jdio/thZx2Aep1ziYr9hdnJdH3zKswA zNxEJsnZvMDRPPJphAZnpwotIjG685KbE0DhC1VsM2oQhCO+0M1o0rCUI0fz/PX/3AVR9r1UvIL 8ViUNtdi6VYTqHLHeZtReAkOb89DQGCK68FWJqXcXGhpmoE1de9pu7zO9sptSfiH+5cyVUKMgzK 8SawpM7EYadylSUvH4OlGD/i6TnTfOS8a42lEgdmJq X-Gm-Gg: ATEYQzwtFg1RiRWbU/+JjGXKgqs48/1cGN7zSocBdvJLoQodkCCL83SMWe8jH/p7q68 VPDPe8sObOMysDXgZKSBEGBaEc73IZCvri1lDULvYRGkZhq0pe83Cd3wlDhJBvHVh6frxhFz8Lp qZgczN5zM/d5SJG9ip+sXOdOOMlY+VHBr54rTS6UFFtQ4MTSpJejFdqwsZkqdKpGCz9UR6BK1It fPiG2PXvcATZ3vzek5fBQS9CLIk7DxbcqRHKMsVMx0q7wON0es23Uv+VWGLulEkCtbmZ4Dq+dks /2NYCBTysV0mBKrK31YC/S7Jpk5CPvMLcueR5XNN6nWV/gb9FhacknEjVJmITdLQmuRTPedkEDP zsCNCJy5DpHTC98H6yeVH37pz3NspWDjX3gJy5BRfrZ+ibR6J3e9HaVME8pbDpuKPS+idpCmCLc N7wbZzWhUKzbP5aZd32X5bO5jc0qg= X-Received: by 2002:a05:600c:c173:b0:485:3812:36dc with SMTP id 5b1f17b1804b1-485381238b3mr100271365e9.9.1773082694406; Mon, 09 Mar 2026 11:58:14 -0700 (PDT) X-Received: by 2002:a05:600c:c173:b0:485:3812:36dc with SMTP id 5b1f17b1804b1-485381238b3mr100271015e9.9.1773082693882; Mon, 09 Mar 2026 11:58:13 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 09/10] whpx: arm64: enable enlightenments if asked for Date: Mon, 9 Mar 2026 19:57:51 +0100 Message-ID: <20260309185752.76865-10-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082756757154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-9-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/arm/whpx/whpx-all.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index c5b108166ac..513551bec1b 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -940,6 +940,43 @@ int whpx_accel_init(AccelState *as, MachineState *ms) goto error; } =20 + /* Enable synthetic processor features */ + WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS synthetic_features; + memset(&synthetic_features, 0, sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES= _BANKS)); + synthetic_features.BanksCount =3D 1; + + synthetic_features.Bank0.HypervisorPresent =3D 1; + synthetic_features.Bank0.Hv1 =3D 1; + synthetic_features.Bank0.AccessVpRunTimeReg =3D 1; + synthetic_features.Bank0.AccessPartitionReferenceCounter =3D 1; + synthetic_features.Bank0.AccessPartitionReferenceTsc =3D 1; + synthetic_features.Bank0.AccessHypercallRegs =3D 1; + synthetic_features.Bank0.AccessVpIndex =3D 1; + synthetic_features.Bank0.AccessHypercallRegs =3D 1; + synthetic_features.Bank0.TbFlushHypercalls =3D 1; + synthetic_features.Bank0.AccessSynicRegs =3D 1; + synthetic_features.Bank0.AccessSyntheticTimerRegs =3D 1; + synthetic_features.Bank0.AccessIntrCtrlRegs =3D 1; + synthetic_features.Bank0.SyntheticClusterIpi =3D 1; + synthetic_features.Bank0.DirectSyntheticTimers =3D 1; + + /* + * On ARM64, have enlightenments off by default + * as they're not needed for performance. + */ + if (whpx->hyperv_enlightenments_required) { + hr =3D whp_dispatch.WHvSetPartitionProperty( + whpx->partition, + WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, + &synthetic_features, + sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); + if (FAILED(hr)) { + error_report("WHPX: Failed to set synthetic features, hr=3D%08= lx", hr); + ret =3D -EINVAL; + goto error; + } + } + hr =3D whp_dispatch.WHvSetupPartition(whpx->partition); if (FAILED(hr)) { error_report("WHPX: Failed to setup partition, hr=3D%08lx", hr); --=20 2.53.0 From nobody Sat Apr 11 21:30:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773082749; cv=none; d=zohomail.com; s=zohoarc; b=NhAVnAAbov8C9vzEH4X01msOIhWzlO3B3viOmDL5CAgO33NdpMj8oU1+I/kwDnnw4KqKl2FSDqWznyYVMIua+6RDGgMGMWf19oGZHg3NVv6OoRuLQ8ZcYN/STQ3YSwvC+MqqgXo2wGjGJ/QmzXLLf3p8aMqhIqr8bdDaGhvawf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773082749; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=oDYjol194ZVndQftAr3Tt0jX4oEACEIZDqVk307+3Gcfsa3DWTBJCsT6AD0aP4IvVrsvjFZrIUjxZsa2HSojEYiQesjiRA/XoKEeYV14Wj3chXDx+VNvl/YTx5WttNYWIr0gkOVH+QoJ1Dt4n3N3k2Ev6SKLHSsx6rSJZ2mILck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773082749392949.6963888311988; Mon, 9 Mar 2026 11:59:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzfo8-000439-Vx; Mon, 09 Mar 2026 14:58:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo7-00040M-H6 for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzfo5-0007rA-VG for qemu-devel@nongnu.org; Mon, 09 Mar 2026 14:58:23 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-529-WvWtpYY5MpmqD0mla67jdw-1; Mon, 09 Mar 2026 14:58:19 -0400 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-439c12269f3so4161967f8f.3 for ; Mon, 09 Mar 2026 11:58:19 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae49177sm27632784f8f.35.2026.03.09.11.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 11:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773082701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=NjnUAwCilAc7TiQQC5zSq+Hx1Bc1P6pTAIRhlB1jtgmAQb7thIHAsa0g+gsklVGPaEO6cV sMBE25HjXVrXm2siHvxA0gGHhf8/ghhklZBaGzr5UfgFwcoqA36BbA8x9naQfkin6E9gfa OftluuhA8pq3MYrOSFofGYJ+W5zcUkA= X-MC-Unique: WvWtpYY5MpmqD0mla67jdw-1 X-Mimecast-MFC-AGG-ID: WvWtpYY5MpmqD0mla67jdw_1773082699 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773082698; x=1773687498; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=UhSEd9fsI/Ac7TXVenZ+6aritHaL8nIpyCHoqANM+grXDZ/f4NPcE8fAe+NcFvymP9 gw2G1a2v1H5yvUZMNTfaoxmUaL9MLUDnEP77BdGQRnq2BOW2yLVSo+N91eTsh650jXu6 pt/CujVE2zl9TKkGxI12MhUJi9cUocbN9eQ1u9tboZJbCJXNBgi0uL1PAHtJnKbM0bB6 pXF3xjLRXQ/+14gIOcMRa32NFkOxnBsOFGtKQFzJjsoTz6rIAYWO7v39QlkQ0W/rWD1/ +pgiVEOnsZ1ThJIByAWR4VIjZo/Mt658FNE4lv5rEAxneJaHGCvqLy2qNu/hvqY/RBJk dUsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773082698; x=1773687498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=mPAW7KQB+gOezQwqz6Tkf/a00WDkAWBJTESIgI2UlUvdhSi0cmcrKzFkoZ/mDIyGUa AEKbZycJT9T2/kUg86wtYWnvgnGSQuhM9n1vqvJsNUZjPjcTQLL0umyYL55AB9EtLnuF CJy5LWyZjy2yUOCTmeUtY40m2YbeAlavF5WS3lxbR0ZSbxTvigD2YFhVRkwyawlE99de XlJu+6JL6HJXVE/wbhyXd/YPZgp7eUdk8auFQQf7Sv4l/IxBFF50tSKIbeO06LdFGxfV p1AYP7HlYz18t4CZzSgw8hLXaCh0oTk4rhqeYR47CsC5jtKgKBeaRjiUmPkZPmQ+o1oe YWbg== X-Gm-Message-State: AOJu0YypNg3b36igdqpGFgL/3eyf4+Reoy/OWMhYrqSrtAXfTbA1EDK4 ImCTcD8KovH1un0zvoimDd81FQcBhcwDSSgdafPF545rH6EIg8c85ujgLOM6zYAtpxsGO4/UMkC WedOSZhyIKSZqm179fYbHday1eOasCRR9ndh9vzhO0RTLyndpoIcQyfVKH6utc0XXoHwRh3xuaz N4qj2aXbSYKG6p3MfKLmNxRvDB9ftD+ETlfULQkHRG X-Gm-Gg: ATEYQzwV7bKEuAxUfCYeB2NZ4vRMzpVSOInfokqOds9fK1Je1bKipliH3BgLJJgVy5o RuU6xRYXcilMFBxBl/JHuJ5EfszV9Ri6zsG35xUAU2mM/vyGC+9SpSyf8EQv9hMVpHE1FWGVANg i8GHGrLYc3hOxzxIT/vS+WOAk+rVEyzR7L21R5yIauxl/pMXyB3N9BVFDUNd17eWF09zVY03AJG sKETyxbCzSr4IvUw4LiyzWrPZNtcSaH5WvF+hGcB3ujwOCZHjw3Hapbdc71zl35aTKY/9rPGYdu Yo90/AD5BaNbXV66o5uafiaUPKPslo37Ba08DoiGXbGMe5MX5E3VH6UvUqOOCefQWC9RZH7BzEG R0UOBpww3/r2HT95ZO840V8uvrziobEhR7XujWS69L3vVqvdtTY7ZmgKEyKb1WUZkEzGeqoPRb/ 4FOnLOysUVrpz3fIssSUNuOHj9cd8= X-Received: by 2002:a05:6000:26d1:b0:439:b486:ba6b with SMTP id ffacd0b85a97d-439da89401fmr21864478f8f.39.1773082697882; Mon, 09 Mar 2026 11:58:17 -0700 (PDT) X-Received: by 2002:a05:6000:26d1:b0:439:b486:ba6b with SMTP id ffacd0b85a97d-439da89401fmr21864407f8f.39.1773082697294; Mon, 09 Mar 2026 11:58:17 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 10/10] whpx: i386: remove SIPI trapping Date: Mon, 9 Mar 2026 19:57:52 +0100 Message-ID: <20260309185752.76865-11-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309185752.76865-1-pbonzini@redhat.com> References: <20260309185752.76865-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773082752719154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni The implementation in Hyper-V works fine and the code currently present doesn't handle x2APIC correctly anyway, so remove it and use the implementation in Hyper-V. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-10-mohamed@unpredictabl= e.fr Signed-off-by: Paolo Bonzini --- target/i386/whpx/whpx-all.c | 97 ------------------------------------- 1 file changed, 97 deletions(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index b095c96962d..4d5d3dbd243 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1692,100 +1692,6 @@ int whpx_vcpu_run(CPUState *cpu) ret =3D whpx_handle_halt(cpu); break; =20 - case WHvRunVpExitReasonX64ApicInitSipiTrap: { - WHV_INTERRUPT_CONTROL ipi =3D {0}; - uint64_t icr =3D vcpu->exit_ctx.ApicInitSipi.ApicIcr; - uint32_t delivery_mode =3D - (icr & APIC_ICR_DELIV_MOD) >> APIC_ICR_DELIV_MOD_SHIFT; - int dest_shorthand =3D - (icr & APIC_ICR_DEST_SHORT) >> APIC_ICR_DEST_SHORT_SHIFT; - bool broadcast =3D false; - bool include_self =3D false; - uint32_t i; - - /* We only registered for INIT and SIPI exits. */ - if ((delivery_mode !=3D APIC_DM_INIT) && - (delivery_mode !=3D APIC_DM_SIPI)) { - error_report( - "WHPX: Unexpected APIC exit that is not a INIT or SIPI= "); - break; - } - - if (delivery_mode =3D=3D APIC_DM_INIT) { - ipi.Type =3D WHvX64InterruptTypeInit; - } else { - ipi.Type =3D WHvX64InterruptTypeSipi; - } - - ipi.DestinationMode =3D - ((icr & APIC_ICR_DEST_MOD) >> APIC_ICR_DEST_MOD_SHIFT) ? - WHvX64InterruptDestinationModeLogical : - WHvX64InterruptDestinationModePhysical; - - ipi.TriggerMode =3D - ((icr & APIC_ICR_TRIGGER_MOD) >> APIC_ICR_TRIGGER_MOD_SHIF= T) ? - WHvX64InterruptTriggerModeLevel : - WHvX64InterruptTriggerModeEdge; - - ipi.Vector =3D icr & APIC_VECTOR_MASK; - switch (dest_shorthand) { - /* no shorthand. Bits 56-63 contain the destination. */ - case 0: - ipi.Destination =3D (icr >> 56) & APIC_VECTOR_MASK; - hr =3D whp_dispatch.WHvRequestInterrupt(whpx->partition, - &ipi, sizeof(ipi)); - if (FAILED(hr)) { - error_report("WHPX: Failed to request interrupt hr=3D= %08lx", - hr); - } - - break; - - /* self */ - case 1: - include_self =3D true; - break; - - /* broadcast, including self */ - case 2: - broadcast =3D true; - include_self =3D true; - break; - - /* broadcast, excluding self */ - case 3: - broadcast =3D true; - break; - } - - if (!broadcast && !include_self) { - break; - } - - for (i =3D 0; i <=3D max_vcpu_index; i++) { - if (i =3D=3D cpu->cpu_index && !include_self) { - continue; - } - - /* - * Assuming that APIC Ids are identity mapped since - * WHvX64RegisterApicId & WHvX64RegisterInitialApicId regi= sters - * are not handled yet and the hypervisor doesn't allow the - * guest to modify the APIC ID. - */ - ipi.Destination =3D i; - hr =3D whp_dispatch.WHvRequestInterrupt(whpx->partition, - &ipi, sizeof(ipi)); - if (FAILED(hr)) { - error_report( - "WHPX: Failed to request SIPI for %d, hr=3D%08lx", - i, hr); - } - } - - break; - } - case WHvRunVpExitReasonCanceled: if (exclusive_step_mode !=3D WHPX_STEP_NONE) { /* @@ -2249,9 +2155,6 @@ int whpx_accel_init(AccelState *as, MachineState *ms) memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY)); prop.ExtendedVmExits.X64MsrExit =3D 1; prop.ExtendedVmExits.ExceptionExit =3D 1; - if (whpx_irqchip_in_kernel()) { - prop.ExtendedVmExits.X64ApicInitSipiExitTrap =3D 1; - } =20 hr =3D whp_dispatch.WHvSetPartitionProperty( whpx->partition, --=20 2.53.0