From nobody Sat Apr 11 21:31:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078335; cv=none; d=zohomail.com; s=zohoarc; b=Lh7Is0BKrXv6083hL335BuhuPFDvkcUWA2letnWzkSw2dtLvOcneE2Ff67dhrC2EWmcEckZUKUproOK1DzGT/Tnt/GHXvdy6MxDrEl41tplywW9u1a0zbFeRG4UVdUO4W387eRxQwekvasOdPJna7BYLE/mLz2NzXpamX67t9Ss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078335; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=bqxW/vvPuJZp9Z8zIh/WPw1bai65Dc9lEnriBbhYQ+tsDQW4ME1lFomGkd/zSWspDb2yaVFEvlUUfJK3msfdABDOESqGP0k9FwApUb2hJAV/RlNGt7zsbwc499UEgNOA1aLBiKntnpqHs7ZYVYiHXfwI1fUelAH/p+mKJOFrosw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078335088181.15963433021318; Mon, 9 Mar 2026 10:45:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzee6-0002eW-UE; Mon, 09 Mar 2026 13:43:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzedy-0002bu-SG for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzedw-00025L-CD for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:50 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-CS31i4tGPLmhSsxCKvrFvQ-1; Mon, 09 Mar 2026 13:43:45 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4853ab1cae0so13968865e9.2 for ; Mon, 09 Mar 2026 10:43:45 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4852378e700sm159681725e9.0.2026.03.09.10.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=ZeX2JqJzI+otvpc4StZ3gN12ANBp51K/G8hLSryGNxfpSizaDbB5+H2H0wEiJuGh9IULGY 5cJx+jEroCpjxvOvkfxseS1+1WiyZRFhQoyr8fjfmqAvwLhjPiMwjrBRugLaRLUtqJiCG2 jS3fE3IOmKUqkpn4Nhc77kEMYB6YfKw= X-MC-Unique: CS31i4tGPLmhSsxCKvrFvQ-1 X-Mimecast-MFC-AGG-ID: CS31i4tGPLmhSsxCKvrFvQ_1773078224 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078223; x=1773683023; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=S0uWz8KI65DEkU3DQSbLt0KgjRxDmQClSOq+YYlJC4sTtnHXDuot7hmJ+DHydVZZpy HMsOPeEDL1I+5i/48l9y/mcrmGrL4vrcwsIXLPhruw94Yd0fjLLCDkXiveffvyrCeLTU SIU9U8dvWYFDStwdLrr7bIW1JzJhhJGbF6UrOO2Rt7+xNajUF/JwlsfLoA0qJmoQVB7O GH6Ai+6kZ3r2Nfw+cliSH4619xkgjdWMFlqtHUO3tkJdsch0IWOnqp99zqUR9ISwklwv tt3I5SJhbsIA1CZhg7BwC86Z5GFkeilBWCaxD6tumlGWCXjMgTkvbTG0X17EQ7yt2+JJ JWog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078223; x=1773683023; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qOy9OTL1uqEbN8LPQAT/LvbFrV6eEdN3lcnzY+kqSow=; b=k8OLpChLX5SuCyf/SJYXWHOdq+X4MDBQ39enfU/CWUOY8cfa6AswSGN8EC6jbGcDuU eRzlCpX1FP9WOkcMlkZks6nKyEXHkwVEq36VI+t+1wAMZm4FPya88EOdUQd6mT1lRAHU ueb1o3OtbvCch9z0dWodxhA988HNMmekh7Xz4hW2x8NldyLGpB7u9ftsQ14B+JlBr183 CI3H8xgLdDl8+zs2+gfAYeXFfH+hQEZyfD1uvBy9bXEQwzd/1atS1g54+npu4jtraLsb QUVWERmKpCk9zOfV5V48xrlM+XvsgyhIi8ggQHIGlLbxxyYVU1zwdeOTiWPKuDpVpIcY 03/Q== X-Gm-Message-State: AOJu0YyZNSiI3dFl3cVWZnsuRFQ/QzvARly+sKt6oMCb6dlPoOCXvKpf giK9rTjdgYv0GCK0zw/DgwcGfNxFUuVeNwj4OXXXF2YxbAcsFOYlkr4kKaiJQPAYKNlngU385aZ J4DD4zT833CzVzk++/263TbvriGXOuE8d9QWJt5lwvRIw2f8795U9OcU3RvFieTBdohMlGWMFDE j6g68ABcwDvDXbM7pMyp+yRisCRAN416pPHDcgmsNK X-Gm-Gg: ATEYQzzEK1jKfuTtS/Njtn+Z7JohlIcAZQ9UGVvMXage62WhN2t+rAXm/SWdaxaQpnE n6dglLJhhol8bUemsN2XH0Ogm+QnHHN7YZJKjhyG0lAwQiwwrmJnpLEosuSnTurcdTfd4kTvv0R KyeeubRq+dyzkxOo00Xce7h2S7Gd8w48T+eOIG9dm2kjd6m+jcsczPW722/ij90++Oa9XJt0Rs0 wSBGeqfdluLjO6VSsrdOL8N89cWpBLACG9vYjbzyRfnZ3jB0dbib/JULbV3hafy2wqxZvog2AF2 kQVuXXBB3gn/ByrwHahwk08EGc2pnFlurIjQGVxHMxzlx3LKDidFRxCLdzYvqxeJAmWRHJweuJQ B9XPS/u1sRfjB1pq4TC+5z/VjrA8XLd6oNUlntr1eYFHVdGXjklKa6+1u1xKsKgZ0/oLQ/FeyEm 4/r573dza+FyvPmlsu2pEfzV0q8wg= X-Received: by 2002:a05:600c:5490:b0:485:35ee:f836 with SMTP id 5b1f17b1804b1-48535eefa3emr92752465e9.2.1773078223406; Mon, 09 Mar 2026 10:43:43 -0700 (PDT) X-Received: by 2002:a05:600c:5490:b0:485:35ee:f836 with SMTP id 5b1f17b1804b1-48535eefa3emr92752095e9.2.1773078222919; Mon, 09 Mar 2026 10:43:42 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Siteshwar Vashisht Subject: [PULL 01/10] xen-block: remove NULL pointer dereference Date: Mon, 9 Mar 2026 18:43:31 +0100 Message-ID: <20260309174340.52174-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078336531154100 Content-Type: text/plain; charset="utf-8" If params is NULL, xen_block_drive_create calls xen_block_drive_destroy with drive =3D=3D NULL. Reported-by: Siteshwar Vashisht Signed-off-by: Paolo Bonzini --- hw/block/xen-block.c | 41 +++++++++++++++++++---------------------- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 5dc4ba9d076..474c12fe4ac 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -883,32 +883,29 @@ static XenBlockDrive *xen_block_drive_create(const ch= ar *id, QDict *driver_layer; struct stat st; int rc; + char **v; =20 - if (params) { - char **v =3D g_strsplit(params, ":", 2); - - if (v[1] =3D=3D NULL) { - filename =3D g_strdup(v[0]); - driver =3D g_strdup("raw"); - } else { - if (strcmp(v[0], "aio") =3D=3D 0) { - driver =3D g_strdup("raw"); - } else if (strcmp(v[0], "vhd") =3D=3D 0) { - driver =3D g_strdup("vpc"); - } else { - driver =3D g_strdup(v[0]); - } - filename =3D g_strdup(v[1]); - } - - g_strfreev(v); - } else { + if (!params) { error_setg(errp, "no params"); - goto done; + return NULL; } =20 - assert(filename); - assert(driver); + v =3D g_strsplit(params, ":", 2); + if (v[1] =3D=3D NULL) { + filename =3D g_strdup(v[0]); + driver =3D g_strdup("raw"); + } else { + if (strcmp(v[0], "aio") =3D=3D 0) { + driver =3D g_strdup("raw"); + } else if (strcmp(v[0], "vhd") =3D=3D 0) { + driver =3D g_strdup("vpc"); + } else { + driver =3D g_strdup(v[0]); + } + filename =3D g_strdup(v[1]); + } + + g_strfreev(v); =20 drive =3D g_new0(XenBlockDrive, 1); drive->id =3D g_strdup(id); --=20 2.53.0 From nobody Sat Apr 11 21:31:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078355; cv=none; d=zohomail.com; s=zohoarc; b=JP2HMALWmjVz7s+Cz859RL/dnCpkiOtxi0EUxHHS/M7l5yLh/4kZZeMTm0wDyKnQlmvtMPChV/FvHTGVY3wGcny3LVNsKCJgBkbjIslRu1IMfIYJYfy1rGpiSf9AXfRRXPXlEuznvawnWOP7XdxfIEG+P7JdzwTtinlVs5UG+Ao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078355; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=e2wdswV8oYSB09kw3FwgnQjbvYvDF9YgSzqvznAAf76WaDdwnhsuwPjpFJGTXxa1HuMjSgK1aa64edtUqi+7FQoVEtfr2iRyLqgQtSF1vP0k64avAiHNK3iYhp3mPvhBXo+SfQG1+Nn/JEKS39ujYkmdHNFi2T3aTzNUxC/G/BU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078355781538.7504888382437; Mon, 9 Mar 2026 10:45:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzee7-0002eb-1G; Mon, 09 Mar 2026 13:43:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee0-0002cU-Mg for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzedy-00025X-PN for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:52 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-O_mq9y7dODuo4ZUJqhCiKA-1; Mon, 09 Mar 2026 13:43:49 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-439ab866bc1so10594368f8f.2 for ; Mon, 09 Mar 2026 10:43:48 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae2b9d8sm29414879f8f.21.2026.03.09.10.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=fyicTwox9YbVeG19vLNzkThQVpMs+ydxoNy1wM6IW87EBEZn8hM2iQX8yqMrHIXM1b1fxa dP9DX4TZr7nUOVNhtQghGh0iKeJEx1QOECfXSUcN0lWH4qzl+i1HKja3yn7ofRyGcjzptg j7owPicUe9h1WUsoePOitg3ebF2ke40= X-MC-Unique: O_mq9y7dODuo4ZUJqhCiKA-1 X-Mimecast-MFC-AGG-ID: O_mq9y7dODuo4ZUJqhCiKA_1773078228 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078227; x=1773683027; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=QXIrlhzIG97gLix2w40sqzNy1KQwWkvr4ctkJmYXmi4pmWYUtffj7f1UIGDRee9CiU deAsbS4lHUWXJ31sJhgP942LB7S7Edu4VvgVly4fzLkfd4jkC9BUeMzbqyEbSlOBPLyF /KcVRDRpObZ+U3yuQLLdSP2QXhgcAieO7gHD4gHIwz7ZPgoa0/8xLE6bG0j9FrUGztvf ZLAszHgQt90BOUXFFTuqpkdIraKwk0UfHpGeRWKH425DodWI4l28jtIA8dxcP3KIBjzs zEkrlndT+NpUQr/qkgrCR4QLvK/yFf+SmJzFvi0oZYPinYfWjXYyewEaQbG89dzr7tue RXJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078227; x=1773683027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uPhfCaHv6CHzKOjPkqk+tdV6bugz5au2t9vUldgffyw=; b=wdZqlIfpNztqDs004gE9CLkrGGHLbl+WF8HAXUya7ooTBOYZFqKhVzhAsAsSIlm0MX axMUNpmzyab/BkEkggT3EbE2JUd9c9cTsH9ABgbqNQEGgIqiLJULGafnFScFNooSAcxy yMxQp9Ysb5CQdUL9/E6MieLjjeRSZ2otm/KQYFyJ7hXtew1TSTtWimfIRuD6NlzH2c/e 59wPHWxP1G57xPTC/xWA2cu8sGmKklyuv+5dtzR212XlZNqmWqkUMYk2JShiXA8L2+sh wGR3Mrz+/SGxYSiD9DmjFk6GavcrIWtK7MqHIQAEcQm63fVxFe6r21pzjUA+nRX6/eNb lLiA== X-Gm-Message-State: AOJu0Yx9B261MSLBL17dtgC8VGa5PvVNp9Coex8Iwk/K7saXF85OIxBF kzfbR4p27k21udhH+s8Qu2p89MXuEJOouQjb+c5eecdr+ebfcAbq0ATX4v7VTlcwkTvyl+zc6Z3 VYBafLy9j0gudpZd03MmmWmGUm6ktnhHslPrw2QQTdSnJGtei5vVtDQ3IW6Mhg1jgMPagSjuMeq ive0NhxdNwgd+lhAn3rwTSIMjs0acv95ErEFiFOfzQ X-Gm-Gg: ATEYQzzBy/69t2zMwwDowKtk18Xw8DPM/XxD3caCGLIx2aIEGnLpnEgTHyUqZSmAd7d 7V6FCCqgzRa7+AlFefpPya5RNo3RSqUTk7+nHurYbO0YnjOiUrpNOuNGkB+vnDL3s0sW21vXis4 QH4T9hNKOhj9CMvaisxi0w3/6dcYSLtjchw9EOJx8B+YZZu7gB7w24nZFXEUkGgYn6w3LWUhsst hrXXprDP1BJ4W971iV15mgBNRerwu34kXlfCKH9z54nNcHc9ZZz1aa9H0mTnAHGR5Acw7NEYfiq YD9VmK6bY92MjRxCn/0tkcjA60ED0k+Zo2CifB+JgBczrM4Xr1W5G/B86MSSvpBzRidKVqCSWTj lVmSloeKzuypxsLBW7hQrt3q4Fi0Zgz6K3z6kQvBwzSDTLia89T8L5N5xg8ujOrirABhnQxqwCL c+XE2LoTxLejG87IVQ6zd5U4Vhq9U= X-Received: by 2002:a05:6000:2481:b0:439:bdd7:4259 with SMTP id ffacd0b85a97d-439da88210cmr22069710f8f.38.1773078227039; Mon, 09 Mar 2026 10:43:47 -0700 (PDT) X-Received: by 2002:a05:6000:2481:b0:439:bdd7:4259 with SMTP id ffacd0b85a97d-439da88210cmr22069663f8f.38.1773078226408; Mon, 09 Mar 2026 10:43:46 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Siteshwar Vashisht Subject: [PULL 02/10] qemu-coroutine-lock: fix has_waiters() Date: Mon, 9 Mar 2026 18:43:32 +0100 Message-ID: <20260309174340.52174-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078357299158500 Content-Type: text/plain; charset="utf-8" has_waiters() is testing a reversed condition. The logic is that has_waiters() must return true if a qemu_co_mutex_lock_slowpath() happened: qemu_co_mutex_unlock qemu_co_mutex_lock_slowpath ------------------------- ------------------------------- set handoff push to from_push memory barrier memory barrier check has_waiters() check handoff which requires it to return true if from_push (or to_pop from a previous call) are *not* empty. This was unlikely to cause trouble because it can only happen when the same CoMutex is used across multiple threads, but it is nevertheless completely wrong. The bug would show up as either a NULL-pointer dereference inside qemu_co_mutex_lock_slowpath(), or a missed wait in qemu_co_mutex_unlock(). Reported-by: Siteshwar Vashisht Signed-off-by: Paolo Bonzini --- util/qemu-coroutine-lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-coroutine-lock.c b/util/qemu-coroutine-lock.c index fac91582b5f..c82ee754beb 100644 --- a/util/qemu-coroutine-lock.c +++ b/util/qemu-coroutine-lock.c @@ -173,7 +173,7 @@ static CoWaitRecord *pop_waiter(CoMutex *mutex) =20 static bool has_waiters(CoMutex *mutex) { - return QSLIST_EMPTY(&mutex->to_pop) || QSLIST_EMPTY(&mutex->from_push); + return !QSLIST_EMPTY(&mutex->to_pop) || !QSLIST_EMPTY(&mutex->from_pus= h); } =20 void qemu_co_mutex_init(CoMutex *mutex) --=20 2.53.0 From nobody Sat Apr 11 21:31:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078275; cv=none; d=zohomail.com; s=zohoarc; b=Ai27b7jThyR9vETgXaTFSF7QhIpKM9KR0oNk8q/k/Y3/zv9MsscOrrLm/vQ7qnfMpwlGHT++EN9QbtNuLcNCcvwhiGMkpRrnAekSV/fkU7+QIuzLgOawOd7CWeSpoIStXAgdlkESHqWqGWToOv4N/7yY7KNEGuDjqtt4VGpSNrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078275; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=MDhTwGjDrhICQnEKuEjQDcI/ULvvkd+jpxTiaPsVWYGy3AKGQ2md5yfMZNJt18ouEaNmPRYdBckEZl19j0RLXpCbFA12gEFdYHNDAOGXYIKZ8ByZCJswbwdsfD4sWWrweYHTrPCT0GanHlOebeC9Fa811Tj8C0mmJx76/+cmhdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078275783452.6828925205532; Mon, 9 Mar 2026 10:44:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzee9-0002g1-60; Mon, 09 Mar 2026 13:44:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee2-0002dF-MJ for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee0-00025p-BP for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:53 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-8-hpmSIWOlG_XTo9iexjdg-1; Mon, 09 Mar 2026 13:43:50 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4839fc4cef6so111316335e9.0 for ; Mon, 09 Mar 2026 10:43:49 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485246ece8bsm138774185e9.4.2026.03.09.10.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=VtSR4o8ROatTGDdsZfD8Fa+2Il9uVO3AxqBgpGC039/ybkxLYIb0gkKtkQAlBVfHzFXvqu Z53wfwpBWfOI/uCJPPktXicdMPZcpzc6UnFdc32RJnrAODZN7161XhG+9Nye7uOJBQA9Zm j2u0coVpRsBxeqb6a9BdfRR7gDNP+/g= X-MC-Unique: 8-hpmSIWOlG_XTo9iexjdg-1 X-Mimecast-MFC-AGG-ID: 8-hpmSIWOlG_XTo9iexjdg_1773078229 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078228; x=1773683028; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=B9niDcVCccsFEO7TtPzHWJp6YEeimUoE64fkLtK4ER5K0917yBoPIqXt/g0nQrVb+9 3yLfXgHMgngFAjBrjOKIhyTFj3sor3DTx5lxaH2bgy/blS6VkFeSp1hYCNnev8I1V+CN FAKeZTq/LNfYjdMk0w/zFYBxjHS6GS8/e4lCJK4UwxPOjpGLyGk05sDvxWqPS2GEFGLj YQWN0fAzyVUzdZQFXbogPVK4IXSJTFic9V8M8L9/2Y67hseXkUBUq1A3jeHU3oe9JOPg UgnQ8MviEt9hQbzG6mVfz8M/plOleVMrjaKb1mViu1R9nRRvUBMoo/c+2MhCyxWqpzgx SvdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078228; x=1773683028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VfikCXhkPujXGahi1K+KJCeU2o/MsWlpko/s3OY9n38=; b=Nr7rLy3/6+DZ4hDWoMuIdla6sw1Jw1lMVFmfsHaoIkTDfUxBo+1G/g+MaWqy2Bjawm 9xZGfBnVumDqVThOIHR6gK5xJpkNQRS827ui7YFhdIB+ylq9jfJqQu7U9B+UChUekm6q ylqh+EJal7moogGM5cCYQhHOobP6OlwMvV8FE9zcgSIeBuD+tcxpOFvueufTiqFeibpz 3QCc03nF2ntgsXYIRFsPIq1ySlCEHAx4KIKV0/GFuFw5p8xxOPsHnKwo1qb9KEmTfsrd 3AbE2wLCsIVW+Yugo1tpWkCbrhgu1uXXMzhA7lQ/CnEOvfRg1XYrCxJOX1i5H+2l9DDp ck8A== X-Gm-Message-State: AOJu0Ywnw5+ZTiO5KMWe7cWPqCnlVv7WLLRffJwKxPbTG+nLwcppj4ll aEDW/3XF14EE7wY/XCRZxLFda2f7EsT5yKCzdgGYg8nDv0RoXsg0xI0TiAfnBfpsOf+eif/vkA0 smFreaJXparp/nb3hRU9KF5422W9MUCXq5qlWO2EVvTlKb0drohg6aAXYYtTPRlXoA2i/TdszSK 2/aGthDLdAEzlKk0jAj3bYokaUSXKG1LWpaOAw85Cb X-Gm-Gg: ATEYQzw2SLdwTYeFQP7hEWD5Le2O/nRJ7O/Thb3fYl5gJEy4HGL/5oNzJ0Ha8WE9Wnd T3TSBkgp6uBxcIUTnuv4YuFJi5q4oMXp/QTUq18YYA7fETJG21cTT/g7Z532mACl8/HBOcDl33q uwgz5Zx2O5rlwo+4qyrlhi+t6DGVWb3J2FmZWp33vj4w6R+Pn8Pecvn/F6hx6WSlQhnDEVnlbJv VpIoVWSmDAUow3NrrSPgOgZnwpyHi1778FwfPx0xFtBevHoA2uHMjj2e4qK8P0L6viMoQkUDlgS tugiU7ehWSoB5H2jo5y22bqiWOEVe1XczFRbsZCNNyghW+Rv/GUk7/LfJtKmc+bWFkMxfBDMq1b nYb2qFb+POTWWau8t1LTJmgBG/ASaq0v95Ganw1V8zO9/OEvwxR0ncp4jPQsY6dMeSKTABSM1Kw m7RhW0foFSxVwtEyss0uhNPv71UbI= X-Received: by 2002:a05:600c:8b4b:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-485419f1614mr7865735e9.11.1773078228128; Mon, 09 Mar 2026 10:43:48 -0700 (PDT) X-Received: by 2002:a05:600c:8b4b:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-485419f1614mr7865305e9.11.1773078227611; Mon, 09 Mar 2026 10:43:47 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Mohamed Mediouni Subject: [PULL 03/10] target/i386/hvf/hvf.c: fix compilation Date: Mon, 9 Mar 2026 18:43:33 +0100 Message-ID: <20260309174340.52174-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078277807154100 Content-Type: text/plain; charset="utf-8" From: Pierrick Bouvier ../target/i386/hvf/hvf.c:476:31: error: use of undeclared identifier 'cpu' 476 | X86CPU *x86_cpu =3D X86_CPU(cpu); | ^ ../target/i386/hvf/hvf.c:479:24: error: use of undeclared identifier 'cpu' 479 | env->cr[0] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR0); | ^ ../target/i386/hvf/hvf.c:480:24: error: use of undeclared identifier 'cpu' 480 | env->cr[3] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR3); | ^ ../target/i386/hvf/hvf.c:481:23: error: use of undeclared identifier 'cpu' 481 | env->cr[2] =3D rreg(cpu->accel->fd, HV_X86_CR2); | ^ ../target/i386/hvf/hvf.c:486:31: error: use of undeclared identifier 'cpu' 486 | X86CPU *x86_cpu =3D X86_CPU(cpu); | ^ ../target/i386/hvf/hvf.c:489:11: error: use of undeclared identifier 'cpu' 489 | wvmcs(cpu->accel->fd, VMCS_GUEST_CR0, env->cr[0]); | ^ ../target/i386/hvf/hvf.c:490:11: error: use of undeclared identifier 'cpu' 490 | wvmcs(cpu->accel->fd, VMCS_GUEST_CR3, env->cr[3]); | ^ 7 errors generated. Signed-off-by: Pierrick Bouvier Reviewed-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-2-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/hvf/hvf.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index a70f8461b04..c0d028b1473 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -472,21 +472,21 @@ static void hvf_cpu_x86_cpuid(CPUX86State *env, uint3= 2_t index, uint32_t count, =20 static void hvf_load_crs(CPUState *cs) { - X86CPU *x86_cpu =3D X86_CPU(cpu); + X86CPU *x86_cpu =3D X86_CPU(cs); CPUX86State *env =3D &x86_cpu->env; =20 - env->cr[0] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR0); - env->cr[3] =3D rvmcs(cpu->accel->fd, VMCS_GUEST_CR3); - env->cr[2] =3D rreg(cpu->accel->fd, HV_X86_CR2); + env->cr[0] =3D rvmcs(cs->accel->fd, VMCS_GUEST_CR0); + env->cr[3] =3D rvmcs(cs->accel->fd, VMCS_GUEST_CR3); + env->cr[2] =3D rreg(cs->accel->fd, HV_X86_CR2); } =20 static void hvf_save_crs(CPUState *cs) { - X86CPU *x86_cpu =3D X86_CPU(cpu); + X86CPU *x86_cpu =3D X86_CPU(cs); CPUX86State *env =3D &x86_cpu->env; =20 - wvmcs(cpu->accel->fd, VMCS_GUEST_CR0, env->cr[0]); - wvmcs(cpu->accel->fd, VMCS_GUEST_CR3, env->cr[3]); + wvmcs(cs->accel->fd, VMCS_GUEST_CR0, env->cr[0]); + wvmcs(cs->accel->fd, VMCS_GUEST_CR3, env->cr[3]); wreg(cs->accel->fd, HV_X86_CR2, env->cr[2]); } =20 --=20 2.53.0 From nobody Sat Apr 11 21:31:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078316; cv=none; d=zohomail.com; s=zohoarc; b=Dgx2BcLkAErW/i2bYLhbXlEoI8Ok6LE7tdPIS8rwuYz8naIEspc9Ffmqj1P5pu91hSjquBOorh8+s8Hk3Jjk0g6fj+iZqB+bjd/44sT0imVwOO+IE2jmJb9+BZ4USHeaF4PKNHqsR+KQ7z58YP7LgbvBTx807hHYs5xo10a69fY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078316; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=S46mE50kK0rRchjOlQmG+mJw+F+POMPKK+/KpaL4HQ2mLOOvRhEi9LXxlwSdZAHEjrD9fBIfa5nxql2+KJO5/J6exOz7SdNXYwMwdiMsTu5hR4taEzCm0RfIxFbPA9JuInTc5f718Ju2A1F55bgJNpzK05QoOKDigDYHS+ddFQU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078316865588.1870031354953; Mon, 9 Mar 2026 10:45:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzee9-0002gW-Pd; Mon, 09 Mar 2026 13:44:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee7-0002eh-2d for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee4-00026H-Ct for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:58 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-FYnz75kjOW6aTycuTLRlaA-1; Mon, 09 Mar 2026 13:43:53 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4806cfffca6so130492505e9.2 for ; Mon, 09 Mar 2026 10:43:53 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541b7f255sm6492655e9.12.2026.03.09.10.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=dm2WTp+gRLFz6JvZNw7TunmPs39EuuFZZxR3oyEMrO9YOCbVuRFHWGJT8RBr1oyF1FLbSL B2gFheTjs27yP/uDR6nLRI2BDsO3iil5tyJEpsRidGnGj609f/xo08FC++tVc5MHndgVda 1H5g+U17RGU0RcYc+rj6teAnKnVoJZ4= X-MC-Unique: FYnz75kjOW6aTycuTLRlaA-1 X-Mimecast-MFC-AGG-ID: FYnz75kjOW6aTycuTLRlaA_1773078232 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078231; x=1773683031; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=GQGMj3SEou+KmW1qM8q7MR4Ku+ObWMOfeCHoRzbfrTwQAd6SZ5I38VbzNCyJRaz9o2 KtZHaVtFQ4wldF9LrCRazKhrR20kA+PRBic/8lQgf6bIdX29mMXQmw12RJVtcav1ji+U TTVFf+W70pRkr79GqZCSOtXSayH1pmpvLDaiwihLNU1gh524wvjs6H1xtVkxjI/2xbMb 4zhYk77exep9xWnlWB7CYXpWAQJr+c4SY0J+qAKPHh0nPdXog/ib2Y7GnGzlMWYUJa2G mt2DbdtidqYDrpbkrLVdWxIpxy9AYYIVFkSkwWEz5IdGXtmSiZpV06m/OZJsawCTdgOP pwyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078231; x=1773683031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AyUHplPpiVSHERYHzgWs9PHhQD8nuM7rmDxiD4Pc/6s=; b=Naaw/ucmab7UUmWYXsKqcbo/vazgsPYbcHeMrR9xbsyOINmjGogulLFrTqG4I3EiZm tI6DRgV82y9tNZfpLsJcfhQOLfHpn5PEBH5OWAMKJyRJw/4nwyqiTABco9lF9UxJRb1Q tJcneHPdUhPcYtsOpEFtUsGEy4aG+f9acXHqvs50vfzP09Xa1I1LzPhDjxTFVw2CA6Np jbSVMI0V/GLsO7R1NLXc4/mSwBAR0AajvvngSKBLmTJuHUYaou2yaJoGQh10n+03CnCi vbAj0j2V/PS7ART/AoejJT/E9iyyVrp8aW2AU5u+n4xMbprw6UeiQXy97nj8zlyJGc0e j5VA== X-Gm-Message-State: AOJu0YyJBOq/ABF7Krk/AeypZSx4xPMXLiWdK+16pfZZW/Avd1xioIJU s/NrceoNwTIEPEHCaGZ01c/OOGI0f+m/0T3ZFBuNGEQ0ixFrdMn1AWcyzHedbzmfyyUKNK5AXRc GKgjBd1A7Gmfzbf1d7aGV0RdjIf6I372DlDv4DjJVt/t6R3XvJo2S8txMO0cgRRG1+s42hA54hM 4RfcnQdtnCVKgSFJ/KyVJ1tVDCfs6m7qNMivNimV2R X-Gm-Gg: ATEYQzwCXdV4QzFGuOcfH5JyK+LcpVQYuyv5jSDCbiAwOpSr3iSC15AVG5BprtxBbyz +mQ+T9bov1cRC+1oNrDGX95+vMRKpKiCa2kL0KbbxLTbmW6aY1kZjHTuQbuTamptMZ04FzSlEt5 exxNnksW03vOv+9gkO4VYFGH79uQSgteOuiv/vLzHgzdDanVpF5naUuGQ1JUOSbvnMyeTWxScOz JWOBBAzZzAdhPzeFQy5zaHPZBGcp9jBJRPuD8EADqoEGyN+bvNZXQfAaExnKMYq7YoYdi0Qo8OX 2c1Bx4T01Udj6GhCHRv22Pl0ui9aIC4lF19xAOFOchpEq48lI0mode4nfxUhrGZLe9G5fveonLl IWhXEsizZzWb6pxksTTL34jqTyt5V2lzTQkt/6LEOSkpLCtQKadBN810UxDWE39Yz1QE7jRe+NT F1hfD63rUdC0G9FB6wXbLmmMJyqCM= X-Received: by 2002:a05:600c:4e4f:b0:485:3a27:a960 with SMTP id 5b1f17b1804b1-4853f4214fcmr41091745e9.0.1773078231262; Mon, 09 Mar 2026 10:43:51 -0700 (PDT) X-Received: by 2002:a05:600c:4e4f:b0:485:3a27:a960 with SMTP id 5b1f17b1804b1-4853f4214fcmr41091105e9.0.1773078230543; Mon, 09 Mar 2026 10:43:50 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 04/10] hvf: arm: unbreak the x86 build Date: Mon, 9 Mar 2026 18:43:34 +0100 Message-ID: <20260309174340.52174-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078319372158500 From: Mohamed Mediouni We don't really have any great choices here, so use the __aarch64__ define = to unbreak the x86 build. Once the CI moves away from macOS 15.1 SDK to... 15.2 even we can get rid o= f these SME stubs horrible hacks. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-4-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/arm/hvf_arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/hvf_arm.h b/target/arm/hvf_arm.h index 6b1c3b9792d..8029d48caf5 100644 --- a/target/arm/hvf_arm.h +++ b/target/arm/hvf_arm.h @@ -27,7 +27,7 @@ void hvf_arm_set_cpu_features_from_host(ARMCPU *cpu); * headers are not available until we raise our minimum macOS version. */ #ifdef __MAC_OS_X_VERSION_MAX_ALLOWED - #if (__MAC_OS_X_VERSION_MAX_ALLOWED >=3D 150200) + #if (__MAC_OS_X_VERSION_MAX_ALLOWED >=3D 150200) && defined(__aarch64__) #include "system/hvf_int.h" =20 static inline bool hvf_arm_sme2_supported(void) --=20 2.53.0 From nobody Sat Apr 11 21:31:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078314; cv=none; d=zohomail.com; s=zohoarc; b=BWOZik9dylb8Xocklz5D1+GWbmNjNMZ5UvEIPWsNG+XBLhSsaUk6pPGG/1B33l/7DO/e4gQnVt9t9J8lSBler94EukrJM/8FWALEafMqMscoeMAuWDDw2ARND9j4GPONcfM4vXvI3foEhGyOJdo4ru2Z6dzJ/jxQ7f0i16elwSw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078314; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=jOyvha/VXjU/+eqh4LC9wvzSJfacjwwSgi3M2scSAagh4VFwS1j82aT2MuVReHsQdHYMCs3FZuEMf1Y0aXCGr2pk8W80DpAAgsHlfrUkSZ9uMQMPhgrmvYt5JYl7GhwOdi2tjoQZTgdg44OGyeeONLxcnFMeGQUtHQnqYRzL8N4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078314574497.86952708972956; Mon, 9 Mar 2026 10:45:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzee8-0002fn-KL; Mon, 09 Mar 2026 13:44:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee6-0002eK-IF for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee4-00026E-CE for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:57 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-WqmRSuojPqG17qrDyVQ9Hg-1; Mon, 09 Mar 2026 13:43:54 -0400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48378df3469so82847555e9.1 for ; Mon, 09 Mar 2026 10:43:54 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485358cd26bsm88598325e9.8.2026.03.09.10.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=MzE4BhJM2ojQRepEL6wbfsCPVdNxsqlKby/AJr0UJbf8C5IPdw8m7jhJi/PKX6EfDLzkKx W+IXwgbqjQEUTTF3wADyzb1voCRQQVewdTv6hDhodxiUIbBhLhZ3ACrAHI7k3otNb2SGn9 qHDb27yQ0k5xvCOKzaE1AXElheB0Fm4= X-MC-Unique: WqmRSuojPqG17qrDyVQ9Hg-1 X-Mimecast-MFC-AGG-ID: WqmRSuojPqG17qrDyVQ9Hg_1773078233 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078232; x=1773683032; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=FVjpbHHaV2WDfV6s+dzOnaQ/6cojg+n/tBU1aLKZooZ6ZTi6/bG1GvJ4PHOwfCXcT9 DqEtqi2fpLiwTtFoTensV1qs6dusuzKGaZSNjUMCQBzFJ7IEeE11/py3Qh6QO5XZ//AK kj7TEvio7FPiNcPJ8hIbAZQYR7J9s5QtXJ71v2GjiBVW/sOIA2kZ06arNIgQPYaniwF8 unM4PV36XAQuUUfQPikLqIHjqfnS0iDQGtA9iAFbW0Ld0oF+Bd4fgy7mihKfxp9QuXi/ JPPcl3AFy9FZ3fSr7JuV4SSC9BxuO+LtlfaxsXyOBA+OUV/ZMRoN3rrwrojLeXfgT08u Qh/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078232; x=1773683032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=barQm0ytYadQlbHRY+PvBMzrx7IGIkBCbHT+M4DhJKE=; b=FVvOo3qz5kk8TZbcFRWK7Dq9QE9bRWCdDE5EIsFXI3KUz9qp0C4GVwOnjzMtPNl2gR COs9KFBYOG7cmygB80/2w/kHGsmWAcciuGazby405qAC9huvBRRJOEfNUS9cjaeH1rl4 IZEJcV/uNJ5TXBd8Gi1d23pco1Pm4guFVVh+D8G228dS/RmAqdoaMN2wNvH3enAmmX/D DxMbpZ3oBsXwD/6O6MF9d7d28/dIsTRWIN8Ur2BVrB3GG1dHLUJYnutj39ioUyBS7Bsr sGq1oSWflmgg3N0EMKPBNbG/EFgEP5JrQL8B/DI1pLfouJBCVkX/J3l/EhFcINTBq0PH mUjQ== X-Gm-Message-State: AOJu0Yx4LmHBVpJA2Mq000SVtH40gTaDZ/9FHcrznamSoWqyhIF/YpdZ hdwTPwJF/JqW1gFWJ0NZbw5mJ/T26vTT9EKiHSFU4cOQGD84U9/SquVqD+BimXWsawKgZl+h7jD FORiDwanpIKivEBzYo5dzoDDX7seTvkbMDicTWvi4+QTcOvdem5udjvJAs3kIqMqQ/fk4S6Kuv8 B9yK4XYPEGsRkLf6lMTYs8NrdBdUL4hlGGprOibqx0 X-Gm-Gg: ATEYQzyYanTaYjWbASo3wa50LHYdR5jv6bvoe3xOhAID5VQAJboLwDR8YZwZksNJkhF U8m4Zkl+keY72i/gGrPuLTw/cYxrqvXAD7q4oLFoii9quLu5k+PKzre2O+8sntNbwAdOmVwwbuD cBIN73vDYyNnSGLjoPRZsX+dCXa1uUlocj6+JMvlhHpxxHM2vStnwdoDrV/PskSAvJ5+aWc3Uzp xKhyZ10fmywnKmCADP7orY/ZrYLoJZD14XE+lMdstG/L3h2sUJdmDb/i/wA0hYS69sk2RfRmS7X YPoV+KqNLXd2FjMPgpq6b3sNK1a6v14yHdokTdrJ1M/F8b6L9uRXSy0P3ldF8w10scMUgwSn20f sk7C09d/QlZ2bVo5wAOXW4vYzB1BLOJqjck25tpQnhdazRscfI4ZXommOMnWfsauMUjIjCiW5gF nYQWeOr+MqKkGgIBcERfjUUZMDA2U= X-Received: by 2002:a05:600c:138e:b0:485:3e00:944a with SMTP id 5b1f17b1804b1-485419d759amr8246875e9.9.1773078232338; Mon, 09 Mar 2026 10:43:52 -0700 (PDT) X-Received: by 2002:a05:600c:138e:b0:485:3e00:944a with SMTP id 5b1f17b1804b1-485419d759amr8246405e9.9.1773078231809; Mon, 09 Mar 2026 10:43:51 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 05/10] whpx: i386: do not enable nested virt when kernel-irqchip=off Date: Mon, 9 Mar 2026 18:43:35 +0100 Message-ID: <20260309174340.52174-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078315044158500 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni This combination is not allowed as of build 26300.7939 and results in: qemu-system-x86_64.exe: WHPX: Failed to setup partition, hr=3Dc0350005 qemu-system-x86_64.exe: failed to initialize whpx: Invalid argument Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-5-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/whpx/whpx-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index c172e86886b..9c60295d553 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2160,7 +2160,7 @@ int whpx_accel_init(AccelState *as, MachineState *ms) goto error; } =20 - if (processor_features.Bank1.NestedVirtSupport) { + if (whpx_irqchip_in_kernel() && processor_features.Bank1.NestedVirtSup= port) { memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY)); prop.NestedVirtualization =3D 1; hr =3D whp_dispatch.WHvSetPartitionProperty( --=20 2.53.0 From nobody Sat Apr 11 21:31:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078317; cv=none; d=zohomail.com; s=zohoarc; b=FwAv4KkkU83AW2Q+Z3KbMDtnQse/9Q2cILimGbVbjpN9A0FC14WyYsdR72R+FALzAANP/fT8J652JEIIt/wx+CViSOj5xa8+55PyyfrI00Mx6AW/cGx2W9+jLv7gV9U1KHPwbzeHHf1nqKGd4f9Sq7lDEKTEmeVdOHIyZmSjziY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078317; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=B1hJdMGhnOaYGnpw96Js3k8i5w/0c06slV6Cdfd4bUVGrt73jNLWpyn3QmGT3on8P6wbFk7KZUAn6Jw8jQxPyR/cyY0+VMfvaBzf7Hl8fEO1GlfRMfMeEC8PA/FcPLEWEjSWoML6/cBwz2rqGYPKqGuzZ7sR8UkL0ZU+6P2lEuw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078317983222.2887768203757; Mon, 9 Mar 2026 10:45:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzeeC-0002hX-9Q; Mon, 09 Mar 2026 13:44:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee8-0002fQ-3r for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee6-00026V-LC for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:43:59 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-gH6Pa9IHPDWNgLv3gpSQ-g-1; Mon, 09 Mar 2026 13:43:56 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-485355493aeso4935105e9.1 for ; Mon, 09 Mar 2026 10:43:56 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541b7f255sm6495965e9.12.2026.03.09.10.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=OGa6WBAUEiQXdelQkYs3ccbwkp4NFdB/Zkuk4LmkneSL2cIfVHL/grVKO8c8RphtQ4fDNX UMRmzBQ2gpMrE1ZVyjrqPm8IfIkX6SMRGgbMd1j1Bb4llfuq8ZlnOMrGwojTiPWjHFDGnn Oxm0zIrM4qejNqYopMfkGhiDgC2363Y= X-MC-Unique: gH6Pa9IHPDWNgLv3gpSQ-g-1 X-Mimecast-MFC-AGG-ID: gH6Pa9IHPDWNgLv3gpSQ-g_1773078236 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078235; x=1773683035; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=q/j53KqR4WltbCSqcFlh9N7FPzpryKbqAkuQHaP0S0Kn7Og3T/h6OxnM/QL3oFzTkt DoW69/s9F32LfBGGkMGiVac1U0o07At6fy5uPj7mNiBL5rOZYBTv4ix9dabnuQW4zgoX 1OcYAIuVBG9x4SBj0VWlviZNBmtR5m5URmrN/qr4oWeYfUTdfFiEyLb+zlNyARtrbVO2 q6Qa61dqkYNo8O2lwtkiDPNcffTJ3hC1+287y1PYoz/CEs6D8xN8t4MoIgSNbQk1zwI9 KtNXj8EpX0dQ9IRsGPQr0leoIR51/9fmIG8wSf9WiH21cLem1ia3L2Gq2sf6Gycjpc0N NwFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078235; x=1773683035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y0eMpYMCvhFSbjZnQVatmA08KRwb8Q1v1D8tShGnW+0=; b=lI5uBXEt5S6QFsKvy/h1ZpTk1LpwZh2W6jnCBtxZCidoMi5/Xx3egDstlXNg43g1sD q0I5NusgU1D9T9npEvP0XpFsm7APIbLrxBXwMKzEGakvSbLgwmDPKaq3ynFQr+7EdBTZ iZTIRMMoSzvTkIjyKeWDrS206Hz83SpaDhaUDHW4KvhDIhonUoHTi/DhEzDqAMMsOnEy SPclONsEors2+6Cfp0O4p4TEZAKcFy+Dq8mWQZItoim6oJqN6PsMoZM1ciChkBuMcdcX GEACOfMamjq97JFhM0qZFj3D8TOo252hijqX0GbqoTqufe8W36vEzOthXpqg98IDIVm+ oYhg== X-Gm-Message-State: AOJu0Yz2tzVbURUcGPTeAAqVvc6blKh8S16HGgy2LqOV2TxrVjjP1VhK ++KmMjQ64ZSc/JY+z/nUQNHgZFPeqy6s/ANGCtaDN1keMn2a4uLX/ho7Kssy1eb3IPy4OJRnPpV XPd+Set13phcEYwhRBCHCqu6/G+VLUcGffqjP5kC7KUnqDr6+brYAmWKClvA9VMTm9G9fKrcP9g lh8kz0lD7gQaetHYUAh3skoXMdq3GPoy9x5PiIFyS6 X-Gm-Gg: ATEYQzw7Jp0QHB5zF3Z9O4iklrwWEQlJBPlrMYZ/zt3qWOnCbMuysMjAn4IPloy5TqA s0cwfgZmvDU3EvP7BsE+nnvBL6r4vCnI3txpQJ+oetmRsUK8bYLBwyVWMrmwF4tkZyCYjWS8/+G 2VbWy1FxBUJpHFLWuGaMwDF34goVVueu48fVMce6xMK4TH1USUlTdnQRzJRIzDKDvtiuYCN7Usu GzCrImOmR5zvD126E39ldUKGzy9XHCdQkxt8EU0qZyBjBC6QYpXsNFpxshBA92LJ7OjPEDLbjTZ loEsAPIdnC1L8NyDZy/oZzjVjKcdvKXMXoG8CZDTJmsw/VfbOD4dIs/q0BeLoMi8kFnBM+wsmFe 9hpRizNT2SHcgmTMdnCTC4FW5aygPEADX3HaCfSkWFCfLvVnAe9hzXYQNLB3VC29uRUcnpC0Gvh 2SyMdhSofQtYxlwNBGRVR50zCjoGk= X-Received: by 2002:a05:600c:c102:b0:485:3bb5:92cf with SMTP id 5b1f17b1804b1-4853bb59937mr44504535e9.12.1773078235030; Mon, 09 Mar 2026 10:43:55 -0700 (PDT) X-Received: by 2002:a05:600c:c102:b0:485:3bb5:92cf with SMTP id 5b1f17b1804b1-4853bb59937mr44504255e9.12.1773078234505; Mon, 09 Mar 2026 10:43:54 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 06/10] target/i386: emulate: LA57 fix Date: Mon, 9 Mar 2026 18:43:36 +0100 Message-ID: <20260309174340.52174-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078349382158501 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Seen on a Sapphire Rapids box with LA57. The top level of the pte array is taken for CR3, so there was one entry too little for 5-level paging. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-6-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/emulate/x86_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/emulate/x86_mmu.c b/target/i386/emulate/x86_mmu.c index 8261ca16351..4e39bae025e 100644 --- a/target/i386/emulate/x86_mmu.c +++ b/target/i386/emulate/x86_mmu.c @@ -56,7 +56,7 @@ static bool is_user(CPUState *cpu) struct gpt_translation { target_ulong gva; uint64_t gpa; - uint64_t pte[5]; + uint64_t pte[6]; }; =20 static int gpt_top_level(CPUState *cpu, bool pae) --=20 2.53.0 From nobody Sat Apr 11 21:31:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078272; cv=none; d=zohomail.com; s=zohoarc; b=VC9v2TvjrOJ1gRHmEDgB8lvQ/Df5/SfmEp9xEuhgX+GR/l1NFbEuBqZTZJG7E+v/ZzCMA3w3bUYF9Ty9+1CXN8IrLDuRW7PJWWaeNZQaIePOFHj0Aen14QePOBvV4OUsXNznlJ79efggg48xA3bBdol7xpWkGJjFskbVt+LTZ68= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078272; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=h4v0RgDN7s1QExbMT1g94CURov0E2gK99/HOXI//V3Wh/4afVuuooYqVYl4VHBSOtK56VWA6pgxjpmVqxsaDqVh7aXMCVZlLu4f0VMxpEqWxncSQ90ws47FgQwJJIR6M8IldxQHBkiZyMpqobsN8X3ofHlrVd5KyN2yJmdhijxw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078272873946.9878050426065; Mon, 9 Mar 2026 10:44:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzeeD-0002i8-00; Mon, 09 Mar 2026 13:44:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee9-0002gV-Ml for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzee8-00026r-3j for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:01 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-5L57NUo3Ob2fkCQwkbaCyA-1; Mon, 09 Mar 2026 13:43:58 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-439b3011be7so5704397f8f.1 for ; Mon, 09 Mar 2026 10:43:58 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae2b9fbsm28928894f8f.23.2026.03.09.10.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=Ua0VQwxgOYPyIsO3ZiczdynNCtT4DWDMQd9nP1AoLMBzTDzZt7LePu4mGfY/t61tljO14o 27HSMP6V5RoLl+b7f+BtFzoIONYlDkGv8zhZlsvfm0gSExF2ptgSf9b70QwrWGO4oyfOWm gWEc6rufoGN72a4d0CU6flhKxNl7DZE= X-MC-Unique: 5L57NUo3Ob2fkCQwkbaCyA-1 X-Mimecast-MFC-AGG-ID: 5L57NUo3Ob2fkCQwkbaCyA_1773078237 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078236; x=1773683036; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=IKy4LUdkbgwUEqYrldqJG/7Iz0zYWbQb/3Rv6uv6cW6iw+L3Q+QnvwTgLUGBBTWAyb HisSueaEgXFCbI66HBMstXroU/w5F/lP//ooagiKcxDLpsp/fCLhx3CWSxA/9Vxdqyco 0i5zqI8kQ9S87olIjLIQmBrYBwdweXlAo7QHAGDQqkHoS6/m3MMa3BSc8+kxqR856RXi XzGQNnqqr9k4ZtuDOM/OiIx1c3vBR9p6wiPMNn9ZHhYwCTGc7D0YSjniZYgiaxJLV7t6 qw2czFnVCMnAm0PSn/+tg9GnbOeARMxQXOqXorO9fhnhIVOajYwtjrX/MEKcE+5asgNQ Z2vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078236; x=1773683036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1Z5Z+z6Fq/CCBee7wdpIAUMGF/0DcL3pK1L+V3B+G7c=; b=aQRczK5JiB3Tj7Z6YdOgj5PRJ4lB7ZeVSCvdeHi5sPRUO9zGgJ/xhxuI1tVYXosagp pjWObSKNnUoirv/zvYmJnxtSCGItibpthoTxed7XTsvVKVIljeRRgxj8zbUbvnTVbCSN BYnPg+eLkrcn1xbWx/tSF3HMo31OsYgMN+V8AQD3AP6xHF0rwnBv/U6VUWbFmuLCiHvr Hm96hkTR1pCam3UeBzKPbWxOKutyfw/eGJlhOIOpripeiRjTLq9RBudQc2YJcOOwuHFb twYY4+ChhKUds69ehSlNSBOxcOnkW+i/uDynsyO5hq3lWQIItWvvLJmRBrLm4lnBoXb0 wZ0g== X-Gm-Message-State: AOJu0YxzELmyxo+vAY7ZyJ7SKITnn1cO1gbOmbMTwrCh/ZcRWaX/iAVW LKMJtNzFXWs8jK4YCC2f3See81yd4OCxf2jBLbyKunHZCs+glhNd3ZInW4zQU8kRXb4CSdFHRxR o4MPpCUiAXLnF7eFE3W/w668tgjBl5ErDhwitkf9poMdvBZNaU6HQDyCX1Cep6dyXTaI/Lv6q1b HWpMFK/0tz71fRiGvkFwfx5itINWGJhR+WL3GNA1kv X-Gm-Gg: ATEYQzwnDjlVOeupYAmcRX7h/WrVBxV/AC8+2e2jqgHt0ucULvgqbrUjAjATYBWcgIQ weeB72XyP59QUVrAIanijLHifd3F1CjeOpL1Hi3nWIOdA/dHWyr2+gdesCQr7a7F1+7qC3Z9dAL SyPnMSY/Cs747ADTCUrB/3/7sMsnKfda9DsMmehlyel0fdeLDSHC7UNvtJLB9ZKSnGGqPd/bPMn 5AoFySucAugcETWnwh58pnL4LSxU1wP/d6P1I8Al3ykgXhsDKupVPDT2Aw0wilHBVTdJ7k/eusD flJfe1JqNjsyXpTzP/dNRzeggufLhuqyHE96RQYWmFqMxv0T4DrCLb21VgnZrZjBCNYICaGMf4c h5wgntohq1C2bbZJkdR0m3cADEontTgw/YFCokdBARRVI0jlmBjf++sAA0ZQNByD+Mm5Okvdqq0 ZtH+5SFVQ6UOJTWKIDU5JhaOaQVKU= X-Received: by 2002:a05:6000:310e:b0:439:c010:a316 with SMTP id ffacd0b85a97d-439da35f6d8mr21636845f8f.30.1773078236101; Mon, 09 Mar 2026 10:43:56 -0700 (PDT) X-Received: by 2002:a05:6000:310e:b0:439:c010:a316 with SMTP id ffacd0b85a97d-439da35f6d8mr21636800f8f.30.1773078235587; Mon, 09 Mar 2026 10:43:55 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 07/10] whpx: i386: enable some more enlightenments Date: Mon, 9 Mar 2026 18:43:37 +0100 Message-ID: <20260309174340.52174-8-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078275209158500 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-7-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/i386/whpx/whpx-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 9c60295d553..bc82995b33e 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2214,9 +2214,12 @@ int whpx_accel_init(AccelState *as, MachineState *ms) =20 synthetic_features.Bank0.HypervisorPresent =3D 1; synthetic_features.Bank0.Hv1 =3D 1; + synthetic_features.Bank0.AccessVpRunTimeReg =3D 1; synthetic_features.Bank0.AccessPartitionReferenceCounter =3D 1; synthetic_features.Bank0.AccessPartitionReferenceTsc =3D 1; + synthetic_features.Bank0.AccessHypercallRegs =3D 1; synthetic_features.Bank0.AccessFrequencyRegs =3D 1; + synthetic_features.Bank0.EnableExtendedGvaRangesForFlushVirtualAddress= List =3D 1; synthetic_features.Bank0.AccessVpIndex =3D 1; synthetic_features.Bank0.AccessHypercallRegs =3D 1; synthetic_features.Bank0.TbFlushHypercalls =3D 1; --=20 2.53.0 From nobody Sat Apr 11 21:31:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078288; cv=none; d=zohomail.com; s=zohoarc; b=F78vpzoZhxq7V83gkuaZVantGGqxhwdRxgFtQ1NG0tknKDI950wOwU1WOoCAI92u4UuC8brQF3Mu9VighvllDU45jv4s186rPjxwOhERHmLPrTylTXcA/bX+5MEI1pUiVyuyAwqyu0x2AZRJPYkTaa0QZQzQlub6bvV3M0lsQuE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078288; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=MycOSJmEXxz5/ptPaSHCmedYQbvA0DUbRfQK/3X8jkxdACusjiZwYyeQpfl24csEuyrxXpkXAFlnbVMJw9lIjro5XzRWmyUQF992FVO0E4ppAZXCIKDQTJyFvsxOIWbBuYN7Lx91LXZOdC1alRvqCBvPfiFwyNZWQx/TQSAIjOQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078288983668.1171001576644; Mon, 9 Mar 2026 10:44:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzeee-000314-2t; Mon, 09 Mar 2026 13:44:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzeeI-0002kw-Am for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzeeD-00027C-30 for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:07 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-7CFWlS42No6cTueZ5j3vfQ-1; Mon, 09 Mar 2026 13:44:01 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-439db9da59eso2976584f8f.2 for ; Mon, 09 Mar 2026 10:44:00 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad977f8sm28153260f8f.9.2026.03.09.10.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=U3GuwWV25EINIp+EG9gZjSLgTRlN9FYGly0p7msjgCZdhEPsRfr0azxMQ/fsjbNNFFerXB faOqfYWATfPxrMdSp+4Oybxt7tHW0NINhFLgGAjMhgsj3krdUnqbB2noU2SCxOTADFyffq xMQpR8f4zDK58Zw6CpxEEpQ98kQO+kQ= X-MC-Unique: 7CFWlS42No6cTueZ5j3vfQ-1 X-Mimecast-MFC-AGG-ID: 7CFWlS42No6cTueZ5j3vfQ_1773078240 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078239; x=1773683039; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=e9xLENHqhMEM4Bgxh9UOh7n4UPzLhQrO3OXMQD829c+N4ptxQzkiy7uXfh33Iyags2 ftT7tWY3A3S6re8mVJBmjGsmW7o1kL2iaOBHro6f5w4pJfOAYwO5mcYJb0eYIoAfYKvf BSm/X0KMm5annWgl4Mo1SWGYRsgG8aZk8MHfkdk3LewA0AVs+mKm9/IXmYH/RGaNK5v3 JR2zuEBKF8mIdPHWv/GhbvrLT6vTHaPrDwqX9ruFaJEbKjzYLKHvKLGw7VsUbVq2zqbD RuRrVjUewARubzBjyCJB/FdbB4OGrgmUTBB1XuI5ovtvDEoVMqg3x8F3aLonR738msLc jvjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078239; x=1773683039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AvStR8y6hpWDqE72q8INHMrameFwTjMrV5Vu65iKqaE=; b=LJh1I+IPkTQNzBfTQiIW8O/1TPHbYeDzwuR3UhfenxLCEbHjJwQ85/ESYzjdEkycV5 MlNfI8WdzOM7YRXcUWN9TIe/cV+S2hfuIv3Y6BrAlema85aC51zLWeBv0qxN1O9SiDyo NuYzVGJSc9fKFBpTg5RSkmqlnEo5hMNCVB7pqgkoXc3IGxLok7/GmkB37qQSNzg7okND HSPvYkPlsD61c5KRzHPBXulSdm7NQTaKIfkajwcT0iAWEIX8JnTqn3Ib2diITz3MBls5 TIxEbeNXlS/EhGKD6kVoVisgVeuFYTJ5TqiuKJRidVBtEOFjAzyx2Qehr2WVB62ZMual EhWw== X-Gm-Message-State: AOJu0YzXbgR0+W+Hh+AVH+HciO6UBfgJml78KsENG6Q949jErEJa2rvX ZPUCeKSVIcFgf4tN+h/fg36Xf1oxGndfPaBmnMFztFFGEdljKPbIE0zTPCHd1tyt1+11SAWqx7I vdjiOlCCiw2mKMDZaay2olSGSpCB9N6Ju2m6vWrLwOZ/GTU4d26DXvMwmLngVwAY2sAfcWREW/S 7SSzqLe7OEbOmxNvHBZ2Av/kX3OyAHQXUma0h7QuUF X-Gm-Gg: ATEYQzz95Wx8JqgmJdsoTRgVFJ80sMDKw2z1jpgWZaNCWLa+BIXArMFS0MM8nG0hgtO Nt25+6NRmV/s1B3/F6yuduxJ3m45jl9Q/vdm1pnsGdTkPkMoJrVxkA6W1ZD5V0BCKtRlfjZypXq GJPFxhLje8g4F80fyKtr5oa/FCXbOgPEjwe4Ls4Yn6wMRZqDjh8z+PwtmLftEb6SMO2TcEemG6W gtKjwYsGr25gn10G1dTJ5SI3NGx96QK+0pAcXnJJfNiyY/L5MA9rHpyIjCvmzVzezKK2ufVmXWh JJOZRORL1RVwbRh39zE9j+WnCNiBaUvEK3Tu1sZYoGksKj+mt2ExnOAI+EiXrZCEiFKqNV5uLVf PoSDpb+6cZQ77sJ2MYbfDUB+aBhxadHIZHqFsotlWbzSV2boRPyeXcKQOGQEX78lq6QGL/4vXO7 gCnwV5Pv6lB2o3leVbDUGR33/WNbA= X-Received: by 2002:a05:6000:1865:b0:439:bcab:405e with SMTP id ffacd0b85a97d-439da885f29mr20835406f8f.35.1773078239007; Mon, 09 Mar 2026 10:43:59 -0700 (PDT) X-Received: by 2002:a05:6000:1865:b0:439:bcab:405e with SMTP id ffacd0b85a97d-439da885f29mr20835353f8f.35.1773078238475; Mon, 09 Mar 2026 10:43:58 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 08/10] whpx: make Hyper-V enlightenments configurable Date: Mon, 9 Mar 2026 18:43:38 +0100 Message-ID: <20260309174340.52174-9-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078292025154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Have them be a machine option instead of a CPU one, to have something avail= able, even if not ideal... The existing Hyper-V enlightenments configuration mechanism is part of per-= CPU configuration, which happens too late for this. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-8-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- include/system/whpx-internal.h | 4 ++++ accel/whpx/whpx-common.c | 43 ++++++++++++++++++++++++++++++++++ target/i386/whpx/whpx-all.c | 20 +++++++++------- 3 files changed, 58 insertions(+), 9 deletions(-) diff --git a/include/system/whpx-internal.h b/include/system/whpx-internal.h index 7a1c9871f18..8482901f714 100644 --- a/include/system/whpx-internal.h +++ b/include/system/whpx-internal.h @@ -42,6 +42,10 @@ struct whpx_state { =20 bool kernel_irqchip_allowed; bool kernel_irqchip_required; + + bool hyperv_enlightenments_allowed; + bool hyperv_enlightenments_required; + }; =20 extern struct whpx_state whpx_global; diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 4863fc86631..b813a5d9d25 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -470,6 +470,41 @@ static void whpx_set_kernel_irqchip(Object *obj, Visit= or *v, } } =20 +static void whpx_set_hyperv(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + struct whpx_state *whpx =3D &whpx_global; + OnOffAuto mode; + + if (!visit_type_OnOffAuto(v, name, &mode, errp)) { + return; + } + + switch (mode) { + case ON_OFF_AUTO_ON: + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D true; + break; + + case ON_OFF_AUTO_OFF: + whpx->hyperv_enlightenments_allowed =3D false; + whpx->hyperv_enlightenments_required =3D false; + break; + + case ON_OFF_AUTO_AUTO: + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D false; + break; + default: + /* + * The value was checked in visit_type_OnOffAuto() above. If + * we get here, then something is wrong in QEMU. + */ + abort(); + } +} + static void whpx_cpu_accel_class_init(ObjectClass *oc, const void *data) { AccelCPUClass *acc =3D ACCEL_CPU_CLASS(oc); @@ -498,6 +533,11 @@ static void whpx_accel_class_init(ObjectClass *oc, con= st void *data) NULL, NULL); object_class_property_set_description(oc, "kernel-irqchip", "Configure WHPX in-kernel irqchip"); + object_class_property_add(oc, "hyperv", "OnOffAuto", + NULL, whpx_set_hyperv, + NULL, NULL); + object_class_property_set_description(oc, "hyperv", + "Configure Hyper-V enlightenments"); } =20 static void whpx_accel_instance_init(Object *obj) @@ -507,6 +547,9 @@ static void whpx_accel_instance_init(Object *obj) memset(whpx, 0, sizeof(struct whpx_state)); /* Turn on kernel-irqchip, by default */ whpx->kernel_irqchip_allowed =3D true; + + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D false; } =20 static const TypeInfo whpx_accel_type =3D { diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index bc82995b33e..b095c96962d 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2232,15 +2232,17 @@ int whpx_accel_init(AccelState *as, MachineState *m= s) synthetic_features.Bank0.DirectSyntheticTimers =3D 1; } =20 - hr =3D whp_dispatch.WHvSetPartitionProperty( - whpx->partition, - WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, - &synthetic_features, - sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); - if (FAILED(hr)) { - error_report("WHPX: Failed to set synthetic features, hr=3D%08lx",= hr); - ret =3D -EINVAL; - goto error; + if (whpx->hyperv_enlightenments_allowed) { + hr =3D whp_dispatch.WHvSetPartitionProperty( + whpx->partition, + WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, + &synthetic_features, + sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); + if (FAILED(hr)) { + error_report("WHPX: Failed to set synthetic features, hr=3D%08= lx", hr); + ret =3D -EINVAL; + goto error; + } } =20 /* Register for MSR and CPUID exits */ --=20 2.53.0 From nobody Sat Apr 11 21:31:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078319; cv=none; d=zohomail.com; s=zohoarc; b=Lmp2QS0mRolwM18mRnAIvlmyQAMnLgKpURizEQKQvd9hwUYT0AyUrVCn6VHbxH4+8oG+kWgIEm/jPL+0b1a03u5ZSkFqJk+d1ujTsk2URhxbNgw+XPQ9r80sb8vuIpU2Yoxf7OrVSLPD+MvsAhYT5O6FCcXIX68H9lCEwNvZSpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078319; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=IuWkK4KnrQz+ZFkYp1QJsyAbBpqvoYsIFUfAC8d+DmDP18xbbngor9sc2GzZnBADf26PEqBdOSw/l9rWnZ+lH1ZVUWUMLokgNaZykPvcYL3T2Gtqp6BIHdS4E3SUXVZlwq6UG9Liljd/dRTZkAt56N3Ll5oRESZ6+yqNInfFFrU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078319356831.763746557887; Mon, 9 Mar 2026 10:45:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzeeq-00037y-HF; Mon, 09 Mar 2026 13:44:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzeeH-0002kq-7V for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzeeD-00027G-3m for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:07 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-OMv0cEcePEW_xNIVihVy3g-1; Mon, 09 Mar 2026 13:44:03 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48535f4d5e1so8367445e9.0 for ; Mon, 09 Mar 2026 10:44:02 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4853a498afbsm79672665e9.0.2026.03.09.10.43.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=ZW/QvYCJPIrZZLIJw4pkSVLF49bSEUIk6PydQlKUTizyLOSWIcDXjmObQKl/lrCYG7TKgE sYWZw7OqK5k9n4xGSriqC1YwjgVVsgxsJOiK+JhG9ZKeKaY0kx66zTCjBrepwtWIwaPJa5 nqEzB+FS9X3xq0w2xdjRxNuBooKR7zo= X-MC-Unique: OMv0cEcePEW_xNIVihVy3g-1 X-Mimecast-MFC-AGG-ID: OMv0cEcePEW_xNIVihVy3g_1773078242 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078240; x=1773683040; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=Uj/FCimUyZTo2G+WmOHVAioUlQU5uALKWgEDy9qxlbcEoQQYri3fO0vCJT2d62cTnZ mTBr1sR7MqtKT7BjIoQJk++sn+MiNY6OPojiJlG+Bb74PratwYErgWHG8fDYjky0G6zw Q1IhFBLJ5TQudoaVZK/iZZD8K8c3vYVwo2EiLmXPTVaYs5n8hIAb9XNK4mc5xnIFWfHD KqwNyv5OkXkWfoDbCcUBUr4V5xC+phs49XgdRmUWLklSSg0H34vmAjrB9wpc0mDSEAl7 tOB5VcTAoLz00dwWg11Iag6msFs4o48684p65jBGTX7nOASpCJvfMxNy6Dkwlmd01mAt CzNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078240; x=1773683040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xFR0ObgIqPLlmWXGp14A60mgMZFVJ2G4Q5gsLMbcTvY=; b=jyRmXB/EvJfjV+re2p95TFdeks1ilxKvgbp9H8Z9AuVDiz2CKJo6i/HRGT4zfjpj7K ZJ/1pDf3h68QILZjgX8ZCWZxsAfKlqqHq8E05rKo208nbMz2KinHzdLNVwHVcHvsOVFb F7oL+TyIGnRVF/lqq3FQMx36GQg6M+7dutgkb53sgvXQoe9PxZ+k83HCg8D/m0lK6eUg PY/fm19LzKCcPKxnEMQJPQHZDKvG3w6Gpux4X9nCxknaplXmsybZVNsE76EJLRr0CkSu xNB41IGBmA09gyNPCWXwAMjZiSSG/HcGfHB7EkGn3+jESVHkhbsEr3La7oAd2HrjejH8 W7Xw== X-Gm-Message-State: AOJu0YxWM0QIMj9cA86N3iD2mGoMODLNcOOXqXZheFChEMg88zHDyihu IfWoNWl0bXRIBef2K2fzNhORL/MgxPuFoyiAdClQyxBfpIvOV7rJpkt99UvWZ1pxasqHSg9b+6d 6PAUPfgwwBHSk9n58kwC197D2QrE1Ce70YNyZ7SFwVziuh9um3zCcS4IcYo9nuwOseOrBgd2T0X 8wQn0PdrFJQ4T3yENKzlnpNET9/7EgsmeizMggnq27 X-Gm-Gg: ATEYQzxgbhk3Eh5lcNuINwgrW6PuqirhFyDrOFpJYcr1CP7YfF2HiHvBhqTquKPyOs+ Lgcx/OwkiFUFGwm4rU8gTpqMpRB9ZOe8imub/9XWUvFPzdDdovfqImWJUYMwYQjs3tHOK6rwMNU zoxsxSV4X+vc3OgQk/NntR9vHNy3w8KTY+BndV7VtPrd9XCfbKBnmGEmSzlJH/bTpDpPlAgaJBd mgjA1H7RelfIHvlTwaU5b8eT86XCJyucMzycsIwAzKnrdCBxDD/OUPrpUttUbpuQemXP98zrJ96 YUK/IVkb1g3Xy9naiqv1/eZfGLgfCASW6jZAo7g5/p8MPVrdCJEmH8zcfMjpCdef8+jICuaEG8V hxh4N2CCnm8PyEX5GYClCm/kbEyATa//Fd/W7R4Ue60As1PiAVjBghd+f0m7g5IoC+Vg8EtJar5 EyxLIPC4sYgMPiFstsli3I7I/HVgM= X-Received: by 2002:a05:600c:1e24:b0:483:887:59b0 with SMTP id 5b1f17b1804b1-48526978dccmr204278825e9.35.1773078240136; Mon, 09 Mar 2026 10:44:00 -0700 (PDT) X-Received: by 2002:a05:600c:1e24:b0:483:887:59b0 with SMTP id 5b1f17b1804b1-48526978dccmr204278455e9.35.1773078239572; Mon, 09 Mar 2026 10:43:59 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 09/10] whpx: arm64: enable enlightenments if asked for Date: Mon, 9 Mar 2026 18:43:39 +0100 Message-ID: <20260309174340.52174-10-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078320396154100 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-9-mohamed@unpredictable= .fr Signed-off-by: Paolo Bonzini --- target/arm/whpx/whpx-all.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index c5b108166ac..513551bec1b 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -940,6 +940,43 @@ int whpx_accel_init(AccelState *as, MachineState *ms) goto error; } =20 + /* Enable synthetic processor features */ + WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS synthetic_features; + memset(&synthetic_features, 0, sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES= _BANKS)); + synthetic_features.BanksCount =3D 1; + + synthetic_features.Bank0.HypervisorPresent =3D 1; + synthetic_features.Bank0.Hv1 =3D 1; + synthetic_features.Bank0.AccessVpRunTimeReg =3D 1; + synthetic_features.Bank0.AccessPartitionReferenceCounter =3D 1; + synthetic_features.Bank0.AccessPartitionReferenceTsc =3D 1; + synthetic_features.Bank0.AccessHypercallRegs =3D 1; + synthetic_features.Bank0.AccessVpIndex =3D 1; + synthetic_features.Bank0.AccessHypercallRegs =3D 1; + synthetic_features.Bank0.TbFlushHypercalls =3D 1; + synthetic_features.Bank0.AccessSynicRegs =3D 1; + synthetic_features.Bank0.AccessSyntheticTimerRegs =3D 1; + synthetic_features.Bank0.AccessIntrCtrlRegs =3D 1; + synthetic_features.Bank0.SyntheticClusterIpi =3D 1; + synthetic_features.Bank0.DirectSyntheticTimers =3D 1; + + /* + * On ARM64, have enlightenments off by default + * as they're not needed for performance. + */ + if (whpx->hyperv_enlightenments_required) { + hr =3D whp_dispatch.WHvSetPartitionProperty( + whpx->partition, + WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, + &synthetic_features, + sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); + if (FAILED(hr)) { + error_report("WHPX: Failed to set synthetic features, hr=3D%08= lx", hr); + ret =3D -EINVAL; + goto error; + } + } + hr =3D whp_dispatch.WHvSetupPartition(whpx->partition); if (FAILED(hr)) { error_report("WHPX: Failed to setup partition, hr=3D%08lx", hr); --=20 2.53.0 From nobody Sat Apr 11 21:31:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1773078331; cv=none; d=zohomail.com; s=zohoarc; b=Nmu2cmx/tXSjZ5UeTGwpHVTejt8xepz3rmTyPghrtRWu+NMyX+U8HyEXDTdQ0UF/bWZ4KK0MslrymsYDkrTlTSDZdTM0fK5no/hm7KCUvCO3VZ7EsMONBvwsMTnzMg1fDcwozx4FBouNjeRAZnnB2Gr+sOjDjqQ1R6q/HeZ2A+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773078331; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=A3fExuEyshklgLg4imO84uAwwu5yvw8RrPuBu6Av70nw1xGeHRr4HlsOy2SIrUbK0UcnIFu1qnjADIm+iFCChqJfZXUS0Y4QAJYloC1H468OACkjLgXw6cAGXEJ8tR02Vzmsn0I4N3wjfezHWPTuDLbgHqmMiFaD37ruWSZTIIM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773078331782751.2800450418321; Mon, 9 Mar 2026 10:45:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzef3-0003Lc-Eh; Mon, 09 Mar 2026 13:44:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzeeN-0002mH-Dy for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzeeF-00027c-Bw for qemu-devel@nongnu.org; Mon, 09 Mar 2026 13:44:10 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-_bjd4DsyO0KYFHwmwyDHxQ-1; Mon, 09 Mar 2026 13:44:05 -0400 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-439c4bde453so4317699f8f.0 for ; Mon, 09 Mar 2026 10:44:05 -0700 (PDT) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485237dd017sm95189205e9.2.2026.03.09.10.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773078246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=YUGvmbjgt/jOSZuX1vsW6fwfcsh4kLPltfypPsr48FRBVTgDIGTgJAMGNJOFhMxnbNIfcu Do5TD39qacnX8jutBo2Gl7xYqDqKMjkt+R3Th0PJfw2QMKR22ctjdTY2HahJxFnjLm0iER O+PrHGJdHybpkI/yq63dpW9VZpNlQKc= X-MC-Unique: _bjd4DsyO0KYFHwmwyDHxQ-1 X-Mimecast-MFC-AGG-ID: _bjd4DsyO0KYFHwmwyDHxQ_1773078244 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773078243; x=1773683043; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=RuRWnE8Gkb6hUaHHY80aLu4+DUX79Kjiaieq/xkVI48efAsStFPdsXELAwuQsbXXr2 qYAHg+6McI3HGU8YYKyPvl5XVpZ/PapSLUNCVZC4dirzFzWsfj4rAUb2RsKrT1hSJc5R UyouD6ngPw+rQ4mpNTDPalGmyyk5i7Tzy18/3RR+72HurcOAvA57qkrSQ8Cs2sGgln5I pycoz2pgWfI+4r4E2lbbNcBtJ9ARHp9N6hcgQw6Z+Q+2jNWHl7hQTweBhpnfyE0b6ijs rpEs4iKPXptEl0AeZz2JBhI8GadIZ6cdEnOvGoMfYctT2tTJ5zh3SMZ3K8lvvmImF3Gh KzdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078243; x=1773683043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1r9g5CqWf0hmFdhCjo01T6zVno1OvrQP8qBF9MdcaDw=; b=Ev2Y7s3bdhutvkIRq5rA5LmhTkNSHQlqbDG30UEPFKZAw30Ow4iby24qkF+lW4H61k 2vjCXwow2s7sVpex9pq41rKMhNLfytIaYoxval5bKmWepK+w55KDzIHEedEcKroF0a+1 BCzey7BQ56STF47w7zUaUOZifskc8wCUk3BZaUJGccnb099vZwgs62+Hi0p15a2E1klZ W2PXdLXTd3tMkghza5uAic4Qwo6yjF3ndIjqybaRiAvhoK8hU68xz7CKQ7ZM+AmC+0F9 D7lLOK9AwugXxZ/mRzWC91X1fdh/zzVcLnaCXfbYfmXFGuo9yp4R3UwugR346OyT6Rsw MlzA== X-Gm-Message-State: AOJu0Yx9YZaO3+JugLcj6FdKOQtMDNwwquJAyfxEmWkqIHYSIPYvaNFJ z2vdTAVTQxEsVDWbnIBYrf9q0VxuprXv0cbDu2I4O7U+OD+EhFgQ+O5Y+TVroQGcq2kZt4WtbEV aUTWOZn0QtJ6r7BjUOkSYQ5fpJvyv8ZRNxgL/feLeyBK06hcLYGamTtbjBGyu8G/MP8cNFgzKFQ JTECJNAje9nlSi0KMnlJb+UO0dYX/05tdQwBs2rLQo X-Gm-Gg: ATEYQzzHDltjdGLQSgIEesumHrF92Lrn2o1dyTKw7mX3tAjBnK/ghtyx3fbv+idPD8D PUDVQfjDjrlrp/w+rfsSyaE74HFWDqYhONcTyLPLZ0iNi/v9IrzVEYbHjsa2D6FRQEewgp9Y5Rc j97YPDGR6Bfpy2nI5BuqFUhAn1aHXmAQNgyoq3Rk+2PMLZvR/9IrQZP6CYLQ1QkGHL1BrJhN45N Gyij4Pw7tcn3Eggpefz7l9MTCqnMYJyGAwAesx9dVTo/IF8ND3UfNQKvVFAMkGBnac4maPDyZOE z+Ab86U2BFdPEU0GnAMImH2mIRGL2r6OF/qWQy9NZew7RILXqSDwAGWjvFUOuCHorVbhhPLBwdc tf8/7I5gglwD2mKpD4RqlkPAHUdWfAC9SQXIW1MclOJPolSc0qNJFlE7QDVhs5rkri89LDODlYx M6ou0amAl1GXnip/DnkKMNp6zrS8A= X-Received: by 2002:a05:600c:3593:b0:485:3c7f:527e with SMTP id 5b1f17b1804b1-4853c7f53cemr54268495e9.15.1773078243538; Mon, 09 Mar 2026 10:44:03 -0700 (PDT) X-Received: by 2002:a05:600c:3593:b0:485:3c7f:527e with SMTP id 5b1f17b1804b1-4853c7f53cemr54267895e9.15.1773078242998; Mon, 09 Mar 2026 10:44:02 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mohamed Mediouni Subject: [PULL 10/10] whpx: i386: remove SIPI trapping Date: Mon, 9 Mar 2026 18:43:40 +0100 Message-ID: <20260309174340.52174-11-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309174340.52174-1-pbonzini@redhat.com> References: <20260309174340.52174-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1773078333205158500 Content-Type: text/plain; charset="utf-8" From: Mohamed Mediouni The implementation in Hyper-V works fine and the code currently present doesn't handle x2APIC correctly anyway, so remove it and use the implementation in Hyper-V. Signed-off-by: Mohamed Mediouni Link: https://lore.kernel.org/r/20260307181856.2209-10-mohamed@unpredictabl= e.fr Signed-off-by: Paolo Bonzini --- target/i386/whpx/whpx-all.c | 97 ------------------------------------- 1 file changed, 97 deletions(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index b095c96962d..4d5d3dbd243 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1692,100 +1692,6 @@ int whpx_vcpu_run(CPUState *cpu) ret =3D whpx_handle_halt(cpu); break; =20 - case WHvRunVpExitReasonX64ApicInitSipiTrap: { - WHV_INTERRUPT_CONTROL ipi =3D {0}; - uint64_t icr =3D vcpu->exit_ctx.ApicInitSipi.ApicIcr; - uint32_t delivery_mode =3D - (icr & APIC_ICR_DELIV_MOD) >> APIC_ICR_DELIV_MOD_SHIFT; - int dest_shorthand =3D - (icr & APIC_ICR_DEST_SHORT) >> APIC_ICR_DEST_SHORT_SHIFT; - bool broadcast =3D false; - bool include_self =3D false; - uint32_t i; - - /* We only registered for INIT and SIPI exits. */ - if ((delivery_mode !=3D APIC_DM_INIT) && - (delivery_mode !=3D APIC_DM_SIPI)) { - error_report( - "WHPX: Unexpected APIC exit that is not a INIT or SIPI= "); - break; - } - - if (delivery_mode =3D=3D APIC_DM_INIT) { - ipi.Type =3D WHvX64InterruptTypeInit; - } else { - ipi.Type =3D WHvX64InterruptTypeSipi; - } - - ipi.DestinationMode =3D - ((icr & APIC_ICR_DEST_MOD) >> APIC_ICR_DEST_MOD_SHIFT) ? - WHvX64InterruptDestinationModeLogical : - WHvX64InterruptDestinationModePhysical; - - ipi.TriggerMode =3D - ((icr & APIC_ICR_TRIGGER_MOD) >> APIC_ICR_TRIGGER_MOD_SHIF= T) ? - WHvX64InterruptTriggerModeLevel : - WHvX64InterruptTriggerModeEdge; - - ipi.Vector =3D icr & APIC_VECTOR_MASK; - switch (dest_shorthand) { - /* no shorthand. Bits 56-63 contain the destination. */ - case 0: - ipi.Destination =3D (icr >> 56) & APIC_VECTOR_MASK; - hr =3D whp_dispatch.WHvRequestInterrupt(whpx->partition, - &ipi, sizeof(ipi)); - if (FAILED(hr)) { - error_report("WHPX: Failed to request interrupt hr=3D= %08lx", - hr); - } - - break; - - /* self */ - case 1: - include_self =3D true; - break; - - /* broadcast, including self */ - case 2: - broadcast =3D true; - include_self =3D true; - break; - - /* broadcast, excluding self */ - case 3: - broadcast =3D true; - break; - } - - if (!broadcast && !include_self) { - break; - } - - for (i =3D 0; i <=3D max_vcpu_index; i++) { - if (i =3D=3D cpu->cpu_index && !include_self) { - continue; - } - - /* - * Assuming that APIC Ids are identity mapped since - * WHvX64RegisterApicId & WHvX64RegisterInitialApicId regi= sters - * are not handled yet and the hypervisor doesn't allow the - * guest to modify the APIC ID. - */ - ipi.Destination =3D i; - hr =3D whp_dispatch.WHvRequestInterrupt(whpx->partition, - &ipi, sizeof(ipi)); - if (FAILED(hr)) { - error_report( - "WHPX: Failed to request SIPI for %d, hr=3D%08lx", - i, hr); - } - } - - break; - } - case WHvRunVpExitReasonCanceled: if (exclusive_step_mode !=3D WHPX_STEP_NONE) { /* @@ -2249,9 +2155,6 @@ int whpx_accel_init(AccelState *as, MachineState *ms) memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY)); prop.ExtendedVmExits.X64MsrExit =3D 1; prop.ExtendedVmExits.ExceptionExit =3D 1; - if (whpx_irqchip_in_kernel()) { - prop.ExtendedVmExits.X64ApicInitSipiExitTrap =3D 1; - } =20 hr =3D whp_dispatch.WHvSetPartitionProperty( whpx->partition, --=20 2.53.0