From nobody Sat Apr 11 23:04:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773071975; cv=none; d=zohomail.com; s=zohoarc; b=mwdaxoH1Dhx5YcbryxTCVz++IGWo/F8DQ+tLjE5J+PncSqLUn3s7ydjlmLCgIkdKwIHIcRZUZeF1lE27wzJ/y5CoUfYk0GdyqNo8vT7Ce5W16+X6rMCjpGO8yKrdoUhj8LZe6kvO816SXsh+j++KmgNgBvlAR6dPmMZe0kKnTm4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773071975; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=AuRv8v324tCQUkX/bfQ3Ovg91hb7uk1tmN4rCfz01G8=; b=LGRduX4J7wFEn3MkfOBXh2iuA4Oijl4+675qzlEvll+A5dNB83n7ArF8uEf55ZIkSZ2wA2KHm1d1O2Kdu9kQe2S3ANeo12rEjfbibIvXU8I7VsSDSfCYB0KVQdr7fB1GYIdt4Wv1LHpBaniqMMG/fMiUg2UkuLbGWM/qA8iQIvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773071975169869.7674862600492; Mon, 9 Mar 2026 08:59:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzd0c-0006c2-82; Mon, 09 Mar 2026 11:59:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzczJ-0004wy-Je for qemu-devel@nongnu.org; Mon, 09 Mar 2026 11:57:46 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzczG-0000rj-Ni for qemu-devel@nongnu.org; Mon, 09 Mar 2026 11:57:45 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-48539cbb7b1so9380455e9.3 for ; Mon, 09 Mar 2026 08:57:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541aad45fsm802025e9.15.2026.03.09.08.57.39 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 09 Mar 2026 08:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773071861; x=1773676661; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=AuRv8v324tCQUkX/bfQ3Ovg91hb7uk1tmN4rCfz01G8=; b=cjPojoAKSdHK3d38fbW2sF5VV9BYbZCObjG8QCJr4nztSN2/qu241NHN+h8eSJvdqg ww48v5tiZ5Uu4rgyrOm1kKNGu+M667Qrtt/XqvxG7JDdsvT8WwBxESTYhyxf8OGxeTGQ Shcg1ctI1aV+rF2z8EZv5EnNY06aira2xAzs8S/ysBOaZgJsOe6SPtX+KTSkuPX/iOqH pmHkJV7IY3MiHeXmzPhwQLgtxOWvO2sWlryw4rsxam4WNDiTHBZnwKI3L+ojkwt/ubL4 MjH+it4MBrORfckkDClKchT2SpFtgzggLhgIDhPYeKsHJeKv3oi5KI/dmvYSVX9inN66 WfQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773071861; x=1773676661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AuRv8v324tCQUkX/bfQ3Ovg91hb7uk1tmN4rCfz01G8=; b=apkoeCR3r6aKNvGD+q+7eZ85YAgb9WpzhS4R1BMmTVMtjYcX5m80smi1k2jzu9qAYZ ywqTA+wHzfUzrdgJI8MdiFYT6s1BoOaZbZdsvxfzCi9kV3BEU5KgvNNxnSWgKOkKR6KI GePw82Dtpo0zIbzt31yr2mgkGheeY2nri681pe5bq69ob7ghzjUv5LA8InTjULNJg5H9 vBSEOE2l06CjlYNkUHAz6tdmThjBjH5o0Zdm/X/R3/DJ+Sj2EuG1vgxS3dwzhMNVtPpy hTdl3Lz32so00XvRCkE9qIe5OSSkHo7wNviKsZ54jo+ZE5K97N/OOUq27olU9CZVu8W6 lVlQ== X-Gm-Message-State: AOJu0Yzf/HErMuEqznZKdbXqFBBah1c4Ma9u+tSHrA4iKJJFDGG7XQGG OEVq/XUsR4xZR7eClUJqAXjYR6NNovFkwFzuxbLfqUpQnKHZnoaq2XcM54gx6BXDLZot444gsfO SIFRD0Mo= X-Gm-Gg: ATEYQzzKOlm9rTOhmICYOJr4uY48zczFGNWpw/u+VScC3chPAvQN6Ltvj1uob0RF0pa ZnmIFcKQJAak/Z8p0lZOH7nvvHJm3tTLV1bgqs1WadjKX36sN+H1g55idmwQhmNQK2jNccsgiTu /KefBDGM87VQGU9+cYuNfr7L2A0tHcpA2AN2HQDHKR8z192ahaiASso0uQHU3f1/3F1rnbzswwu GDUKuKovt2+2vfD3alRegxfpyrjLq6N2uImFfU5Oh97uFVCXz88TecpdPqToOQShGmcojGJOdbc OxHzQ7FIM5ranj6kcygBNwz2nuHiC4k0Ve4CScBFl2/ABC7bRFzRabrA1t+n8CP+4ym9ctFG7WC wV/J+Agj7eNnlmtAZZxRUVVg+bpY8ieHI522pLqoXTR4FYbmdQmGNVVi1wtDXPQd3UTTqm5Kc40 Qdpvs6/A72me/+ySZLnJie4G/zy0MitCzqzMGQ48vR0FNY8+1BxjNSWcMWmw4yLwPFqjILMGp2 X-Received: by 2002:a05:600c:4f55:b0:485:3c66:e230 with SMTP id 5b1f17b1804b1-4853c66e4eamr55050955e9.29.1773071860592; Mon, 09 Mar 2026 08:57:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 47/49] hw/i3c/dw-i3c: Fix memory leaks in error logging paths Date: Mon, 9 Mar 2026 16:52:17 +0100 Message-ID: <20260309155219.62400-48-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309155219.62400-1-philmd@linaro.org> References: <20260309155219.62400-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773071976271158500 From: C=C3=A9dric Le Goater object_get_canonical_path() returns an allocated string that must be freed by the caller. Use g_autofree variables to ensure that memory is not leaked. Resolves: Coverity CID 1645550 Resolves: Coverity CID 1645553 Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260309093838.364126-1-clg@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i3c/dw-i3c.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index 3d8b95a14c4..e9bdfd6af2a 100644 --- a/hw/i3c/dw-i3c.c +++ b/hw/i3c/dw-i3c.c @@ -490,8 +490,9 @@ static int dw_i3c_recv_data(DWI3C *s, bool is_i2c, uint= 8_t *data, /* I3C devices can NACK if the controller sends an unsupported CCC. */ ret =3D i3c_recv(s->bus, data, num_to_read, num_read); if (ret) { + g_autofree char *path =3D object_get_canonical_path(OBJECT(s)); qemu_log_mask(LOG_GUEST_ERROR, "%s: NACKed receiving byte\n", - object_get_canonical_path(OBJECT(s))); + path); ARRAY_FIELD_DP32(s->regs, PRESENT_STATE, CM_TFR_ST_STATUS, DW_I3C_TRANSFER_STATE_HALT); ARRAY_FIELD_DP32(s->regs, PRESENT_STATE, CM_TFR_STATUS, @@ -1107,8 +1108,9 @@ static void dw_i3c_resp_queue_push(DWI3C *s, uint8_t = err, uint8_t tid, static void dw_i3c_push_tx(DWI3C *s, uint32_t val) { if (fifo32_is_full(&s->tx_queue)) { + g_autofree char *path =3D object_get_canonical_path(OBJECT(s)); qemu_log_mask(LOG_GUEST_ERROR, "%s: Tried to push to TX FIFO when " - "full\n", object_get_canonical_path(OBJECT(s))); + "full\n", path); return; } =20 --=20 2.53.0