From nobody Sat Apr 11 23:04:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773071673; cv=none; d=zohomail.com; s=zohoarc; b=I8mf5t8fICm/HcDcdemaQVyPPGPeWGZFTDBR4aUPeGFDz6yoT2ElqULaZdWrry2DmCkTzDxyZ0NPnAW6ZKspXV9SE2A02YTEiPhkVcLSSp4TLowkK5+RzHgolbUmHJjk7vQ8/aT77Vchq1gd0EgAhsEwGyBoinBf0vm0sC6RRnI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773071673; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=vQ2Sn8Wbqu1NrXuJtMyexGGxp0O6O+LoeTC8M+EESYw=; b=c/hFkcxWAJGuu9b33djRZKaBzsqWq2dyhnXomfjoJTgCi5RjgPa2mnQ0Q1z80lQEjQIOAJQfJ6QID0l56lzaN1rSJcd4g48iaOKlQwSE4s+69pAejCe1lxBF7Um9R1Biof4DUb1Rhxl2mjl1LhpynhJYFuLgtlslajRNXrZw9ss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773071673407895.5344678320781; Mon, 9 Mar 2026 08:54:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzcvz-0007KJ-CI; Mon, 09 Mar 2026 11:54:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzcvm-0007Ez-Eq for qemu-devel@nongnu.org; Mon, 09 Mar 2026 11:54:08 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzcvj-0000LW-QO for qemu-devel@nongnu.org; Mon, 09 Mar 2026 11:54:05 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4852f73d0a3so17544945e9.3 for ; Mon, 09 Mar 2026 08:54:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fb3668csm558452765e9.13.2026.03.09.08.54.01 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 09 Mar 2026 08:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773071642; x=1773676442; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vQ2Sn8Wbqu1NrXuJtMyexGGxp0O6O+LoeTC8M+EESYw=; b=hWev81pIKmphWWSpLrOAF0CA1WQ22MJXkU4PPtBhm05fzvi8EzioAxJRQ+eDitb4kB UkhalOxwOsku5CLr0eDAlZ5s3MDArbuY+F0CvcmiHQilJSDVpuUoTJmnIk0xC5BgAeZK 6Rnef4JujChbyZ4lC5WWj96DNfc8uZ0PuuFKGBBllhRwky7PRCaHSLb/++Pnc3AblBUC WDj4f9bc/PTOkTD4fpuhAX+YCL4lIRpIJ0aV96KBtyaKqNl0Y7T77uXUP1t67+DZV9R8 qsHQi84m3ZxNfm+qfyxv96islowNDNBabkwAimCNXLzJl+LECdkubphz7kBTZ7uI5D+5 V3+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773071642; x=1773676442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vQ2Sn8Wbqu1NrXuJtMyexGGxp0O6O+LoeTC8M+EESYw=; b=stWh7l3uRRQWN3CvH0Vk3jv2Z+bN61Uq8GN3vSW7rKv5/9Fv7J4I0SDxDo6hHhZx7D +qBPfd0a1aKdbb25Rfh9eLJ5sz39oG2pW+74sfPY44L5tc1qJOKmqQZhEOcuTfOpPVL7 gowgF/cLyTF0zfmWau76HzKJmlWbz1N4ZryL+wUrBuGQsO4CaeO0s+dpB3RxO4K4tSSy JAXqoPJgoW9re7kMXVSHkzHzeq18CAqFQjVG6JAqzrWkLle0pqASMTPd1VvxK4/7Wyai bcjr4Xnsr6cVLQDaaTFPxo938GrvuzLXX21i+4lQ4dj8acpk6FwfrkzIsmSqLdai5wTe YK3A== X-Gm-Message-State: AOJu0Yz8cbPYN9unRgq6EI0mLYUcAIYFICuvpM6gZGt/iH3+nefJEjse Bd+KYsvg5kEuPQu2K74Odtw1qc3SogI1xmpPxip/rm1Df+LuUvO3Px0/pot4tn6Wmx3unCgXK5H DdHwMg8w= X-Gm-Gg: ATEYQzyK99qNgPIjYZm1nRKbxusjLJCd5xK8ajRMU7Kbm0V9EgKrlBW8KFiqM0nTe1y viqHSfdlZxjNXloGK+lXdKtNHLYkISaPlB+tH9LJObVSMmHyH6Ahii67eEXQtw9S/E1Qhx2Kdv/ 18f8jJTKw81/5mQ2o8TF7zUGmxZWrOmgs67mNJz7CZ3l5pSUSF8cTgRtKXkaRruorZ15R7CZVZ5 1Mq6EtKXxaooqbc/QxZwBR380+BHIMjl7a63s3PZuV7sYZXqURXuixKx0tGQzQ7P+ryOhbn6X3d sfyl8UvqtNTIn9Q80ar6N1sZhaGE8kCa1TPK46ONFF/7+YLc26xvqDeKe0+CUUdfPmhUbELqmLK V45ZiyLnydnSh3xs5VT2a5tGc7aPNqhWUo6DINUAeCcJioRwYDkiTjsXXtI0/Qyx6KMyjzWs0Ir CuRrJqspYBCHrRa8YLejbmuRDJKeusLuNtVi5v+y/iamhKCUIxaSXtSaSCqKNt6vCraaEyNF92 X-Received: by 2002:a05:600c:8b2f:b0:485:3a59:99ca with SMTP id 5b1f17b1804b1-4853a599b8cmr81905465e9.16.1773071641839; Mon, 09 Mar 2026 08:54:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 15/49] hw/rtc/pl031: : Remove PL031State::migrate_tick_offset field Date: Mon, 9 Mar 2026 16:51:45 +0100 Message-ID: <20260309155219.62400-16-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309155219.62400-1-philmd@linaro.org> References: <20260309155219.62400-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773071675372154100 The PL031State::migrate_tick_offset boolean was only set in the hw_compat_4_0[] array, via the 'migrate-tick-offset=3Dfalse' property. We removed all machines using that array, lets remove that property, along with the pl031_properties[] array which is now empty. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-Id: <20260307154202.86309-7-philmd@linaro.org> --- include/hw/rtc/pl031.h | 1 - hw/rtc/pl031.c | 22 ---------------------- 2 files changed, 23 deletions(-) diff --git a/include/hw/rtc/pl031.h b/include/hw/rtc/pl031.h index c8b26c2f00e..75779c63122 100644 --- a/include/hw/rtc/pl031.h +++ b/include/hw/rtc/pl031.h @@ -36,7 +36,6 @@ struct PL031State { uint32_t tick_offset_vmstate; uint32_t tick_offset; bool tick_offset_migrated; - bool migrate_tick_offset; =20 uint32_t mr; uint32_t lr; diff --git a/hw/rtc/pl031.c b/hw/rtc/pl031.c index b56877c3a20..09d1b15c779 100644 --- a/hw/rtc/pl031.c +++ b/hw/rtc/pl031.c @@ -278,18 +278,10 @@ static int pl031_tick_offset_post_load(void *opaque, = int version_id) return 0; } =20 -static bool pl031_tick_offset_needed(void *opaque) -{ - PL031State *s =3D opaque; - - return s->migrate_tick_offset; -} - static const VMStateDescription vmstate_pl031_tick_offset =3D { .name =3D "pl031/tick-offset", .version_id =3D 1, .minimum_version_id =3D 1, - .needed =3D pl031_tick_offset_needed, .post_load =3D pl031_tick_offset_post_load, .fields =3D (const VMStateField[]) { VMSTATE_UINT32(tick_offset, PL031State), @@ -319,25 +311,11 @@ static const VMStateDescription vmstate_pl031 =3D { } }; =20 -static const Property pl031_properties[] =3D { - /* - * True to correctly migrate the tick offset of the RTC. False to - * obtain backward migration compatibility with older QEMU versions, - * at the expense of the guest RTC going backwards compared with the - * host RTC when the VM is saved/restored if using -rtc host. - * (Even if set to 'true' older QEMU can migrate forward to newer QEMU; - * 'false' also permits newer QEMU to migrate to older QEMU.) - */ - DEFINE_PROP_BOOL("migrate-tick-offset", - PL031State, migrate_tick_offset, true), -}; - static void pl031_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->vmsd =3D &vmstate_pl031; - device_class_set_props(dc, pl031_properties); } =20 static const TypeInfo pl031_info =3D { --=20 2.53.0