From nobody Sat Apr 11 23:07:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773071632; cv=none; d=zohomail.com; s=zohoarc; b=Wd1SF06ODXuUDup7I5G+IiXL3e50YvQjvso1dwbD+nVIPAv0CmC+8WeUejtcnCpwS+rnOUj0LHcbix5oOyQ3AaL4DdySk7luXDzvJ7mysBj7OF9D//5frV9up/8ZjtDLG9NISx9sCHAZl+0bAbtBC5b4Y2tU4I0S6P3S3zP+oVY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773071632; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=pgpA3PHGmA2cywOmnIHp4QQstzRdLHRlcUMp4w2UsrY=; b=Lk+6CXhGIcv1A7CmN1mczAnWtYIyQ8FGm49Tkh6isdrCZAGSPq+Qz7O7sJ/dQvDq7O+hY4DEHDxrFC0j+OVktsVx0+Y88xEi6hPTApmU8dUJmCfGUQGpoRqOlZJ2bUZroWmQJxQAUmzua5Vohv/K9zWvS2TODH+yi9VhYEkR9/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773071632173914.9079899042507; Mon, 9 Mar 2026 08:53:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzcvL-0005aR-NJ; Mon, 09 Mar 2026 11:53:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzcvE-0005Bl-Fk for qemu-devel@nongnu.org; Mon, 09 Mar 2026 11:53:32 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzcvC-0008FP-Ns for qemu-devel@nongnu.org; Mon, 09 Mar 2026 11:53:32 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-439aeed8a5bso9200468f8f.3 for ; Mon, 09 Mar 2026 08:53:30 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae2b9d8sm28693381f8f.21.2026.03.09.08.53.27 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 09 Mar 2026 08:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773071609; x=1773676409; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pgpA3PHGmA2cywOmnIHp4QQstzRdLHRlcUMp4w2UsrY=; b=hw05L4sm07BFjE1hsZoDVU/p1m5aPvMWfElezukKU0/Ezpa6htKlSyjpg4QagPvAVy r6G3Afk6xtTh49tJy7/OXvQDYBrTnQ+YAiKvXgkn/FlvQ0B4ogxcKmKPcYm8bJHDh35m CQJzIu7k23fTU8aa/WdW09qy768Ljdkhi5tC/y4cSRDA6FzIAeWWMgNh8nQ3u+wteOUp nqJJZD0529sH+SZS6H6REX0EOs8eNkBOfTugSZ+Wu+4nE3/0NFEBoJ7p3ruEAMDdY9Pa p9R9oE5RH9SWzd1yFwTn/PCp7yKuMg3B5EOVDy8cRCUZX7bNJGLp8gGmoZGj2B7AhlBx ziWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773071609; x=1773676409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pgpA3PHGmA2cywOmnIHp4QQstzRdLHRlcUMp4w2UsrY=; b=gNdT4JA2zNyiQAWz2Y/JJJn1VsoqdeJVEUbR7i/F0XpVW/+QachoB+sj89uFHq8YXv l61p+ldYbv/mrqyI8eJCFcj5B1TXDXzb0pUGHrdENGSXnNFD2nNDEKExcx9YF7pV34pS X60D69tb81ZyiwdVN71V16SN35whEe5bteyGdpNSfChgVLlOE2Kjkyc2QWKbDGkDf/E1 MXc18Ss3Fm/hoDVbROA60nGzDT45otxsh42y8fow8JeIZGvzyyIuiil6WRFwodc87AkS zKNK4A8reKaqwkIE41L8E8vkEWWxq/4EruBrhtp7WGqrcEhHpNZoaGvZ2js9NJKGkB88 Ijgg== X-Gm-Message-State: AOJu0Yzl7bs2Qv3A4KngIG+I0Q2tX2k/G3us8R8lR+VUqjmNtt4xb3CZ 9SrLkEqRtgEI4wX5qMBAZuNfpbRDB83/TKxHQdfHWVHSW1iQT3uJwYddgimiskBy57yEHTxwBt8 3UJSj+l4= X-Gm-Gg: ATEYQzyP+WpeviDGrwDQNl9F/ZABKAgO0DXbLDvee7YRo29CpnUn8otTHTiT/LpszAS 2LvG69GOUIbWr8NY7vvEYScF7E/4p/fYvQKDNo1zw0KEGjpluf5piakPATWBjbH09JEF0LlizSX bYNJ777y1ww9BlSR379PYnjytmEyHORidc9cAytHZ8nK3itPr1l4iEXuVUT98cNuDexVuLBYbgc 47PjEWMg3SfL8FeBpvG1Ip5eUC5W91J653HpyN5x+aWlb5eW8Azc67cwH5d4s9ENkN7qwyXJ2iw 4WkESHZ7IjY6H79b2wGqQo7KFPrDsgX4z5Zd4M+QSl3Z4XVdyLY58ArDpFHg3lOjXVYgH6JneCt MZW+7xR+30sNqux1AGBxSOpDnNgoNokYZ5vNKFQsRp/i7VQf2t1SSIguasm+bEElNJv/B9fwEl2 tKALddNzKmDd5puuyN2ZgVY3qQ4IWPClYO7r6+a2TNPok2PAr/Yk35THIe5+O6Ve/C2DhLdMS5h vaXIyEm3kg= X-Received: by 2002:a05:6000:40cb:b0:439:cc01:c9ee with SMTP id ffacd0b85a97d-439da5554a3mr18488588f8f.3.1773071608643; Mon, 09 Mar 2026 08:53:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/49] hw/pci-bridge/pcie_rp: Remove PCIESlot::disable_acs field Date: Mon, 9 Mar 2026 16:51:40 +0100 Message-ID: <20260309155219.62400-11-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309155219.62400-1-philmd@linaro.org> References: <20260309155219.62400-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773071634232158500 The PCIESlot::disable_acs boolean was only set in the hw_compat_3_1[] array, via the 'disable-acs=3Dtrue' property. We removed all machines using that array, lets remove that property and all the code around it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-Id: <20260307152635.83893-10-philmd@linaro.org> --- include/hw/pci/pcie_port.h | 3 --- hw/pci-bridge/pcie_root_port.c | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/hw/pci/pcie_port.h b/include/hw/pci/pcie_port.h index 53cd64c5edf..b28af067a66 100644 --- a/include/hw/pci/pcie_port.h +++ b/include/hw/pci/pcie_port.h @@ -60,9 +60,6 @@ struct PCIESlot { PCIExpLinkWidth width; bool flitmode; =20 - /* Disable ACS (really for a pcie_root_port) */ - bool disable_acs; - /* Indicates whether any type of hot-plug is allowed on the slot */ bool hotplug; =20 diff --git a/hw/pci-bridge/pcie_root_port.c b/hw/pci-bridge/pcie_root_port.c index fe3ced56851..7c3e78010b4 100644 --- a/hw/pci-bridge/pcie_root_port.c +++ b/hw/pci-bridge/pcie_root_port.c @@ -117,7 +117,7 @@ static void rp_realize(PCIDevice *d, Error **errp) pcie_aer_root_init(d); rp_aer_vector_update(d); =20 - if (rpc->acs_offset && !s->disable_acs) { + if (rpc->acs_offset) { pcie_acs_init(d, rpc->acs_offset); } return; @@ -151,7 +151,6 @@ static void rp_exit(PCIDevice *d) static const Property rp_props[] =3D { DEFINE_PROP_BIT(COMPAT_PROP_PCP, PCIDevice, cap_present, QEMU_PCIE_SLTCAP_PCP_BITNR, true), - DEFINE_PROP_BOOL("disable-acs", PCIESlot, disable_acs, false), }; =20 static void rp_instance_post_init(Object *obj) --=20 2.53.0