From nobody Sat Apr 11 23:07:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1773009626; cv=none; d=zohomail.com; s=zohoarc; b=CDsQwj5c0NNc/a2W9eC0yIeCSZauawuHRqH+e4so078m7ADlgXD+020YYtMUS2ehLscJn1vyUe/xiz+yRhXPMDOZQXUjrd4EYt2lVrYjmgaWsZ5ehOgySxvw7n7nG2oETtYKtgOR7VGe60QmCCgratdqdCPMyRT7ncNnKyEyfp4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773009626; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Vi22zdaCk2LuAhPhd6uA58Ohth+YuI+ifJV1zGOLiuk=; b=b6Ye9DcM+eOInp49O5nGWWiZhW35CKQkvg89xsfp9VDySbVMYKLt330bsvHrPmgl5RNfBum1UvxC+I0yfleCb7/uDxtBDQAvmnT3MqPXdddyEgDoGpGOgfTqPpvxtVYsjxBnnz+3SdOksUpfXDu6e0JZIrQAhA6ZBDPN+21YphI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773009626125683.5119591884937; Sun, 8 Mar 2026 15:40:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzMnG-00015M-89; Sun, 08 Mar 2026 18:40:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzMnF-00013N-12 for qemu-devel@nongnu.org; Sun, 08 Mar 2026 18:40:13 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzMnD-00042V-0y for qemu-devel@nongnu.org; Sun, 08 Mar 2026 18:40:12 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-439c56e822eso5450723f8f.2 for ; Sun, 08 Mar 2026 15:40:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae36785sm19858880f8f.27.2026.03.08.15.40.07 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 08 Mar 2026 15:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773009609; x=1773614409; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Vi22zdaCk2LuAhPhd6uA58Ohth+YuI+ifJV1zGOLiuk=; b=vHO20rK7Yu18qr33qERLJmQinTkmf58jqAbfvBr/2hlg5fuekXG/n5gL0SQgG9qsA3 8GnmeKaKr6WS85l4ft80ohlHP/rhaREHrXO7exExANF5rlz3K8HoQryJUFvHW7UhtSsM TIpo1RYrJvzHvTCnheNA8lXbC+7KHfO6yJayqjKrg81dBFO29V37Mpw4SvfkO15wT+Cy vqAYqhck43O18GTqOEV4T51YJxFV/+jUn/G224bIZGuGgzLFjP6IMWxx9S9YnurkWjcm 7lRFCFgzLY4ChrdA6tbaK5uncEAwgUQb7vcOd8gS5L6nHS0LbwPXlzUk12o4jo2nDWYu NUCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773009609; x=1773614409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Vi22zdaCk2LuAhPhd6uA58Ohth+YuI+ifJV1zGOLiuk=; b=wNAwmSyPwZ+ybkYCKMk4jzwGUB/88bJ8POUPPATLO2Hk8oNK+Z6r/ymjKq+Xj/0dxr IVuM/oAV30BkjzLu6A/XvT+/EMmp8NR0VYHmGpWeLf4gaJYwyU0mNf/Fi0KV69ekIkL+ paf61zYjmYDUrVav/TrFvMR1KyzhWWC9smTOpQFElvuY9pFMdAHQ77CAcYcAYaFy5JEA Uhq/610Mklmf66tWxTZC49YSzogBFWvlQlG+uHU62QrLfDLsAGHqvqOCrmdrYwzYdo0V mceQTixuRDrXw2noJgrbmStASIvZHXyclvNVxe0VPXZcgcIo9pKhKE0oEOYshaK0CR83 CzDg== X-Gm-Message-State: AOJu0YyS51uI05lqv37Z9VU/EUxTo98+QjXLEIo/K+PabdwPJ9DtSIlj BXXkuSTZU/VFMDhhw8fZrXl3BC+TOHl2I2M0tdhHVIY+5MKy46JsWSsQvHXZG7gZ/+qObbUz+6r ecg4EMjk= X-Gm-Gg: ATEYQzzJJvyYTxyq10hhqOHHNeHniqB/L45T7dTs0p3atbTZV70IG5iaDsbqPnLPOdm NFNBLmTvmwXmp9Lx3sZroXSRH+jGCapwxqvSUVkIzNrHd0DPSHar+FrSYCk2g470XDK6JiLegjl X+XMsZWfkptDzZHh8cZ85eJblQAprMG8p5+fhCgyZL/UUGPfm3sTrNGFVj6VlZeaBYEStJI3DOt PWzssTrjv29uPrrzQAL+ieyDRIveOoB7/BrxdtRFlJQ8uJJTYwAGWmL9rgD0urCGDT6pMxBF+L+ b0QfESFemavA3InuJ4L0YndLj/wWVGRJRK+iEiuhEICAkOWnlbzOihiCVS2Y7E37u17E5zgli9B Upy7LUGkMzP963DaypaGdIg3S+7YIuRMMtdcso2f1norktrrKJimp0KqhUKTLZwa7uJoTftqax9 V8/pX0Ff6TqA2kPZ/cxbsRVlvjIN6TrTkpTjIVmxqn+3BuTtGIsTSK1o47EXylB3W7LI6daHiO+ fTUsQ== X-Received: by 2002:a05:6000:3113:b0:439:ba75:7db7 with SMTP id ffacd0b85a97d-439da555428mr15016841f8f.7.1773009609197; Sun, 08 Mar 2026 15:40:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 49/49] hw/char: Drop disable property of Diva GSP card Date: Sun, 8 Mar 2026 23:34:33 +0100 Message-ID: <20260308223433.25503-50-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260308223433.25503-1-philmd@linaro.org> References: <20260308223433.25503-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1773009627176154100 From: Helge Deller The "disable" property is not used, so drop it. Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Helge Deller Message-ID: <20260307195243.8813-3-deller@kernel.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/diva-gsp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/char/diva-gsp.c b/hw/char/diva-gsp.c index f9aa6e326d6..53fd0fe2a13 100644 --- a/hw/char/diva-gsp.c +++ b/hw/char/diva-gsp.c @@ -51,7 +51,6 @@ typedef struct PCIDivaSerialState { SerialState state[PCI_SERIAL_MAX_PORTS]; uint32_t level[PCI_SERIAL_MAX_PORTS]; qemu_irq *irqs; - bool disable; } PCIDivaSerialState; =20 static void diva_pci_exit(PCIDevice *dev) @@ -159,20 +158,18 @@ static void diva_pci_realize(PCIDevice *dev, Error **= errp) =20 static const VMStateDescription vmstate_pci_diva =3D { .name =3D "pci-diva-serial", - .version_id =3D 1, - .minimum_version_id =3D 1, + .version_id =3D 2, + .minimum_version_id =3D 2, .fields =3D (const VMStateField[]) { VMSTATE_PCI_DEVICE(dev, PCIDivaSerialState), VMSTATE_STRUCT_ARRAY(state, PCIDivaSerialState, PCI_SERIAL_MAX_POR= TS, 0, vmstate_serial, SerialState), VMSTATE_UINT32_ARRAY(level, PCIDivaSerialState, PCI_SERIAL_MAX_POR= TS), - VMSTATE_BOOL(disable, PCIDivaSerialState), VMSTATE_END_OF_LIST() } }; =20 static const Property diva_serial_properties[] =3D { - DEFINE_PROP_BOOL("disable", PCIDivaSerialState, disable, false), DEFINE_PROP_CHR("chardev1", PCIDivaSerialState, state[0].chr), DEFINE_PROP_CHR("chardev2", PCIDivaSerialState, state[1].chr), DEFINE_PROP_CHR("chardev3", PCIDivaSerialState, state[2].chr), --=20 2.53.0