From nobody Sat Apr 11 23:07:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1773002201; cv=none; d=zohomail.com; s=zohoarc; b=O62/UhSfVaBW6dvny4CAfNMuM/XyzR3y2wNUlGkAmPzbXUsjTPPRLgdKnt6lQ4oQy7j7VMX5MWw6po1aIvbC0D8OxZmpit/z5P4y7y1YsJvnjTQL5GOFewuoe1Rr7pgk87Wxb0f4Jk6eIJeiTQvvYbq45be0ZSxsLforTGZQcb8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773002201; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rGa+Qk9w7jO0yb09YCUU3MEUEX2jrREiC7pzktGBq9g=; b=SrUpvA5KOPG5zV0ic2vrQJya7pr/AcQKm10tLtR/1T8/faRjK4oSHdtIXb9UCZxIIYcyoA+K7hx3EuBKB3CYDpthmBwWcdv8Lb3nbc3pB40y2eVyQqfU+laf1JNcLEdtfSqkwGEW9wjn0BdREUXc0vELUqSBILUBHzJlBMdOEGk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773002201985138.25309145778886; Sun, 8 Mar 2026 13:36:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzKqc-0007Hx-FV; Sun, 08 Mar 2026 16:35:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzKqb-0007Fy-08 for qemu-devel@nongnu.org; Sun, 08 Mar 2026 16:35:33 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzKqZ-00045c-KG for qemu-devel@nongnu.org; Sun, 08 Mar 2026 16:35:32 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-439ce3605ecso2605113f8f.0 for ; Sun, 08 Mar 2026 13:35:31 -0700 (PDT) Received: from Provence (dynamic-2a02-3100-25c6-8f00-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:25c6:8f00:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae2bdf8sm20995508f8f.25.2026.03.08.13.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 13:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773002130; x=1773606930; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rGa+Qk9w7jO0yb09YCUU3MEUEX2jrREiC7pzktGBq9g=; b=WpeSB+xPA7eTCjTbiNfNBL5Nl2d3gfJWuT1Osj8ZBhl4D57QmnWV4uGcLnL2CGDzJh JB6KDJ1vdFsbQna+x/34y2actYmKAkb5pArxuPjFWOOzcRgVpX4JIFLTKbiG/dy4GNiL ZAdmZEOgau6AYTORViBYtxFNsPKT8SrFBnnRbZErokzyuArelOoQmCH8bEsRrEhDbrHS IZbXG9pIgoHj4Q+cwfpblrd1agJR1qTgZgKBEaKz6BbwbvZsIxg7jI8XNUDIoAlq4QlF M/xh5UMz4beJap0vuBJta9SPX9qRsieAv7+4h72dCBdSlEDFxsyY1btFBacDKF5QIl64 fj9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773002130; x=1773606930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rGa+Qk9w7jO0yb09YCUU3MEUEX2jrREiC7pzktGBq9g=; b=O1NkagizuguL36dcDlwRgozTVafBVuO6ACt2uLZ9Sx2L/r4Pffw4ksnguPwit6OOW8 A+XXEccn50rM90nAwhgz6AyC25eNhx7OpGiJdusAis1DD/7A8Cr5eOQziX0jy/KPawcR FMR67Gb6zZxWL9brRotTc8SRjdQWu7mcAj5ilOyBqNFG6yLk6b14NHR3p1HcDmvaTKCe outNkATyHN+io0jNrDFJjubCtpf6VlcwEQpYE/8UJd2P81AASkXHWu7UgNsUsykom0XY shK3aop33hQ1sn4Jwc2fHZ3LhhuPDtPO3yybhWhtrxbVJ63XBqdLqW7ng9vxBFKVJgMr 7Wzw== X-Gm-Message-State: AOJu0YytXnraoCHn7TbJ8NM1srrf162E8D7diT1XhSdWC1WYDO50Cpou vhOFNqHeMaPvHcFClO+FqdYi42i1Fa1ko6OvEfi5mppYEYXsALWb3zd7cnd+Aw== X-Gm-Gg: ATEYQzwfoIfUlvAKwOzOs6xGLmMALfD80g/Cl4yfcg246tzfNmMBdll0NJR6catXpCq WTWGh6pSm/4MFTiA8rxlNQbsWFZjpSuX7H5/g9w1N5kTkQAcoOT/z8Y/udSOJSvGq7VOsrfPfM1 aTPuLaFCq4/yHbTLqZ8C3ZCgg4vtk4kFKcRd1DVO7yMzNwf6de8TtgZCyLSphf+quWUTaf7LSza 5JprZstkNhm6FDidx+EdPKHR29u2l+OZjAlBUBQuOWKELgS3vXT2O54ze4CG5DkQ65Fp6prCO64 858zWA+X2sDJdxj00iV9t8DRGjMSey1Ew0GUFqsnyHXAfMsWpvhRD8H6l5XKzaIFt+Ip3XuIT3c wkVguAofc4wCfhJBUEnAaZh2fsVCk1F77EF7EkGNyDWgCzmiMbnV93B0HIPDNcHV7l8njdUGzGY Hn+44loJK4JEKEDeuZ8RuCKwk3WH/xoSFKbfGNWwsuRDa68uWG+Lsmx/WW9GVA4Jheg/uNHb32S 4uLMIf0H8i+C+SlXyKgd9f+u2KPDDE= X-Received: by 2002:a05:6000:4313:b0:439:a95b:3c43 with SMTP id ffacd0b85a97d-439da65e31amr15851395f8f.21.1773002129604; Sun, 08 Mar 2026 13:35:29 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Eduardo Habkost , Paolo Bonzini , Laurent Vivier , qemu-trivial@nongnu.org, qemu-arm@nongnu.org, Michael Tokarev , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Peter Maydell , Bernhard Beschow Subject: [PATCH 4/5] system/vl: Fix reference count of machine object Date: Sun, 8 Mar 2026 21:35:15 +0100 Message-ID: <20260308203516.160103-5-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260308203516.160103-1-shentey@gmail.com> References: <20260308203516.160103-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=shentey@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1773002205263154100 Content-Type: text/plain; charset="utf-8" object_new_with_class() and object_property_add_child() leave a reference c= ount of two while the QOM root is the sole owner. Fix the reference count to be = one by calling object_unref() once. Signed-off-by: Bernhard Beschow --- system/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/system/vl.c b/system/vl.c index 38d7b849e0..91b390dafd 100644 --- a/system/vl.c +++ b/system/vl.c @@ -2197,6 +2197,7 @@ static void qemu_create_machine(QDict *qdict) current_machine =3D MACHINE(object_new_with_class(OBJECT_CLASS(machine= _class))); object_property_add_child(object_get_root(), "machine", OBJECT(current_machine)); + object_unref(current_machine); qemu_create_machine_containers(OBJECT(current_machine)); object_property_add_child(machine_get_container("unattached"), "sysbus", OBJECT(sysbus_get_default())); --=20 2.53.0