From nobody Sat Apr 11 23:08:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1773002202; cv=none; d=zohomail.com; s=zohoarc; b=AXQmzQKOcNtlTBLPW95L1l8EMDQclxjv0vp1fK0fWGZXM/3IjnRE1xHEDvQ91ZQS11wdQVe1n2/jztRIbyA/sBEq0jhhogwkLTHxFzYLQ62D2Z2wg8MQG3q2nEiGGvOqUfNy025smvWTEPOTIYU1IXY9IICCQhkNWTpHxoBefQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773002202; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ht0en4g7BEiKReMa2mnsHtL6XNX6arYhl4MswHJxcl8=; b=NjlS8WLLo7mjOWv8TRNrCsdzpKgExiHhTg2Yrbes5Pz06QxErVwlyI24gChs/WqjJdW2pNA8k/Mwg72nrq5rvKrEikEvRQlrgFcwJGpevkFruGPvbsmibctdr87AGiyi6QkIWNP5ZgBx2e2Ec7dbC+bFPMCEG4spnWOI0w9nrY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1773002202075538.9385328869918; Sun, 8 Mar 2026 13:36:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzKqb-0007H5-R4; Sun, 08 Mar 2026 16:35:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzKqZ-0007Er-TT for qemu-devel@nongnu.org; Sun, 08 Mar 2026 16:35:31 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vzKqY-00045A-Dn for qemu-devel@nongnu.org; Sun, 08 Mar 2026 16:35:31 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-439d8dc4ae4so1042880f8f.2 for ; Sun, 08 Mar 2026 13:35:30 -0700 (PDT) Received: from Provence (dynamic-2a02-3100-25c6-8f00-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:25c6:8f00:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae2bdf8sm20995508f8f.25.2026.03.08.13.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 13:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773002129; x=1773606929; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ht0en4g7BEiKReMa2mnsHtL6XNX6arYhl4MswHJxcl8=; b=T3A7DnVYpUPWKv8BLxTSpn2rKSbwjBUSn2DSsl/8hkOdJp2iHbP9bsbvnJaBaFuyED NukXIcMy3zVKFyHdKKGPzadPbdeCJWwSr4Wcel9vyG9jHocT8Idi8yfN5UhLTRYh3jIE gOumEg6jjl7VEsQqpe+h1ocvXoxasIBwEEdaKM4DXKb3z4mhxZ/EMAOe1e5Q8YBJiWnZ JFS8RJreryIqthrGEmfoxCPQlL5FviJNj7iGpTXMgEhKA4puuuAE8hoMH2hYq7ahX4Wo AlsQfIo6LTQp8mW076ZdLResI8XJsXRiqkNJV5zgPzz9wJGVHX0k91h6hKLcNDC0DmJq 4tVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773002129; x=1773606929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ht0en4g7BEiKReMa2mnsHtL6XNX6arYhl4MswHJxcl8=; b=f0m40uX4TpTSv+N1b8WwPrBeyclqAw4JAolYHhGo8UHoODq8RhWFR7NU9BSGJtVBxN eagBHbfv0a7QWDaCYt1LMKcv3jPL6QRyPl5il1ZblpU9wyXQF71XmPUu7lP59LxgD5Gh if32cfWpI9loKZj1G8DdY4rZF6snfS2VaWQqgy8dkBWXM7CnHaIktAg5w4urpqYYGmfG 2GjkpgTqwEDj7dZZChRQz0mts1xSj/lHWW8R37AfsWhdRYJmnf3Q5qifC3QeNpzE76UE qLc17MBykIMMjGJNXfPxAs+dXNfhSpYmrOMkF9+BiYPo7CfIRVMWaVrhwUwVwbg4vBBS kUBQ== X-Gm-Message-State: AOJu0Yx30G+HytPooYF0tOHWBRCINWAqk4VL0zOso6JsstJoj3AjeBhd WQa38fNrFcCxGHivMpMQvNLrJpj9u8sAoE1Mfn7SLKBgv+OwPOkUokxpgVypXA== X-Gm-Gg: ATEYQzzq7IbRIey6EPnhNT6ziDzctjtdJCJQXKAZ5oZVy5pJyUFOZolkgXFGKjyGDpd iWtFp0VM3VspY6kwGgPxv+e6GSsKAFJvzH5EnMhqm4P5WlupP6zHiWfTSWlZvEFQUf+aWwd9wfP 8tZGwYl0vwwRwe6ePQoBQmM4hU4r2z1x7qpFRhh/qSmq/6Ag9U1TrLJrp+3VAtJcppx2SU8W+fl Jrij8YG0fmB93/rQNjlBO2uoZShFRYdhDlGoFoFZhKNsw3UBc1PBmawJ4mVissvQ8zxD89YxnOc K41fxzAbOqquVSo3fFWZvZAx4O28f1xDfO1j31UJ04QRA8zT4H2ENscXuwNHuhlb6xF3iKXNs7Z Ohb8zQ2ALvglG4xzgQwnB2TQeIAHaA27ZGkQy8yuFg9813WoKzFVkNfElfarsxRUUt02FomSVk2 qYroGMk5hnq418hI6B7UJWRKEpUT3t47ZYg1ZlY8pTOmSSJw0EnjvDzQP3Sv7Sio/BAMTWtW0Lz 9fLdr8iMwagaVEK4EGhxaujB+En5TU= X-Received: by 2002:a05:6000:4210:b0:439:becb:6286 with SMTP id ffacd0b85a97d-439da87c5a7mr15185221f8f.54.1773002128422; Sun, 08 Mar 2026 13:35:28 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Eduardo Habkost , Paolo Bonzini , Laurent Vivier , qemu-trivial@nongnu.org, qemu-arm@nongnu.org, Michael Tokarev , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Peter Maydell , Bernhard Beschow , Gaurav Sharma Subject: [PATCH 3/5] hw/arm/imx8mp-evk: Fix reference count of SoC object Date: Sun, 8 Mar 2026 21:35:14 +0100 Message-ID: <20260308203516.160103-4-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260308203516.160103-1-shentey@gmail.com> References: <20260308203516.160103-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=shentey@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1773002205048154100 Content-Type: text/plain; charset="utf-8" object_new() leaves a reference count of one, and object_property_add_child= () then leaves it at two. This would leak the SoC object if the machine object= was destroyed since the machine is the SoC's sole owner. Fix this by converting= to object_new_with_props() which gets the parenting and reference count right = in one go. Fixes: a4eefc69b237 ("hw/arm: Add i.MX 8M Plus EVK board") cc: Gaurav Sharma Signed-off-by: Bernhard Beschow --- hw/arm/imx8mp-evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/imx8mp-evk.c b/hw/arm/imx8mp-evk.c index b84ac91a17..cfc3038c36 100644 --- a/hw/arm/imx8mp-evk.c +++ b/hw/arm/imx8mp-evk.c @@ -74,8 +74,8 @@ static void imx8mp_evk_init(MachineState *machine) .modify_dtb =3D imx8mp_evk_modify_dtb, }; =20 - s =3D FSL_IMX8MP(object_new(TYPE_FSL_IMX8MP)); - object_property_add_child(OBJECT(machine), "soc", OBJECT(s)); + s =3D FSL_IMX8MP(object_new_with_props(TYPE_FSL_IMX8MP, OBJECT(machine= ), + "soc", &error_fatal, NULL)); object_property_set_uint(OBJECT(s), "fec1-phy-num", 1, &error_fatal); sysbus_realize_and_unref(SYS_BUS_DEVICE(s), &error_fatal); =20 --=20 2.53.0