From nobody Sat Apr 11 21:31:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772964182; cv=none; d=zohomail.com; s=zohoarc; b=eBmpx06nbqiygK4X7xckeM5Ch0EqPmHHMU+3al4/bvHQo+if4QZAUrJyiTQmcCanmhA2tZjlrlCe1wihkEzDafpOnCSCdwoawLqEl/5DeCnTRmzmZONeIcocbZQ5Wsjpx7P1fz9iBnd1LWTlCyQGHC17YeuB3saFBESLis2omaE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772964182; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s5oOmyJ7GDywcCZW2d/HUaKfm+0stme6E5UgPupt0uM=; b=cp+0YzDSMDwukm8xTRYMFtO+EE958bFxpgAePyDPBFiP2XqKZs29MGd3aicZ2Btl57TlIPx8g77iXxkPRoO+exYD7V32DouYGAF3wdKzTPdcXaC69pag9RMrzdXmte0oz/KhBXITPOKWqZAhuZ1Uwi8NP04B5K1wY8F+90qyYEw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772964182801301.958714294046; Sun, 8 Mar 2026 03:03:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzAxf-00054q-Up; Sun, 08 Mar 2026 06:02:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzAxe-00054Y-1u for qemu-devel@nongnu.org; Sun, 08 Mar 2026 06:02:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzAxb-0002lm-Gl for qemu-devel@nongnu.org; Sun, 08 Mar 2026 06:02:09 -0400 Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-j_2gj6J_PHeO6xG9t2LQdA-1; Sun, 08 Mar 2026 06:02:03 -0400 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c7391540c49so1871143a12.0 for ; Sun, 08 Mar 2026 03:02:02 -0700 (PDT) Received: from ani-lenovo.lan ([122.176.129.56]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-829a467239asm7035509b3a.26.2026.03.08.03.01.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 03:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772964124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=s5oOmyJ7GDywcCZW2d/HUaKfm+0stme6E5UgPupt0uM=; b=R5C4E8QEKDG9WUHbBW+1qIzi/wau0MiIJD/fx+nkeDWajj5w7R1STWewWEBSpaCxvUyjcW Qkg/BQt2T/XS6F7ry5vNAImYsVTgxu0ruZ16+3ImxkAI513kL2Eitt4kDjW/Cx+wj2JXIU 7rSn36fmzQYetNhZntlFAgfcLyV+ZVM= X-MC-Unique: j_2gj6J_PHeO6xG9t2LQdA-1 X-Mimecast-MFC-AGG-ID: j_2gj6J_PHeO6xG9t2LQdA_1772964122 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772964122; x=1773568922; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s5oOmyJ7GDywcCZW2d/HUaKfm+0stme6E5UgPupt0uM=; b=A5TSMJjfJR5k4eRRzs3JWI4DlQ9cfnQQFlqgMQLtWYInmWMkaFLQQrvrDObs7RhPxD EDeMPgYhthq0wPoFENRiA4MlhS+I1yDRG+ENQEVUrw+GRbHgr1kzv3twMRXK8AFlCEpQ pYMPZSSMc5TA+KX2vS3nipOWiTmp22KPTdZQOA9hLB6GTuyPR3oTYY6Ty7uIKDlIzs1s d6gHO1QOaPXhLCt4WOgGPdhUom04rr+umB0UqIX1WofkocIoQFOr9N0Cso8xOSyanUZS lpmukhfET3M0L66+TTm0i2cU4aINlzKOUsYkI9qs91cXqLFenz2QSG1sFcX1sekbnpII vdDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772964122; x=1773568922; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s5oOmyJ7GDywcCZW2d/HUaKfm+0stme6E5UgPupt0uM=; b=ogBW/Se1S9f03xku5Xir+fukJNcjXVm8RmlucIc3W8HUs6WQ9BJxkC2mF+LkQItETb 0Hs253txUlWEDTNGQTWL1IuRr3rLaXgFRHtBG4fLqMZPlmQMOZT8vrICMPVf2lfvxbPK lNAIev+ZyGTl0MZRHDN/ejuPtX+LPmcROYpFrBIU3bwje1fKOxspZQP14gBgSvKVoTMK xsbQnfLY2AS87J9A8JHz2FwKQHmq/00/rXvjelDOOLa4SZAvXWVyt3eLEZ2v6o5DBHK2 Ex/n71zLNHlNSbsu/D/7TWjntRri1Q2Q636MbOryooUXV8JkSg4yWj08xPgOncE+eiGL KzAg== X-Forwarded-Encrypted: i=1; AJvYcCXVxGK+N2cIpB4XO1dTzbBGFgsgCSgCNhyDmQ/9hXSa3z+kfxFvwn+BUPek3thHCK/b5ZtPTVI8I+Y3@nongnu.org X-Gm-Message-State: AOJu0Yx1wpXrEnPMPqCM7UUZIHpbqr2U4ZLa3CS0F0lPQuHtSDKpkIpx GAsf9rJ+X6wh5IocMdWqCo44rUUtCYpnu0Mfw3397OHuDqqOOR1bNA/8hRaklWnQgaxOH9vhY6s 2A8n2hp5AJxhXz6H/WlWOGWmRBMzqkg/3aIaqW5ESyVeDG6+xP8/+LHXz X-Gm-Gg: ATEYQzyaTjGPcudYSCc3mbXcb5eT6x0hJg3rcJTTWTY7UxJa6eChzOyX5fAqttFuIDs qie9PazQD3+DS4Uk0xiUwb5C68plQFXfMB4Zce9yHSo1jz5jUzNUWxq5TL0dGvuHpFGLwtGLx6m 8cGINOo35wv+j70naHKzIhYnlxI0ccoMkNzenmYCpxGFBuCb0DSuEltiy2lSkvOdyLNZVZRHGEZ 53YBXTE8oXOrtVZyE2puQ0ntdzlggGqHdno/hiquKvZrJ7Cii2F+QwT7ePsqSIaDMavAP62NoMc OY13r32ImYN1U5miQUZzM8pi07OJEk6CxFgIcHm6s5IjCl4G3o3gnOE8YWdIHRXk1y1eb7w8l0i WaewYmLgYuMthtSeDzL3cJA0GALLD9kKy4+H8VXuawYbh03e0x5NDM4kfyg== X-Received: by 2002:a05:6a00:4b53:b0:821:853f:b9c3 with SMTP id d2e1a72fcca58-829a30c203emr6973545b3a.58.1772964121865; Sun, 08 Mar 2026 03:02:01 -0700 (PDT) X-Received: by 2002:a05:6a00:4b53:b0:821:853f:b9c3 with SMTP id d2e1a72fcca58-829a30c203emr6973524b3a.58.1772964121453; Sun, 08 Mar 2026 03:02:01 -0700 (PDT) From: Ani Sinha To: Peter Xu , Fabiano Rosas Cc: Ani Sinha , Markus Armbruster , Prasad Pandit , qemu-devel@nongnu.org Subject: [PATCH] migration: assert that the same migration handler is not being added twice Date: Sun, 8 Mar 2026 15:31:48 +0530 Message-ID: <20260308100148.162503-1-anisinha@redhat.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=anisinha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772964185032154100 Content-Type: text/plain; charset="utf-8" Currently the code that adds a migration blocker does not check if the same blocker already exists. Assert that the migration handler being added has not been added already. CC: Markus Armbruster CC: Peter Xu CC: Prasad Pandit Signed-off-by: Ani Sinha Reviewed-by: Peter Xu --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index a5b0465ed3..840cf0dfe2 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1702,6 +1702,8 @@ static int add_blockers(Error **reasonp, unsigned mod= es, Error **errp) { for (MigMode mode =3D 0; mode < MIG_MODE__MAX; mode++) { if (modes & BIT(mode)) { + assert(g_slist_index(migration_blockers[mode], + *reasonp) =3D=3D -1); migration_blockers[mode] =3D g_slist_prepend(migration_blocker= s[mode], *reasonp); } --=20 2.52.0