From nobody Mon Apr 13 10:21:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913256; cv=none; d=zohomail.com; s=zohoarc; b=A+HTxVUwO5YEAy+nJlN+uQoRr09SiyqWaHWy/WuZF1kLcOiRN1uvrRfKKKQ8F6CAPGjxF3SH53Csuq0G9QBSushh958f2Oqw0kbgP5AIXjvNPjoOwPA1KCCuGlSP8xNJJcXFALa8IkKruSc3MFQYLUEawD90xrM8PR+odBdtXWY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913256; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C60/E/IVj9dnvYUqWaAM/Zqf1/21G4/fN1AXYPsrhnI=; b=aSTg6gKcD9z25PW4nzzfPF8l11KW53khLyWeGOW/RNDQrbLjJTvFD0x0rOgyVfVouoF+WlMwRUGcJQq9AcDptEMkDbt6wkjBDZHMJHkHa6c0o10R0FOWZ2pRNETcFgqyXqLeGuoMwjmV6lsphr/3s2SKw8QeNh1IA+nA5KJsrMc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913256723216.36073416396778; Sat, 7 Mar 2026 11:54:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxi0-00085Y-JA; Sat, 07 Mar 2026 14:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhy-000851-G3 for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:06 -0500 Received: from sea.source.kernel.org ([172.234.252.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhx-0008Um-0u for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:06 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B8297419DB; Sat, 7 Mar 2026 19:53:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70771C19423; Sat, 7 Mar 2026 19:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913183; bh=yQjfyq4uMUjaesM0EhyZ3X0IrXyyB6Sp6uAxR9zq4is=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nLe/FlHBJfO649QuXOXXPGqzRwOH3LxaqrP34Q2ci2NK28v7JNq6zDkPxrWw7o95K 6YKsJ+6K/HKTUBqKMkzomHrfUKUbk0jL7SMPnMcCzRakUl9ZSktUvyVI/ONGi4czKV 4YHxEpXJ7P65CxITYlNa9xF1SZPHxKej2kBBmwhVd2gVdEY8LnGGdaa+X/r9ffTEzN GAqvYDiMODU4NK7PI7rU+LYNon8WgqRe9fvzkLFZrR6r71Jdyv7vph6Vk/aMYgDW25 fmUlrrUszkJMfRyDYEAoqaCjmYCQ0Uhy8dyJ7mNgZEs8z7KW+Fsq4WG0/MihbNT5t1 ejbr38DcVufAA== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 06/12] linux-user: fix matching ioctl numbers in print_ioctl Date: Sat, 7 Mar 2026 20:52:37 +0100 Message-ID: <20260307195243.8813-7-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.234.252.31; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913259003154100 Content-Type: text/plain; charset="utf-8" From: Andreas Schwab target_cmd in struct IOCTLEntry is a signed int. Make sure the ioctl cmd argument in the syscall is converted to int when matching, so that it works correctly with an ioctl cmd that has bit 31 set. Signed-off-by: Andreas Schwab Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/strace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 02d610a7f8..2cbaf94c89 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -1021,12 +1021,12 @@ print_syscall_ret_ioctl(CPUArchState *cpu_env, cons= t struct syscallname *name, int target_size; =20 for (ie =3D ioctl_entries; ie->target_cmd !=3D 0; ie++) { - if (ie->target_cmd =3D=3D arg1) { + if (ie->target_cmd =3D=3D (int)arg1) { break; } } =20 - if (ie->target_cmd =3D=3D arg1 && + if (ie->target_cmd =3D=3D (int)arg1 && (ie->access =3D=3D IOC_R || ie->access =3D=3D IOC_RW)) { arg_type =3D ie->arg_type; qemu_log(" ("); @@ -4359,7 +4359,7 @@ print_ioctl(CPUArchState *cpu_env, const struct sysca= llname *name, int target_size; =20 for (ie =3D ioctl_entries; ie->target_cmd !=3D 0; ie++) { - if (ie->target_cmd =3D=3D arg1) { + if (ie->target_cmd =3D=3D (int)arg1) { break; } } --=20 2.53.0