From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913264; cv=none; d=zohomail.com; s=zohoarc; b=ShmRRDMtTtytJxFo59eJx0e9PzTe0eGdGaTORWDYKo4nuNdhmHRL0oKE/KL/hbSxlFHyXXdHzFj6hQumOFZQcWflGw9q877fatbOA1CPFNN9ce917Cx3LhVPxv18KP41SRphCKBuVFcQWg0fvy3fC+nyFRYYcgRRm2f3n3Ldwy0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913264; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Fb0TIOdaFmlzIsBPQlzDkn06cB4T3grJ7EiQgq3S9Js=; b=VFF38G/odVHhCnjOmKsi3wCn0eG3D55w10swnP0pMG3ODdZJBmzyeYxYm4nNGkYrVdtoLeXsvwChYVrFKE4cc2CpjUb4XibUjivW3amPiGWkcdhMWMjGb2b2FcN13tLe3fiABfxV+XbwmNRWtF28HORb3mHsixiePb4OrV/CRNY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913264218512.2866478423672; Sat, 7 Mar 2026 11:54:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxhm-00082I-OA; Sat, 07 Mar 2026 14:52:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhl-000821-7E for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:52:53 -0500 Received: from tor.source.kernel.org ([172.105.4.254]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhj-0008Tl-Pu for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:52:52 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id CB03B60053; Sat, 7 Mar 2026 19:52:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55A64C19422; Sat, 7 Mar 2026 19:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913170; bh=5T1LhH5J6f2Ao8dbBECeACv01ggKw++t/KA2Q4VUqbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ht4SaHEB3fJ77h+c54n7q15lkfDx3MNGHqDre2/Cg+mi+RCSkboDtpyWoCzuOe8OU iREowilfSC7a0L2GLbPfsWFYuPFfnsNacjcCPW41Mt9JRJDl/C4rpNDRV48wLTZ/4h 7xfL1xby7sqKn/HbOWqpevKhqN+yF9Tv7puPIyI7EdfEZ94E6HxxPHR/LRClux/iBV HPW1afZFqWBIGv+Q7BHDy8zqSrDWaLJg4tkjt+J1cMB54QoSlvMJO5EUcbJ6IEWH3q 2s+LRNlqrYvLimzmcxI5bqrPA4EqbjhOrIPa/qBwVdo4+h+ZR1li9pEqYbgJDPkHva repzGkrkeIrOA== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 01/12] hw/hppa: Avoid leaking a diva-gsp device Date: Sat, 7 Mar 2026 20:52:32 +0100 Message-ID: <20260307195243.8813-2-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.105.4.254; envelope-from=deller@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913266987158500 Content-Type: text/plain; charset="utf-8" From: Helge Deller Create a Diva-gsp unconditionally on all 64-bit PCI machines. The A400 usually comes with a Diva card. The C3700 has a built-in SUPERIO chip, which we haven't implemented yet, so running with an emulated Diva is the best we can do for now. Signed-off-by: Helge Deller Suggested-by: Peter Maydell Reviewed-by: Peter Maydell --- hw/hppa/machine.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index f55e84529f..50ace81528 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -380,18 +380,15 @@ static void machine_HP_common_init_tail(MachineState = *machine, PCIBus *pci_bus, =20 if (pci_bus && hppa_is_pa20(&cpu[0]->env)) { /* BMC board: HP Diva GSP PCI card */ - dev =3D qdev_new("diva-gsp"); - if (dev && !object_property_get_bool(OBJECT(dev), "disable", NULL)= ) { - pci_dev =3D pci_new_multifunction(PCI_DEVFN(2, 0), "diva-gsp"); - if (!lasi_dev) { - /* bind default keyboard/serial to Diva card */ - qdev_prop_set_chr(DEVICE(pci_dev), "chardev1", serial_hd(0= )); - qdev_prop_set_chr(DEVICE(pci_dev), "chardev2", serial_hd(1= )); - qdev_prop_set_chr(DEVICE(pci_dev), "chardev3", serial_hd(2= )); - qdev_prop_set_chr(DEVICE(pci_dev), "chardev4", serial_hd(3= )); - } - pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); + pci_dev =3D pci_new_multifunction(PCI_DEVFN(2, 0), "diva-gsp"); + if (!lasi_dev) { + /* bind default keyboard/serial to Diva card */ + qdev_prop_set_chr(DEVICE(pci_dev), "chardev1", serial_hd(0)); + qdev_prop_set_chr(DEVICE(pci_dev), "chardev2", serial_hd(1)); + qdev_prop_set_chr(DEVICE(pci_dev), "chardev3", serial_hd(2)); + qdev_prop_set_chr(DEVICE(pci_dev), "chardev4", serial_hd(3)); } + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); } =20 /* create USB OHCI controller for USB keyboard & mouse on Astro machin= es */ --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913221; cv=none; d=zohomail.com; s=zohoarc; b=DxETKOntxk1WMnZg9vveHV/QVOE7bmumN97fQetqS/+PDcn1YxkDMZW5vj9c5lkKNbC7VTnbUSBOVAs/ly2Fhffznd3iToeZwQNEd2Et81PXpyiNhR1xvioNxadGwT9kD70BVl6CEx79s0f35m/k64d3fXV0sy5tSasNhumJVuw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913221; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=k46VEq0C27L5eafGpLC96KYtE6aW1SyvskxLsnjorUk=; b=LffxMaMF6xYLDWxtJE2Bv165jkh6V4zHafv2DzEIMYX2LeUmcK5dv1DoeO/s0oOc3osVBhp796bZBPbRxqLx8xuD5bZl40KdBxpsvT8AhPPQfdGOp/ln46LgCVCXCA+RO4MWUHMe7RoL8E/kt/gdkJBz0JNnC204Abk/QEzsIXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177291322141543.5753695645152; Sat, 7 Mar 2026 11:53:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxhp-00082x-EI; Sat, 07 Mar 2026 14:52:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxho-00082a-6A for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:52:56 -0500 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhm-0008U0-Mf for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:52:55 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 40B5B43D7C; Sat, 7 Mar 2026 19:52:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE060C19423; Sat, 7 Mar 2026 19:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913173; bh=QIdUQ5ojIh6pUED378YIZDxyX5WSDR8KZ+KkV6/pMI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b8hNLXWXcm8LN48N+6JsdNpX7zcmG6+hnyT8GZHMbckIxPTx1r+2F9zHLW196aMp8 c8+ElyJEKwNcysqF5jHA12tf1jPvNpGdZTJqx4CPFH4WbPWyfM97CWBDQ8brMyjCbR sQRaPnVee8fGiw46fjxNpIJYtMduCeVIcqCsWW9zN5dmaV0hlBTYKqNYh9EZ63b9xk 28JuuK/7YWGNKX+0l8poFhpCilJw1/kI8sYbPobrZehiDS7hoRdXgqKA2TReUmRtEO e0LBJJe65Q6HJu+j0M4FRMOVwdM7s2oMNL328WVMLOCQ99fsInX00+c9Kn40LnHiTx O9y6PbGg2HLzg== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 02/12] hw/char: Drop disable property of Diva GSP card Date: Sat, 7 Mar 2026 20:52:33 +0100 Message-ID: <20260307195243.8813-3-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2600:3c0a:e001:78e:0:1991:8:25; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913223099158500 Content-Type: text/plain; charset="utf-8" From: Helge Deller The "disable" property is not used, so drop it. Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Helge Deller --- hw/char/diva-gsp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/char/diva-gsp.c b/hw/char/diva-gsp.c index 280d0413c6..2be5183216 100644 --- a/hw/char/diva-gsp.c +++ b/hw/char/diva-gsp.c @@ -51,7 +51,6 @@ typedef struct PCIDivaSerialState { SerialState state[PCI_SERIAL_MAX_PORTS]; uint32_t level[PCI_SERIAL_MAX_PORTS]; qemu_irq *irqs; - bool disable; } PCIDivaSerialState; =20 static void diva_pci_exit(PCIDevice *dev) @@ -159,20 +158,18 @@ static void diva_pci_realize(PCIDevice *dev, Error **= errp) =20 static const VMStateDescription vmstate_pci_diva =3D { .name =3D "pci-diva-serial", - .version_id =3D 1, - .minimum_version_id =3D 1, + .version_id =3D 2, + .minimum_version_id =3D 2, .fields =3D (const VMStateField[]) { VMSTATE_PCI_DEVICE(dev, PCIDivaSerialState), VMSTATE_STRUCT_ARRAY(state, PCIDivaSerialState, PCI_SERIAL_MAX_POR= TS, 0, vmstate_serial, SerialState), VMSTATE_UINT32_ARRAY(level, PCIDivaSerialState, PCI_SERIAL_MAX_POR= TS), - VMSTATE_BOOL(disable, PCIDivaSerialState), VMSTATE_END_OF_LIST() } }; =20 static const Property diva_serial_properties[] =3D { - DEFINE_PROP_BOOL("disable", PCIDivaSerialState, disable, false), DEFINE_PROP_CHR("chardev1", PCIDivaSerialState, state[0].chr), DEFINE_PROP_CHR("chardev2", PCIDivaSerialState, state[1].chr), DEFINE_PROP_CHR("chardev3", PCIDivaSerialState, state[2].chr), --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913221; cv=none; d=zohomail.com; s=zohoarc; b=I8yFPnmVg2yGYVSunJDaOqMkAp3qf6Z0L1IdUrSdNFcHjMo6krxeBhi2kT2IbdGYMuyr2ZhOAF0XHcZJi5xs+Wp44cGkaxzoGkqcc299RBknIxgmPau/DQdr8WK4KToJiTHIVFLGi6+mMpqr9m3pLHvE+9VAn+c+oR7nZ2PGfrY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913221; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uSUoduXt1McMZ+xp4HI8Tm+6BrIMPYdhMvyXUl5DEIg=; b=fzqLdK28hLSyUKkxdmzyVkVFzUhnDJgjgEFa+QAr5DaaeG8m3qJM4G+7+wyjsCB2NbLCUCzVT4jSNPq+KK/f0LhrcgCgNRiEr9kCZ8rCjtuTZq+WMfAHZ8f9L1JS7i/bUwZxdNcYgUCtWvlbJHn6UuQ0RSJOEyPqge8ZFf1m8zc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913221032120.73558641424347; Sat, 7 Mar 2026 11:53:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxhs-00083O-Bj; Sat, 07 Mar 2026 14:53:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhr-00083A-4p for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:52:59 -0500 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhp-0008U9-8b for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:52:58 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D735942AFC; Sat, 7 Mar 2026 19:52:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 921C3C19422; Sat, 7 Mar 2026 19:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913175; bh=0nM1s+NQvWZ8mFk4qsfcfN21HkyWkiji/p4/PrOht4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PYvsxZ1nbnLz3SYK6iAvVvDoKc/ccirJKRFdtiq/tHAtrpHD9LYQSly1VkMe4oBJI 5FFLxQZYBc5br0ge9WJOQ2shpGDHs11Wbq4W6K11+ZKRWMh5J8554VUcir7NS0TTcS sPA7KWEZ0SD/sv4YS8dyDWtBa72zoRD+7n8Kt6a5l/fyvNAyk4V0hvc8rMVaPZvgkf dw5hbBCyKcBZ4rxDY1+pn4wLzvIUFw3zgVF4cji6MbEvQ1Ry3LEvOdFFDaC4lspS43 0QoyeGqBRhv2kDzqBGxH24TdVQe8ROHy0bPduPa6crhxaYDG76c6Sp1nBnmyRJmaTw enfkqy0bw4I+A== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 03/12] linux-user/strace: fix printing of file offsets Date: Sat, 7 Mar 2026 20:52:34 +0100 Message-ID: <20260307195243.8813-4-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2600:3c0a:e001:78e:0:1991:8:25; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913224819154100 From: Jean-Christian C=C3=8ERSTEA Previously, 64-bit file offsets (loff_t) were printed using `print_raw_para= m()` function, which led to silent truncation of the upper part. This commit fix= es this issue by adding two helper functions: 1. print_file_offset32(): prints 32-bit file offsets (off_t) 2. print_file_offset64(): prints 64-bit file offsets (loff_t) Changelog v2: 1. Make `print_file_offset32()` static. 2. Use `last` parameter in `print_file_offset32()`. 3. Rename `low` and `high` parameters of `print_file_offset64()` to `word0`, `word1` respectively 4. Convert `last` to bool for `print_file_offset[32,64]()` 5. Use `PRId64` instead of `PRIu64` for `print_file_offset64()` 6. Fix `print__llseek()` Signed-off-by: Jean-Christian C=C3=8ERSTEA Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/strace.c | 43 +++++++++++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index ca67cfd09d..d253b522bf 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -85,6 +85,10 @@ UNUSED static void print_enums(const struct enums *, abi= _long, int); UNUSED static void print_at_dirfd(abi_long, int); UNUSED static void print_file_mode(abi_long, int); UNUSED static void print_open_flags(abi_long, int); +UNUSED static void print_file_offset32(abi_long offset, bool last); +UNUSED static void print_file_offset64(abi_long word0, + abi_long word1, + bool last); UNUSED static void print_syscall_prologue(const struct syscallname *); UNUSED static void print_syscall_epilogue(const struct syscallname *); UNUSED static void print_string(abi_long, int); @@ -1664,6 +1668,20 @@ print_open_flags(abi_long flags, int last) print_flags(open_flags, flags, last); } =20 +/* Prints 32-bit file offset (off_t) */ +static void +print_file_offset32(abi_long offset, bool last) +{ + print_raw_param(TARGET_ABI_FMT_ld, offset, last); +} + +/* Prints 64-bit file offset (loff_t) */ +static void +print_file_offset64(abi_long word0, abi_long word1, bool last) +{ + print_raw_param64("%" PRId64, target_offset64(word0, word1), last); +} + static void print_syscall_prologue(const struct syscallname *sc) { @@ -2256,11 +2274,13 @@ print_fallocate(CPUArchState *cpu_env, const struct= syscallname *name, print_raw_param("%d", arg0, 0); print_flags(falloc_flags, arg1, 0); #if TARGET_ABI_BITS =3D=3D 32 - print_raw_param("%" PRIu64, target_offset64(arg2, arg3), 0); - print_raw_param("%" PRIu64, target_offset64(arg4, arg5), 1); + /* On 32-bit targets, two registers are used for `loff_t` */ + print_file_offset64(arg2, arg3, false); + print_file_offset64(arg4, arg5, true); #else - print_raw_param(TARGET_ABI_FMT_ld, arg2, 0); - print_raw_param(TARGET_ABI_FMT_ld, arg3, 1); + /* On 64-bit targets, one register is used for `loff_t` */ + print_file_offset64(arg2, 0, false); + print_file_offset64(arg3, 0, true); #endif print_syscall_epilogue(name); } @@ -2666,8 +2686,7 @@ print__llseek(CPUArchState *cpu_env, const struct sys= callname *name, const char *whence =3D "UNKNOWN"; print_syscall_prologue(name); print_raw_param("%d", arg0, 0); - print_raw_param("%ld", arg1, 0); - print_raw_param("%ld", arg2, 0); + print_file_offset64(arg1, arg2, false); print_pointer(arg3, 0); switch(arg4) { case SEEK_SET: whence =3D "SEEK_SET"; break; @@ -2688,7 +2707,7 @@ print_lseek(CPUArchState *cpu_env, const struct sysca= llname *name, { print_syscall_prologue(name); print_raw_param("%d", arg0, 0); - print_raw_param(TARGET_ABI_FMT_ld, arg1, 0); + print_file_offset32(arg1, false); switch (arg2) { case SEEK_SET: qemu_log("SEEK_SET"); break; @@ -2719,7 +2738,7 @@ print_truncate(CPUArchState *cpu_env, const struct sy= scallname *name, { print_syscall_prologue(name); print_string(arg0, 0); - print_raw_param(TARGET_ABI_FMT_ld, arg1, 1); + print_file_offset32(arg1, true); print_syscall_epilogue(name); } #endif @@ -2736,7 +2755,7 @@ print_truncate64(CPUArchState *cpu_env, const struct = syscallname *name, arg1 =3D arg2; arg2 =3D arg3; } - print_raw_param("%" PRIu64, target_offset64(arg1, arg2), 1); + print_file_offset64(arg1, arg2, true); print_syscall_epilogue(name); } #endif @@ -2753,7 +2772,7 @@ print_ftruncate64(CPUArchState *cpu_env, const struct= syscallname *name, arg1 =3D arg2; arg2 =3D arg3; } - print_raw_param("%" PRIu64, target_offset64(arg1, arg2), 1); + print_file_offset64(arg1, arg2, true); print_syscall_epilogue(name); } #endif @@ -3308,7 +3327,7 @@ print_stat(CPUArchState *cpu_env, const struct syscal= lname *name, print_syscall_epilogue(name); } #define print_lstat print_stat -#define print_stat64 print_stat +#define print_stat64 print_stat #define print_lstat64 print_stat #endif =20 @@ -4302,7 +4321,7 @@ print_pread64(CPUArchState *cpu_env, const struct sys= callname *name, print_raw_param("%d", arg0, 0); print_pointer(arg1, 0); print_raw_param("%d", arg2, 0); - print_raw_param("%" PRIu64, target_offset64(arg3, arg4), 1); + print_file_offset64(arg3, arg4, true); print_syscall_epilogue(name); } #endif --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913270; cv=none; d=zohomail.com; s=zohoarc; b=aMbydTfrn3Bor0HGsxRDNXn4G+IkfakmksJQ+vSwD0pHP9LCGty/m+RLUMu0eNmZrm4u6/n383IMEPtyvhnA8c6KJaESJNm9OhUe287epiHeo6jXdxkZe5Xjqglw+Yq0hmxyyxbJ3URl72sYWiOCjzKKN48Jm+Zy1oxoOrUB6gA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913270; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OiWqY4jx9zgepgcKQ3oVVPBV7ndNOo28jF8CZifChgM=; b=fpumu7zwjvWz+Ov9JwXDEzcBpZFGTaw8bL8V0wxZ5aRIRqkg5ConpD4GbgKS42O1rrIJ5F/EYg8rjJl4orrxMRqZuqvaQeXTjeKrCe8cFDQccN4eVEJDbgdm+3+Tj+at0KQPKyO31SVh8hJ2ygUOxtEBOig9psNLloUCDMPaXCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913270143451.50162301335115; Sat, 7 Mar 2026 11:54:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxhu-00083x-Qb; Sat, 07 Mar 2026 14:53:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxht-00083Y-6t for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:01 -0500 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhr-0008UI-OA for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:00 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A8B15600AD; Sat, 7 Mar 2026 19:52:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3556AC19422; Sat, 7 Mar 2026 19:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913178; bh=Q/dSbHczdz4sFIvaB36AMEBCEZDprQsZ7Vlhqrv2Nk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P52kXPp42gDPLo25CZoXBEkosb3nidJjgF4SbmvrBABavaLE++qyu435ViYtXXM/b onn7bRbvaqgueF27Bmu88rmzEpD3oetEANpp37v6o4xMcffR05WHJ+LYF3sITEjiKQ sqjxJ1u0Uxysuw6DKo+7sgo1/AQeye42WNRyFamjZyVOsmsLfryamJNNXt0ELqg0mV 3l5p6e5QJ9lKhmS0M45dNWGMvt6QU4Q/zdF1PIOmdQN7Dicct4X1cjVRoXNEqGNjSf 0TFAIqprm16fxBD8soL2x44gmnSrL3mi4ISnS4wDJqX9Z5A/asnE5AHTldrjMwSUUR gYT7V0b1U64vw== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 04/12] linux-user: properly check flags in openat2 Date: Sat, 7 Mar 2026 20:52:35 +0100 Message-ID: <20260307195243.8813-5-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2600:3c04:e001:324:0:1991:8:25; envelope-from=deller@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913271069154100 Content-Type: text/plain; charset="utf-8" From: Andreas Schwab target_to_host_bitmask truncates the bitmask to int. Check that the upper half of the flags do not have any bits set. Signed-off-by: Andreas Schwab Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/syscall.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 99e1ed97d9..064bc604c9 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8831,6 +8831,10 @@ static int do_openat2(CPUArchState *cpu_env, abi_lon= g dirfd, } return ret; } + if (tswap64(how.flags) >> 32) { + return -TARGET_EINVAL; + } + pathname =3D lock_user_string(guest_pathname); if (!pathname) { return -TARGET_EFAULT; --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913227; cv=none; d=zohomail.com; s=zohoarc; b=bFxembbbSx7iQdz/kuxAI5faUi7A3+7/xHy+FcIWX4cb6/cHTlrDUOqgDf5eAOhlYzUMmCgv+XW2QVBTT6eHY2Idc2prMhdrBdmKAKZ/7Y7uLsP9WVTAfyhIU19Auicw29YgLnOcuZQYMCCpmzhpK/MMsyJ0Qafj+NqZpQqpJ8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913227; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pOHD/F7f5VC0lspgxbEftxX6aKc1DYx6XC+H05Brb0s=; b=gPtAVMTGUnh6vpvlHpIT4wjLVzm5NnUjTwH/fNnts0JvuM4rrXjtE0SH5VCUtF4+qBGX89zxqpSUCEW9SqiBTbrfTnsp36yPgjzQI2Q+fllBr/vueK0u47rU11GSYHoP9yBfe5zRMsllgvyfBLQiiiNZuM2i10XlVXRWKXbG7rc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913227365965.6188696971457; Sat, 7 Mar 2026 11:53:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxhw-00084g-4v; Sat, 07 Mar 2026 14:53:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhv-000841-AH for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:03 -0500 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxht-0008UY-SR for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:03 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4F55D600AE; Sat, 7 Mar 2026 19:53:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCE01C19422; Sat, 7 Mar 2026 19:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913181; bh=vm/aA9SwjzkHcfVSNxqZDO1EuMwbYIzCIFfKiGC9xog=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tVzaRF69REcr3kFJ3j2yYnKYW/6RbrBZ9qy4PENdcPbG7mvyIrhRTabMN808TvVKi Hh5KCPYoQMybwFP32oS0Gx2PArWM829VHiMK7eTm5imxOPR3UCkYmWWb3RluZuEY5o Zx2SAmxyR3rXrx8+0cTXVKtqjgC8QtzpQw9+jhN+fb20iZZORRlORGbKKOW4fhLl9o Dd5QcSSjoVzE6u9cqK+CP8iS4qA7UD0EkCSgXIqgq3r4obnmcFhXijEaY+9ItQerxV ZCD9z4K4YhPPbZZ1OuyAxj5Cp32yB/ply80VG7R6hItAVMRgLn+2kXJ5KOSWNzyJqw WDR403+JmJ6cQ== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 05/12] linux-user: Check if RESOLVE_CACHED flag is defined before using it Date: Sat, 7 Mar 2026 20:52:36 +0100 Message-ID: <20260307195243.8813-6-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2600:3c04:e001:324:0:1991:8:25; envelope-from=deller@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913230769154101 Content-Type: text/plain; charset="utf-8" From: Frank Chang openat2.h was introduced in Linux kernel 5.6. However, RESOLVE_CACHED flag was only added in kernel 5.12 and later. Therefore, we need to check if RESOLVE_CACHED flag is defined before using it. Signed-off-by: Frank Chang Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/strace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/strace.c b/linux-user/strace.c index d253b522bf..02d610a7f8 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -1129,7 +1129,9 @@ UNUSED static const struct flags openat2_resolve_flag= s[] =3D { FLAG_GENERIC(RESOLVE_NO_SYMLINKS), FLAG_GENERIC(RESOLVE_BENEATH), FLAG_GENERIC(RESOLVE_IN_ROOT), +#ifdef RESOLVE_CACHED FLAG_GENERIC(RESOLVE_CACHED), +#endif #endif FLAG_END, }; --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913256; cv=none; d=zohomail.com; s=zohoarc; b=A+HTxVUwO5YEAy+nJlN+uQoRr09SiyqWaHWy/WuZF1kLcOiRN1uvrRfKKKQ8F6CAPGjxF3SH53Csuq0G9QBSushh958f2Oqw0kbgP5AIXjvNPjoOwPA1KCCuGlSP8xNJJcXFALa8IkKruSc3MFQYLUEawD90xrM8PR+odBdtXWY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913256; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C60/E/IVj9dnvYUqWaAM/Zqf1/21G4/fN1AXYPsrhnI=; b=aSTg6gKcD9z25PW4nzzfPF8l11KW53khLyWeGOW/RNDQrbLjJTvFD0x0rOgyVfVouoF+WlMwRUGcJQq9AcDptEMkDbt6wkjBDZHMJHkHa6c0o10R0FOWZ2pRNETcFgqyXqLeGuoMwjmV6lsphr/3s2SKw8QeNh1IA+nA5KJsrMc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913256723216.36073416396778; Sat, 7 Mar 2026 11:54:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxi0-00085Y-JA; Sat, 07 Mar 2026 14:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhy-000851-G3 for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:06 -0500 Received: from sea.source.kernel.org ([172.234.252.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhx-0008Um-0u for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:06 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B8297419DB; Sat, 7 Mar 2026 19:53:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70771C19423; Sat, 7 Mar 2026 19:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913183; bh=yQjfyq4uMUjaesM0EhyZ3X0IrXyyB6Sp6uAxR9zq4is=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nLe/FlHBJfO649QuXOXXPGqzRwOH3LxaqrP34Q2ci2NK28v7JNq6zDkPxrWw7o95K 6YKsJ+6K/HKTUBqKMkzomHrfUKUbk0jL7SMPnMcCzRakUl9ZSktUvyVI/ONGi4czKV 4YHxEpXJ7P65CxITYlNa9xF1SZPHxKej2kBBmwhVd2gVdEY8LnGGdaa+X/r9ffTEzN GAqvYDiMODU4NK7PI7rU+LYNon8WgqRe9fvzkLFZrR6r71Jdyv7vph6Vk/aMYgDW25 fmUlrrUszkJMfRyDYEAoqaCjmYCQ0Uhy8dyJ7mNgZEs8z7KW+Fsq4WG0/MihbNT5t1 ejbr38DcVufAA== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 06/12] linux-user: fix matching ioctl numbers in print_ioctl Date: Sat, 7 Mar 2026 20:52:37 +0100 Message-ID: <20260307195243.8813-7-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.234.252.31; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913259003154100 Content-Type: text/plain; charset="utf-8" From: Andreas Schwab target_cmd in struct IOCTLEntry is a signed int. Make sure the ioctl cmd argument in the syscall is converted to int when matching, so that it works correctly with an ioctl cmd that has bit 31 set. Signed-off-by: Andreas Schwab Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/strace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 02d610a7f8..2cbaf94c89 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -1021,12 +1021,12 @@ print_syscall_ret_ioctl(CPUArchState *cpu_env, cons= t struct syscallname *name, int target_size; =20 for (ie =3D ioctl_entries; ie->target_cmd !=3D 0; ie++) { - if (ie->target_cmd =3D=3D arg1) { + if (ie->target_cmd =3D=3D (int)arg1) { break; } } =20 - if (ie->target_cmd =3D=3D arg1 && + if (ie->target_cmd =3D=3D (int)arg1 && (ie->access =3D=3D IOC_R || ie->access =3D=3D IOC_RW)) { arg_type =3D ie->arg_type; qemu_log(" ("); @@ -4359,7 +4359,7 @@ print_ioctl(CPUArchState *cpu_env, const struct sysca= llname *name, int target_size; =20 for (ie =3D ioctl_entries; ie->target_cmd !=3D 0; ie++) { - if (ie->target_cmd =3D=3D arg1) { + if (ie->target_cmd =3D=3D (int)arg1) { break; } } --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913265; cv=none; d=zohomail.com; s=zohoarc; b=kHFt/7ZVjI2OKKx6TOLrDW6WMS8HG5HC42JuArEapIua/ZFWLeUnFROYDqhBysrudz3/dKUgxWDiTVdQ/mjGK4isdhb8oGEkFHAE5vODridHymXy2RagnN6Oyt8E2tKGUNSTzkbL7rmSV5a9QfNVXlso+HmKr7xF1/89dlbDm8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913265; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0qxjUKHbGw3PUFw8IovST12B6LLBxwGdRlZxle8olbQ=; b=PBFKs3ox042tL8g1VwSeiQ1NPkhl3j3+IryDT0t5sPBsKSe+k2dwXlQ281RNW5X05J07WlhltH3fjVisWBaKb5qRc5cUD95MgjwQIZfLSPc5h90g0qdMfJnYya9Ir30Fvh2vFUAqsx/uKpFebB+skngiYTl15s2LMfd1Fvmu/Gk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913265555735.1413132076667; Sat, 7 Mar 2026 11:54:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxi1-00085h-VT; Sat, 07 Mar 2026 14:53:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxi0-00085Z-MD for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:08 -0500 Received: from tor.source.kernel.org ([172.105.4.254]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxhz-0008Uw-81 for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:08 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 88D0B600B0; Sat, 7 Mar 2026 19:53:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 139D6C19423; Sat, 7 Mar 2026 19:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913186; bh=lUwAO9km4/S+zD0o1NtjbvrV7Uoam/HK5Wb+d30GVks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kgAauUvUrYW4MARgBrOrN6uHfpL0HlyWskVlYHRqQ/0qN/TR2YXTV4hnbRfDC+x7i gt7WdDjAQ1pySM26+lJwyo53WhS6zMBGPD7vLzkssQvJs9pTF+Bsz7ZXprILr/qfUp ogvoeRWwB25NnjDCZkDRZ1jv1OqKhgnp7geO1i53faLePif0X/RU8tMrh65u2oNc4N vk68VuLv4YbuDr8IxRf7VLCG7bZYDgEwsoChAPnlSWWz4zESs5MracPL40xmiZbsY4 x2Q6DjeADWj2lRMceiiWgYmW69d/faBlkt/M9pRIH+1Sux0ScnIJNusVkh8TH7o8bw j3IMTLepDtPFg== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 07/12] linux-user: fix TIOCGSID ioctl Date: Sat, 7 Mar 2026 20:52:38 +0100 Message-ID: <20260307195243.8813-8-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.105.4.254; envelope-from=deller@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913266998154100 Content-Type: text/plain; charset="utf-8" From: Andreas Schwab TIOCGSID is IOC_R, not IOC_W. Signed-off-by: Andreas Schwab Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/ioctls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index 6ecfe6306e..5b7d00e92f 100644 --- a/linux-user/ioctls.h +++ b/linux-user/ioctls.h @@ -26,7 +26,7 @@ IOCTL(TIOCSCTTY, 0, TYPE_INT) IOCTL(TIOCGPGRP, IOC_R, MK_PTR(TYPE_INT)) IOCTL(TIOCSPGRP, IOC_W, MK_PTR(TYPE_INT)) - IOCTL(TIOCGSID, IOC_W, MK_PTR(TYPE_INT)) + IOCTL(TIOCGSID, IOC_R, MK_PTR(TYPE_INT)) IOCTL(TIOCOUTQ, IOC_R, MK_PTR(TYPE_INT)) IOCTL(TIOCSTI, IOC_W, MK_PTR(TYPE_INT)) IOCTL(TIOCMGET, IOC_R, MK_PTR(TYPE_INT)) --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913274; cv=none; d=zohomail.com; s=zohoarc; b=EA1UcENBsBHy1slBbHxTwXxvmVHuYCUlVPRC8mT6JFDDtzZ5KzEaGo+BILmmu4qGHP05Gsw93BCCHmUhwem6oeg9uBUVZiMQFf1da8ygtEsImX5IAUMuB5Fy+5UFfS6HtKEVXxeq0ciTIKCR1DAn+paFA1sC5nhc6Ib1sr4fsyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913274; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SEUWDP+j9Tz0R+9Ke8orT8ktTOaSzEPXuiMbKnfZjYo=; b=ESBY+bzaAtRXJmHcLUwENt1yTwrZWrFvB2wmAqeMSMIIoxtf/gbkirndHe0Wk1egPLEL2DOR2QRi3Ax8Q09yR34xSGFfm6Q9+W+P1a5PeZR+DDy0vD1/RT6t/4xCst90dwxgY0ecjC6RGnQ1d7pixz6xBcWXFJneZKobGTNI/NE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913274291337.5213405398375; Sat, 7 Mar 2026 11:54:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxi4-000867-8g; Sat, 07 Mar 2026 14:53:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxi3-00085y-8G for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:11 -0500 Received: from tor.source.kernel.org ([172.105.4.254]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxi1-0008VB-NB for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:11 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 2C0F2600C4; Sat, 7 Mar 2026 19:53:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB90FC19422; Sat, 7 Mar 2026 19:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913188; bh=cXfFHAsd3SNFbK+y4uunPJeG053eQtIxwzALDggDNXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=liGZLtnRZEuKC2w+YT1Lnl7JsquTIWV62aM6uranG0EVgkwqJszIAGAlSAtrz7sur rsjxQBEcurgxwNwStx+kbz0aS5DogQ8f4EGWDMeEqSFYMMzhueoslfJrdRlz5KSMnS b3OkE8WmJmXV8x0PKK3dIFSrRmyJq0YYQkvivBkkp6IAY+iAFHu1Vp0NSLwP2oHoIM PgvTCPpsmGddzXS5gJFa5/7RsxpxoGdUvlCE8eOYyaBDbJkm4dir8/2jg3CNIFUCgJ 7kBGqrD9uy8c2MN78xh2oadU6bLgrzjKACSFvTtWGsNZwKubIFP9M4GITjvlRM91rD CgQeNcBiBGw/w== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 08/12] linux-user: Deal with mmap where start > reserved_va Date: Sat, 7 Mar 2026 20:52:39 +0100 Message-ID: <20260307195243.8813-9-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.105.4.254; envelope-from=deller@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913277152154100 Content-Type: text/plain; charset="utf-8" From: Bingwu Zhang Fixes: 4c13048e02d9 ("linux-user: Use page_find_range_empty for mmap_find_v= ma_reserved") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3310 Signed-off-by: Bingwu Zhang Reviewed-by: Helge Deller Signed-off-by: Helge Deller --- linux-user/mmap.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 07175e11d5..76978a56a8 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -423,12 +423,15 @@ abi_ulong mmap_next_start; static abi_ulong mmap_find_vma_reserved(abi_ulong start, abi_ulong size, abi_ulong align) { - target_ulong ret; + target_ulong ret =3D -1; =20 - ret =3D page_find_range_empty(start, reserved_va, size, align); + if (start <=3D reserved_va) { + ret =3D page_find_range_empty(start, reserved_va, size, align); + } if (ret =3D=3D -1 && start > mmap_min_addr) { /* Restart at the beginning of the address space. */ - ret =3D page_find_range_empty(mmap_min_addr, start - 1, size, alig= n); + ret =3D page_find_range_empty(mmap_min_addr, MIN(start - 1, reserv= ed_va), + size, align); } =20 return ret; --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913221; cv=none; d=zohomail.com; s=zohoarc; b=eDOvTtfF9Y9B3ysD2g3SwlXkx2W1uzJqz50zV59LUQ8HdlEBiREtRv8Rp4n+ljGP7DPpO/MLbsf1kX4ns+FUOxz2mbOmB1WDg0eTszbMpafugrRhD3FBGTQSpZi/NxcslKd5EEwlD9rNhIW03ZJQfJy1Z1zhAATNbM6+LzLbsXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913221; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lZkHo09QG/R+ynV6EnvVAVJAIGJKyd2kmZEk8HBv4BE=; b=ZhMGVQc33Fe0UYw7CcjySaX/swU/mYazYLo8LtrrRXTQ9JSmqfsW+zbvfKOg+BT0b7IX7NBwUay4nOjaJ/HWNyejoLSx1Db8kh1E0c5f4uAXz7CN1LZcC0J/YgVwOaCJLSX1PeKZ6oZADsd3afDZcfvKmkma6Mg/xd6NjDuibEA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913221748416.95078765682285; Sat, 7 Mar 2026 11:53:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxi7-00087V-SX; Sat, 07 Mar 2026 14:53:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxi6-00086Y-7T for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:14 -0500 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxi4-0008VM-FV for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:13 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9515E4448E; Sat, 7 Mar 2026 19:53:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F9BDC19422; Sat, 7 Mar 2026 19:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913191; bh=OOKfroUsa/NmmKFDrQXJY1cwDi1GkvGCyavkONtRuAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nZ5QELcoMuG41M0Ort6CBbgWBlrPLDffM800Pa/YGNHxMqHuaiF6S1uvEq7kfoAII 4HpywoSmkdPuBh1Qna0XgF96VrlqLyhKjlQwGy30+WidGvYBg9wGi+5mZ39uqkHAwd 7qhdF28Ml9WH8Ra3CeXA9b00Fmy0I6FFuAu+AcwMQ2xolyyJjT8Rs7TBOWwQcxLmuX XrPcVEUGQXRNSkQvxQOe5o8Zt46ixQmsgNLKO/bYQHWuNOWvAzl5M7EnP5+52ZNIY9 x8jPazCyDgesdjRmSLPGslt3DrtzvlTHQh6B+gE9BMtKnt8Cc0tEHbq2u+uj4XYhzM jyLG1zyBmdFzA== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 09/12] bsd-user: Deal with mmap where start > reserved_va Date: Sat, 7 Mar 2026 20:52:40 +0100 Message-ID: <20260307195243.8813-10-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2600:3c0a:e001:78e:0:1991:8:25; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913223201158500 Content-Type: text/plain; charset="utf-8" From: Bingwu Zhang Fixes: f12294b5bd21 ("bsd-user: Use page_find_range_empty for mmap_find_vma= _reserved") Signed-off-by: Bingwu Zhang Reviewed-by: Helge Deller Reviewed-by: Warner Losh Signed-off-by: Helge Deller --- bsd-user/mmap.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c index 24ba1728eb..fe77eceb48 100644 --- a/bsd-user/mmap.c +++ b/bsd-user/mmap.c @@ -258,12 +258,14 @@ abi_ulong mmap_next_start =3D TASK_UNMAPPED_BASE; static abi_ulong mmap_find_vma_reserved(abi_ulong start, abi_ulong size, abi_ulong alignment) { - abi_ulong ret; + abi_ulong ret =3D -1; =20 - ret =3D page_find_range_empty(start, reserved_va, size, alignment); + if (start <=3D reserved_va) { + ret =3D page_find_range_empty(start, reserved_va, size, alignment); + } if (ret =3D=3D -1 && start > TARGET_PAGE_SIZE) { /* Restart at the beginning of the address space. */ - ret =3D page_find_range_empty(TARGET_PAGE_SIZE, start - 1, + ret =3D page_find_range_empty(TARGET_PAGE_SIZE, MIN(start - 1, res= erved_va), size, alignment); } =20 --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913227; cv=none; d=zohomail.com; s=zohoarc; b=Xlv4DLjpFv+WZnl4KJaMIvGFoZwF3qUEWJXqvtohOgi1C3Ds5d4uYiDQNXEMjQD2eoRb+5X2wKVsPZY3QU9g9hlFSpjhRFGS0w+6zWF/44PJVjCAzvNAdDIW+fEsaO1/FLcKScd3S34fvqC851vDw/yNggGj2qSbwHnfHY1IGDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913227; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YYO/v39xtS79zc8WhYQQKADBJqbyPNe6NOpE3+YREPs=; b=XvVWPeG1WoqrL/W7UJwAIb0kcDeDTgvQ2a+SkkmzNjN+wCS5VBMBm+mVPTiqz6HCt8v2CEvZygXvHSI7j1z9izPL/3QzG1sUgTjig+HEb/g4PKbyS+9kcI1J+fezyfYTswwsbWwIO1U+od0drCdhmWvycKnAIyNLw5Ktb1eUZcA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913227423529.0605390308413; Sat, 7 Mar 2026 11:53:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxi9-00087p-S0; Sat, 07 Mar 2026 14:53:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxi8-00087Z-JI for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:16 -0500 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxi7-0008VW-23 for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:16 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3A71F43515; Sat, 7 Mar 2026 19:53:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E66CEC19422; Sat, 7 Mar 2026 19:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913194; bh=x2p9sfsUBTUAYtkqoTf6MRparRAy9QhO3P2K4BkAkCQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T12hHsbfvCwnQbixu8gSulfU/29Ws6hUs/w6m7zhX+971RrvIUefIhJagc2C8qTjU x73gf/1NslIzl5TABZBDsdqvLjsUp9yksXCQWx3L8zpw5O5Do88sqpYqMZWpS/fomP 2GbASiBJHrEvksq9mIuF+qFbGWzTBB7ulCjIAPN9Z7m3FeHi56d+crxQUCwNAr3TW9 cCaQTwxVdL1TRyD8cnHaFUAIzTo2bcZm3CO/8dae+NhKoKasftX1pQ96dHPK/pnQEU gNUlypJ9FGzz68ttEZMT+U1mPeZJYxGn7uAClo298zbulLNGCf6o0RjO4uNu869PZ7 jir8gw9+LNlFw== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 10/12] tests/tcg/multiarch/test-mmap: Print more details Date: Sat, 7 Mar 2026 20:52:41 +0100 Message-ID: <20260307195243.8813-11-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2600:3c0a:e001:78e:0:1991:8:25; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913230801154100 Content-Type: text/plain; charset="utf-8" From: Bingwu Zhang Useful for debugging Signed-off-by: Bingwu Zhang Signed-off-by: Helge Deller --- tests/tcg/multiarch/test-mmap.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/tcg/multiarch/test-mmap.c b/tests/tcg/multiarch/test-mma= p.c index e297f4b1e9..88f7a04101 100644 --- a/tests/tcg/multiarch/test-mmap.c +++ b/tests/tcg/multiarch/test-mmap.c @@ -442,19 +442,19 @@ void check_invalid_mmaps(void) =20 /* Attempt to map a zero length page. */ addr =3D mmap(NULL, 0, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); - fprintf(stdout, "%s addr=3D%p", __func__, (void *)addr); + fprintf(stdout, "%s addr=3D%p errno=3D%d\n", __func__, (void *)addr, e= rrno); fail_unless(addr =3D=3D MAP_FAILED); fail_unless(errno =3D=3D EINVAL); =20 /* Attempt to map a over length page. */ addr =3D mmap(NULL, -4, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); - fprintf(stdout, "%s addr=3D%p", __func__, (void *)addr); + fprintf(stdout, "%s addr=3D%p errno=3D%d\n", __func__, (void *)addr, e= rrno); fail_unless(addr =3D=3D MAP_FAILED); fail_unless(errno =3D=3D ENOMEM); =20 /* Attempt to remap a region which exceeds the bounds of memory. */ addr =3D mremap((void *)((uintptr_t)pagesize * 10), SIZE_MAX & ~(size_= t)pagemask, pagesize, 0); - fprintf(stdout, "%s mremap addr=3D%p", __func__, (void *)addr); + fprintf(stdout, "%s mremap addr=3D%p errno=3D%d\n", __func__, (void *)= addr, errno); fail_unless(addr =3D=3D MAP_FAILED); fail_unless(errno =3D=3D EFAULT); =20 @@ -465,8 +465,11 @@ void check_shrink_mmaps(void) { unsigned char *a, *b, *c; a =3D mmap(NULL, pagesize * 2, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS,= -1, 0); + fprintf(stdout, "%s addr=3D%p errno=3D%d\n", __func__, (void *)a, errn= o); b =3D mmap(NULL, pagesize * 2, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS,= -1, 0); + fprintf(stdout, "%s addr=3D%p errno=3D%d\n", __func__, (void *)b, errn= o); c =3D mmap(NULL, pagesize * 2, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS,= -1, 0); + fprintf(stdout, "%s addr=3D%p errno=3D%d\n", __func__, (void *)c, errn= o); =20 fail_unless(a !=3D MAP_FAILED); fail_unless(b !=3D MAP_FAILED); @@ -479,6 +482,7 @@ void check_shrink_mmaps(void) =20 /* Shrink the middle mapping in-place; the others should be unaffected= */ b =3D mremap(b, pagesize * 2, pagesize, 0); + fprintf(stdout, "%s mremap addr=3D%p errno=3D%d\n", __func__, (void *)= b, errno); fail_unless(b !=3D MAP_FAILED); =20 /* Ensure we can still access all valid mappings */ @@ -489,6 +493,8 @@ void check_shrink_mmaps(void) munmap(a, 2 * pagesize); munmap(b, pagesize); munmap(c, 2 * pagesize); + + fprintf(stdout, " passed\n"); } =20 int main(int argc, char **argv) --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913260; cv=none; d=zohomail.com; s=zohoarc; b=Wsa3PDkq7qWoe2714YYykGMRh1G/ZbggCM6xPBMJY/Vcj9UwHReAyliEfQZLyneyJSgviO+u4n0YGxrkBLXf6AshB2+mgwZGclr7nHYm0/dfjw3zwigI+lIw0n6eAlYGdLx/0sIrR/zyxDDng9agNjNLXeK7AvzzNdQ4Jomr4X0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913260; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UQ8oxzqfSkrIuJfoVQVH5xQ2TSlFySjuO0h6N4mKyuA=; b=BrDkIoKLib7lZkvSdHc008irkDFLrLUOFNwEe27+DWGZ3PyIa9OBDwyOu3+wBRZRraLTCwuVp7BOijIm9Xv1/H7awTRgQmuOMWdXBQUPOR8LTy3vpFfPdNm38Kk407pa7NpZoriNwQWz8TiLioU7S+M8kpX81Vcry1yOiqgu6sY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913260695899.3975019099214; Sat, 7 Mar 2026 11:54:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxiC-00088F-DX; Sat, 07 Mar 2026 14:53:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxiB-000887-Dh for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:19 -0500 Received: from sea.source.kernel.org ([172.234.252.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxiA-0008Vg-0F for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:19 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D035142148; Sat, 7 Mar 2026 19:53:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ACCDC19422; Sat, 7 Mar 2026 19:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913196; bh=fGNhZhGwYx5O0WsKa+ya31k08B1YR0SmQJGqiNNdM0g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gHJTaNqgrfZLtsL9dcqL6eiwgnaRB1WujCx8lyXeP9vFCdg2HjlfvNzhAEAeQ1uZC +B32vU6y/fw+5e/35PQ4SJUdgaI1n4nKqudUVud3B4uB8sR3Tf6fy54gIY7TIzpeo6 GjnTEpBZYix83qv7RW7rKTdmoR6xBvYnd8HoBD/FWPN8WIFDqWH6H3ZpkhdeDVA3wW l8N0eBkdFX5WB4cKkjpkKcmrSgSUvGo46o+LK4Zhr9GdXNvL+uOcnot0tgW6UAx3re DfXWNSFUJGNjnaZVTeREjds4U+zLaZaa/YRG/O2ZBAcgRTtDxAbABpZupIU9d7yIHX Rmg8KtCEqRMPw== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 11/12] tests/tcg/multiarch/test-mmap: Check mmaps beyond reserved_va Date: Sat, 7 Mar 2026 20:52:42 +0100 Message-ID: <20260307195243.8813-12-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.234.252.31; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913263027154100 Content-Type: text/plain; charset="utf-8" From: Bingwu Zhang Unfixed mmap calls where start > reserved_va or the max guest addr should have a valid result. Signed-off-by: Bingwu Zhang Signed-off-by: Helge Deller --- tests/tcg/multiarch/test-mmap.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/tcg/multiarch/test-mmap.c b/tests/tcg/multiarch/test-mma= p.c index 88f7a04101..2bfa529127 100644 --- a/tests/tcg/multiarch/test-mmap.c +++ b/tests/tcg/multiarch/test-mmap.c @@ -497,6 +497,20 @@ void check_shrink_mmaps(void) fprintf(stdout, " passed\n"); } =20 +void check_mmaps_beyond_addr_space(void) +{ + unsigned char *addr; + addr =3D mmap((void *)(-(unsigned long)pagesize * 10), pagesize * 2, + PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + fprintf(stdout, "%s addr=3D%p errno=3D%d", __func__, (void *)addr, err= no); + fail_unless(addr !=3D MAP_FAILED); + + memcpy(dummybuf, addr, 2 * pagesize); + munmap(addr, 2 * pagesize); + + fprintf(stdout, " passed\n"); +} + int main(int argc, char **argv) { char tempname[] =3D "/tmp/.cmmapXXXXXX"; @@ -540,6 +554,7 @@ int main(int argc, char **argv) check_file_unfixed_eof_mmaps(); check_invalid_mmaps(); check_shrink_mmaps(); + check_mmaps_beyond_addr_space(); =20 /* Fails at the moment. */ /* check_aligned_anonymous_fixed_mmaps_collide_with_host(); */ --=20 2.53.0 From nobody Mon Apr 13 08:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1772913247; cv=none; d=zohomail.com; s=zohoarc; b=nqSEbMORi5oDRWjLlr23iOaGOKY0v4RVHXQQ8QtBHN+T/WlJRjrxBMGUIbG2iOHK/xOJdPx0S/XQCByaZO5wzDns9vf1LCRn40Z/lcegDvGlAczdMzutijd+3xNwnYMvgys3or/8qQqb+9L9L9rbcyKHLzTl2geePDLodZjQbC4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772913247; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9+HD+rmhkwezmMWzPd8THwkQ2xfHBNZz9XQydJekhxQ=; b=Z4O8DzC06sLzoHfKCQYcSfTKr1DKnF13pZcpjJFmFU6eOTWoPjx1SXV0AxSRha0WsfnRpYq+kWQPhB7CgtQJH53svObXJ6VTVVkFR8J4Yf6J2rjLHmawq7QX9lUTXoZvfuzYiiwF0Iv9HbxWS0FlgUZoB2dikgd69tU/IOzg53w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772913247535672.2543230180745; Sat, 7 Mar 2026 11:54:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyxiF-00089G-DA; Sat, 07 Mar 2026 14:53:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxiD-00088l-Iu for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:21 -0500 Received: from sea.source.kernel.org ([172.234.252.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyxiC-0008Vq-A7 for qemu-devel@nongnu.org; Sat, 07 Mar 2026 14:53:21 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 74671429E7; Sat, 7 Mar 2026 19:53:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DFD9C19422; Sat, 7 Mar 2026 19:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772913199; bh=iLgVWhB/TsC5r5zIEl2ocO7gnuTYhna8kv+GAWad4Oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s33fm/GBNTRa2zdNE3VDaazqITWvV8YY5LYyw1BRAvg6pn/hcJAQew6ioBfgiG6Fo 2V2/fjZTQzcodAqLQ8U/5sYpE5wkmR3CXKa8i9N32Ed6NUIIpjprNo2fvwspTaJudQ TkmwDrjY16i/a1N5CPWh/YImRbNEiDQrR8Nv927DNbDxuZxcIGZuVHNk9D2trhJwWu Eg/hTp0MtKCb9DxKXZziZEx8dqnMoKdm3x0ekHDynHwyL9brWtGuXhXUm8FOKv7GXG B21IqY5YF6xyOld712xQ2104ig7KHOnRRxfgxFzM4dV6mQbio32w/PWccQQEafNK4u A/DP0mzrsfknA== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Warner Losh , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Kyle Evans , Paolo Bonzini Subject: [PATCH 12/12] linux-user: Improve formatting for mremap() Date: Sat, 7 Mar 2026 20:52:43 +0100 Message-ID: <20260307195243.8813-13-deller@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260307195243.8813-1-deller@kernel.org> References: <20260307195243.8813-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=172.234.252.31; envelope-from=deller@kernel.org; helo=sea.source.kernel.org X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1772913249088158500 Content-Type: text/plain; charset="utf-8" From: Helge Deller Improve slightly the strace output for mremap(). Print the old_address and new_address as hex values, old_size and new_size as unsigned, and the flags as integer. Signed-off-by: Helge Deller --- linux-user/strace.list | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.list b/linux-user/strace.list index 51b5ead969..35f001fecd 100644 --- a/linux-user/strace.list +++ b/linux-user/strace.list @@ -641,7 +641,7 @@ { TARGET_NR_mq_unlink, "mq_unlink" , NULL, print_mq_unlink, NULL }, #endif #ifdef TARGET_NR_mremap -{ TARGET_NR_mremap, "mremap" , NULL, NULL, NULL }, +{ TARGET_NR_mremap, "mremap" , "%s(%#x,%u,%u,%d,%#x)", NULL, NULL }, #endif #ifdef TARGET_NR_msgctl { TARGET_NR_msgctl, "msgctl" , NULL, NULL, NULL }, --=20 2.53.0