From nobody Mon Apr 13 10:58:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=unpredictable.fr ARC-Seal: i=1; a=rsa-sha256; t=1772874537; cv=none; d=zohomail.com; s=zohoarc; b=KFZpVKuHo5llGLxjw2Jimr04yptqxmYFhKXkn335J6j4eTxHSAcZRczd8pVlu4dJscjwISXlFYz30y+TvXn4c8R/MBcF2eRGKmv/JeulXv/J+C5solaKeuFRHNBRTo5mGd1Oiu0Nn74d7nZA0IgQ7SWUVP0SjYEBoMOwfW0zJiw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772874537; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=15Wr/qFQ0GSLP0MpMuauhM/vfqwWNU5xwujZf7sJ9io=; b=ZQWXAKBtVH+VSAU1gIvijOtXSkILKjrVz7iOPwTFdWAvYvYXAc7F2fjKJcBI+EL2nf3JidRGLJnLhxj1puIYvE/Dm1Z3Olegrdbe7PS26A1p4GMDLALGV60YDkchBn+5P0DJW6mUmLClCr4n4j1HTgCLibWEYjp2fJo4yjpVhNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772874537013302.6283741047106; Sat, 7 Mar 2026 01:08:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyncD-0006jq-7Y; Sat, 07 Mar 2026 04:06:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vync9-0006hI-Fi for qemu-devel@nongnu.org; Sat, 07 Mar 2026 04:06:25 -0500 Received: from qs-2007f-snip4-11.eps.apple.com ([57.103.84.191] helo=outbound.qs.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vync7-00010R-KH for qemu-devel@nongnu.org; Sat, 07 Mar 2026 04:06:24 -0500 Received: from outbound.qs.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-2d-60-percent-7 (Postfix) with ESMTPS id B91E5180012F; Sat, 7 Mar 2026 09:06:21 +0000 (UTC) Received: from localhost.localdomain (unknown [17.57.155.37]) by p00-icloudmta-asmtp-us-east-2d-60-percent-7 (Postfix) with ESMTPSA id 1F82B180011C; Sat, 7 Mar 2026 09:06:20 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1772874382; x=1775466382; bh=15Wr/qFQ0GSLP0MpMuauhM/vfqwWNU5xwujZf7sJ9io=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme; b=LNPMZJBkaxq39r/Gi2hA3+3r13ITU6uksJC7sRlJwLoMH2iAv+aC/3BUn9G4orGsjwAirffPDXcYHhalNDB2hZrdDvK9IVMKkuAtIBw45gFu16z6db+7w3OMH8LSojVb4xAX7XKz384UDOPj8jyzJ2ZDteYVZq7xxvoSuqGR6pQRRX1B9ZjcWi+fDksensuvbhLTxE58r+cK4bcldxqjaheJlchjNuvzb6YF3vatgcSFNmk3AVR6LMQr+4EtR2zNpL4JcJUmmL14+CluFoeecOULdPvCWM8guZfMuyq0CEBTVkO8IYXBE46T+YSJX91P1QO/TIewHGYRayXo+RBIvA== mail-alias-created-date: 1752046281608 From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: Peter Maydell , Alexander Graf , Phil Dennis-Jordan , Roman Bolshakov , Mads Ynddal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Manos Pitsidianakis , qemu-arm@nongnu.org, Mohamed Mediouni Subject: [PATCH v17 07/14] hvf: gate ARM_FEATURE_PMU register emulation behind not being at EL2 Date: Sat, 7 Mar 2026 10:05:59 +0100 Message-ID: <20260307090606.95300-8-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260307090606.95300-1-mohamed@unpredictable.fr> References: <20260307090606.95300-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: SP3ndxO-Rsz2ggE4tWrObsQ-pppVrN3u X-Proofpoint-GUID: SP3ndxO-Rsz2ggE4tWrObsQ-pppVrN3u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA3MDA4MyBTYWx0ZWRfXw/Krt8RnwLvC thSuv9kocoaedyounR7L2u1O/R6q6tBE+gHbBb/AkoJFYKko8pQb96MUy+SWYjJiycpXHGtb/XV 2dLbA5wqPgaZhE/FLQOmrxIgJ8ojPdNqn87Bv2Lth0fmZ01ydsefDMGqVb4njfNL4PZlwWI7PhR oFZOrw9FPUhtxWyVT07c0oE2Qrpgemv2+RqY3AagedgmjmePXi+dpqUXNEBMxYqa9TmaSbGHkQS TKaoDwz8+Um5myEch2R89UB9tDk0AISli+hz3DsdC3bnvJZME6+bcH6M+jmlmZgZ1wlVXoevSr4 uJq+dmu/QKKqJBDFRN88rf3HabiAXpkHf1ukoEjW869DoHoL1RnThLTNwaNCJo= X-Authority-Info-Out: v=2.4 cv=CN8nnBrD c=1 sm=1 tr=0 ts=69abea8e cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117 a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=lOv7bB1OiAV5i3s2B4UA:9 a=NqO74GWdXPXpGKcKHaDJD/ajO6k=:19 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-07_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 adultscore=0 clxscore=1030 malwarescore=0 mlxlogscore=748 spamscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2603070083 X-JNJ: AAAAAAABkPewVmk8BJ3LBFCIe23IHFbfIx64G2o0LvGNXmiv8U4b/D/7gYuwujrlXOwjGVMpC2p+OmXrAfG4inivgRBlJQ+VSotCz5tVpRUmGyWT2fe4oU48SgGvZTGVu1cZ/2pNVW6iFQGuNR7S5nL+pYAA30C0xI6OSDXP/NMCYei1ZOTuSq3Y+9DIDBxNQe4gKyRy5TOx5m+VTf1a6SBNOKIQ3YAFfVF4OyWQABTEmaiEbdT2CiAtaMfNjaw3NJ36G1HEE/ny1JFaIyr1uR2p3CD/X15uhefWVHPQKelY/uHqskPK0EWFU4IhhGKrV/Bml9RkJkYYVDpvQdUmviRM0hfPRf5Mzst2OS4h816bK21WDQcPCtC78Hda86ILDBHGM5pXwHZ6+Ncbsnt/IozIvtet7YjSLb5R05+XQRRdLA/FAUyAYrlC/UszB6JyfZb+eMc9QexsqUye1NMKBx/A1M1LbKolrKWlt4+Kk0VFtLPVeL2XqfvrlTpCptMr1YrrlC1JLTw1i3SM3ElR35Ber40iGimlwtJOibEBcOqPAg+I9Tn+o5q1EtawR5R+DJPm6sxMlzfZSZFF3csJDci785yPTcOYxL2KI5DeCCQd/HuitpOFI7izCoF4n6jbepKzXS1/QUiLruA7uJ1Y64XoSCKmi2lujwEZIEOVnUuwK1Gmikic8wz5kkAG8wnWsIJlcbZM7BAgluuDKx8wuctbmnl5DNS0PGSOU2Da83oFjqn9RTCVslLMsZ/LH+DkazjjP2w= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=57.103.84.191; envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.411, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.679, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @unpredictable.fr) X-ZM-MESSAGEID: 1772874538278158500 From Apple documentation: > When EL2 is disabled, PMU register accesses trigger "Trapped MSR, MRS, or > System Instruction" exceptions. When this happens, hv_vcpu_run()=E2=80=AF= returns, and the > =E2=80=AFhv_vcpu_exit_t=E2=80=AFobject contains the information about thi= s exception. > When EL2 is enabled, the handling of PMU register accesses is determined = by the PMUVer > field of ID_AA64DFR0_EL1=E2=80=AFregister. > If the PMUVer=E2=80=AFfield value is zero or is invalid, PMU register acc= esses generate "Undefined" > exceptions, which are sent to the guest. > If the PMUVer=E2=80=AFfield value is non-zero and valid, PMU register acc= esses are emulated by the framework. > The ID_AA64DFR0_EL1=E2=80=AFregister can be modified via hv_vcpu_set_sys_= reg=E2=80=AFAPI. Signed-off-by: Mohamed Mediouni Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf/hvf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 0bb33abb9f..f926e16fd7 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1601,7 +1601,7 @@ static int hvf_sysreg_read(CPUState *cpu, uint32_t re= g, uint64_t *val) ARMCPU *arm_cpu =3D ARM_CPU(cpu); CPUARMState *env =3D &arm_cpu->env; =20 - if (arm_feature(env, ARM_FEATURE_PMU)) { + if (!hvf_nested_virt_enabled() && arm_feature(env, ARM_FEATURE_PMU)) { switch (reg) { case SYSREG_PMCR_EL0: *val =3D env->cp15.c9_pmcr; @@ -1862,7 +1862,7 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t r= eg, uint64_t val) SYSREG_OP2(reg), val); =20 - if (arm_feature(env, ARM_FEATURE_PMU)) { + if (!hvf_nested_virt_enabled() && arm_feature(env, ARM_FEATURE_PMU)) { switch (reg) { case SYSREG_PMCCNTR_EL0: pmu_op_start(env); --=20 2.50.1 (Apple Git-155)