From nobody Mon Apr 13 12:17:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772816291; cv=none; d=zohomail.com; s=zohoarc; b=Dt4KcrFZ1YujiPuehSmXSvAV6KMvx6FVi4caGNV3fECSx/mHf9h+glzuomhMe/esvkhdftxzS/hH2vR+zgoAJXl8m9jpBD8X79RmZwlwPpDDlCvHOj6v0E++IG7hHTf9/zx5ATlxVt5h2xRAyggVbA7kfDTDMeEa1lHSy5qMoAw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772816291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H2hTvCXF7y48kvG1MuleNY6neqOHdNPnnW2J7Zk4xgI=; b=ZilzM8KjW4UI/ErzuS/zpL7NtHYclyavOUMGnF7nQDy8BX+EMz5z+66qbWynYNpsfcYkrwx5cUk9VeMdkQ2w/pvF8DeYJqzO8k5AwA1sCVcZwi+Tr8d27iQ5Uy9vB+qAcapI3fxBjcmxacRsae/6MmgL+fIn0OIwCqMtph6yJkc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772816291116667.9565184953908; Fri, 6 Mar 2026 08:58:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyYUk-0004fO-7M; Fri, 06 Mar 2026 11:57:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyYUi-0004ev-MT for qemu-devel@nongnu.org; Fri, 06 Mar 2026 11:57:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyYUg-0006j0-85 for qemu-devel@nongnu.org; Fri, 06 Mar 2026 11:57:44 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-imH1wZ74PC-B-BVoDoZeYg-1; Fri, 06 Mar 2026 11:57:38 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E19B41956053; Fri, 6 Mar 2026 16:57:34 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.45.225.197]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7B2DE18001FE; Fri, 6 Mar 2026 16:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772816261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H2hTvCXF7y48kvG1MuleNY6neqOHdNPnnW2J7Zk4xgI=; b=NfQs9mkkam0TeJHeii8xwkDHCjCr5o2h0Siq2w20wiMXsO735bMXK7X1vwYTlN9cScJpu8 xPKlOnNRXrc//eADmHcA3AFTKh1GupcGXd5oY6QA1igXMLccwWRipnoVQIyIBq4wXL0NaH dQxS2S/ozJkDzepzmGpHKPUQVOvKejE= X-MC-Unique: imH1wZ74PC-B-BVoDoZeYg-1 X-Mimecast-MFC-AGG-ID: imH1wZ74PC-B-BVoDoZeYg_1772816255 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Keith Busch , Kevin Wolf , Stefan Hajnoczi , Avi Kivity , Fam Zheng , Hanna Reitz , Jesper Devantier , qemu-block@nongnu.org, Klaus Jensen , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/4] hw/nvme: report error for oversized 'serial' parameter Date: Fri, 6 Mar 2026 16:57:15 +0000 Message-ID: <20260306165717.3360110-3-berrange@redhat.com> In-Reply-To: <20260306165717.3360110-1-berrange@redhat.com> References: <20260306165717.3360110-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.411, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.679, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772816293221154100 The 'serial' accepted by the NVME device is at most 20 characters long. An over-sized user supplied value should be reported rather than silently truncated. Signed-off-by: Daniel P. Berrang=C3=A9 --- hw/nvme/ctrl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index cc4593cd42..e6b2e3b70a 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -8600,6 +8600,11 @@ static bool nvme_check_params(NvmeCtrl *n, Error **e= rrp) error_setg(errp, "serial property not set"); return false; } + if (strlen(params->serial) > NVME_ID_CTRL_SN_MAX_LEN) { + error_setg(errp, "'serial' parameter '%s' can be at most '%d' char= acters", + params->serial, NVME_ID_CTRL_SN_MAX_LEN); + return false; + } =20 if (params->mqes < 1) { error_setg(errp, "mqes property cannot be less than 1"); --=20 2.53.0