From nobody Mon Apr 13 15:13:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=unpredictable.fr ARC-Seal: i=1; a=rsa-sha256; t=1772786077; cv=none; d=zohomail.com; s=zohoarc; b=kvl7gZp9QaiNi7c2i4Vc1/h/vtNTDT72MbOpFF7m3thApTMiHwZiBxte39GINp1s8dw7ktvY7qHZ6kHzza37I9c7cejiQuANT2rsPMA6hsA80ax/X9xMWweLsCPxIqN7CV8Ad+8azp140d8XHxrH7jbD8FqGw4Sfe4Fv6HxlF7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772786077; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y+yE9Mxv+j3AxlnQVfT8up/hLQSVuBLP9oFMs4YPNg4=; b=QxPV2ofZtSa/HKxoWpfKPoKlXu0AX6C9v66gzZllIDX8SasX0/uLKb59loTyKc93DuPlMwlggO7MLEKSBfgsnrK/1e0CwkzhD588liZupuIp8v45IgULadRb3bFgoDw4xyQLDQOt1fnNXcb+Pk5f1uomdgMBdTmSD2YWGiTLaMs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177278607742355.85978500994429; Fri, 6 Mar 2026 00:34:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyQc5-0008Ha-Sh; Fri, 06 Mar 2026 03:32:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyQbF-0007Ie-IM for qemu-devel@nongnu.org; Fri, 06 Mar 2026 03:32:02 -0500 Received: from p-west2-cluster1-host1-snip4-1.eps.apple.com ([57.103.68.4] helo=outbound.mr.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyQb9-0002Ue-In for qemu-devel@nongnu.org; Fri, 06 Mar 2026 03:31:55 -0500 Received: from outbound.mr.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-2a-10-percent-1 (Postfix) with ESMTPS id 32A2218003D6; Fri, 6 Mar 2026 08:31:45 +0000 (UTC) Received: from localhost.localdomain (unknown [17.57.152.38]) by p00-icloudmta-asmtp-us-west-2a-10-percent-1 (Postfix) with ESMTPSA id 607EC18003DF; Fri, 6 Mar 2026 08:31:42 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1772785906; x=1775377906; bh=y+yE9Mxv+j3AxlnQVfT8up/hLQSVuBLP9oFMs4YPNg4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme; b=C9z5XSqZhjPfRtzxCu7NtAwpzOfYwl5Uh+jZpSBKQ6pARKogL7v5nXuMR485rutNnZw8VeYrYTDJIhHVd7h5Xswz2+RAeS8gvPDuVQY351/Uksp4oyvSk7BnTeCs11xtHyyutKKLPNZeuvjY4VuIvchcNl+Fd38hKiwJMW3nbO3gogrvisGD5/qZmL7Fm1VO8vCSLraiQI/invC4RgwJpTTVZgtsikQtA+PZ+HqPOielwHJQot/QL4txlNJW+tKMhGveaDA9V914VxCVU8nmjGJTUwuJ38hA42ZNOu1tog7V4BB8ZmWgR+uP7wa1Y6fG8OWWtuiXtyXgRuPr/+c8Hw== mail-alias-created-date: 1752046281608 From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Roman Bolshakov , Mads Ynddal , qemu-arm@nongnu.org, Peter Maydell , Cameron Esfahani , Manos Pitsidianakis , Phil Dennis-Jordan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexander Graf , Mohamed Mediouni Subject: [PATCH v14 10/19] hw/arm, target/arm: nested virtualisation on HVF Date: Fri, 6 Mar 2026 09:31:04 +0100 Message-ID: <20260306083113.74177-11-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260306083113.74177-1-mohamed@unpredictable.fr> References: <20260306083113.74177-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: AHLVYrXbRuyqA8Zy9vLovTJSPW7etn_p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDA4MCBTYWx0ZWRfX0FU7fZ4dTa3j 6LzlCQKKpuXmTXPDQgsBsfG2Yjl6oQeEchp4cOuao39eiyHe4HtsjPRIcPVJzF03Q89fa13NqZr 0IlN6zugf1u3gtwQ9ylaRoZuX0vOgbhaSR3uV8XC/xyBobk2VdUWVs4KL4xHvvRPBPwK6q2gSHG eSlit7iHtOw2UPVVo+aap66xP7+51wV7XUyKBI4t4KzTZbjLaY0RQ05PD88yUWRO/1NSWxZfLS6 doCUPduDq9ah7Aln0rV51TTMIhizz6o1jVkMB0yH1eS58LzXmOpPbzGkdEU/vdJU/cHK32PUYNs WtwEO6WZldf/0Zg0WBZ77jEK8tnt/rrEeVBGCyXEtsUwQl6S9SaCjlWcq8IvhY= X-Authority-Info-Out: v=2.4 cv=DrpbOW/+ c=1 sm=1 tr=0 ts=69aa90f2 cx=c_apl:c_pps:t_out a=9OgfyREA4BUYbbCgc0Y0oA==:117 a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=0QeE6rx795gg9bSW8oEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: AHLVYrXbRuyqA8Zy9vLovTJSPW7etn_p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_02,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=860 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1030 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2603060080 X-JNJ: AAAAAAABXCDpJ56t3yq4qpLu8cei0euQoK0PV2eYuxLHQZXlprIWG893S6UsMo50jOglIQoCZU9lI0dIdWI+7KblcMdqxeQJE+WFV5oFE9C8NE6AtuK9zYKWJUgIeuAfp2Z3Wy1QvuYQwYSUBv05hFAbA2onsVIF8Jbf5f/CgpJFmDz/UidvjhL9Z16JM7KR5kPORrXd4JF4NIBwSdXeXSrzsaMFwg5gYhUf4QfweZdGlziVFFWmwb9bx9yq86Pwl7wZ6Z5IhCku6gI7MiRnrtVZPf+jELThxxEueMt7egGc6HpzAO15s/2ET1J/E9uxtNghUtmSmEVpkSmfOobD1/MdirnN9I5nOlEwrXRYSHAvdDmQYO+jSBgJ1hhLgkyyp1caKRSzFeeLLM7HbZ41r0ZpT10ERCV0IbEaQrPElM3PW+1KyCcfRLGmLSS371fPfaAzJihuD5f5o0Z7vClEeO84+VhUXYbaAe8FAMIA20Jfst+wgtA3XO94SAOy+48FwxKyqDB+dT4hJRXqDEK6IFeXG/pzzQUH16D9EReCtRtwIGST4b/4qUT/xUAknAy8p3CRxlsq5CvVjQRBeO47unZ8DhMk1e1bu2KUVBejo03YM/i4Q6M7CRnC11VuPJmfyymj/iRZSWzd/LMfpGBx4qTrtDtwcHKdYvXA4usZ1O9/J3IUVB3kN4gv8eOE6EFdhL5NsC7ZbmpGaKEKOMYT0+7Wcc+6z7IX8ZEOWm7z0BjoAgLzzq297W4i0jRR9pFigh2En935xZh+ Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=57.103.68.4; envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.892, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.622, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @unpredictable.fr) X-ZM-MESSAGEID: 1772786078995158500 Signed-off-by: Mohamed Mediouni Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/hvf/hvf-all.c | 1 + accel/stubs/hvf-stub.c | 1 + hw/arm/virt.c | 5 +++++ include/system/hvf.h | 5 +++++ target/arm/hvf/hvf.c | 36 ++++++++++++++++++++++++++++++++++-- 5 files changed, 46 insertions(+), 2 deletions(-) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index a296b108bc..1c1437b467 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -24,6 +24,7 @@ =20 bool hvf_allowed; bool hvf_kernel_irqchip; +bool hvf_nested_virt; =20 const char *hvf_return_string(hv_return_t ret) { diff --git a/accel/stubs/hvf-stub.c b/accel/stubs/hvf-stub.c index 6bd08759ba..cec1cbb056 100644 --- a/accel/stubs/hvf-stub.c +++ b/accel/stubs/hvf-stub.c @@ -11,3 +11,4 @@ =20 bool hvf_allowed; bool hvf_kernel_irqchip; +bool hvf_nested_virt; diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7a6fad1094..90769936d0 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2661,6 +2661,11 @@ static void virt_set_virt(Object *obj, bool value, E= rror **errp) VirtMachineState *vms =3D VIRT_MACHINE(obj); =20 vms->virt =3D value; + /* + * At this point, HVF is not initialised yet. + * However, it needs to know if nested virt is enabled at init time. + */ + hvf_nested_virt_enable(value); } =20 static bool virt_get_highmem(Object *obj, Error **errp) diff --git a/include/system/hvf.h b/include/system/hvf.h index dc8da85979..0f0632f7ae 100644 --- a/include/system/hvf.h +++ b/include/system/hvf.h @@ -28,9 +28,14 @@ extern bool hvf_allowed; #define hvf_enabled() (hvf_allowed) extern bool hvf_kernel_irqchip; #define hvf_irqchip_in_kernel() (hvf_kernel_irqchip) +extern bool hvf_nested_virt; +#define hvf_nested_virt_enabled() (hvf_nested_virt) +#define hvf_nested_virt_enable(enable) hvf_nested_virt =3D enable #else /* !CONFIG_HVF_IS_POSSIBLE */ #define hvf_enabled() 0 #define hvf_irqchip_in_kernel() 0 +#define hvf_nested_virt_enabled() 0 +#define hvf_nested_virt_enable(enable) 0 #endif /* !CONFIG_HVF_IS_POSSIBLE */ =20 #define TYPE_HVF_ACCEL ACCEL_CLASS_NAME("hvf") diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index c37493b92a..c90124338f 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -27,6 +27,7 @@ #include "system/memory.h" #include "hw/core/boards.h" #include "hw/core/irq.h" +#include "hw/arm/virt.h" #include "qemu/main-loop.h" #include "system/cpus.h" #include "arm-powerctl.h" @@ -1103,6 +1104,10 @@ static bool hvf_arm_get_host_cpu_features(ARMHostCPU= Features *ahcf) (1ULL << ARM_FEATURE_PMU) | (1ULL << ARM_FEATURE_GENERIC_TIMER); =20 + if (hvf_nested_virt_enabled()) { + ahcf->features |=3D 1ULL << ARM_FEATURE_EL2; + } + for (i =3D 0; i < ARRAY_SIZE(regs); i++) { r |=3D hv_vcpu_config_get_feature_reg(config, regs[i].reg, &host_isar.idregs[regs[i].inde= x]); @@ -1200,6 +1205,15 @@ void hvf_arch_vcpu_destroy(CPUState *cpu) assert_hvf_ok(ret); } =20 +static bool hvf_arm_el2_supported(void) +{ + bool is_nested_virt_supported; + hv_return_t ret =3D hv_vm_config_get_el2_supported(&is_nested_virt_sup= ported); + assert_hvf_ok(ret); + return is_nested_virt_supported; +} + + hv_return_t hvf_arch_vm_create(MachineState *ms, uint32_t pa_range) { hv_return_t ret; @@ -1211,6 +1225,18 @@ hv_return_t hvf_arch_vm_create(MachineState *ms, uin= t32_t pa_range) } chosen_ipa_bit_size =3D pa_range; =20 + if (hvf_nested_virt_enabled()) { + if (!hvf_arm_el2_supported()) { + error_report("Nested virtualization not supported on this syst= em."); + goto cleanup; + } + ret =3D hv_vm_config_set_el2_enabled(config, true); + if (ret !=3D HV_SUCCESS) { + error_report("Failed to enable nested virtualization."); + goto cleanup; + } + } + ret =3D hv_vm_create(config); if (hvf_irqchip_in_kernel()) { /* @@ -1392,6 +1418,13 @@ static void hvf_psci_cpu_off(ARMCPU *arm_cpu) assert(ret =3D=3D QEMU_ARM_POWERCTL_RET_SUCCESS); } =20 +static int hvf_psci_get_target_el(void) +{ + if (hvf_nested_virt_enabled()) { + return 2; + } + return 1; +} /* * Handle a PSCI call. * @@ -1413,7 +1446,6 @@ static bool hvf_handle_psci_call(CPUState *cpu, int *= excp_ret) CPUState *target_cpu_state; ARMCPU *target_cpu; target_ulong entry; - int target_el =3D 1; int32_t ret =3D 0; =20 trace_arm_psci_call(param[0], param[1], param[2], param[3], @@ -1467,7 +1499,7 @@ static bool hvf_handle_psci_call(CPUState *cpu, int *= excp_ret) entry =3D param[2]; context_id =3D param[3]; ret =3D arm_set_cpu_on(mpidr, entry, context_id, - target_el, target_aarch64); + hvf_psci_get_target_el(), target_aarch64); break; case QEMU_PSCI_0_1_FN_CPU_OFF: case QEMU_PSCI_0_2_FN_CPU_OFF: --=20 2.50.1 (Apple Git-155)