From nobody Sat Apr 11 23:08:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772748692; cv=none; d=zohomail.com; s=zohoarc; b=ZlKLRmzGcVwM86tbCoYsa7pNUm6+lzxLHl7cCxdCE3g5JnWbG0nUiGdz7fW6Rntmzm2wXQ2xlnddxDTA5sIZMr+9I8WEc5IPmX3bXuoJkuCKACILCDAGxAM30ImhQTD89EfFDcpMOOWjFVtU/oRaXnv/W5wLSz/b0grZimntTsU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772748692; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=T/8vBrNspQwC+4wrO/zavy+wMEo5y5nyjJoJrIaKZns=; b=lAvteWxJxuSVCyyQga3zVdBXZG8szZa+6DU6+vy0XY9IXqS4/dNuT6J239h6Ej4N2h62CFsUrwJgKxnU02d2ZHpMBLYw1w3LoterGXBbDxY7jTkAoU1aHNe+Na55XuCFWnGG5dQD7QgSWIHV2vd1bGCjpZwNNZdCd1xyDIl8tn8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772748692192153.7926701486724; Thu, 5 Mar 2026 14:11:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyGt5-0001EH-Ra; Thu, 05 Mar 2026 17:09:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyGsu-00012F-Pr for qemu-devel@nongnu.org; Thu, 05 Mar 2026 17:09:33 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vyGst-0002Gh-Dz for qemu-devel@nongnu.org; Thu, 05 Mar 2026 17:09:32 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48375f1defeso64610575e9.0 for ; Thu, 05 Mar 2026 14:09:31 -0800 (PST) Received: from Provence.localdomain (dynamic-2a02-3100-2989-c400-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:2989:c400:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fa87e56sm67419615e9.0.2026.03.05.14.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 14:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772748569; x=1773353369; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T/8vBrNspQwC+4wrO/zavy+wMEo5y5nyjJoJrIaKZns=; b=FMxzRkv1Cw7z3y72SyUoiK5N7TKDkFp7m9YV05ocumUtloutuV0ud8jvPSHDZ+RoeS 4sPbW9tWYq8HEPWr/rbcYTMIYADUKXTsN2JRt1M14/5tbdVrv3FQ4xt3FhxTZOUmdpkH pkZp91XSCyOcpoEaP9SptY//L+fgRPf4MuuvDWFxEE0dmkr8CzeLt9S05WBV6P0qSfOX KNWhuVLskN3a28bVb3BimyHYhioRmSi9qg7m+u3+mHxyat8JnnXiNLMcnpCpzMvZIYDV b91wjUcROrwpQiOqpN6baGsNxVXMTVIg7a4HwhdzCBtzo8HGfnLN82hmXFpYaTFctKdX 90vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772748569; x=1773353369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T/8vBrNspQwC+4wrO/zavy+wMEo5y5nyjJoJrIaKZns=; b=UZcOeMO4PMIOM4Yf726QHcS/NrrO2HERbeQNvD3LdwwLVC+Q5kQ/0RaWrxNIUkHFdz R3VbjTlffm0ZmOXTpA9KAaygVuYUxoPMN/dTyypAymkPhyimrOPiiWw36b0DqmrENU39 kU77e4PdV1IE1+jtE/umCsP7EcNgaecnGgXS8mUMANEzGV9QLktLCs7LxDWbpCR+Buwg t3QtVrlA6IphuF9uLYIbxMFwj+i5PJYkwg9KYHIwMX/1ZSeDbLBXHQXMrTwfUj36KJi1 WVHRpKvbM6ZYY0Prn6SMZQNuf/JnwB0doMeRhAlRGHSIIWk906zJQUQfxIj0jbPTKIka 3MIQ== X-Gm-Message-State: AOJu0Yx+tl3SFniAb97QzTIi6ULYMde5fFXFPTKJwxjr0wTZvVxfHair aHhp5nxUgHQRbqg/janjGmrlQcZQMMn3B/4jc710MzF5FvCfDD3PY1iazat76g== X-Gm-Gg: ATEYQzx4C6F+dwpW1T1MOSlDNEKNGfmMKi1PcjiYp05f3XxYjJkSHYcyr7jcZOCz35q 98oL/Xt2mA8kV6bYbgjdNR04ZiOMQS2Qy47XC/oLloPo0X6leFhXsPI7Tvev4jvM0mxu5oYYtgD nuJb9GmInjtxFRisWiIY0Jt0U7HNQ5qs8hzGVuLLsWPLQZvXokTYGrwbbXTEtV1yq5ayiR3wo11 lvbIibp5I1L38pv55Z72iOvQfaq73Rq2IaNWAk/4fVN1h/XK0Yoj3Co89GqMKF1tdROYl7FFPxw 9krVAXo6dw8JO4JGegT3Wulf3oum0EORVMSr9cDmJPmDk8v2QH3ytndL5kU+lbQpDJv/0dumNeX g/onoVDSayoEsjjkYwIzLb+yYmmJl+Md3cFf1vofQQYJnmSJ0pjMZ3JXYg2Yfc4UgiIOtgsxiRB 6rxuzv7HBPq1QcnIaX09rPRjpId+qIDI3o4WjjekIvKbnzjNBI2b0sNorI+A+4CGUVCxUefXWnK OkOOKckNdyp4egAtwgR087v4BVodKLYTnFb/2UAJGH+5UI= X-Received: by 2002:a05:600c:198a:b0:480:f27c:6335 with SMTP id 5b1f17b1804b1-485235fddd0mr17724115e9.25.1772748569104; Thu, 05 Mar 2026 14:09:29 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , "Michael S. Tsirkin" , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Troy Lee , Joel Stanley , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Paolo Bonzini , Peter Maydell , Andrew Jeffery , Steven Lee , Jamin Lin , qemu-arm@nongnu.org, Helge Deller , Bernhard Beschow Subject: [PATCH v3 08/14] hw/char/serial: Remove unhelpful comment Date: Thu, 5 Mar 2026 23:09:05 +0100 Message-ID: <20260305220911.131508-9-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260305220911.131508-1-shentey@gmail.com> References: <20260305220911.131508-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=shentey@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772748694829154100 Content-Type: text/plain; charset="utf-8" There is no "is_load" flag and one can tell from the method name what the method does. Remove this unhelpful comment. Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell --- hw/char/serial.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 2c558cb9fc..f73de1ae4f 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -281,9 +281,6 @@ static void serial_xmit(SerialState *s) s->lsr |=3D UART_LSR_TEMT; } =20 -/* Setter for FCR. - is_load flag means, that value is set while loading VM state - and interrupt should not be invoked */ static void serial_write_fcr(SerialState *s, uint8_t val) { /* Set fcr - val only has the bits that are supposed to "stick" */ --=20 2.53.0