From nobody Sat Apr 11 23:07:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772748697136448.1692837042036; Thu, 5 Mar 2026 14:11:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyGsv-00011y-9U; Thu, 05 Mar 2026 17:09:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyGsp-0000zl-I6 for qemu-devel@nongnu.org; Thu, 05 Mar 2026 17:09:27 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vyGsm-0002DX-12 for qemu-devel@nongnu.org; Thu, 05 Mar 2026 17:09:25 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-439c9eb5d36so2163630f8f.2 for ; Thu, 05 Mar 2026 14:09:23 -0800 (PST) Received: from Provence.localdomain (dynamic-2a02-3100-2989-c400-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:2989:c400:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fa87e56sm67419615e9.0.2026.03.05.14.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 14:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772748562; x=1773353362; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6VeLOTnhmpK3hGfuKtvu330mCQPPVQNuv7C0J7IEVho=; b=V0vBBOLbnAaqAJOWAPI9ZEddCBvzmWIVyN6qhvgVxZybqk0brWBKxVT7oEjgOEbmks TLwsIn+/xmGbsiriaszq2j2uhai6CzNEoSZCNnhyW+P4Fwj3fzKn+Rsddh86ZrsvVsbJ DJFE3fB54V6TEv4jLifFc9XEeHCkI2MpYwZ7v5plOVfxRW7e1vRcs587oszk1s+83ZSG DliGpzpv1y1vPCsvcAt5svm+ruyUAjJgBkhtw8+3vc8DlD8i6XBWV43MZDzK1Ti1gs0g IIqOEPYnXAjg3Yni8hoTKYAOuThCqvsG7ditdZPov0p5NGUNaPv8msVr7dBfBWomZlkJ La5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772748562; x=1773353362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6VeLOTnhmpK3hGfuKtvu330mCQPPVQNuv7C0J7IEVho=; b=dXQPC3PoPs8bzJWGXZm/9HHWeaz0YydPWTdOchtcdcg37MnqVqfGRR5B2q32blCosw eV/DUZJ3Jj6lbbf+s8cwWldzBOYxNVFtalwLy/NLVIAiEd/LQ4dMwL/f/tqCXhONysis mmVSYZH+KYZASAEzXwzxIW/sEfj3ti9S3zu/IiwitooImZM3mSMBNT4mNAvUfNDer8VS oHV1IPSFlWb9gEnosaS31ALW2Ls10hcHSMH3XopKwUr/aiIDmexBjaNAq8ViF7ued6Rr E+v/UrPVETevDlRQpxgs6DMTCahazCJ3yXBxwmdfBJqz0nruQPE3FyVfZDR0qJdulI5z bt9w== X-Gm-Message-State: AOJu0YwTwhXuVWiE0Nh0077IYmmI81GxrYYGfK7nEM1sAomFvIYemh7Y 9wcd14VOh6eFt78mcrjrrSGNDaf34NrLL4VFl2xxxoCP8DptPaUiCgIv0irPJw== X-Gm-Gg: ATEYQzxJA8OufUA2JflBxBLRIIo3kx2kENCYbpcKmxLSf0dZdysAbLLzQyP/RVAlN8V q2Oa9cf3Ywaya0pqWnuZauVqkNGX/uqTNPBIHb/3wkr1MNsNGFkmCZdg9jWZqAlwO+fRd000PJE MxYYC0Ar3Y1V7pUKsKN4oDw/1BJeWJI0+M0TF5JCh1YI2hgJtecwE0yCa1dyu5hZVPE1AccKd7M HpzyMkEywR6mRJTABMPMuWlSxgddULgaQ+L8S70dYXC2eALrh/xNT/jyxSJo9QIoSrcqw7MKjh3 KiBQLcpPhmC0cgx8Y6f//MdPK2x0q2k6HQkXBnBqdGz1qdg1F6Uep/GyITcvUztH/TmopIDnygg gceMRlczUEfQ3SBhIjWb9PG4SAPdheXDIOrYkpQZRbZnQx3NSaPicpAWTSYQUpGOf7x5ACPEzuB k0jR5oPIK7XYtdlOGIMDOBoqlvjTFb6rVeypXFFgwn8oslnskItOrViJsce7pCi+/+awbSbCWEb IZvx7+d5meGiY2JA7se2BPY6JIxf2TsGoGyP02L4zpDFZc= X-Received: by 2002:a05:600c:4688:b0:47e:e7e5:ff32 with SMTP id 5b1f17b1804b1-485198a3bc4mr116276825e9.34.1772748561651; Thu, 05 Mar 2026 14:09:21 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , "Michael S. Tsirkin" , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Troy Lee , Joel Stanley , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Paolo Bonzini , Peter Maydell , Andrew Jeffery , Steven Lee , Jamin Lin , qemu-arm@nongnu.org, Helge Deller , Bernhard Beschow Subject: [PATCH v3 02/14] hw/char/{diva-gsp, serial-pci-multi}: Fix deinitialization order Date: Thu, 5 Mar 2026 23:08:59 +0100 Message-ID: <20260305220911.131508-3-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260305220911.131508-1-shentey@gmail.com> References: <20260305220911.131508-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=shentey@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772748698816154100 Content-Type: text/plain; charset="utf-8" The memory region is owned by the device being unrealized, so must be removed from the mapping before unrealizing. Fixes: d66bbea4e0d3 ("serial: add 2x + 4x pci variant") Fixes: 274074708455 ("hw/char: Add emulation of Diva GSP PCI management boa= rds") Reported-by: Peter Maydell Signed-off-by: Bernhard Beschow --- hw/char/diva-gsp.c | 2 +- hw/char/serial-pci-multi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/diva-gsp.c b/hw/char/diva-gsp.c index 280d0413c6..f9aa6e326d 100644 --- a/hw/char/diva-gsp.c +++ b/hw/char/diva-gsp.c @@ -62,8 +62,8 @@ static void diva_pci_exit(PCIDevice *dev) =20 for (i =3D 0; i < pci->ports; i++) { s =3D pci->state + i; - qdev_unrealize(DEVICE(s)); memory_region_del_subregion(&pci->membar, &s->io); + qdev_unrealize(DEVICE(s)); g_free(pci->name[i]); } qemu_free_irqs(pci->irqs, pci->ports); diff --git a/hw/char/serial-pci-multi.c b/hw/char/serial-pci-multi.c index 17796b93dd..7782452018 100644 --- a/hw/char/serial-pci-multi.c +++ b/hw/char/serial-pci-multi.c @@ -56,8 +56,8 @@ static void multi_serial_pci_exit(PCIDevice *dev) =20 for (i =3D 0; i < pci->ports; i++) { s =3D pci->state + i; - qdev_unrealize(DEVICE(s)); memory_region_del_subregion(&pci->iobar, &s->io); + qdev_unrealize(DEVICE(s)); g_free(pci->name[i]); } } --=20 2.53.0