From nobody Sun Apr 12 00:56:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772748644; cv=none; d=zohomail.com; s=zohoarc; b=GFiiiNUttt6qcb/IN44m9SVUPcKkU9+mW0zaliy0NfGKtFalDx0Uaz4+9M6u8yR1K+2YkiT2C/wQs9mTtEC0w13tjriFsTj2F2Tvenpsj7tJP9D1dZZGDppa+ykR1htpFr9qyCUBrZNwtetBQFJ5lAt9SuxKWTk2lcAudpHW9yM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772748644; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mfHZMVt3w+CNCstm9dcEqkFY9F06DbEsvAYeYDdgYzI=; b=DDhtGnlhckutRiEbXOSs57GeRcG6uDoyM29LU5apMLaFak3kKZZANmRQW+E5uvNHAGu1D0PzsB9MFdVIZ3qxb0bUbLJwVzRFYq3POirhKxDV4105jc6dac0l8VIHZ38DAssNCzZ0WBfUV82dcbTPX5FnPKoF7qo6vBvgLdV4rJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772748644599317.60361875561273; Thu, 5 Mar 2026 14:10:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyGtF-0001Ox-PG; Thu, 05 Mar 2026 17:09:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyGsz-00017P-HB for qemu-devel@nongnu.org; Thu, 05 Mar 2026 17:09:37 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vyGsy-0002IW-4Z for qemu-devel@nongnu.org; Thu, 05 Mar 2026 17:09:37 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-48371119eacso101042325e9.2 for ; Thu, 05 Mar 2026 14:09:35 -0800 (PST) Received: from Provence.localdomain (dynamic-2a02-3100-2989-c400-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:2989:c400:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fa87e56sm67419615e9.0.2026.03.05.14.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 14:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772748574; x=1773353374; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mfHZMVt3w+CNCstm9dcEqkFY9F06DbEsvAYeYDdgYzI=; b=k4WXf/5HA09mBG6VleDQlftXYW2gCjpAyGy6eVuqAG/Lpv5iv+0m4JUqN2n2whVR4u MDkQ3ssiIJgasSTNB1OeKVl6oXi5seE8jUnc5NCs7qbZ5b1gxjm6d3J7lNVfJjac9bB8 wOoJoP2FA5lOCwp89TcF2xlnOAEURHGZymZlGM9HlHHFpRBC/yzMUzWRN5ctZtIsPcK8 kkSBYEC+S+p95uMzVnfC7mbGk8/EeuyUJSof9GJBY/FY2Pf5XrlJSgAQgkowzgxeQMiE ObwpVPTDcEDEoHAHkYxP8wbRasqAbDolR1ZiunSyoJsI1PB35PPp1XRWHBNl63a8sD32 fJvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772748574; x=1773353374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mfHZMVt3w+CNCstm9dcEqkFY9F06DbEsvAYeYDdgYzI=; b=ZZ06to+Z4wfZTceoXJsCC6/AS4eeSmQdZ3TsFl4WByah3vhpHkNkeBieXp9+L1TGVz 1qoZT/D482bq8VS/an6JBSi+8ffu4i95Ti8VucnZM1uodhKAuJXlxYoOZXOkQVDjOA9z UnvNYWkwvEYD9ZshO5bUXxvwKAbJwEaCmbOXSusuzCaAOf3cDBEbBjLinBoQPpiiU4KD iHBnqMuBITTNLY1YWBhIbH9jJTcVostyVHtEQBgCZh5toi6lTkpTmfOD9grvi+qx4B8+ X8lN6jo6COVSBDKeFP05s+XLSjNLz6lndfsHGu+Ek9g+ZmQIimB3leSNlgSqkZV0WaKA WygA== X-Gm-Message-State: AOJu0Yy0udQlff7iirxYwMUsQOoSs+AfNE7HiAbi8mt3f+a/V9A325+y c6w70sKhgrMl54UDrC74UzlbBoIo0ijMtOVCU5qeBPZs3IkojSu1nh9gE0WLdg== X-Gm-Gg: ATEYQzxFTJxBHhRCdh2nIT2Qq7cx/g0OcQhClbrUICjAOwPvjj4pvy3anoFGQD8pouu 56PxMLAklOo5o/HKCue11DI5H7ssGethr2i1a7Si8F+RdEjXwa2Ce8V1g+gBu7KK7gJIGRzTkVv iCFl4KMiVagZT65+D8QxqkA3hJnU00IHtph6kQ5he1ihBOvIoHh8lLs+BvGDHJ0sa4VQ0kEUVUI IfdIu/hZtcBBSQ/4kkDopKA3indXo4SJIaIg+N1Me73bC7mSh15tbc8O0bRKRSlrv9EtabJyZLt HX1WqAK0QcuYaS97a52gV8+q+GyHwvhIgj/KtgRWIow2dyDZWgKE1EqK1ufDaTPIItSwgL+lCof d4u0Zk4xZqvcAvkszZeAEMPei2U+G5OR5+e9KtdOceTnCx9n/QUVfXi0yzppTmUTbssvRuBdEeD d07iJCMCnPISB+6YWfm44hGsbhfCtME+tm1dWG7LD+fUUYk2+RMVilLMd/r44jTMZKSQJxisPJP yLCB8ovCs81HClPDHPOdj/U5FtyVxbDfP8SUO3dhr0tnIE= X-Received: by 2002:a05:600c:1f88:b0:480:4a90:1afe with SMTP id 5b1f17b1804b1-4852360e3d2mr18066675e9.34.1772748574239; Thu, 05 Mar 2026 14:09:34 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , "Michael S. Tsirkin" , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Troy Lee , Joel Stanley , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Paolo Bonzini , Peter Maydell , Andrew Jeffery , Steven Lee , Jamin Lin , qemu-arm@nongnu.org, Helge Deller , Bernhard Beschow Subject: [PATCH v3 11/14] hw/char/serial: Avoid implicit conversion when tracing Date: Thu, 5 Mar 2026 23:09:08 +0100 Message-ID: <20260305220911.131508-12-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260305220911.131508-1-shentey@gmail.com> References: <20260305220911.131508-1-shentey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=shentey@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772748646127154100 On 64 bit targets, the MemoryRegion API passes an address and a value as uint64_t, so use that for tracing. Keep the uint8_t for reading since this is what the device model produces. On targets with less than 64 bits, uint64_t is wide enough to avoid narrowing. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Bernhard Beschow --- hw/char/trace-events | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/trace-events b/hw/char/trace-events index 9e74be2c14..a3fcc77287 100644 --- a/hw/char/trace-events +++ b/hw/char/trace-events @@ -5,8 +5,8 @@ parallel_ioport_read(const char *desc, uint16_t addr, uint8= _t value) "read [%s] parallel_ioport_write(const char *desc, uint16_t addr, uint8_t value) "wri= te [%s] addr 0x%02x val 0x%02x" =20 # serial.c -serial_read(uint16_t addr, uint8_t value) "read addr 0x%02x val 0x%02x" -serial_write(uint16_t addr, uint8_t value) "write addr 0x%02x val 0x%02x" +serial_read(uint64_t addr, uint8_t value) "[0x%02" PRIx64 "] -> 0x%02" PRI= x8 +serial_write(uint64_t addr, uint64_t value) "[0x%02" PRIx64 "] <- 0x%02" P= RIx64 serial_update_parameters(uint64_t baudrate, char parity, int data_bits, in= t stop_bits) "baudrate=3D%"PRIu64" parity=3D'%c' data=3D%d stop=3D%d" =20 # virtio-serial-bus.c --=20 2.53.0