From nobody Fri Mar 27 03:59:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772744162; cv=none; d=zohomail.com; s=zohoarc; b=eafhsd+Lh65OYADeDm+gmg7ikPQbD2WQk0867+8+A6ZPvF+l0o6HPNRWxWhQQPlf+e0vuZ7CD9WMebyECy5/WRnESExIgjz5lTaikng3a4ECkSZZ73zQvpAczrGvJx+6LD+x/BbuxLHFzgBwpsB9WIRpEWgTfR3jkipip8VCM/s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772744162; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nkGRHnWZzEkpTkOUXW6elzMRnuyLVvfMOFl+6+n7Ots=; b=nvfFFOubsdYzs5VSWzT7YJtd5PcYT66NYusUPpMcR9PXsMnNHu7KCi4l5xyzaRWGAWhTBXaqY7KhMXYuodJvHA1yuTrG33bLYobeHGv9XNN7u7TF0YK0xPUW03iMQ9pA3s5kzm7HJabeEtbRsT/Lq8CGNpU85AJaOl2baOqte8U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772744162516430.9516767858962; Thu, 5 Mar 2026 12:56:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyFjd-0003Xq-NH; Thu, 05 Mar 2026 15:55:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyFjM-0003QO-A5 for qemu-devel@nongnu.org; Thu, 05 Mar 2026 15:55:37 -0500 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vyFjI-0006gK-2r for qemu-devel@nongnu.org; Thu, 05 Mar 2026 15:55:35 -0500 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-829756f3ee9so2100179b3a.2 for ; Thu, 05 Mar 2026 12:55:30 -0800 (PST) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8297e4fbbd4sm3847454b3a.53.2026.03.05.12.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 12:55:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772744129; x=1773348929; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nkGRHnWZzEkpTkOUXW6elzMRnuyLVvfMOFl+6+n7Ots=; b=tDpvrEcgnxNNl/GHhIhPUk8WMJPcWQHul30cV7vLcIq+7ukbcxl47DuEjOZo52oDJH 8VQaBvdKeUU3mdMWyGn8mRNCd+Miz7OtYWkuQL+uZFAh0i/LVRmKYtzhH+LDdwliSmou CJSLubsxQaM2sp9XfzRYW8AlIgtmtqPcosIjuZ2Md9ds2TngDycNk/DT8J3FmEKZlYL7 Z5MjMV56ASfEmq4mirwZI9OswhDrgM8AGUdUf/1LxMU5vVFkjOHMm19Dy1wwM3Fq5Hew +ZpdxCZ75fQBh9H6gTjnGaS+OougWVNkJYR4Jnu8ZiQlYkAVtd9xU0UGDJB1rHyDR7QH jSzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772744129; x=1773348929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nkGRHnWZzEkpTkOUXW6elzMRnuyLVvfMOFl+6+n7Ots=; b=KQfiOPflWAuvNiXRnz+OxREIYrQFi2/VD8kXjl7OiXTRxsQTUoSL9Bi9bPxmNpwzPp NhMmrMyMvjDr1cQF2sGlDRXQxl7NfHNYvh4PdcMPn3DqZde6Rg9Q4Y0v6UdrQ/HXatdh T+iTThhlcpz/HTObV3g5+MXdiVxF29NHxwS9TXf0VU5P5NJ5K/pXV0Odtmxsp70IfWEG 2+QIpilgVF6AdvpRlw7vkdOdVqeBesLlBoxwmW6ShpyQL9WhjAlVr3KrSMqmB6CaOwMp uRQNrzgZMykvlg4kHXgJJ5vXlxwob2mWMbTcZHspV2sku1/rAFBu1YpEXUK6Bd6bfYoC dbCQ== X-Gm-Message-State: AOJu0YwFD4B2hhiVJEX9SXjLLhNd/6rfnG0jAi4It4R176Lzz2s8PbKY Tqg6ihWGj7HCgOjAq6sxXeoPTK0h2zzCqK0H2+ysBcfUP2NxXO0BqHEhMVMuJYFHSJPGm9BqjDN D3Hkb X-Gm-Gg: ATEYQzxj8iaNje3k87RLuToq4hKSFEnF4lA/CLr235TzbuZhpynYhaOH6jWgr0yW0Tc MES0SgbI3xjVOS59Pmbw6w7f5XVZkxaJURWHnHediOO8iELfD1SdqW4rI+kK5XCS12SXHoVk8V2 rakwgK/JmsbG60CC2Ep9sl4Psr3a0ahYEORHrWlFvgH6yU05UfrkuY6g+lV4nUUcMSttcil7+zh Bava0OFEPGe4p8Es0rfI1XqaSpVxly4nIoQvDNIH3trFQot3PVRIZ9+GZeafWdvgsXTd1pyAvCi HjXx/MxReENiO55hR8nhbfiTkUn+sIMclc2CD7smezI9U5w1TL/iUyRoL+xjPfh1akoIlCa57L+ G3BCO0WtY4FPb6/oBwNpPB4GUqI20gjPJkJaQVEIo7R2w1BR/muoDzIY0w7yfCfykgvke5RPK+a LEMk5yuCfRnSENZM5ftMaxz07L9v4Hu8RReREk/eSkIzZHruiJmvwEvXykZXN+4oGjZhJaKNDW+ Wyt X-Received: by 2002:a05:6a00:399b:b0:827:37d5:af5a with SMTP id d2e1a72fcca58-82972b414b7mr5913503b3a.19.1772744129028; Thu, 05 Mar 2026 12:55:29 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org, peter.maydell@linaro.org, richard.henderson@linaro.org, pbonzini@redhat.com, stefanha@redhat.com Cc: pierrick.bouvier@linaro.org Subject: [PULL 3/6] hw/virtio: Inline virtio_access_is_big_endian() Date: Thu, 5 Mar 2026 12:55:17 -0800 Message-ID: <20260305205520.2125218-4-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260305205520.2125218-1-pierrick.bouvier@linaro.org> References: <20260305205520.2125218-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772744164810154100 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Link: https://lore.kernel.org/qemu-devel/20260225041948.52929-4-philmd@lina= ro.org Signed-off-by: Pierrick Bouvier --- include/hw/virtio/virtio-access.h | 29 ++++++++++++----------------- hw/virtio/virtio.c | 4 ++-- 2 files changed, 14 insertions(+), 19 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index e3148c23881..506be642c9f 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -21,14 +21,9 @@ #include "hw/virtio/virtio.h" #include "hw/virtio/virtio-bus.h" =20 -static inline bool virtio_access_is_big_endian(VirtIODevice *vdev) -{ - return virtio_vdev_is_big_endian(vdev); -} - static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { stw_be_p(ptr, v); } else { stw_le_p(ptr, v); @@ -37,7 +32,7 @@ static inline void virtio_stw_p(VirtIODevice *vdev, void = *ptr, uint16_t v) =20 static inline void virtio_stl_p(VirtIODevice *vdev, void *ptr, uint32_t v) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { stl_be_p(ptr, v); } else { stl_le_p(ptr, v); @@ -46,7 +41,7 @@ static inline void virtio_stl_p(VirtIODevice *vdev, void = *ptr, uint32_t v) =20 static inline void virtio_stq_p(VirtIODevice *vdev, void *ptr, uint64_t v) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { stq_be_p(ptr, v); } else { stq_le_p(ptr, v); @@ -55,7 +50,7 @@ static inline void virtio_stq_p(VirtIODevice *vdev, void = *ptr, uint64_t v) =20 static inline int virtio_lduw_p(VirtIODevice *vdev, const void *ptr) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { return lduw_be_p(ptr); } else { return lduw_le_p(ptr); @@ -64,7 +59,7 @@ static inline int virtio_lduw_p(VirtIODevice *vdev, const= void *ptr) =20 static inline int virtio_ldl_p(VirtIODevice *vdev, const void *ptr) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { return ldl_be_p(ptr); } else { return ldl_le_p(ptr); @@ -73,7 +68,7 @@ static inline int virtio_ldl_p(VirtIODevice *vdev, const = void *ptr) =20 static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, const void *ptr) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { return ldq_be_p(ptr); } else { return ldq_le_p(ptr); @@ -83,9 +78,9 @@ static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, c= onst void *ptr) static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s) { #if HOST_BIG_ENDIAN - return virtio_access_is_big_endian(vdev) ? s : bswap16(s); + return virtio_vdev_is_big_endian(vdev) ? s : bswap16(s); #else - return virtio_access_is_big_endian(vdev) ? bswap16(s) : s; + return virtio_vdev_is_big_endian(vdev) ? bswap16(s) : s; #endif } =20 @@ -97,9 +92,9 @@ static inline void virtio_tswap16s(VirtIODevice *vdev, ui= nt16_t *s) static inline uint32_t virtio_tswap32(VirtIODevice *vdev, uint32_t s) { #if HOST_BIG_ENDIAN - return virtio_access_is_big_endian(vdev) ? s : bswap32(s); + return virtio_vdev_is_big_endian(vdev) ? s : bswap32(s); #else - return virtio_access_is_big_endian(vdev) ? bswap32(s) : s; + return virtio_vdev_is_big_endian(vdev) ? bswap32(s) : s; #endif } =20 @@ -111,9 +106,9 @@ static inline void virtio_tswap32s(VirtIODevice *vdev, = uint32_t *s) static inline uint64_t virtio_tswap64(VirtIODevice *vdev, uint64_t s) { #if HOST_BIG_ENDIAN - return virtio_access_is_big_endian(vdev) ? s : bswap64(s); + return virtio_vdev_is_big_endian(vdev) ? s : bswap64(s); #else - return virtio_access_is_big_endian(vdev) ? bswap64(s) : s; + return virtio_vdev_is_big_endian(vdev) ? bswap64(s) : s; #endif } =20 diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index c0c4599b586..22d798e6cdd 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -222,7 +222,7 @@ static inline uint16_t virtio_lduw_phys_cached(VirtIODe= vice *vdev, MemoryRegionCache *cache, hwaddr pa) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { return lduw_be_phys_cached(cache, pa); } return lduw_le_phys_cached(cache, pa); @@ -232,7 +232,7 @@ static inline void virtio_stw_phys_cached(VirtIODevice = *vdev, MemoryRegionCache *cache, hwaddr pa, uint16_t value) { - if (virtio_access_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { stw_be_phys_cached(cache, pa, value); } else { stw_le_phys_cached(cache, pa, value); --=20 2.47.3