From nobody Fri Mar 27 05:01:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1772739860; cv=none; d=zohomail.com; s=zohoarc; b=mhrGuWpRKhYgb/Sq7QKFkNZfwhk20GvKcZmoHlZw7kvK1o3eUk6iboDKrDjXbha3FBRvm577BEB9/lBguREhnhm36+uUqYMCAPAPYuDTBvb+CgVv6r0mguFSRKRcxDCpEAnB1vuYbBBoNNCx1PrWdBO7i29mruUNSEWCX+XnlsM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772739860; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=87dUWNkHcTPzQRSbWhPCiEzsPvmojygUsu9xACani3Q=; b=aKvvq3ZuY03XAaCzgz0qTKZ1uuIeanL1xJAFjFAscJJINivHHGLiY0qlg+vimJ9ykrI9BXKV/GHhzlN4QWvxvpqZ0EBYX56vp0f9sn9Xk5XbGBdEIg3Vmui31vGzHqDshv/5tFfFAZChYqK8Qu/xBsW12IXIMWIItRz4CjdpObA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772739859143919.5453750011686; Thu, 5 Mar 2026 11:44:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyEbl-0004zU-JI; Thu, 05 Mar 2026 14:43:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyEbj-0004z8-FT for qemu-devel@nongnu.org; Thu, 05 Mar 2026 14:43:39 -0500 Received: from forwardcorp1a.mail.yandex.net ([178.154.239.72]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyEbh-0001yd-LW for qemu-devel@nongnu.org; Thu, 05 Mar 2026 14:43:39 -0500 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:a189:0:640:4da6:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 69346C01EF; Thu, 05 Mar 2026 22:43:33 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:b93::1:1]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id VhvFMN0A1Cg0-a7Ib3pOl; Thu, 05 Mar 2026 22:43:32 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1772739812; bh=87dUWNkHcTPzQRSbWhPCiEzsPvmojygUsu9xACani3Q=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=EQR8fDptTWODqUoVP4iTOX1IHkV7dbdA34I0Yl1g/HoR/50XGoZ2g+rNcfD1qKZ3Y 6tJ7652EqySusz90HLEEt9njuZNRCHnJTdkUojDe7OVhzk3fBBL94u2mI45so2rFrp 0PjDpFm7J9UUYiv9E93aHPRVG3HqoTcOkVoNyPt0= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: jasowang@redhat.com Cc: qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru, vsementsov@yandex-team.ru Subject: [PATCH 13/12 v3] net/tap: check that user tries to define zero queues Date: Thu, 5 Mar 2026 22:43:29 +0300 Message-ID: <20260305194329.1470084-1-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260218202829.1322088-1-vsementsov@yandex-team.ru> References: <20260218202829.1322088-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.72; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.892, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.622, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1772739862246158500 Content-Type: text/plain; charset="utf-8" Add check for queues parameter to be non-zero, and for fd/fds parameters to be non-empty. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 4 ++++ net/util.c | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/net/tap.c b/net/tap.c index 1623ddff5fb..383e158d5e2 100644 --- a/net/tap.c +++ b/net/tap.c @@ -807,6 +807,10 @@ static int tap_parse_fds_and_queues(const NetdevTapOpt= ions *tap, int **fds, error_setg(errp, "queues exceeds maximum %d", INT_MAX); return -1; } + if (tap->queues =3D=3D 0) { + error_setg(errp, "queues must be greater than zero"); + return -1; + } queues =3D tap->queues; *fds =3D NULL; } else if (tap->fd || tap->fds) { diff --git a/net/util.c b/net/util.c index 1998a6554e0..8265f155484 100644 --- a/net/util.c +++ b/net/util.c @@ -94,6 +94,11 @@ int net_parse_fds(const char *fds_param, int **fds, int = expected_nfds, return -1; } =20 + if (nfds =3D=3D 0) { + error_setg(errp, "no fds passed"); + return -1; + } + *fds =3D g_new(int, nfds); =20 for (i =3D 0; i < nfds; i++) { --=20 2.52.0