From nobody Sat Apr 11 23:07:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772733565; cv=none; d=zohomail.com; s=zohoarc; b=JJAsVsWptMKPp71YlS2dWM16J5uUitv4yldeTCg6thma0G4fvY3oE9Psfg4QYVPQh5UnwA1U/gWja5i4r8peiK6oGftAraOzbm6k5XQkEhWz+ZXRe/ImmILStSXqnTMi2/eLxhi5oE7HRTQMKjfrLwQzQUHuxWViAAu16ZdQ+ks= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772733565; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1JSzgSUMOxOfNGU/S9xqyN1CPD7KoKksKD2uB9sdKPA=; b=j3S0Yv3IVQ9qkSMAtLMIzCSlC0hMIiB9Sd4qnQa8XPDl/GqZ1yB8hqwCV/Unf67gsRFqXQR8AWsFmRNG+TUhWZo+qznQh4+Z2t/G9UgBSMl6/Tk8TiIhUd5lDHxsIAGcJ/xCLGnv8szFwcE6yfScg+tbkcQcLIP10kD05mjGzxQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772733565109551.0305002135773; Thu, 5 Mar 2026 09:59:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyCx3-00070z-B9; Thu, 05 Mar 2026 12:57:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyCwz-000700-Vq for qemu-devel@nongnu.org; Thu, 05 Mar 2026 12:57:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyCwx-0003V1-Ov for qemu-devel@nongnu.org; Thu, 05 Mar 2026 12:57:29 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-omnzWyzwN8GsXFiej9X_MQ-1; Thu, 05 Mar 2026 12:57:23 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 78B2D195608F; Thu, 5 Mar 2026 17:57:22 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.32.26]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B5E723003E9E; Thu, 5 Mar 2026 17:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772733447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1JSzgSUMOxOfNGU/S9xqyN1CPD7KoKksKD2uB9sdKPA=; b=DYlJ/nCPgHjGKTcDcNWayIejXww12rba1dS4+G4V+7R07Ed2VL55hTREsUAg+ikpZHz2Jd CMf5w9zCaelfYvzyyr79pKqSPvqAwVUHsxJ/CsklF66X+vYRUzD+CTU5NYl/9HOGWU7hSL jP86vWto3I+j7gfLYTEjzdWsyMIcXTw= X-MC-Unique: omnzWyzwN8GsXFiej9X_MQ-1 X-Mimecast-MFC-AGG-ID: omnzWyzwN8GsXFiej9X_MQ_1772733442 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jithu Joseph Subject: [PULL 03/38] hw/i3c/aspeed_i3c: Switch to DEFINE_TYPES() and align parent_obj naming Date: Thu, 5 Mar 2026 18:56:36 +0100 Message-ID: <20260305175711.1119025-4-clg@redhat.com> In-Reply-To: <20260305175711.1119025-1-clg@redhat.com> References: <20260305175711.1119025-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.892, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.622, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772733566408158500 From: Jamin Lin Following review feedback, update the Aspeed I3C device to use the DEFINE_TYPES() macro instead of an explicit type registration function. DEFINE_TYPES() is the currently recommended approach in QEMU for registering multiple TypeInfo entries and avoids boilerplate type_init() code. Additionally, rename embedded SysBusDevice fields from "parent" to "parent_obj" to comply with the QEMU coding style guidelines for QOM objects. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Tested-by: Jithu Joseph Link: https://lore.kernel.org/qemu-devel/20260225021158.1586584-3-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/i3c/aspeed_i3c.h | 16 ++++++---------- hw/i3c/aspeed_i3c.c | 35 +++++++++++++++-------------------- 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/include/hw/i3c/aspeed_i3c.h b/include/hw/i3c/aspeed_i3c.h index 7a984e1f01ab..bd0ffc84eab9 100644 --- a/include/hw/i3c/aspeed_i3c.h +++ b/include/hw/i3c/aspeed_i3c.h @@ -21,28 +21,24 @@ OBJECT_DECLARE_TYPE(AspeedI3CState, AspeedI3CClass, ASP= EED_I3C) #define ASPEED_I3C_NR_DEVICES 6 =20 OBJECT_DECLARE_SIMPLE_TYPE(AspeedI3CDevice, ASPEED_I3C_DEVICE) -typedef struct AspeedI3CDevice { - /* */ - SysBusDevice parent; +struct AspeedI3CDevice { + SysBusDevice parent_obj; =20 - /* */ MemoryRegion mr; qemu_irq irq; =20 uint8_t id; uint32_t regs[ASPEED_I3C_DEVICE_NR_REGS]; -} AspeedI3CDevice; +}; =20 -typedef struct AspeedI3CState { - /* */ - SysBusDevice parent; +struct AspeedI3CState { + SysBusDevice parent_obj; =20 - /* */ MemoryRegion iomem; MemoryRegion iomem_container; qemu_irq irq; =20 uint32_t regs[ASPEED_I3C_NR_REGS]; AspeedI3CDevice devices[ASPEED_I3C_NR_DEVICES]; -} AspeedI3CState; +}; #endif /* ASPEED_I3C_H */ diff --git a/hw/i3c/aspeed_i3c.c b/hw/i3c/aspeed_i3c.c index fff259ff665f..e7cdfbfdbda6 100644 --- a/hw/i3c/aspeed_i3c.c +++ b/hw/i3c/aspeed_i3c.c @@ -337,13 +337,6 @@ static void aspeed_i3c_device_class_init(ObjectClass *= klass, const void *data) device_class_set_props(dc, aspeed_i3c_device_properties); } =20 -static const TypeInfo aspeed_i3c_device_info =3D { - .name =3D TYPE_ASPEED_I3C_DEVICE, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(AspeedI3CDevice), - .class_init =3D aspeed_i3c_device_class_init, -}; - static const VMStateDescription vmstate_aspeed_i3c =3D { .name =3D TYPE_ASPEED_I3C, .version_id =3D 1, @@ -366,18 +359,20 @@ static void aspeed_i3c_class_init(ObjectClass *klass,= const void *data) dc->vmsd =3D &vmstate_aspeed_i3c; } =20 -static const TypeInfo aspeed_i3c_info =3D { - .name =3D TYPE_ASPEED_I3C, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_init =3D aspeed_i3c_instance_init, - .instance_size =3D sizeof(AspeedI3CState), - .class_init =3D aspeed_i3c_class_init, +static const TypeInfo aspeed_i3c_types[] =3D { + { + .name =3D TYPE_ASPEED_I3C, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_init =3D aspeed_i3c_instance_init, + .instance_size =3D sizeof(AspeedI3CState), + .class_init =3D aspeed_i3c_class_init, + }, + { + .name =3D TYPE_ASPEED_I3C_DEVICE, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(AspeedI3CDevice), + .class_init =3D aspeed_i3c_device_class_init, + }, }; =20 -static void aspeed_i3c_register_types(void) -{ - type_register_static(&aspeed_i3c_device_info); - type_register_static(&aspeed_i3c_info); -} - -type_init(aspeed_i3c_register_types); +DEFINE_TYPES(aspeed_i3c_types) --=20 2.53.0