From nobody Sun Apr 12 00:55:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772733734; cv=none; d=zohomail.com; s=zohoarc; b=XgWIWd5U7p3cGUEvwnZKHOU7fFEyv9OdNvq6DzrNQtQV2kbC11a7YDo7hKvS9L2SGTlTmgfBwuM5wAxEqrS9gJ1x7LtpnoDOkOPznvNqSE64wmOrrioU0dCCwzZoFijbd0cMGjdZCWiahUJZFFDWPmh8waCqmpXF5F/9uu0FUNU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772733734; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oVqWreGFCxOxEVN1cMXNwqHjmBSo3Eq8G8YAa3svd0c=; b=ldYVlQis64SkcKj7sHPq36/4Kh2VcBQ5rBf2PJY003cF0S+c9rRImKDUaErdxDXlofatpo1st5zmG1rtTZZD4OmPh8UV+In/pCguq5Lb6wQDa3OtbzvjUbn9ZG+/NUN60GNcF+4UiAAwFgDv4e4uWigHAWCe07TRL6baIAZVH8k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772733734480381.37074194146066; Thu, 5 Mar 2026 10:02:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyCzd-0004E6-LZ; Thu, 05 Mar 2026 13:00:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyCy7-0000IM-8u for qemu-devel@nongnu.org; Thu, 05 Mar 2026 12:58:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vyCy4-0003n0-3N for qemu-devel@nongnu.org; Thu, 05 Mar 2026 12:58:38 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138--RGcB68tMT2YvMvKYIbGqg-1; Thu, 05 Mar 2026 12:58:32 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 242B418002C7; Thu, 5 Mar 2026 17:58:31 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.32.26]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 619823003E9E; Thu, 5 Mar 2026 17:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772733515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVqWreGFCxOxEVN1cMXNwqHjmBSo3Eq8G8YAa3svd0c=; b=hk4NmExKDvZsd1zENzWpjPW02EBIlCxa729F+gxjgMu2xscaLtXv49O+HWfFq1/+8wPGCx rDTeN+j7+syAfRa5/o2TXXJUqmOF6WqQ9x0qpP7Qkz62Lst9Kx+Hj6HuquAD6OK2Cj0xgj sf0EnOhsGEFLCrq+nsxXNLPSqhUQqiw= X-MC-Unique: -RGcB68tMT2YvMvKYIbGqg-1 X-Mimecast-MFC-AGG-ID: -RGcB68tMT2YvMvKYIbGqg_1772733511 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , Jithu Joseph , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 28/38] hw/i3c/mock-i3c-target: Simplify GETMRL byte extraction logic Date: Thu, 5 Mar 2026 18:57:01 +0100 Message-ID: <20260305175711.1119025-29-clg@redhat.com> In-Reply-To: <20260305175711.1119025-1-clg@redhat.com> References: <20260305175711.1119025-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.892, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.622, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772733736285154100 From: Jamin Lin The GETMRL handling logic extracted MSB/LSB bytes from s->cfg.buf_size using a mask-and-shift expression: (buf_size & (0xff00 >> (offset * 8))) >> (8 - (offset * 8)) While functionally correct, the expression is difficult to read and obscures the intent, which is simply to return a 16-bit value in MSB-first order. Replace the mask/shift formula with explicit MSB/LSB extraction: offset =3D=3D 0 -> buf_size >> 8 offset =3D=3D 1 -> buf_size & 0xff This makes the code clearer and easier to review without altering behavior or data ordering. No functional change. Signed-off-by: Jamin Lin Reviewed-by: Jithu Joseph Link: https://lore.kernel.org/qemu-devel/20260303013322.1297499-5-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/i3c/mock-i3c-target.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/i3c/mock-i3c-target.c b/hw/i3c/mock-i3c-target.c index b99709a08b52..1ae2cf9e1de1 100644 --- a/hw/i3c/mock-i3c-target.c +++ b/hw/i3c/mock-i3c-target.c @@ -146,9 +146,12 @@ static int mock_i3c_target_handle_ccc_read(I3CTarget *= i3c, uint8_t *data, if (s->ccc_byte_offset >=3D 2) { break; } - data[s->ccc_byte_offset] =3D (s->cfg.buf_size & - (0xff00 >> (s->ccc_byte_offset * 8= ))) >> - (8 - (s->ccc_byte_offset * 8)); + if (s->ccc_byte_offset =3D=3D 0) { + data[s->ccc_byte_offset] =3D (uint8_t)(s->cfg.buf_size >> = 8); + } else { + data[s->ccc_byte_offset] =3D (uint8_t)s->cfg.buf_size; + } + s->ccc_byte_offset++; *num_read =3D num_to_read; } --=20 2.53.0