From nobody Sat Apr 11 23:03:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772708061; cv=none; d=zohomail.com; s=zohoarc; b=UloKUW9AoLyA9jX4TCtWeE5jlc6scJ+DLiSunJf3WJCqLNTCKkSG9o/uAKlooxG8g23b9sh6kAUBUBoeMHutFFK+r/Rpnf6apByugrKtbhueOQEMJn7TN3gE7URgC+yDoXcyB7rxep7+6PB6q536FrMX6CKhB1JBCqTanB2nNv0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772708061; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6ekLPVHYOVkLZAradQmSaJNW1TZzwmRdnf71YAxurjM=; b=OBTBSeUkaBmS5i0yz2wq+z7S3J5neGaYJttam7l7DWWEHpIntKiT+Vj3w/Na8StCQEZELkON10JV31f9+1FIhf49Ccj121pKXvAs0jtPO3ATkSi4gQcM0SfGrTGYrXAF1VOHvPsqMA+7k4UWhOjnNfdf6yVAJc4a2S8gciyCKwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772708061467972.3248689040425; Thu, 5 Mar 2026 02:54:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vy6KN-0001ss-2S; Thu, 05 Mar 2026 05:53:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vy6KK-0001s3-Nz for qemu-devel@nongnu.org; Thu, 05 Mar 2026 05:53:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vy6KI-0005Wc-NO for qemu-devel@nongnu.org; Thu, 05 Mar 2026 05:53:08 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-O5rzmCneONaPHOuIok8u9Q-1; Thu, 05 Mar 2026 05:53:02 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C7C09195605C; Thu, 5 Mar 2026 10:53:01 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.75]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B5A743003E98; Thu, 5 Mar 2026 10:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772707985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ekLPVHYOVkLZAradQmSaJNW1TZzwmRdnf71YAxurjM=; b=aLSk1+kLGRuKPc21Jr7EQolPgGCWRFA+blww4B1292yIPKwtKuhtHCicUSxXC/SJIE1jK3 239W0aZ5Cq1LCKkFBnjORkXdYiHT96BWx4cQQBdEFi6xhcrcSBav270TPknP6YRgC9f1nG IQPGG/2Y4j3q8ffeJtI4nno2RXHTxd4= X-MC-Unique: O5rzmCneONaPHOuIok8u9Q-1 X-Mimecast-MFC-AGG-ID: O5rzmCneONaPHOuIok8u9Q_1772707981 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Igor Mammedov Subject: [PULL 13/28] hw/net/virtio-net: Remove VirtIONet::mtu_bypass_backend field Date: Thu, 5 Mar 2026 11:52:00 +0100 Message-ID: <20260305105215.302571-14-thuth@redhat.com> In-Reply-To: <20260305105215.302571-1-thuth@redhat.com> References: <20260305105215.302571-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 33 X-Spam_score: 3.3 X-Spam_bar: +++ X-Spam_report: (3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.703, RCVD_IN_VALIDITY_SAFE_BLOCKED=1.386, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772708062539154100 From: Philippe Mathieu-Daud=C3=A9 The VirtIONet::mtu_bypass_backend boolean was only set in the hw_compat_2_9[] array, via the 'x-mtu-bypass-backend=3Doff' property. We removed all machines using that array, lets remove that property and all the code around it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20250501210456.89071-17-philmd@linaro.org> Reviewed-by: Igor Mammedov [thuth: Adjusted patch for latest changes in the master branch] Signed-off-by: Thomas Huth Message-ID: <20260225092024.794595-14-thuth@redhat.com> --- include/hw/virtio/virtio-net.h | 1 - hw/net/virtio-net.c | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h index 5b8ab7bda79..371e3764282 100644 --- a/include/hw/virtio/virtio-net.h +++ b/include/hw/virtio/virtio-net.h @@ -218,7 +218,6 @@ struct VirtIONet { uint64_t saved_guest_offloads; AnnounceTimer announce_timer; bool needs_vnet_hdr_swap; - bool mtu_bypass_backend; /* primary failover device is hidden*/ bool failover_primary_hidden; bool failover; diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index eccb48ad426..2a5d642a647 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -935,8 +935,7 @@ static void virtio_net_set_features(VirtIODevice *vdev, int i; =20 virtio_features_copy(features, in_features); - if (n->mtu_bypass_backend && - !virtio_has_feature(vdev->backend_features, VIRTIO_NET_F_MTU))= { + if (!virtio_has_feature(vdev->backend_features, VIRTIO_NET_F_MTU)) { virtio_clear_feature_ex(features, VIRTIO_NET_F_MTU); } =20 @@ -3160,8 +3159,7 @@ static void virtio_net_get_features(VirtIODevice *vde= v, uint64_t *features, vhost_net_get_features_ex(get_vhost_net(nc->peer), features); virtio_features_copy(vdev->backend_features_ex, features); =20 - if (n->mtu_bypass_backend && - (n->host_features & 1ULL << VIRTIO_NET_F_MTU)) { + if ((n->host_features & 1ULL << VIRTIO_NET_F_MTU) !=3D 0) { virtio_add_feature_ex(features, VIRTIO_NET_F_MTU); } =20 @@ -4251,8 +4249,6 @@ static const Property virtio_net_properties[] =3D { DEFINE_PROP_UINT16("tx_queue_size", VirtIONet, net_conf.tx_queue_size, VIRTIO_NET_TX_QUEUE_DEFAULT_SIZE), DEFINE_PROP_UINT16("host_mtu", VirtIONet, net_conf.mtu, 0), - DEFINE_PROP_BOOL("x-mtu-bypass-backend", VirtIONet, mtu_bypass_backend, - true), DEFINE_PROP_INT32("speed", VirtIONet, net_conf.speed, SPEED_UNKNOWN), DEFINE_PROP_STRING("duplex", VirtIONet, net_conf.duplex_str), DEFINE_PROP_BOOL("failover", VirtIONet, failover, false), --=20 2.53.0