From nobody Sat Apr 11 21:31:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1772726765; cv=none; d=zohomail.com; s=zohoarc; b=jYspH8XeBdsOsY4dmGVcSyNbt9dmVT8592N1oLat7TgtNFpGxqsPioF7w80IHexi+xlmAGBnPNB+yoxG4/iBmoayxf7Gfdo1pqTrFnKetgzoTsqysOMMW2NHvoNp+0Eti8gQ0SO6lH6wHB8JvE3iX6eVS5HsoPEtJt5He8/QBbU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772726765; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zHhsPPDLkdSeU9tjRW5N7Haoe6QZcMPx6LMe84vrOkg=; b=J6YXDsNKnONearn7AajISdM5rCpw7a0L2mCOz1No61ifzT3eCNsvk9cCeD7sGCtFfmP2UZh/yKoHjnIzhGEZU+tugCvA+SZrg0NXCO0DMVftE73RTdhOpC4hLmgtQTDGwlHLnXxmtcvko4uLlD11AD4tnRnsVKZ9U0TQLiqZny4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772726765766946.6401481293184; Thu, 5 Mar 2026 08:06:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyBCW-0002rL-P6; Thu, 05 Mar 2026 11:05:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3r6mpaQcKCvwtijspi2ksskpi.gsquiqy-hiziprsrkry.svk@flex--pefoley.bounces.google.com>) id 1vyBCO-0002qu-7S for qemu-devel@nongnu.org; Thu, 05 Mar 2026 11:05:16 -0500 Received: from mail-yx1-xb149.google.com ([2607:f8b0:4864:20::b149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3r6mpaQcKCvwtijspi2ksskpi.gsquiqy-hiziprsrkry.svk@flex--pefoley.bounces.google.com>) id 1vyBCH-0002Zd-Cs for qemu-devel@nongnu.org; Thu, 05 Mar 2026 11:05:11 -0500 Received: by mail-yx1-xb149.google.com with SMTP id 956f58d0204a3-64c42aa5d66so14080073d50.0 for ; Thu, 05 Mar 2026 08:05:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772726704; x=1773331504; darn=nongnu.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zHhsPPDLkdSeU9tjRW5N7Haoe6QZcMPx6LMe84vrOkg=; b=u/Jolj5sd6LwD5FVWZl6yC5EAsJak2J+vihOtnAf8SbDX8AZpMELlk9dr8JLCmCs6I P/vbRIiXkz6H5OPc8PCe4/bJBU+tGCAM9jxXfKLTfiSNqfZ7HSTGsSciUB3xmnswQLTA 1ejBq1jqPqXHe0PqNJ6pLJWZEGc6iaVaLmhOIuAH86/vlcldMuB9CUTuqYVETESDw8gZ 4gVrOSk09cqVdEpdngMlMd1xwL2E3UyN4VPy7uk0JP8Q+eCCSZJSdmY0B5qzkwfnNleL YqrR7xJVCzSfK51Te/Gxw/VZ6ZZ6ai/wEVBC1Dndip4I2O0la1wAwKmrgctkKCasPmGg tWlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772726704; x=1773331504; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zHhsPPDLkdSeU9tjRW5N7Haoe6QZcMPx6LMe84vrOkg=; b=oOVT+jWiAEPoiLiMFX0P+9v0mWusc9zL92lf/+UFt5UHFt9/QF9ufJwts3hx8XjA1v /kW2Tp80uBXEeVDUJ462guYPOvUSt7JlZwRIhAdKYMUW+qnXvhfIbuAgdBiK2OTKhS/+ gz+dtSWgfH3eLLEAYBDan3+lZ5RzvdC46a1p0Go5yaKMUk7kVBPFpSUL7cSVMyZ8QSkj 2ERtn7G5yLEbJvqqiqAszgi2QFYIur+zKJYcW4Vj18S4Y+mo2H7DYIZ5T/fYJf+iLkiF Oz6gNOSRFJBN2zuOvSp+j/CBx4w/Ll/hqjU9vdaZH61OgYRzArqBfABNeEZ4KNFXd3gq LWmA== X-Gm-Message-State: AOJu0Yx8PvZRz18scXO/g3ITYyU3/GN07OCz4kLM9zZmS9zsAEly53nZ QXJ/FYaJWqFJ7piT8mKmE5o0mwyAWEyGfDHibIeyJIdY/1W/wBsVdWVIaJ8w52DYgE64a7pK8ig 4p3uXudCCXOhW0UF8myvDU3cEuJ2awrKBe2qmou9szUUY99tb1EbSbb0VsgelorCZ3Z/D7NcAKh tBs4U6bro93Iaq8w/y/3JDa9fB/oHeirvL4hr7Q9az X-Received: from yxiv7.prod.google.com ([2002:a53:b007:0:b0:64a:ef75:1b5]) (user=pefoley job=prod-delivery.src-stubby-dispatcher) by 2002:a05:690e:429b:20b0:644:60d9:8648 with SMTP id 956f58d0204a3-64d10d275fcmr132512d50.87.1772726703947; Thu, 05 Mar 2026 08:05:03 -0800 (PST) Date: Thu, 05 Mar 2026 11:04:56 -0500 In-Reply-To: <20260305-passt-v2-0-f0582198afc0@google.com> Mime-Version: 1.0 References: <20260305-passt-v2-0-f0582198afc0@google.com> X-Mailer: b4 0.14.3 Message-ID: <20260305-passt-v2-1-f0582198afc0@google.com> Subject: [PATCH v2 1/2] Only kill passt if it wrote a pidfile From: Peter Foley To: qemu-devel@nongnu.org Cc: Jason Wang , Laurent Vivier , Peter Foley Content-Type: text/plain; charset="utf-8" Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::b149; envelope-from=3r6mpaQcKCvwtijspi2ksskpi.gsquiqy-hiziprsrkry.svk@flex--pefoley.bounces.google.com; helo=mail-yx1-xb149.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1772726768344154100 Content-Transfer-Encoding: quoted-printable Avoid killing qemu if passt failed before writing a pidfile. pid is initialized to 0, so calling pid in this scenario would kill the entire process group. Reviewed-by: Laurent Vivier Signed-off-by: Peter Foley --- net/passt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/passt.c b/net/passt.c index 9ed811a514..b3d4b71314 100644 --- a/net/passt.c +++ b/net/passt.c @@ -102,7 +102,9 @@ static void net_passt_cleanup(NetClientState *nc) } #endif =20 - kill(s->pid, SIGTERM); + if (s->pid > 0) { + kill(s->pid, SIGTERM); + } if (g_remove(s->pidfile) !=3D 0) { warn_report("Failed to remove passt pidfile %s: %s", s->pidfile, strerror(errno)); --=20 2.53.0.473.g4a7958ca14-goog From nobody Sat Apr 11 21:31:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1772726752; cv=none; d=zohomail.com; s=zohoarc; b=eay83q7XLUepsOPsn3MDypli7lISvOvbX3SlA3WxCVNx6tWlzsR1zedLyYUYp9OPW9K1ZoteDPDu0/WlqXKTXSLKAFB100VXB3XD3E+kkgB7MezJ3V3cPkD50AZwsRVZdRbHyDiyQB4CcAzoTf/6Bdke2f4wyfFTVqaCPOvlfS0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772726752; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Rmz6hcKCoQK2IWrB3YiSRHYszKxMw9qvE6cNbjLHzdA=; b=dYuCw6vCt8f23b04J6UtTTb8vDoAGUJUsBYY8agC3TIP95YPTBDpLdaD+lTWVUlhJ97I2sBBs6g+dcqXKoKKC5IqwHSvC3yULcBFs3wVk9PiVNU02cIVi4MhiHBdzZHlpx6w5hB/r3NdTVIyOR+MUVt8ZVv/byWroAOn9Qlgav4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772726752199665.6510854100444; Thu, 5 Mar 2026 08:05:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vyBCY-0002ty-8I; Thu, 05 Mar 2026 11:05:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3sampaQcKCv4vklurk4muumrk.iuswks0-jk1krtutmt0.uxm@flex--pefoley.bounces.google.com>) id 1vyBCV-0002rN-TK for qemu-devel@nongnu.org; Thu, 05 Mar 2026 11:05:24 -0500 Received: from mail-yx1-xb14a.google.com ([2607:f8b0:4864:20::b14a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3sampaQcKCv4vklurk4muumrk.iuswks0-jk1krtutmt0.uxm@flex--pefoley.bounces.google.com>) id 1vyBCL-0002Zm-KM for qemu-devel@nongnu.org; Thu, 05 Mar 2026 11:05:17 -0500 Received: by mail-yx1-xb14a.google.com with SMTP id 956f58d0204a3-649f0d26e5eso11042825d50.0 for ; Thu, 05 Mar 2026 08:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772726706; x=1773331506; darn=nongnu.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Rmz6hcKCoQK2IWrB3YiSRHYszKxMw9qvE6cNbjLHzdA=; b=krMUfyHDA/lH7we7lIY7Eg3uzZ3/cG8/tdYRElY0BG6rees+9B/2XRv7IvmRfQaEv8 13JWKBvnA/t+j1Ptch3G8qEx1NbUC+6hZDJH+0lR4ig03jP7wp5MBF0F7Du4ua4FiIN6 GnLNdyY7WshhKICLaaYa8Pyfgyocqp28fI4ugI+tECzZpXn0UMCsxxWZ7gEYe7V3JhWs dgEMItv9o93q1OCfs/TU6DJ3XqCLdo7xhDZaPYlW0O6ZeezKMapPDzo2p9catROM/U66 NJXBugk2ZqntGmrDpjr5miNBlmru4Bh5w47cm3ncpepO0II6WZQiBRVlZmjYb+snUbt8 JV7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772726706; x=1773331506; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rmz6hcKCoQK2IWrB3YiSRHYszKxMw9qvE6cNbjLHzdA=; b=nuHHhyBBiLeNHeDnKmFSHDrbV1cjRPplCIWR0uX4k9/px5VEgPee5gr0oIpFS8BLlf LkbsBcRTzmjOyQEF96y9XMkk/gUm7EkntvNGnDff3ikfoSiv++LwO01LIkeQK9O05WeS hfgo2myvIRJGBlbq/iPlZU5aztI/CtwyRgmFly30/MSIgV1GqjN7+kyxY01RtYPFc96D NsrLzZfieXx7Ajl8+Y8n8LNNh/0/z/V5/+zXAyjlXiDEYi+HMbGNd4UmSXdfhaIUE64K FPr+FSNWDYSLm4r8fFwQVcuD+CPy2L+Qmx5mirJG+MW74eKv3fLIHfTXlVvdjYXObXP3 lVYw== X-Gm-Message-State: AOJu0YxO22Htg9anTQD1yXl26BEswkARQpK5f/oI+MfLLJI4mf2jZyw/ jU9RUb31nM1kgk1adRrdsls7svT3LcrhKIvx8KqHndPVcYz3VLJjiD66IiKSu0uU3V7HEN58Iy0 VT00yj6rYdBqXG/LaFM1yFtUvhyk/+NUEscyi4U47zlbBFVIYjLhfZwCw/FXLBzO4mXm6UHyT8z RMoPD/Csl0XiyOnSPB0d56835+I9NTxRgFKBuDxVrm X-Received: from yxdv8.prod.google.com ([2002:a05:690e:448:b0:64c:9860:71ef]) (user=pefoley job=prod-delivery.src-stubby-dispatcher) by 2002:a05:690e:4086:b0:64c:a7d9:e1dc with SMTP id 956f58d0204a3-64cf9b27c92mr4799256d50.4.1772726705239; Thu, 05 Mar 2026 08:05:05 -0800 (PST) Date: Thu, 05 Mar 2026 11:04:57 -0500 In-Reply-To: <20260305-passt-v2-0-f0582198afc0@google.com> Mime-Version: 1.0 References: <20260305-passt-v2-0-f0582198afc0@google.com> X-Mailer: b4 0.14.3 Message-ID: <20260305-passt-v2-2-f0582198afc0@google.com> Subject: [PATCH v2 2/2] Don't try to read the pidfile if passt got a signal From: Peter Foley To: qemu-devel@nongnu.org Cc: Jason Wang , Laurent Vivier , Peter Foley Content-Type: text/plain; charset="utf-8" Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::b14a; envelope-from=3sampaQcKCv4vklurk4muumrk.iuswks0-jk1krtutmt0.uxm@flex--pefoley.bounces.google.com; helo=mail-yx1-xb14a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1772726754424154100 Content-Transfer-Encoding: quoted-printable g_subprocess_get_if_exited returns false if passt was killed by a signal, s= o we fall through to trying to read the pidfile. Update the error when passt exits to include the exit code. Reviewed-by: Laurent Vivier Signed-off-by: Peter Foley --- net/passt.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/net/passt.c b/net/passt.c index b3d4b71314..4ff94ee509 100644 --- a/net/passt.c +++ b/net/passt.c @@ -270,8 +270,17 @@ static int net_passt_start_daemon(NetPasstState *s, in= t sock, Error **errp) return -1; } =20 - if (g_subprocess_get_if_exited(daemon) && - g_subprocess_get_exit_status(daemon)) { + if (g_subprocess_get_if_exited(daemon)) { + gint status =3D g_subprocess_get_exit_status(daemon); + if (status) { + error_setg(errp, "Passt exited with code %d", status); + return -1; + } + } + + if (g_subprocess_get_if_signaled(daemon)) { + error_setg(errp, "Passt killed with signal %d", + g_subprocess_get_term_sig(daemon)); return -1; } =20 --=20 2.53.0.473.g4a7958ca14-goog