From nobody Sat Apr 11 21:30:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772701396; cv=none; d=zohomail.com; s=zohoarc; b=Si0HaqZyR3s53lfEyspgzB4NDOVyinkWU3J+vQewEPOSufKSS/rVG1AdLueDipZo+Kf8vKqwPp5OjEbbnPNT2D18YJ453h5a7Ny5Bsa0sfvpaSd4HZcIrG4W9jNHBhiBIknh9Sy7E94ByFYiJzxIdMnP2HPwOMcE/g/03QJx4eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772701396; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8QoUGmUAa3KUwJmVXNGxYKSxT0FoPFd3CLt2SlmodI8=; b=gDaVjfaAiTOn1/q/W5rrFWRvlX6s6NEwx8lwIgw3OAjTF5cTjEoRyF9vkyMWXLaq6fmsehXCQvP3GucWnknETBNJvylwYYSmeSVZYLFKoChyY15GkfIUsHfoY5MRlxn/O6h8qnpWSdqYiBObsgCOezMEojQXpblFMJy7c5u6c0o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772701396710601.3407590818443; Thu, 5 Mar 2026 01:03:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vy4bb-0004jE-AY; Thu, 05 Mar 2026 04:02:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vy4bX-0004il-F3 for qemu-devel@nongnu.org; Thu, 05 Mar 2026 04:02:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vy4bU-0006ms-Fb for qemu-devel@nongnu.org; Thu, 05 Mar 2026 04:02:46 -0500 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-vth4Yo9xNn2dYwxMagJDUg-1; Thu, 05 Mar 2026 04:02:40 -0500 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4836abfc742so62401465e9.0 for ; Thu, 05 Mar 2026 01:02:40 -0800 (PST) Received: from lleonard-thinkpadx1carbongen13.rmtit.csb ([176.206.19.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fb27a20sm60045395e9.9.2026.03.05.01.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 01:02:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772701362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8QoUGmUAa3KUwJmVXNGxYKSxT0FoPFd3CLt2SlmodI8=; b=TmtQctibMbPxa+A+1idgiWTMlWJY1TMyUNOCuJAu/sfcASlB1WIFMUIWp/ut2F7143o/bD IEY/srOuBA/NuxRK81q3kYY3r15hpWunz/wyLpVJO/Lb3NL7lxQIMEa+bgLOZY2GSQkqji 0panTCV7Gw0W8ZBypvhzhAsTItopanM= X-MC-Unique: vth4Yo9xNn2dYwxMagJDUg-1 X-Mimecast-MFC-AGG-ID: vth4Yo9xNn2dYwxMagJDUg_1772701359 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772701359; x=1773306159; darn=nongnu.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8QoUGmUAa3KUwJmVXNGxYKSxT0FoPFd3CLt2SlmodI8=; b=UeZK8eiRF4YNnYAseTNHw69BdaGFFl9nV9uiKL0Q2m4ZwTe5O0Pqq0Y9Cba3ia0moa qF0nuMte+BMzvbmglxkh2YVPaCzmLI3GNC5MN1JmUUwqCHXd6dxKf3A+q3z9dahgRbA3 X5iVLj5afFhDts3kbpcg/GZZC6yhj8EIe18a6VOmmSmqVSSkdjVcuGQtIM9ByucrwGam brjGUssz9QOswdTsO5DfQwomgO6eJ0ag56DLhobKR5lg1g090g2KLO8PPeSfbNIujvdo jdDdLdv0lceAS/0lJJigZz0Xp7es6xJ9Yjovoi//3DVNI64k/j6kab2clDTQFiFU2B4L 8kCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772701359; x=1773306159; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8QoUGmUAa3KUwJmVXNGxYKSxT0FoPFd3CLt2SlmodI8=; b=nq/hkP/gyjdnVaoGyHueVr0XRsukTASaejbWhOYv/sRLhoFrLdsqQ8eD3UyobZPALA yTCZF0LvjKuMORxnRA+5icCQnmSK1KQnIgaWXFLTzEzHHgeH4rtGWUszWpIKrLGxtPR0 24lfhaU6Y9N0gxFe7RSXt0boTd/0ko2OBIgy/5dSxBDJ9fjxI4U//HiN1P9rNu6e/3Vo Tpvc90YvciCa4CAw3P4h9WN35BTPu32zdp8Y+rYvaAAYdIloqs0bvf9ifzqzKfDbprIi 0nLhanIc9c93k+IyuV9Wg1/lMKWj6uyMDCKf9Hm4neNFBZPbpebEfR8By1uuL4mPq463 MTxA== X-Gm-Message-State: AOJu0Yx/wsRBNeDzuw889g8ci3/GxZLqWoDTllGoJw62w6GLPPa9akBX EhW84/z3tngrBuCpWL9PlvpzYWy3NtF21P7khAwZJqnTjc34Y+Ze+r20UP3PMijndY6/E0AMihx Ul60TEL7CHzIBAhJQpdvVwdElEnIz9K/lWOIWuPbr3iB0d5iFtJG4IbwC X-Gm-Gg: ATEYQzzskfx5deNqC7giZsQrgHjqLSKCV8JQcPY+EaaHFAWOXXHE3qIH01g6q9NAvXW eL0LRVXPidt2JOTfkLaH1vNzx/vgBaTM1Qu2dLf0Gj/5tbVZPGUXNGOlpw9bvBGDaDd+kKqkzTM aDLBMGGvrjka3/qeo7lTVJIffNcdU20z3o1a6zVFurMafJiVysJU9dpte9Ue4eYZzsBt4wTJD0L B43AnP5OvfHYeKJhdAOV32jhXUR/G5TwCTzGjp9hZ9Pu6huOEs+B3zwOhe/jEOVZvvC3ftkdar3 msiZ4K6P/QTkIx6bCGaoQBV6JC3ebnDI+ew/6BcB+yL0dW6SVLBUaAAxPWjcXwMB7sjA7Fn92xA VOGnAsOwEDKkSEC4UOvD9178DtgISr+W1DDnHh7egsOJPRiomXwawfKWvwdaa X-Received: by 2002:a05:600c:4454:b0:483:702f:4633 with SMTP id 5b1f17b1804b1-4851982700amr74233775e9.4.1772701359229; Thu, 05 Mar 2026 01:02:39 -0800 (PST) X-Received: by 2002:a05:600c:4454:b0:483:702f:4633 with SMTP id 5b1f17b1804b1-4851982700amr74233265e9.4.1772701358745; Thu, 05 Mar 2026 01:02:38 -0800 (PST) From: Luigi Leonardi Date: Thu, 05 Mar 2026 10:02:11 +0100 Subject: [PATCH] igvm: fix build when igvm is not installed in a well known path MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-master-v1-1-6574442f5ee8@redhat.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYwNT3dzE4pLUIt1UQ0OLJGOLVGNDk1QloOKCotS0zAqwQdGxtbUAfb8 CSVgAAAA= X-Change-ID: 20260305-master-e118b38e314e To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Stefano Garzarella , Ani Sinha , Paolo Bonzini , osteffen@redhat.com, Luigi Leonardi X-Mailer: b4 0.14.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=leonardi@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 0 X-Spam_score: -0.0 X-Spam_bar: / X-Spam_report: (-0.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.703, RCVD_IN_VALIDITY_SAFE_BLOCKED=1.386, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772701398376158500 `stubs/igvm.c` includes `igvm-internal.h`, that in turn includes the igvm l= ibrary. This is required just for the QIgvm declaration and creates an unnecessary dependency on the library. Since igvm is not listed as a dependency of stubs, this results in build failing when the library is not installed in a "well known" path of the system. Add a forward declaration for QIgvm and move the definition of `qigvm_directive_madt` to `igvm.h` so that we can drop `igvm-internal.h` fr= om `stubs/igvm.c`. Fixes: dea1f68a5c ("igvm: Fill MADT IGVM parameter field on x86_64") Suggested-by: Stefano Garzarella Signed-off-by: Luigi Leonardi --- include/qemu/typedefs.h | 1 + include/system/igvm-internal.h | 5 ----- include/system/igvm.h | 5 +++++ stubs/igvm.c | 1 - 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index 416a8c9acead659786f22dfa7542f7af93699cec..cbe6f7f4c7c1092017296cbba09= cc79b03b45b79 100644 --- a/include/qemu/typedefs.h +++ b/include/qemu/typedefs.h @@ -102,6 +102,7 @@ typedef struct QEMUSGList QEMUSGList; typedef struct QemuSpin QemuSpin; typedef struct QEMUTimer QEMUTimer; typedef struct QEMUTimerListGroup QEMUTimerListGroup; +typedef struct QIgvm QIgvm; typedef struct QList QList; typedef struct QNull QNull; typedef struct QNum QNum; diff --git a/include/system/igvm-internal.h b/include/system/igvm-internal.h index 38004bd908e773a3ffc2343a9035be86dc6a8ace..1d36519ab082c02e27461e94850= a1ccf6b583e66 100644 --- a/include/system/igvm-internal.h +++ b/include/system/igvm-internal.h @@ -74,9 +74,4 @@ IgvmHandle qigvm_file_init(char *filename, Error **errp); QIgvmParameterData* qigvm_find_param_entry(QIgvm *igvm, uint32_t parameter_area_index); =20 -/* - * IGVM parameter handlers - */ -int qigvm_directive_madt(QIgvm *ctx, const uint8_t *header_data, Error **e= rrp); - #endif diff --git a/include/system/igvm.h b/include/system/igvm.h index 5573a6111ae754e2de49ba72a354b36c4b6fe747..f9231f03ec8015928d0968ac59c= 72a1b6d9f00b9 100644 --- a/include/system/igvm.h +++ b/include/system/igvm.h @@ -27,4 +27,9 @@ int qigvm_x86_get_mem_map_entry(int index, int qigvm_x86_set_vp_context(void *data, int index, Error **errp); =20 +/* + * IGVM parameter handlers + */ +int qigvm_directive_madt(QIgvm *ctx, const uint8_t *header_data, Error **e= rrp); + #endif diff --git a/stubs/igvm.c b/stubs/igvm.c index 47d5130d9d7488fb1092a0b5389a864d83e8b2f2..9e9f683fc9607bae85baaaa2f26= 9eba594ae0574 100644 --- a/stubs/igvm.c +++ b/stubs/igvm.c @@ -12,7 +12,6 @@ #include "qemu/osdep.h" =20 #include "system/igvm.h" -#include "system/igvm-internal.h" =20 int qigvm_x86_get_mem_map_entry(int index, ConfidentialGuestMemoryMapEntry *entry, --- base-commit: 333aaa55f051977cc897fb71e0a9ed52bb00a675 change-id: 20260305-master-e118b38e314e Best regards, --=20 Luigi Leonardi