From nobody Sun Apr 12 00:57:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772643127; cv=none; d=zohomail.com; s=zohoarc; b=QU9768sVYjH1ZdhqGC4W/BUP/G5lTwdD/Nm/OxSjKxChJNBlyDmtfRrwJzeR+CuWEpv18MX3sYxbPV9rGEer1ZHeZwaYSxThM5YmO9Rf4O0zUZC+No+f4RJjsWBPhgxsIIbLc+Hjld6vVydJXVINpDhSTeGxekpAcQytU0UXjWo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772643127; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=e5chmRJdStSTBUIyVExBHarHbJeDveLuSTCJqeJVI00=; b=X/bc6HiAZfIh3pooRt8W/EmxlkqrqTfYqsgK1PfiDEXallak33k88y/rG8YI8hGQRb9jP8vsWJmvmgZkljTrNWlfxYCMTawyD6XDji6FeZqo9HRKFxsqmYaeuz59D/1Bj3CHlzdFTycKxYtTNH1RY9qqs5IV4u8hlCY/2D85yy4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772643126964656.9090655970971; Wed, 4 Mar 2026 08:52:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxpR2-0003sh-S9; Wed, 04 Mar 2026 11:50:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxpQy-0003pX-Cz for qemu-devel@nongnu.org; Wed, 04 Mar 2026 11:50:52 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxpQv-0002PQ-Pw for qemu-devel@nongnu.org; Wed, 04 Mar 2026 11:50:52 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-660dcafc85aso2140367a12.0 for ; Wed, 04 Mar 2026 08:50:48 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65fabd4695bsm5941312a12.12.2026.03.04.08.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 08:50:45 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 014915FD5B; Wed, 04 Mar 2026 16:50:44 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772643047; x=1773247847; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e5chmRJdStSTBUIyVExBHarHbJeDveLuSTCJqeJVI00=; b=Q2kL+I9wUYbVepJ1wqsmGXWU9/Qhgo4AGB6EZoesUn2HV0FUw9mGyifBT+zKCqkaEO ifkePFgcOSOvzGZZefNFoqUVL73w0qXaG6VPglxaGXBAqi19fNV27xgYYkjdu/AXDGfH lLhwodLh54zZj7Igz0kPXFeYDWe+DMUoeLAZ62nF4AL+FSTYWLVWoaMt1x63JlHz3wV0 FKhLj9SBz9x0qUdiT7c3nnDUp4QbBmP8PlRPQe19a9TUffUuESgbO2lk+Pa4CptgocZx c9/ufjhu4bXv9dF5dUTg1RHKph2anU8fIlBUfjyAbZBjrmxnP7TMjNGAGUVp6C7aS+8o HrNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772643047; x=1773247847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e5chmRJdStSTBUIyVExBHarHbJeDveLuSTCJqeJVI00=; b=T+uMU9U29PqZSLKwEA1fE9guldmKHiYiiYnJjmsbr+vaPaOBMTKgmznpeu21PJTw1w MV0++GffPiAMyKemgda1f/F6Tm6V5zRd9s/XJnW6sTeKThwyIk8QVanjav5OYay+zxA+ M8avxu+udqo+7kbQxnvnKaHiJUYn2dvteYkcu3hYvMgEtQhAN7A+86+EBgcGnJeoQpLD RCDOxT4VfAG1qF2iSQg7C4Q2KhCf5XFGzQe5YIqSIp+47pjiloq+uVEL68HCSwOsLxLp tdDtLY9h35HUmpxEdToFxljFMXiJzUU2YV3BzYQXt33QsgJ/q06mLSUwupTcSwrmpATu msIw== X-Gm-Message-State: AOJu0YyDjJCrp8vnDVUtnQaHiw56aRm9DIwOcP/E0QGaXPv+IScoILLL CgR4hwQ4KzphNgBrnDTOaZfFqT/No3qcUQc+4a1YR4ml1PiF1t15FFjj+P/ZAG1Bp5U= X-Gm-Gg: ATEYQzxllFiYqxHq3KP4/Ik+ytlfO7nE06qw362RnrYXMyVe8EBmspl/cV14MNgsco2 CBlua0BUysVgGYgZYsT3/k1zZOBzOeRj0wTYBysBYfJFwpzD/2YNBY1pLEsPIbLiCs14Rk3N9XE RPWZCWkmDKvHEJgqXahzucjWUdJ81FHH2ryEDgvqOPd494SkSb5XZuGTsrZOwiQj3CAJB7jEBFp NoN9p+mwCV+BlGUYgoypiBzl3PVWQXKDOKL+OIcFbDkI4Xvwv2+V7zEjCcQDXETN7MmwZobDU/F V6EH6FCKX376Kz6MkZbHef/sEK/qSLrt1cwKbVEHledGNYHyxDzF0aEZOB3uu/u70xjBGjShKtf nOvy8MA2LfL17hQQ/kgkadmb2zrgLlbdx/41dDQlT//DXEgNuG9KeTjMGURoAVX4Lv+BQsjuyLl +3or2AnMX+QKlhifTCKwTbhCbPuMjvleaG6Q== X-Received: by 2002:a50:85c8:0:b0:660:f98d:227e with SMTP id 4fb4d7f45d1cf-660f98d2539mr845874a12.23.1772643047221; Wed, 04 Mar 2026 08:50:47 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Peter Xu , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , David Hildenbrand , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Markus Armbruster , Akihiko Odaki , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Eric Blake , "Michael S. Tsirkin" , Dmitry Osipenko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Akihiko Odaki , Pierre-Eric Pelloux-Prayer , Yiwei Zhang Subject: [PATCH 03/20] ui/gtk: Don't disable scanout when display is refreshed Date: Wed, 4 Mar 2026 16:50:25 +0000 Message-ID: <20260304165043.1437519-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260304165043.1437519-1-alex.bennee@linaro.org> References: <20260304165043.1437519-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772643128322154100 From: Dmitry Osipenko Display refreshment is invoked by a timer and it erroneously disables the active scanout if it happens to be invoked after scanout has been enabled. This offending scanout-disable race condition with a timer can be easily hit when Qemu runs with a disabled vsync by using SDL or GTK displays (with vblank_mode=3D0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Benn=C3=A9e Acked-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Yiwei Zhang Signed-off-by: Dmitry Osipenko Message-ID: <20260303151422.977399-2-dmitry.osipenko@collabora.com> --- ui/gtk-egl.c | 1 - ui/gtk-gl-area.c | 1 - 2 files changed, 2 deletions(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index ae9239999cd..0dbb429958e 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -180,7 +180,6 @@ void gd_egl_refresh(DisplayChangeListener *dcl) =20 if (vc->gfx.glupdates) { vc->gfx.glupdates =3D 0; - gtk_egl_set_scanout_mode(vc, false); gd_egl_draw(vc); } } diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index cd86022d264..c709b2ce0f6 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -199,7 +199,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl) =20 if (vc->gfx.glupdates) { vc->gfx.glupdates =3D 0; - gtk_gl_area_set_scanout_mode(vc, false); gtk_gl_area_queue_render(GTK_GL_AREA(vc->gfx.drawing_area)); } } --=20 2.47.3