From nobody Sun Apr 12 00:55:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1772593296; cv=none; d=zohomail.com; s=zohoarc; b=W9b/SCmSqm2yv/MjyMKqb4EVFfUZfR1dkQH/TLN6LJ0ONAebCd9UBv1d00/4Wk+xgzn3+xgS4Szy2tVQ/L9hWPpQwm0j/pPn5PAWzknP+8aJW2YRZiAUE24riyZbntDeCfCvU6IdNnXM+ex5fdTa2V4vYieY07NT743TUl5hBs0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772593296; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IZ9hTXQut/xr7cptKaFXHAYY93WC/1F3b8tBsa3cjE4=; b=LdS3egxD+pGDNdI1rRY8xX9OfGmziyxc4bmLCGhmaph8sRqGGHxU76MY3DwWU4JfwhkaraDQCwuVIi/lhwfNf/+fXZZixMo3q6vU8iTTyWcs7KbOZwsw75W8qswEn0Ay3H7oYl8CmEvV00qYMgO0GJ1T9z5VnvO+bweCcGm/Z2E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772593296359287.3851464042825; Tue, 3 Mar 2026 19:01:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxcSV-0002MC-GN; Tue, 03 Mar 2026 21:59:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxcSS-0002LC-Hn; Tue, 03 Mar 2026 21:59:32 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxcSR-0000Ut-2n; Tue, 03 Mar 2026 21:59:32 -0500 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62404TTC126572; Wed, 4 Mar 2026 02:59:29 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ckssmncqs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Mar 2026 02:59:29 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 623Nwiag010335; Wed, 4 Mar 2026 02:59:29 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4cmc6k4xe4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Mar 2026 02:59:29 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6242xROI12780272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Mar 2026 02:59:27 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BA09758043; Wed, 4 Mar 2026 02:59:27 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8F7485805F; Wed, 4 Mar 2026 02:59:26 +0000 (GMT) Received: from t15.ibmuc.com (unknown [9.61.180.105]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 4 Mar 2026 02:59:26 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=IZ9hTXQut/xr7cptK aFXHAYY93WC/1F3b8tBsa3cjE4=; b=K/Qu7quJuqjzl3a6FOZRiiGnxGioaMAlQ kO94fMMUIFgIY2GUfS2ExXCAnXqMTvkCPm+bJm09+Bl/xSG0pHIcDj4sCKwPP2kI V8w3qpnRbC23PvMKtAzsVvFWNQ8B3RDP0BLAc1UvloyyeDOt2rFJM6hFnjRPiWRw eAmBVgnsqGOalPMInQMMQqxgvsZ3Pg4AsOhzh9cTMYlGY/1QJWM52vaAzw7OKao9 0qEjJFw6Sxc6pHavcr9n7vcug2IupAGb2ztEUBmMksL+8bWUyoFJ+jOH7iS71ScS uEfHvt1L6YE+lAhtIPZs1mLejc3kDc6ASSavhKZFIeEG+njpHaKDg== From: jrossi@linux.ibm.com To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, thuth@redhat.com, mst@redhat.com Cc: jjherne@linux.ibm.com, alifm@linux.ibm.com, farman@linux.ibm.com, mjrosato@linux.ibm.com, jrossi@linux.ibm.com, zycai@linux.ibm.com Subject: [PATCH v4 03/15] pc-bios/s390-ccw: Always reset virtio device on failed boot attempt Date: Tue, 3 Mar 2026 21:59:05 -0500 Message-ID: <20260304025917.2157032-4-jrossi@linux.ibm.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20260304025917.2157032-1-jrossi@linux.ibm.com> References: <20260304025917.2157032-1-jrossi@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDAyMSBTYWx0ZWRfX7tviXmqE5qs/ r4d5ffys8HC4R0nsENjGgRfYfhqnM1WP95tu8HuWSQNeuLmndDDCVdUzqIB9gmVRLGdK4oPY5Kl E3SagpewqI5wPn4FjxD1hZ15krT4ht2tteZKzRpwY5X8Ngssm2XvF6Zcz+k2efGyFllWPgo5shV jGvosoSmbUgEE8jemipCOiLYBf04Gt9VMKx5pRuXoWuMKY+Wh4LxPhDbZh7PBKRtSZi+HgxA/QH vozWODAr3La9ueH1u07loLE/gN240/3bXll+A5qLLb9o4OAu+PrBIZUFabUL5Sy8sa54Q1p12UF rqk4v1x0IuM5axWR4vq5cL5E/JU7jTvXHHBotrZugeAv3JoBj6sBq7q3rbZnp1vXbK1HDFZwuOL UTJYSTgQuuTWm1n23TPwKDiWaLBxc9M7cP+eRyZGnsiZDRwr6Gs9/fu8rxTnJzsC9yOhiePdFYp joiBoI0AOQirWKBvo3A== X-Proofpoint-ORIG-GUID: hL7IdAJkxRwJ63FTcBOw-OP-bahj9PRm X-Proofpoint-GUID: hL7IdAJkxRwJ63FTcBOw-OP-bahj9PRm X-Authority-Analysis: v=2.4 cv=AobjHe9P c=1 sm=1 tr=0 ts=69a7a011 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=YW-40rnn-hUE6FG0_2oA:9 a=ZXulRonScM0A:10 a=zZCYzV9kfG8A:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_01,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040021 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=jrossi@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.322, RCVD_IN_VALIDITY_SAFE_BLOCKED=1.141, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1772593297459139101 Content-Type: text/plain; charset="utf-8" From: Jared Rossi The virtio spec necessitates that live virtqueues must not be altered. Res= et the failed device so that the queues are not live before we attempt to boot= any fallback devices. Signed-off-by: Jared Rossi Reviewed-by: Eric Farman Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index 76bf743900..8e2c99bee1 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c @@ -277,7 +277,8 @@ static void ipl_boot_device(void) break; case CU_TYPE_VIRTIO: if (virtio_setup() =3D=3D 0) { - zipl_load(); + zipl_load(); /* only return on error */ + virtio_reset(virtio_get_device()); } break; default: --=20 2.52.0