From nobody Sun Apr 12 02:49:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772576626; cv=none; d=zohomail.com; s=zohoarc; b=Me79avrAiQWXDpzaRZ81ufX07rwq99L/OcFkvw9/n+qB6Ti2KhWCw+Oi8SdPp4OMTAe0Q/8/sMPCGGkkRgBmUYW2KxfeyV9zjBZagSAnJeYOoFqAdeeoGdg0B8KPcO1+PVtZmzHXDEVUlRaF4ev8tO5Y7eQUAdDKYcwHV+yRdbU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772576626; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RXoZ/fOhayTS8r0vRAm++6Mi1cXikEvcCxkP8GuhY3Q=; b=bCfLQ0sxjVFzaGmAbgx706lLSnrTH+tLl+JgoawsOe64Xb8DKylfNhpKPlbuTIZEVFxLDfum2CHB1ZlAEu+JS9ivzMhW2cFazAPOg88szXKgmAuMPwpnASsBf86UYCJSjW64NZN9txDMPTE4UkIV5dx9xqmGxat1SBRFhehEZCY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772576626763940.4601561976197; Tue, 3 Mar 2026 14:23:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxY87-0004k5-Bn; Tue, 03 Mar 2026 17:22:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxY85-0004iy-L6 for qemu-devel@nongnu.org; Tue, 03 Mar 2026 17:22:13 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxY84-0002Rr-7c for qemu-devel@nongnu.org; Tue, 03 Mar 2026 17:22:13 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4837f27cf2dso55886975e9.2 for ; Tue, 03 Mar 2026 14:22:11 -0800 (PST) Received: from Provence (dynamic-2a02-3100-1c79-b600-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:1c79:b600:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485187c81adsm7577715e9.6.2026.03.03.14.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 14:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772576530; x=1773181330; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RXoZ/fOhayTS8r0vRAm++6Mi1cXikEvcCxkP8GuhY3Q=; b=kg0FfzW9jYgQcquMqQeVZKov/EwkSt3HGsZ+iPvUaharvQXzRugTHOw9WT9OOVv4ah CEkUlnV+wTaegJMsOdwgjK77+qlQviiEyGitYCKMifI/WJWpv+bXHxmQ75WJE9YP/kt8 JKiKLk1rIsnN9YU/ixFaynaLhVam7P0nTsa3QdjDDNlBMlqB8Zg+YhEHBT3ZgjogI05W bkMZrsQpC3mUiPmOBjQQ2S6r7jbWBwjd0FvTMzmHl9aD+BRte8BF9Jfes0ZTzG3hkplI frm9CaSTuYOvGQe6pNn86XpHhNaHprG0Lc4CBRS40sbFi+Q07k8eLk6sDRGag9sHi8Nf JKsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772576530; x=1773181330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RXoZ/fOhayTS8r0vRAm++6Mi1cXikEvcCxkP8GuhY3Q=; b=sDWFcxeJhwHKyOANWkyho1dlwHbp8VrWBH/VII4EVgJjKp6J0TdFxKC5ZwT8Fd6ql+ /fKLdyuunOPwR+BFRmgGJFT7sTgLlI4QZGlwnvkrmx2NiLEPC1x2J96g7h13LO9lqsMB b11TR/ixzlnCFIHOKy+sxfnEwBAeDLcYOwaMmm1bu0E+A0yY/PS/wt+Q9nEIJ3Md0OAt 7Haf36IMM3k+mxcm0EXQ6fvIIjdtK5AH+56w1ZZCyOslVwxV9U+BfTKiCRCPFGZrWO1k e7mDYolZkS9zxJG6/oHpfxFnVKwO8r+yBDT1mWQeeSiAZPhFOP9gSKHO9oC5h/zCq85T h14Q== X-Gm-Message-State: AOJu0Yzp1S8EvUlMSGxg46n2lXsJHXvYuHmfg6i4mfMBL7x5X9067ij8 19LK2Vtveb086XhSGC83P4UzLMVrNXD+Jzd7tiqpmjv3E+DGNcR2kAvFifEQbA== X-Gm-Gg: ATEYQzx0ib4KhlvIKpswt+JN8BsYrgQnIql4IM6YvNADEy4cnrXZiBDUi/HsKZcb8JE q9P7D7EQYYXWoDlTfJGlkhFHaqfcxF1/sVd1k9Pnv59qBZC32S2XXzbswuXP0k89kEhrTd5qiIf xEBateyb91zxdrbatjHNRWFP9yzeTLXTrTAJFSMbLZ6QJlF5flLXlXPldAYhMG5fBstCrnME1Nv anTk4JRSYmD0INwc57UDjK6SIRKxweNHylN5emfTXS2CTucILiqjL7vkQgq6KK1bbF22RGfo+FP NPgAydBtsdbFpTLtlqSsJEeG8V61ym3qlDfkL0VTLbLCF3OOMkjHuJJXQC3JXXSWP6RjhXv3dZj K/KK1Q01B7awDk6XwSu29h56oS2RDM1BdYAs38qGyguySTrGsUXGtCe5jYQjw7Y9+t/r0UBdoXP 2/436y1OgIvke4YvUUKwWLupm5AXaw6Hk8MLKq1EVOEO3+SUow0fh4JSSrmRL9e1ndyPtfBJIa7 K/6TE+mO1Kwo3RjTC09LE3MUOA52hs= X-Received: by 2002:a05:600c:4592:b0:480:52fd:d2e4 with SMTP id 5b1f17b1804b1-483c9b78c20mr335635305e9.0.1772576530219; Tue, 03 Mar 2026 14:22:10 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Helge Deller , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Steven Lee , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Troy Lee , Richard Henderson , Mark Cave-Ayland , qemu-arm@nongnu.org, Jamin Lin , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , "Michael S. Tsirkin" , Andrew Jeffery , Peter Maydell , Joel Stanley , Bernhard Beschow Subject: [PATCH v2 07/13] hw/char/serial: Remove stale comment Date: Tue, 3 Mar 2026 23:21:37 +0100 Message-ID: <20260303222143.142741-8-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260303222143.142741-1-shentey@gmail.com> References: <20260303222143.142741-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=shentey@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772576629276158500 Content-Type: text/plain; charset="utf-8" There is no "is_load" flag and one can tell from the method name what the method does. Remove this stale comment. Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell --- hw/char/serial.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 2c558cb9fc..f73de1ae4f 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -281,9 +281,6 @@ static void serial_xmit(SerialState *s) s->lsr |=3D UART_LSR_TEMT; } =20 -/* Setter for FCR. - is_load flag means, that value is set while loading VM state - and interrupt should not be invoked */ static void serial_write_fcr(SerialState *s, uint8_t val) { /* Set fcr - val only has the bits that are supposed to "stick" */ --=20 2.53.0