From nobody Sun Apr 12 00:56:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772576593; cv=none; d=zohomail.com; s=zohoarc; b=W63Th1K3oS7vceMhU2Fa7SUL+KIHqLQQNGcpYyZxlaqTKsAFGuFMJGRUK4voLYMh6qmwSVBx8c6a2Y+viKcnQhLckKwHRdl7TsIzNYtp7cRvsBZXZtQW0NhccN9vEmg5Ij61hDXTmxMZlqDyAgJ8s9hw6jI4SjQ23iCcm6Dazpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772576593; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kQcKbngO5gEYvP1cyAmsSZ3twrSC/3ssI8QyeEW5Z+s=; b=TLkNfLJpAP05ztyhlTg49wWB9DGIqSdck0a4cklVW/STS05KgZ4ArXuejomC+8SugJzVBeFanhZ0o3VjuSBpSXoApv+Hn8C27+mxg10DWp6FgZz5naSGGPQ82I0u0A/QbS6gbhQWGmWmDu3VMoNZEQwGuNDybUg3QnpExyRodgI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772576593836863.2050789961072; Tue, 3 Mar 2026 14:23:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxY8B-0004lw-AR; Tue, 03 Mar 2026 17:22:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxY8A-0004l9-5Z for qemu-devel@nongnu.org; Tue, 03 Mar 2026 17:22:18 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxY87-0002TQ-Ez for qemu-devel@nongnu.org; Tue, 03 Mar 2026 17:22:17 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-48375f1defeso46546765e9.0 for ; Tue, 03 Mar 2026 14:22:15 -0800 (PST) Received: from Provence (dynamic-2a02-3100-1c79-b600-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:1c79:b600:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485187c81adsm7577715e9.6.2026.03.03.14.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 14:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772576534; x=1773181334; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kQcKbngO5gEYvP1cyAmsSZ3twrSC/3ssI8QyeEW5Z+s=; b=S9Ln4QA8uSGDVFlR8QxMcuS1IKxS0uhVBEA+LbwDjJ16cfOMW1vxPISkdXBQr2oNAM rY9hDQcP9e4QK5inIC2GAGS9OSL1Is1c6BIs6lsQqYsa5qloL9+LcWcyvA2gXwo2ol/2 ci8S2Viy30MCAthkVdMLyFtLjbUbKKybiNTyW2eAVcluQ9Le7uBgzbTU/0fN6+9URCiv 95DliXLyAa9740P5BqESTBDl60C0UAFVRlkYYmmlSkesvLHnFTTvEnm1Vf9WuzKO5nIJ i32GIBI1i6R8ZVEcXr8PzUk1y6f4m1yCy5whFlwuHDk0sg8xr+19+rShF3cvQaOpfAHB /P3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772576534; x=1773181334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kQcKbngO5gEYvP1cyAmsSZ3twrSC/3ssI8QyeEW5Z+s=; b=idpDm4ppjxKB0unH7sfn6ryHFyPw6wbRx4hcQnDXxVJmre02Xaan9rWbrCyzfbcVzb PF5LBjHdcxwk9Y86+aF6yDB7+xX9IwpVT6BaJO5q+PJk+ozwxo7KXvyQwMb1U+IgSCt0 Sz528fYn31d/i6CHo+5VcBypbRUWjzqa9WBwciAVc+8jQ19vgczM82dx1ln5Le0r91rQ izKlfWyWoLadhX86cJFjns7/EZWwnWMgZ7UfIjWTAt5oUdwfqvQhnYnjSJ+ldzL4V7lN NuP4Dh71qZ8b10Ne8fRp7kWey6vRnfI+5zS2zQVjt+G/u45stm9nTO1JmOudU7xiqmWG D2Wg== X-Gm-Message-State: AOJu0YwIsnajutA0RMolCjcgqf3cpYiqQZWw3dGV0xYhb+iZABTQYfEh wfBzSb/Co7pvumeX3P4D+bM29/k6l5IJMJjxO2ck5+mC3nDEQcII2+MtokzzHg== X-Gm-Gg: ATEYQzzNpzdkdpmxTwVMnl2g9/J2/vjApIXMrEfIEPnzz6a9USCcK7GYGWxQxZxkrFa S6kTaaxLV2LkRSh1Z8Po5Nrnoz5dupbSeTuLa4dfWqOjmvT718EIXgqQMpAeZfH+QZUxjp7oS2z eVyfa3lYjLh9osZdhjIhnjGFBFunFdnH7D0ikv2/yZq5QdZefv7zSQfesc+Dq60aEpwdvkdQOm3 lrRic9NltjdZQvhfijvsxwzzOuN9ZhIqSbs05mttfWPmqZTKY6PN1/7+9XNPtAkBUmBs7TX5L5s LmTBsuFKy3HIGAPNEx/d6fYNnNRjZGDH0VvRa8AVREkrf9VS2t+eqkXMJc94z5/AhJEO+SvTM97 f42OEIc8QrzWOedixkOD5rfqZZW9u6oLuYBoxoBb62/YS8vAVzgmQhKsICNMJXhfvuY9JUBme4K oB3iXfD7LjzM0pJugiJ7TRBGYn8Ygq140CUMw+vI+XOOHWTlnXKwQuPPmqO4zNmEACft5zVgwW+ 23Pm9bUpQvGRhw+8yUsPd1JH6OPxGhbik6AGzsRtg== X-Received: by 2002:a05:600c:444d:b0:480:4a90:1afe with SMTP id 5b1f17b1804b1-483c9c2be1dmr286021745e9.34.1772576533734; Tue, 03 Mar 2026 14:22:13 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Helge Deller , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Steven Lee , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Troy Lee , Richard Henderson , Mark Cave-Ayland , qemu-arm@nongnu.org, Jamin Lin , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , "Michael S. Tsirkin" , Andrew Jeffery , Peter Maydell , Joel Stanley , Bernhard Beschow Subject: [PATCH v2 10/13] hw/char/serial: Avoid implicit conversion when tracing Date: Tue, 3 Mar 2026 23:21:40 +0100 Message-ID: <20260303222143.142741-11-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260303222143.142741-1-shentey@gmail.com> References: <20260303222143.142741-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=shentey@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772576597119158501 Content-Type: text/plain; charset="utf-8" On 64 bit targets, the MemoryRegion API passes an address and a value as uint64_t, so use that for tracing. Keep the uint8_t for reading since this is what the device model produces. On targets with less than 64 bits, uint64_t is wide enough to avoid narrowing. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/trace-events | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/trace-events b/hw/char/trace-events index 9e74be2c14..a3fcc77287 100644 --- a/hw/char/trace-events +++ b/hw/char/trace-events @@ -5,8 +5,8 @@ parallel_ioport_read(const char *desc, uint16_t addr, uint8= _t value) "read [%s] parallel_ioport_write(const char *desc, uint16_t addr, uint8_t value) "wri= te [%s] addr 0x%02x val 0x%02x" =20 # serial.c -serial_read(uint16_t addr, uint8_t value) "read addr 0x%02x val 0x%02x" -serial_write(uint16_t addr, uint8_t value) "write addr 0x%02x val 0x%02x" +serial_read(uint64_t addr, uint8_t value) "[0x%02" PRIx64 "] -> 0x%02" PRI= x8 +serial_write(uint64_t addr, uint64_t value) "[0x%02" PRIx64 "] <- 0x%02" P= RIx64 serial_update_parameters(uint64_t baudrate, char parity, int data_bits, in= t stop_bits) "baudrate=3D%"PRIu64" parity=3D'%c' data=3D%d stop=3D%d" =20 # virtio-serial-bus.c --=20 2.53.0