From nobody Sun Apr 12 00:55:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=unpredictable.fr ARC-Seal: i=1; a=rsa-sha256; t=1772571104; cv=none; d=zohomail.com; s=zohoarc; b=M68BI4r2PodkZF+QWvegjMqpzwJuvCRSaVvJV3UBwWrWi8xaqzC99Fcmz/KiwxzmHrkhEvGyslEZCatC4M9flG+VpaYKwdvoZFFC/w5LyveXYVAFQMBXOsxsNULMBziiBg1S2yS/xkOZ6dWH74Ha0h3PekGWa9awSwsclbjgbhc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772571104; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y3JlG+z3H9s3sHt/x0Tuo8JzSDhUpyc6A/I7Tj0fIfs=; b=AXav3AvqzN+qGtMvtJZJytgJqvs8FhzBhw4mXQKSusgPbzzl7ET1r/h+8uoAnlZ4XG38w9OnzTGLrwuRHdY8m2/kLEZp7wQhfc+ByR6Wakzwx2eEaFEbpA+aUOsKpdleoFzpu4vibSFX8iMGroTgKWjSaXUb0EYAsODv9hmFaZs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772571104229959.7171602042374; Tue, 3 Mar 2026 12:51:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxWhJ-0006B7-35; Tue, 03 Mar 2026 15:50:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxWhE-00061u-42 for qemu-devel@nongnu.org; Tue, 03 Mar 2026 15:50:24 -0500 Received: from p-east2-cluster6-host2-snip4-10.eps.apple.com ([57.103.76.191] helo=outbound.st.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxWhB-0000mT-CM for qemu-devel@nongnu.org; Tue, 03 Mar 2026 15:50:23 -0500 Received: from outbound.st.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-1a-20-percent-2 (Postfix) with ESMTPS id 4057D1800424; Tue, 3 Mar 2026 20:50:17 +0000 (UTC) Received: from localhost.localdomain (unknown [17.42.251.67]) by p00-icloudmta-asmtp-us-east-1a-20-percent-2 (Postfix) with ESMTPSA id CA480180012C; Tue, 3 Mar 2026 20:50:14 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1772571020; x=1775163020; bh=Y3JlG+z3H9s3sHt/x0Tuo8JzSDhUpyc6A/I7Tj0fIfs=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=K2ZEeZFrCO6lAp8Z35uUzwCr9wdNiXLgRDnSPV9+5NhBzxZFrvLU4QRljLMNJYmIcb314o5htSrm+EOCmLtOh7xM5OlcnNJMW1osmRxRkTWQ2e0yRQwvauYUMP7srYou4G8E/xLR1v0pGIFqsoKn3nYw2NAeKdJesffWch2V+xeYbCfDGk9WLdJITLzL8XlkMXzOJ3qc2WuK9qCL8Ru1Askk1ilrM3BlkBjDcZiwLeve3mdlbFj1IQH8WtIkU6c1h1tVCuHtVY5bg3W58gbt4Aa2HZ0Aah/ZnYBTkRUDityTTzw/Z/qzukedVh+4g1KwKfn7S0qU9KDMUJInAtmkfg== mail-alias-created-date: 1752046281608 From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Zhao Liu , Pedro Barbuda , "Michael S. Tsirkin" , Cameron Esfahani , Mohamed Mediouni , Peter Maydell , Roman Bolshakov , Phil Dennis-Jordan , qemu-arm@nongnu.org, Wei Liu Subject: [PATCH v3 7/9] whpx: make Hyper-V enlightenments configurable Date: Tue, 3 Mar 2026 21:49:57 +0100 Message-ID: <20260303204959.31156-8-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260303204959.31156-1-mohamed@unpredictable.fr> References: <20260303204959.31156-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 5go7WhVrQWT7SmQIItTlHSkSemc4f3rO X-Proofpoint-ORIG-GUID: 5go7WhVrQWT7SmQIItTlHSkSemc4f3rO X-Authority-Info-Out: v=2.4 cv=K/gv3iWI c=1 sm=1 tr=0 ts=69a7498a cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117 a=YrL12D//S6tul8v/L+6tKg==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=BRqF0JgGwH6LvUrOcfoA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDE3MSBTYWx0ZWRfX7AmmhhffwzN1 PndZkDZEJ73/y8B524hufZaFjwPpcfK511eu7rhhsdTQy1pVCVaAve9Oo5q8zL6jDUVHudIdf+5 iUlLV7FjsIP9W649vYqQvIyXL7Y2WKl/eZbU6sstGP7KIGyuknxABTqSnr6/1qYuoaoXl8cXc8o bBbs8AqcvVrE4WBrIb46ki9iYlaJZUZE2UEYxr8bkmIVAtkrNL1i0T7Lmd6j3OdC42XG7Dg18F1 hz6jw4/YS65OMBBUVKPYsgH35tdYYrj2grI/1jDpSTWRdQvhOlARmOQRKSUsPgJ0x+hYlOjKbUR h5oAmpEP67g4mfC8Rxzhwwy/cTiaebPcXRqG6nxJ0Xj09VI+N0dp4ren6b3HnA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-03_03,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1030 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2603030171 X-JNJ: AAAAAAABgpjdZUbs+sXZ7QqVpLNGzUeLzt0R7c4kM9ac/vIzkaNfbp+G+BNAZN5WsyO+Wtq924ylfKCEw6mfE2zvLFJzL+y5u0XBc/jU+HDhIKpebdmR43CanOpf5IQtNTbfs68QJKEYA0lXZ+sjPDJaT+yqXpXhQdXoty6SVowzE6gzH+0067SVkPQ3qUk6gMFqXOoGLzgMQKu9tK2rJA608OOvOzgejpzPVVlj5cwJqngoyTLyos8R1XYGAE6AeibKkVTnUePyKh4jfV3RkBhDltRlLpGZmOBgqOQvZROTkTv6h0n0blX/PRas758ejWkqKJQHh8dp4qBV7/mFtsN/p80QRAS1rhyAx0ELg1AsfvNrkDoIpPkfZBW5Tx+8bGmmX7Lk/kGBTJJI7G+BtW6x+yv4o8XmjkricjlEmOWvH28xyng7eYBXuKnXvz4jdtiggb6fQxnqJYOy9fnD3MuNMKe6e+3Mm3HHvkHIP5PZpzErl9Zw4f5+8QTeNeg0Pz6DolEY9L39zliUv+pwIUIVyEAKXFK4RAGtQ7vnGeOs+jDxP593tVeC5gRtClSEdvHbCOuKyyf5vtavqydfRRY8Qaz0ZDfO4HqmAN2T4obOkq0NlPegT8NdYjV9Vgl0FS9umhls1ylkTdZ3YszjXpyQU8k29MNhZxAYl4URP3QlCOa/rVyJHfrw9XIF0c3oULk7IcdD+hyLbgJYdo2mzLsE0yiq8Lrbwy3TAo/agIoRG3mlbTPutyeYVqcuKWGuMjg= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=57.103.76.191; envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.322, RCVD_IN_VALIDITY_SAFE_BLOCKED=1.141, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @unpredictable.fr) X-ZM-MESSAGEID: 1772571105808158500 Content-Type: text/plain; charset="utf-8" Have them be a machine option instead of a CPU one, to have something avail= able, even if not ideal... The existing Hyper-V enlightenments configuration mechanism is part of per-= CPU configuration, which happens too late for this. Signed-off-by: Mohamed Mediouni --- accel/whpx/whpx-common.c | 44 ++++++++++++++++++++++++++++++++++ include/system/whpx-internal.h | 4 ++++ target/i386/whpx/whpx-all.c | 20 +++++++++------- 3 files changed, 59 insertions(+), 9 deletions(-) diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 4863fc8663..dae9ff0800 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -25,6 +25,7 @@ #include "qapi/qapi-visit-common.h" #include "migration/blocker.h" #include "accel/accel-cpu-target.h" +#include "qemu/target-info.h" #include =20 #include "system/whpx-internal.h" @@ -470,6 +471,41 @@ static void whpx_set_kernel_irqchip(Object *obj, Visit= or *v, } } =20 +static void whpx_set_hyperv(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + struct whpx_state *whpx =3D &whpx_global; + OnOffAuto mode; + + if (!visit_type_OnOffAuto(v, name, &mode, errp)) { + return; + } + + switch (mode) { + case ON_OFF_AUTO_ON: + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D true; + break; + + case ON_OFF_AUTO_OFF: + whpx->hyperv_enlightenments_allowed =3D false; + whpx->hyperv_enlightenments_required =3D false; + break; + + case ON_OFF_AUTO_AUTO: + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D false; + break; + default: + /* + * The value was checked in visit_type_OnOffAuto() above. If + * we get here, then something is wrong in QEMU. + */ + abort(); + } +} + static void whpx_cpu_accel_class_init(ObjectClass *oc, const void *data) { AccelCPUClass *acc =3D ACCEL_CPU_CLASS(oc); @@ -498,6 +534,11 @@ static void whpx_accel_class_init(ObjectClass *oc, con= st void *data) NULL, NULL); object_class_property_set_description(oc, "kernel-irqchip", "Configure WHPX in-kernel irqchip"); + object_class_property_add(oc, "hyperv", "OnOffAuto", + NULL, whpx_set_hyperv, + NULL, NULL); + object_class_property_set_description(oc, "hyperv", + "Configure Hyper-V enlightenments"); } =20 static void whpx_accel_instance_init(Object *obj) @@ -507,6 +548,9 @@ static void whpx_accel_instance_init(Object *obj) memset(whpx, 0, sizeof(struct whpx_state)); /* Turn on kernel-irqchip, by default */ whpx->kernel_irqchip_allowed =3D true; + + whpx->hyperv_enlightenments_allowed =3D true; + whpx->hyperv_enlightenments_required =3D false; } =20 static const TypeInfo whpx_accel_type =3D { diff --git a/include/system/whpx-internal.h b/include/system/whpx-internal.h index e7b915ccbf..abea3ddeee 100644 --- a/include/system/whpx-internal.h +++ b/include/system/whpx-internal.h @@ -41,6 +41,10 @@ struct whpx_state { =20 bool kernel_irqchip_allowed; bool kernel_irqchip_required; + + bool hyperv_enlightenments_allowed; + bool hyperv_enlightenments_required; + }; =20 extern struct whpx_state whpx_global; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 915d79152e..4968a5a3e4 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2219,15 +2219,17 @@ int whpx_accel_init(AccelState *as, MachineState *m= s) synthetic_features.Bank0.DirectSyntheticTimers =3D 1; } =20 - hr =3D whp_dispatch.WHvSetPartitionProperty( - whpx->partition, - WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, - &synthetic_features, - sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); - if (FAILED(hr)) { - error_report("WHPX: Failed to set synthetic features, hr=3D%08lx",= hr); - ret =3D -EINVAL; - goto error; + if (whpx->hyperv_enlightenments_allowed) { + hr =3D whp_dispatch.WHvSetPartitionProperty( + whpx->partition, + WHvPartitionPropertyCodeSyntheticProcessorFeaturesBanks, + &synthetic_features, + sizeof(WHV_SYNTHETIC_PROCESSOR_FEATURES_BANKS)); + if (FAILED(hr)) { + error_report("WHPX: Failed to set synthetic features, hr=3D%08= lx", hr); + ret =3D -EINVAL; + goto error; + } } =20 /* Register for MSR and CPUID exits */ --=20 2.50.1 (Apple Git-155)