From nobody Sat Apr 11 23:07:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772556072; cv=none; d=zohomail.com; s=zohoarc; b=XzsAbc+rD18TjpkbnKUfXzHBLudLiW0/vmQLpG3JynDkIMyBdI323MpJieJYAHEKwGlX3jKKzakHVJSQttyo49FkqPIkHgGs6A9dpKRRAA8ajzJxcMKJsW9WZy/JBxgJSJt5DJN9UB4Bvviys9+DSD+pbktdrUYXMMi9I+uzEMk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772556072; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=t8u602C9Q/wNZVt3luVyi3m3X/+imtMU6KMp7n4fBEI=; b=c93Nw9H4ImE/hMkVgMKjGzGxCH86NRHKMTQZylBErUUOVBZ19jC2wz9YL/gaLY0TjLtzrAVOtI5miB0XJ1/OliAPi8Q3PxlCjZclS7p89ddYp6le0cc5ZgWRzSh99LwZ9qIJ6JPCLJ1/UaZECMJfHTPqsb4wxPtd4b3rmi2cWAw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772556072162694.5113617061822; Tue, 3 Mar 2026 08:41:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxSnR-0002mn-7O; Tue, 03 Mar 2026 11:40:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxSnP-0002mb-5x for qemu-devel@nongnu.org; Tue, 03 Mar 2026 11:40:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxSnD-0005ob-V8 for qemu-devel@nongnu.org; Tue, 03 Mar 2026 11:40:25 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-uCchg5QlORmB9JN8hshNCg-1; Tue, 03 Mar 2026 11:40:12 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 52B1B1955DB6 for ; Tue, 3 Mar 2026 16:39:46 +0000 (UTC) Received: from localhost (unknown [10.44.22.9]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A00F71800590; Tue, 3 Mar 2026 16:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772556014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t8u602C9Q/wNZVt3luVyi3m3X/+imtMU6KMp7n4fBEI=; b=NvAba8GpKFe0xIjpbvcOvGroK+NZt0DxUkVkOxcrzkzrmFYrovqzAKJKWa9pndjk6aRqru GowUgJBDHWbi26GIjVjz12IiJoYBiynnBFBOvr/2rLO99j6x/01jR2nvh9lhc3HnIsjmej Td/lTw2R2Y3ZvTNwV9gYkRCYF5KiMWQ= X-MC-Unique: uCchg5QlORmB9JN8hshNCg-1 X-Mimecast-MFC-AGG-ID: uCchg5QlORmB9JN8hshNCg_1772556012 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] ui/dbus-listener: Fix FBO leak in dbus_cursor_dmabuf Date: Tue, 3 Mar 2026 17:39:43 +0100 Message-ID: <20260303163943.153613-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 27 X-Spam_score: 2.7 X-Spam_bar: ++ X-Spam_report: (2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.322, RCVD_IN_VALIDITY_SAFE_BLOCKED=1.141, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772556075323139100 From: Marc-Andr=C3=A9 Lureau cursor_fb is a local egl_fb that gets an FBO allocated via egl_fb_setup_for_tex but is never destroyed, leaking the framebuffer object on every cursor update. Add egl_fb_destroy() after the cursor data has been read. Fixes: commit 142ca628a7 ("ui: add a D-Bus display backend") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 3e2b4adf41f..fff7cf83274 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -660,6 +660,7 @@ static void dbus_cursor_dmabuf(DisplayChangeListener *d= cl, egl_fb_setup_for_tex(&cursor_fb, width, height, texture, false); ds =3D qemu_create_displaysurface(width, height); egl_fb_read(ds, &cursor_fb); + egl_fb_destroy(&cursor_fb); =20 v_data =3D g_variant_new_from_data( G_VARIANT_TYPE("ay"), --=20 2.53.0