From nobody Sat Apr 11 23:02:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1772545475; cv=none; d=zohomail.com; s=zohoarc; b=TS3iMQJbhPsNKA3T51EVOM/KK8O7Iass19btcj4iwKPXecL9PNSZxWnkVTKpezmdSL1qojr/4puKaKB4E4bAqraTLOZ6Su/rF3lFQ/sKGeXDhN9TIWAWXpPalCTwQwpUMRwgH1RB1DeOiZT/2u8cWuaLVZyG4LvAUOe3DYdInBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772545475; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2hXVkzNATR8J0anuapMeOR5MGDaANuJNBMswWbvHgmY=; b=RjwyWSOgJYQLcXWiXsm1gLGJY6yHJW+1yu1l1l5QfZExdKyM1ETEKoD1UWzdN2VqtXzV77uhITDKV9r/ZOO+nfNsawxjxbvf48gfCo3vbaFHV0PZl7H6KilrS04UR7pA4nbz7NvmrpSx+40QHCkdfY/4U9lrNuhu26T+2cC5I0A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772545475103320.01366896850675; Tue, 3 Mar 2026 05:44:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxQ2s-0003Mq-F1; Tue, 03 Mar 2026 08:44:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxQ2m-0003MG-UT for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:14 -0500 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxQ2l-0001Kg-1C for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:12 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2AE865BE06; Tue, 3 Mar 2026 13:43:55 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 79CD03EA69; Tue, 3 Mar 2026 13:43:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0N2mD5nlpmlXYAAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 13:43:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hXVkzNATR8J0anuapMeOR5MGDaANuJNBMswWbvHgmY=; b=0g8A2NhepWBbkUx+d9KocNcSBrKLjRm+TUcPpbZMF/BPsWp04kFn0nHAjOpc/SuMH8qx/V cDeEH+CeKT/yStNzcBo3UvQ86iMolPzCK7yBpzrPAsojq/Q1dQZnyahqEoyshk2tDOzBEY RuBLzgrdl1Tl5UVANAcdPv8q6+2mJ24= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hXVkzNATR8J0anuapMeOR5MGDaANuJNBMswWbvHgmY=; b=GB2ioHycfNA4ansEDe1+4Y3xTPA+8Y1wmtZb5+TGsDWcJF7J7jf7yQHQ7WHIh9b5VesfNp 50zbXtd/s1pTNvBA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=0g8A2Nhe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GB2ioHyc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hXVkzNATR8J0anuapMeOR5MGDaANuJNBMswWbvHgmY=; b=0g8A2NhepWBbkUx+d9KocNcSBrKLjRm+TUcPpbZMF/BPsWp04kFn0nHAjOpc/SuMH8qx/V cDeEH+CeKT/yStNzcBo3UvQ86iMolPzCK7yBpzrPAsojq/Q1dQZnyahqEoyshk2tDOzBEY RuBLzgrdl1Tl5UVANAcdPv8q6+2mJ24= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hXVkzNATR8J0anuapMeOR5MGDaANuJNBMswWbvHgmY=; b=GB2ioHycfNA4ansEDe1+4Y3xTPA+8Y1wmtZb5+TGsDWcJF7J7jf7yQHQ7WHIh9b5VesfNp 50zbXtd/s1pTNvBA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: adityag@linux.ibm.com, thuth@redhat.com, berrange@redhat.com, peterx@redhat.com Subject: [PATCH v3 1/5] tests/functional/migration: Use socket_dir Date: Tue, 3 Mar 2026 10:43:44 -0300 Message-ID: <20260303134348.8890-2-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260303134348.8890-1-farosas@suse.de> References: <20260303134348.8890-1-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 2AE865BE06 X-Spam-Score: -3.51 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1772545477592139100 Use QemuBaseTest.socket_dir instead of calling tempfile directly so all tests have consistent directory prefixes. Suggested-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- tests/functional/migration.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/functional/migration.py b/tests/functional/migration.py index 2bfb1f7790..0aa873edba 100644 --- a/tests/functional/migration.py +++ b/tests/functional/migration.py @@ -11,7 +11,6 @@ # This work is licensed under the terms of the GNU GPL, version 2 or # later. See the COPYING file in the top-level directory. =20 -import tempfile import time =20 from qemu_test import QemuSystemTest, which @@ -65,9 +64,8 @@ def migration_with_tcp_localhost(self): self.do_migrate(dest_uri) =20 def migration_with_unix(self): - with tempfile.TemporaryDirectory(prefix=3D'socket_') as socket_pat= h: - dest_uri =3D 'unix:%s/qemu-test.sock' % socket_path - self.do_migrate(dest_uri) + dest_uri =3D 'unix:%s/migration.sock' % self.socket_dir().name + self.do_migrate(dest_uri) =20 def migration_with_exec(self): if not which('ncat'): --=20 2.51.0 From nobody Sat Apr 11 23:02:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1772545517; cv=none; d=zohomail.com; s=zohoarc; b=kU26JQ7mTq8c3tVtCl7WH49OgDRrsho3MEsuRnMrQ0khPQO256oX0E42uxwC3yn6B1um9GvezdSn8eA7QzVtTeSxLD6wIzyq01puFnuFA2a5f49f8rOy2l0pP33JL0UKpPw6bsYsrmsJcW2nbj+QErkbps/7z/urkeDNztM3CLU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772545517; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CK3MqBz7nWHDbJwoF86o05bOuAWFxATe2udVQsxhLeo=; b=PuWRLwW8c61XM7Q0orGsFC+Ls6zdsa86ZfUHakU6lC5KTECjgdDsF+TS2iCLVWekTtglrVDTWe2NIg/ns1WI3oQdNdxKDa38pKO+7MPIkPKcfB3vy5s0SgEkaib1opW6rdhKq0a6/L9mfU+2tmb+LelZ7Mm3t2+RiPJ4ux6VObE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772545517458883.7857702045496; Tue, 3 Mar 2026 05:45:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxQ30-0003OI-59; Tue, 03 Mar 2026 08:44:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxQ2x-0003Nj-4t for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:23 -0500 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxQ2v-0001Nv-JQ for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:22 -0500 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 53E6F5BE0E; Tue, 3 Mar 2026 13:43:57 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A1F953EA69; Tue, 3 Mar 2026 13:43:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +BhnGZvlpmlXYAAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 13:43:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CK3MqBz7nWHDbJwoF86o05bOuAWFxATe2udVQsxhLeo=; b=xbPb3X3R11coKa1QE13cjLmCh/73sOuf4BXlERScjIssQjilgqmReQxBBJZ0Z8+SWKz0bN KsWUYqbBA0yVpm5Qx4ywIqGM4zGGZeTHqZuF7VYQwHUdtHr7j/iohnZR3rzg4+5IC6JzYY TeQjwA+PGxjvWVEnVoBZLnE8RtZVZrw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CK3MqBz7nWHDbJwoF86o05bOuAWFxATe2udVQsxhLeo=; b=74/Tb/TK+7hK/gilL/4cXmy9nsNU5Y8u01NsTd9LDmJCCBcl2MdAci0Flx1Rm/b9mHvW+g pfLvQlV29F/e8TDQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CK3MqBz7nWHDbJwoF86o05bOuAWFxATe2udVQsxhLeo=; b=xbPb3X3R11coKa1QE13cjLmCh/73sOuf4BXlERScjIssQjilgqmReQxBBJZ0Z8+SWKz0bN KsWUYqbBA0yVpm5Qx4ywIqGM4zGGZeTHqZuF7VYQwHUdtHr7j/iohnZR3rzg4+5IC6JzYY TeQjwA+PGxjvWVEnVoBZLnE8RtZVZrw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545437; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CK3MqBz7nWHDbJwoF86o05bOuAWFxATe2udVQsxhLeo=; b=74/Tb/TK+7hK/gilL/4cXmy9nsNU5Y8u01NsTd9LDmJCCBcl2MdAci0Flx1Rm/b9mHvW+g pfLvQlV29F/e8TDQ== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: adityag@linux.ibm.com, thuth@redhat.com, berrange@redhat.com, peterx@redhat.com Subject: [PATCH v3 2/5] tests/functional/migration: Add migrate_vms Date: Tue, 3 Mar 2026 10:43:45 -0300 Message-ID: <20260303134348.8890-3-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260303134348.8890-1-farosas@suse.de> References: <20260303134348.8890-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1772545519737139100 Content-Type: text/plain; charset="utf-8" Add a migration helper to MigrationTest that uses the migrate-incoming QMP commmand and takes the already instantiated VMs. The -incoming 'defer' command line option is preferred way instead of the -incoming URI syntax that's currently used. Suggested-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/functional/migration.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/functional/migration.py b/tests/functional/migration.py index 0aa873edba..3362e5c743 100644 --- a/tests/functional/migration.py +++ b/tests/functional/migration.py @@ -40,6 +40,11 @@ def assert_migration(self, src_vm, dst_vm): self.assertEqual(dst_vm.cmd('query-status')['status'], 'running') self.assertEqual(src_vm.cmd('query-status')['status'],'postmigrate= ') =20 + def migrate_vms(self, dst_uri, src_uri, dst_vm, src_vm): + dst_vm.qmp('migrate-incoming', uri=3Ddst_uri) + src_vm.qmp('migrate', uri=3Dsrc_uri) + self.assert_migration(src_vm, dst_vm) + def do_migrate(self, dest_uri, src_uri=3DNone): dest_vm =3D self.get_vm('-incoming', dest_uri, name=3D"dest-qemu") dest_vm.add_args('-nodefaults') --=20 2.51.0 From nobody Sat Apr 11 23:02:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1772545522; cv=none; d=zohomail.com; s=zohoarc; b=BBlOtbJzAM3YmjMXQtw8OchMEJKUfbguwBbaXL/Gxd3MNCIMXjkYVY1utR6lQgLPm8vt5IwdbQP4VX0r8jsPMSagjSHss+TnZztxYtYPin1u/u9+Wl9mE5js3fSssNs5Ki5fWUJ+3IzC7qIelCrUQMKewqI9E9McwUYOnfndNzM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772545522; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XAMl8TjKrno+NXucicsGsu9H+ENi6nLYqJAg2vADj2c=; b=G3fPdMdHEBdTF0DJgik44MNdNThxV7p7R/ftyf2AkEGTvuQljcYnz77hqMmHxmfho2P/D/3WnoZBf3PRg6vB19qJifGDwNXXubpZ4GWOq8pyOi4BhNeak5MgqXmSZKhM2BFyNGt1Q4B6935+V1qvrQSXIdmR9pGC79GtfgU2wDU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772545522770558.0225338552708; Tue, 3 Mar 2026 05:45:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxQ37-0003Q3-DE; Tue, 03 Mar 2026 08:44:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxQ35-0003P1-0A for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:31 -0500 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxQ33-0001Oc-4f for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:30 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7B0165BE11; Tue, 3 Mar 2026 13:43:59 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CA5303EA69; Tue, 3 Mar 2026 13:43:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eFtUI53lpmlXYAAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 13:43:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XAMl8TjKrno+NXucicsGsu9H+ENi6nLYqJAg2vADj2c=; b=mgKa4adyR6FP7GxGPT64uN5sMftyaF8XR13w9LQIWrHWuWWvNsS+QruzF6lxpuFisma2th QraX6xERGWP6Z/86n8eEQBb0m236DQdF56n/Lnd8TOpwKI3s/JIagDim3Cgrhxi0ocuHoJ ZGfEgrGzZULghjwWCa+8ioq/6RxTPHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XAMl8TjKrno+NXucicsGsu9H+ENi6nLYqJAg2vADj2c=; b=3BlyXdVRnuchxLTc3p4yKDYEUjVYGovw95c4aoBAtLEqplkU09Ck456DMxBzIymelox2UX YwgN/vmi169cxoCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mgKa4ady; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3BlyXdVR DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XAMl8TjKrno+NXucicsGsu9H+ENi6nLYqJAg2vADj2c=; b=mgKa4adyR6FP7GxGPT64uN5sMftyaF8XR13w9LQIWrHWuWWvNsS+QruzF6lxpuFisma2th QraX6xERGWP6Z/86n8eEQBb0m236DQdF56n/Lnd8TOpwKI3s/JIagDim3Cgrhxi0ocuHoJ ZGfEgrGzZULghjwWCa+8ioq/6RxTPHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XAMl8TjKrno+NXucicsGsu9H+ENi6nLYqJAg2vADj2c=; b=3BlyXdVRnuchxLTc3p4yKDYEUjVYGovw95c4aoBAtLEqplkU09Ck456DMxBzIymelox2UX YwgN/vmi169cxoCA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: adityag@linux.ibm.com, thuth@redhat.com, berrange@redhat.com, peterx@redhat.com Subject: [PATCH v3 3/5] tests/functional/migration: Use the migrate_vms helper Date: Tue, 3 Mar 2026 10:43:46 -0300 Message-ID: <20260303134348.8890-4-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260303134348.8890-1-farosas@suse.de> References: <20260303134348.8890-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Score: -3.01 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 7B0165BE11 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.322, RCVD_IN_VALIDITY_SAFE_BLOCKED=1.141, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1772545524598139100 Content-Type: text/plain; charset="utf-8" Change do_migrate() to call the migrate_vms() helper and provide it with the two VMs already created. Rename do_migrate -> migrate and adjust the callers. While here, standardize on the "src" and "dst" names. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/functional/migration.py | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/tests/functional/migration.py b/tests/functional/migration.py index 3362e5c743..49347a30bb 100644 --- a/tests/functional/migration.py +++ b/tests/functional/migration.py @@ -45,17 +45,19 @@ def migrate_vms(self, dst_uri, src_uri, dst_vm, src_vm): src_vm.qmp('migrate', uri=3Dsrc_uri) self.assert_migration(src_vm, dst_vm) =20 - def do_migrate(self, dest_uri, src_uri=3DNone): - dest_vm =3D self.get_vm('-incoming', dest_uri, name=3D"dest-qemu") - dest_vm.add_args('-nodefaults') - dest_vm.launch() + def migrate(self, dst_uri, src_uri=3DNone): + dst_vm =3D self.get_vm('-incoming', 'defer', name=3D"dst-qemu") + dst_vm.add_args('-nodefaults') + dst_vm.launch() + + src_vm =3D self.get_vm(name=3D"src-qemu") + src_vm.add_args('-nodefaults') + src_vm.launch() + if src_uri is None: - src_uri =3D dest_uri - source_vm =3D self.get_vm(name=3D"source-qemu") - source_vm.add_args('-nodefaults') - source_vm.launch() - source_vm.qmp('migrate', uri=3Dsrc_uri) - self.assert_migration(source_vm, dest_vm) + src_uri =3D dst_uri + + self.migrate_vms(dst_uri, src_uri, dst_vm, src_vm) =20 def _get_free_port(self, ports): port =3D ports.find_free_port() @@ -65,18 +67,18 @@ def _get_free_port(self, ports): =20 def migration_with_tcp_localhost(self): with Ports() as ports: - dest_uri =3D 'tcp:localhost:%u' % self._get_free_port(ports) - self.do_migrate(dest_uri) + dst_uri =3D 'tcp:localhost:%u' % self._get_free_port(ports) + self.migrate(dst_uri) =20 def migration_with_unix(self): - dest_uri =3D 'unix:%s/migration.sock' % self.socket_dir().name - self.do_migrate(dest_uri) + dst_uri =3D 'unix:%s/migration.sock' % self.socket_dir().name + self.migrate(dst_uri) =20 def migration_with_exec(self): if not which('ncat'): self.skipTest('ncat is not available') with Ports() as ports: free_port =3D self._get_free_port(ports) - dest_uri =3D 'exec:ncat -l localhost %u' % free_port + dst_uri =3D 'exec:ncat -l localhost %u' % free_port src_uri =3D 'exec:ncat localhost %u' % free_port - self.do_migrate(dest_uri, src_uri) + self.migrate(dst_uri, src_uri) --=20 2.51.0 From nobody Sat Apr 11 23:02:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1772545509; cv=none; d=zohomail.com; s=zohoarc; b=FMPo+nIeyWC862Y2ShbN9xgrXHMQ+bjpEmvIJPP+uAh5FjBZdmhTVF5S3I5MM4DepHoplj9wW3CLxlwK/4RNLd/izbRc1QiXxxmZjjbQ6Va/UKBxOT9dcJWelNCl4F95FTygH+mZREs/o0kaL14X3xZ/8lPZbwQypPJ/5+crMdA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772545509; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mxjeLUJszQMmJ1r35bQr9hxExQvM5gWxQasZu3M05Es=; b=NvhG1oSU/wlexw0mIf8W/RwJg48wkxTrt20QKC1IG3SoEdAsbFPXuAXF29siIhAUqpntcsdaQGrLBmTT6C6PnwJlnXZQDLEgBW2VtTYHS9qA+6GhzMHMp4k2ApftV0I0W45K+FhZ6Tv78YT4HQse8tN2S1iOUDNZuYbuuHj3cLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772545508693870.4229525524781; Tue, 3 Mar 2026 05:45:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxQ2v-0003NK-O8; Tue, 03 Mar 2026 08:44:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxQ2r-0003Mm-LX for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:18 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxQ2p-0001NQ-Gx for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:17 -0500 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 234143F1F6; Tue, 3 Mar 2026 13:44:02 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F26D83EA69; Tue, 3 Mar 2026 13:43:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6OkZLZ/lpmlXYAAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 13:43:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxjeLUJszQMmJ1r35bQr9hxExQvM5gWxQasZu3M05Es=; b=xUAh6JksFPIk7zzpdXwz5JzZT+RzLtpoIY28kfEY9RxZpiJVnwlmW1Wrpjh2ysjwitlvYO 4kr1HF4z6n5qpjXOsr2LOyeBxcQNDexoVdhLLhKTmwn824QUX8dTmvZCegYOTMSAdTP2R1 m10mW2UsNvWO2DVVpmBFv+2pRVNrfKE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxjeLUJszQMmJ1r35bQr9hxExQvM5gWxQasZu3M05Es=; b=aVPMlMFg/hc2W1r8lPYWWYshVbUYFcsu5byZqG++SbJ9MJ1DMzv1V8InQdhCUtCEZw8AOY O8/zNr6n+/p37dAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxjeLUJszQMmJ1r35bQr9hxExQvM5gWxQasZu3M05Es=; b=xUAh6JksFPIk7zzpdXwz5JzZT+RzLtpoIY28kfEY9RxZpiJVnwlmW1Wrpjh2ysjwitlvYO 4kr1HF4z6n5qpjXOsr2LOyeBxcQNDexoVdhLLhKTmwn824QUX8dTmvZCegYOTMSAdTP2R1 m10mW2UsNvWO2DVVpmBFv+2pRVNrfKE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxjeLUJszQMmJ1r35bQr9hxExQvM5gWxQasZu3M05Es=; b=aVPMlMFg/hc2W1r8lPYWWYshVbUYFcsu5byZqG++SbJ9MJ1DMzv1V8InQdhCUtCEZw8AOY O8/zNr6n+/p37dAA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: adityag@linux.ibm.com, thuth@redhat.com, berrange@redhat.com, peterx@redhat.com, Nicholas Piggin , Harsh Prateek Bora Subject: [PATCH v3 4/5] tests/functional/ppc64/pseries: Inherit from MigrationTest Date: Tue, 3 Mar 2026 10:43:47 -0300 Message-ID: <20260303134348.8890-5-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260303134348.8890-1-farosas@suse.de> References: <20260303134348.8890-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[linux.ibm.com,redhat.com,gmail.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1772545511933139100 Content-Type: text/plain; charset="utf-8" Make the PseriesMachine class inherit from MigrationTest so the next patch can access migration routines without needing to instantiate a MigrationTest object. This is just for cleanliness of the code. Note that creating a separate class for migration wouldn't work quite well because the class attributes of PseriesMachine would then have to be exposed to that class somehow. Suggested-by: Peter Xu Signed-off-by: Fabiano Rosas --- tests/functional/ppc64/test_pseries.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/functional/ppc64/test_pseries.py b/tests/functional/ppc6= 4/test_pseries.py index b45763c305..ce39e16a22 100755 --- a/tests/functional/ppc64/test_pseries.py +++ b/tests/functional/ppc64/test_pseries.py @@ -11,7 +11,7 @@ from qemu_test import wait_for_console_pattern from test_migration import PpcMigrationTest =20 -class PseriesMachine(QemuSystemTest): +class PseriesMachine(MigrationTest): =20 timeout =3D 90 KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 console=3Dhvc0 ' @@ -116,11 +116,11 @@ def test_ppc64_linux_migration(self): wait_for_console_pattern(self, console_pattern, self.panic_message, vm=3Dsource_vm) =20 - PpcMigrationTest().do_migrate_ppc64_linux(source_vm, dest_vm); + self.do_migrate_ppc64_linux(source_vm, dest_vm); =20 # ensure the boot proceeds after migration wait_for_console_pattern(self, self.good_message, self.panic_messa= ge, vm=3Ddest_vm) =20 if __name__ =3D=3D '__main__': - QemuSystemTest.main() + MigrationTest.main() --=20 2.51.0 From nobody Sat Apr 11 23:02:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1772545494; cv=none; d=zohomail.com; s=zohoarc; b=SZ3+3jhNiJ4eDjr3zEpaWuuofARtjeTV7gh+NL1z+4+0JkO34u/bOd2/WY0UI1HUs36swZK+Cy4hBAVTvdCORLAxM+5NrRrhSQ6sGxl3jjThXxbTK/eGxCqbSQmeZqUe9EI7EbQgA/rjvPbyZ29HxAUe7ZY1PxLFwJa4U0bc14c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772545494; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7tGonAeDe2b7I3VQ7EDQZfqIbH3fBzOO/S2hixyrBN4=; b=Qfl0bZLN3a7mF06UlcqnLX3ATVp8w0qWquDVuRL/u27XA+5g50n/wg10AJ3wPeIA/HPvYn+tvSW7GGh/z7i04+DyOaOe54ogpMEsrcepktiza2zwruNUEH/B/Pg4HlwBZRHgROIJTW3PZHUUiL5VLeHHtnJuV2JUI6w5hlzOvn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177254549459997.19814667396247; Tue, 3 Mar 2026 05:44:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxQ34-0003P0-Un; Tue, 03 Mar 2026 08:44:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxQ33-0003Os-RQ for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:29 -0500 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxQ31-0001OM-Ig for qemu-devel@nongnu.org; Tue, 03 Mar 2026 08:44:29 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C127F3F7F2; Tue, 3 Mar 2026 13:44:04 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D0613EA69; Tue, 3 Mar 2026 13:44:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aERAGKLlpmlXYAAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 13:44:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tGonAeDe2b7I3VQ7EDQZfqIbH3fBzOO/S2hixyrBN4=; b=uyVNn1M9jN64LjaMUxoWDB3TcfgXZK1MyafnL5ufuiVYlyn0UI+55FKlSwr5dCdrWT+vtC 3Sw3X1ndso9OM8ch4h85kRTO9KmTq/gHHYcglKTr/BHjD9UCmLTMgnZFkXsTZvIykIcKiG 51G/YfRIe5HnYMNpm06B6l6RYqhBOrU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tGonAeDe2b7I3VQ7EDQZfqIbH3fBzOO/S2hixyrBN4=; b=3/QXZWLvoaNgRfout1VwDVM2MzXXdzip15dhc/vNBXNzC5feh0I9bnaDolg8CBlvZwIPKe iHHy5jK0AIksbBBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uyVNn1M9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="3/QXZWLv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772545444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tGonAeDe2b7I3VQ7EDQZfqIbH3fBzOO/S2hixyrBN4=; b=uyVNn1M9jN64LjaMUxoWDB3TcfgXZK1MyafnL5ufuiVYlyn0UI+55FKlSwr5dCdrWT+vtC 3Sw3X1ndso9OM8ch4h85kRTO9KmTq/gHHYcglKTr/BHjD9UCmLTMgnZFkXsTZvIykIcKiG 51G/YfRIe5HnYMNpm06B6l6RYqhBOrU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772545444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tGonAeDe2b7I3VQ7EDQZfqIbH3fBzOO/S2hixyrBN4=; b=3/QXZWLvoaNgRfout1VwDVM2MzXXdzip15dhc/vNBXNzC5feh0I9bnaDolg8CBlvZwIPKe iHHy5jK0AIksbBBQ== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: adityag@linux.ibm.com, thuth@redhat.com, berrange@redhat.com, peterx@redhat.com, Nicholas Piggin , Harsh Prateek Bora Subject: [PATCH v3 5/5] tests/functional/ppc64/pseries: Remove custom migration routine Date: Tue, 3 Mar 2026 10:43:48 -0300 Message-ID: <20260303134348.8890-6-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260303134348.8890-1-farosas@suse.de> References: <20260303134348.8890-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux.ibm.com,redhat.com,gmail.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCPT_COUNT_SEVEN(0.00)[7]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Rspamd-Queue-Id: C127F3F7F2 X-Spam-Score: -3.01 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.322, RCVD_IN_VALIDITY_SAFE_BLOCKED=1.141, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1772545495067158500 Content-Type: text/plain; charset="utf-8" Don't implement a custom migration routine at PpcMigrationTest and instead reuse the generic one from MigrationTest. This removes the dependency of PpcMigrationTest from PseriesMachine. Having one test import another causes unittest code to instantiate the imported test, resulting in the setup and teardown methods being invoked for the imported test class, even if no test from that class will be executed. If run in parallel, the extra setup/teardown methods that result from importing can race with the ones from the actual test being executed and cause the following error: File "/tests/functional/qemu_test/testcase.py", line 238, in tearD= own shutil.rmtree(self.workdir) ... FileNotFoundError: [Errno 2] No such file or directory: '/build/tests/functional/ppc64/.../test_migration_with_exec/scratc= h' Fixes: f4e34d0fd5 ("tests/functional: Add a OS level migration test for pse= ries") Reported-by: Aditya Gupta Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/functional/migration.py | 5 +++++ tests/functional/ppc64/test_migration.py | 11 ----------- tests/functional/ppc64/test_pseries.py | 4 ++-- 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/tests/functional/migration.py b/tests/functional/migration.py index 49347a30bb..e995328e83 100644 --- a/tests/functional/migration.py +++ b/tests/functional/migration.py @@ -65,6 +65,11 @@ def _get_free_port(self, ports): self.skipTest('Failed to find a free port') return port =20 + def migration_with_tcp_localhost_vms(self, dst_vm, src_vm): + with Ports() as ports: + uri =3D 'tcp:localhost:%u' % self._get_free_port(ports) + self.migrate_vms(uri, uri, dst_vm, src_vm) + def migration_with_tcp_localhost(self): with Ports() as ports: dst_uri =3D 'tcp:localhost:%u' % self._get_free_port(ports) diff --git a/tests/functional/ppc64/test_migration.py b/tests/functional/pp= c64/test_migration.py index a3b819680b..7d49ee175b 100755 --- a/tests/functional/ppc64/test_migration.py +++ b/tests/functional/ppc64/test_migration.py @@ -22,17 +22,6 @@ def test_migration_with_exec(self): self.set_machine('mac99') self.migration_with_exec() =20 - def do_migrate_ppc64_linux(self, source_vm, dest_vm): - with Ports() as ports: - port =3D ports.find_free_port() - if port is None: - self.skipTest('Failed to find a free port') - uri =3D 'tcp:localhost:%u' % port - - dest_vm.qmp('migrate-incoming', uri=3Duri) - source_vm.qmp('migrate', uri=3Duri) - self.assert_migration(source_vm, dest_vm) - =20 if __name__ =3D=3D '__main__': MigrationTest.main() diff --git a/tests/functional/ppc64/test_pseries.py b/tests/functional/ppc6= 4/test_pseries.py index ce39e16a22..7373ca1647 100755 --- a/tests/functional/ppc64/test_pseries.py +++ b/tests/functional/ppc64/test_pseries.py @@ -9,7 +9,7 @@ =20 from qemu_test import QemuSystemTest, Asset from qemu_test import wait_for_console_pattern -from test_migration import PpcMigrationTest +from migration import MigrationTest =20 class PseriesMachine(MigrationTest): =20 @@ -116,7 +116,7 @@ def test_ppc64_linux_migration(self): wait_for_console_pattern(self, console_pattern, self.panic_message, vm=3Dsource_vm) =20 - self.do_migrate_ppc64_linux(source_vm, dest_vm); + self.migration_with_tcp_localhost_vms(dest_vm, source_vm); =20 # ensure the boot proceeds after migration wait_for_console_pattern(self, self.good_message, self.panic_messa= ge, --=20 2.51.0