From nobody Sat Apr 11 23:08:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772501642; cv=pass; d=zohomail.com; s=zohoarc; b=WQ24s4Y3wQePqsNIqTmviK2hW7Q9oER9hhmm2xafbrUozICeOWH7XpWfPt+cFkfE4jbSoNcnkNzsu4D13slWYk2IBE8efkDvg+F2GnrWg/jJSqZzm9GyMB5G78lp4rkyTniWiNN1Blb8Xcrj/uIaD60v725dZGjm2JlQCyuuLYI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772501642; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s+GR2S7YkbEsBdgqc3Yoq/8fBKVYEvLAthdvH9b2SwQ=; b=Q1cms/rCTAsmA/6vpwKwJ0WtY3Qv1CFYvzvorhmIJeRGeJwM6KeHHS96Lidcor+raLqoxLxp+HEJY+76ESoUGItc1Lgpw1fQsik6aLWNdtKNFNhXPkzokv+e/SnkE5bHL4s4sFFfIRQidJTlJYts8+dbSyDAq9oICP5Y1qa/3zo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772501642449447.6128926285371; Mon, 2 Mar 2026 17:34:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxEdl-0003UL-OO; Mon, 02 Mar 2026 20:33:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdh-0003Tk-Vm for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:35 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdg-0002EW-LP for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:33 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by OSQPR06MB7973.apcprd06.prod.outlook.com (2603:1096:604:429::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 01:33:25 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Tue, 3 Mar 2026 01:33:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WlINJEduh0jEmneTvsnJBAzM34zyK2D5hLjGrWhuD/uy3HSb1qf8FrlcRkTI4TQ+qAa/GwYZUNRKlv2ACuLXxkceKrEcDykxr2+m+YfqufOjWEm00nRBTBs6KlPowuWuN1B5AXZlWKAGRhggGxFdQz400sfOltWe0crL4k5fLHs0Ex4vAmrE7NJfdbTOGrrzWRUba+1goNy2VPF+GRvckPAqN2/uSkVnUwp+tRv50oOloIRr0oiP9b5XiwNTpOQQJyegBftjN72/0R05KTRg//A+TOvE9rRTC+YD9z9LyhVYjZQwJqkm+keE5Cc/t6W8523eQxW5S/jSfhOOLUQT2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s+GR2S7YkbEsBdgqc3Yoq/8fBKVYEvLAthdvH9b2SwQ=; b=N37Pglh8NwX18KLWT8DhNQemCuZvql3i+axqAWQrPnTwA0d4df3RMfwfSu2QvEkHYdQq3hmDrBigS32QBaT4bG28G50ucP8l3EIJnhCUUUr3wKx8np9pPYCJpD71ufHBQth8b0l03WAoi2aPIpnOk2Vb3sA360LkRBkly46iYUyh1DTcP7ebSnb5/+nvvJP1tKYHb/RVp188MHDcEhEmtWeJGupJhmpyXHG1mPI8fhrn066j/JG4VNWhyA4TDpgTL7IllcSWMTkIUNAVRNVMZsao3a8Qi9tZNs5TKjuSnrnViNRVJMxqZttoOlsr31XoTkAQehh+XrfjY/+mR3eETQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s+GR2S7YkbEsBdgqc3Yoq/8fBKVYEvLAthdvH9b2SwQ=; b=MV3uX+/i+N3OmugehZ2CptsgnErHT30UTf4DrKxlTcRRfww7+fDgAv8htv1/WSzmt4w7djxRX6227CKnu2yARzycjBbF6oCMRZ8w4+gIL1wSPW/MygnHWlhOfj7DSA0ePFPu8tXZQ05mVRPYCwRpZsbCQ73oLFkv5Fismjxt1STDDpKR7L8RBA1pZFnDc//RG2Cf6CoiJrlzJLgU4UeALU/3Df8swL6pXI8BsUdUo1l9HRKP2pMjmCY+mViEKIPAIdQfZy8Y6BFmzzbbE30skkWyTdZHnCBgsEhD151QNPVaXoLlR4P1v3qUnGE5TudowWxwzy8t/iPk7IcRMn8OFw== From: Jamin Lin To: "clg@kaod.org" , "jithu.joseph@oss.qualcomm.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen , "nabihestefan@google.com" , "komlodi@google.com" Subject: [PATCH v2 1/4] hw/i3c/dw-i3c: Use ROUND_UP() for RX buffer allocation alignment Thread-Topic: [PATCH v2 1/4] hw/i3c/dw-i3c: Use ROUND_UP() for RX buffer allocation alignment Thread-Index: AQHcqq26TxDo8hMDak+MUH+hFbYV5Q== Date: Tue, 3 Mar 2026 01:33:24 +0000 Message-ID: <20260303013322.1297499-2-jamin_lin@aspeedtech.com> References: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|OSQPR06MB7973:EE_ x-ms-office365-filtering-correlation-id: 9951bcb3-befe-46c3-6193-08de78c4dcfe x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021; x-microsoft-antispam-message-info: ErQCeQzYpgEOvH3+EMPvEvTVnUAK0zHAjKebSR2HDJt2PSdjuHpj8T74mVG1Whfp3c6hvdd6DFSJoaI09XfLf9wbzsVlQR6GVbIx5aiAtOpJNZgCnK/+OaTqVDxnT4eN+KwEOQ6ZZkpp8448dyLPpIQi/EBE3bZe9F9o7eyiVGi1i52OFwHQd61nF9zMBLfSWf7Db596W7r3aiN1pLKaJMXmnzYOTiSxtLDWMY0X+VdcNkYwb8IV3XgU1N2mOFhB/xoQe50TVWhCidMTXryrYU8lly1IKw/iDvhO75MG1n9g7oi9+4RtPWklM5WWOOOya1mtpdBwJt56tOTam+gf7cS7Smm3QWqs2TFqaXVgqrtD6RGU2kSbTKvTdcorJUYfeeWQOkYfHS0MoSMFSGYtV/9wJXtlk7kUO4+4evxSmVGsc4sMgOj9BLlSQlPx36+NHVpfCUVUJKLrCkeVo8HY6GOa6aRYokM6mhYXmXXjggTfOlNdGSljRJJaPHtWumIfQs9cgT9eHV5OWvBCzQgWq68Q9HDrizfEL0DP8BVzI6TIyLy7Wnqb5GjmLFWY2xNY/CrlUSft/pEig4AaD2S3PDCMtYPERJmxgwIIcqgnDk0lwt1XbW/20BR1olqVJrlVX5p+Ovnp7Lbh4blaHHNMsfu8lK/t6f3+NxYio7QKInP+LmOYYp5OXoiLgjNxIK5LT7RUGYhooGAdQyjZw/kvU25fLc+vvUtsmroyIoJmglNN9gXg3f2/+P5SmrHemBETGb9KKVPjpswfWnYksdIYbJ5bc24f/Z6nF2OGnw9Jiso= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uVpWr8ujUGm8d/6fkp1XVV4Pcyh4m9HQya0pNZ8tP3B5TLH6+QACVc8Zsj2S?= =?us-ascii?Q?i7D9KKpyC3rMf57rCxyx4Zpl/RV6jQp5WlUaQnzxHB7KN8mSVCIH3wwYGSUM?= =?us-ascii?Q?NygmiidxOR5VA4RxcVaa2bUe3OFanH9ikWCKqKtcJZM+VbBFnxETfON2FLH6?= =?us-ascii?Q?fXvsV6kzrRridjsQ6koDIPJGoHMQBSNRTkiEvAQXEo1eisXL33t/38U6Vvyt?= =?us-ascii?Q?H5diQy5eqgSBZqUpmGPFvidaNshWnGLjxHq/PqafdRgwFp0dmYMLqZZ2lfW9?= =?us-ascii?Q?MlaAHrZpJibe2gyZ3SYltlnjxBajUEmx4si4DIkwtoUqH7vCm74zJ89oS0wA?= =?us-ascii?Q?oUeRMjfR1JVN4Ld4JXaNucL0xpp6HQMyf2cf8Hqy8UO73hUFaXAxiWLB6laO?= =?us-ascii?Q?ekOHxvp+HNFKWzzWwunODm7omcNaFHAkoHq8FLYuvN3XUoflRIwntKtvSP9y?= =?us-ascii?Q?FxVKjn45R9S9Rr73YrixsM4gGvxz9zBRv2mnv9C78YOCJ97X7a+7YH43Av5N?= =?us-ascii?Q?fxzHpl6UyTbLNZr957mN7eeH5SiiyRmjeOU3H76qrXwimbo2aq3PGqhrazyc?= =?us-ascii?Q?FVRXdq1FjiXQ014ykBTAAT09TLRGNkmzZtMTyOfwZSkiOcChagdQ2kPzm0Yw?= =?us-ascii?Q?5FLfrGxQjBsUPhpk/lj3twyGyUZxg+hQcAqU/n/CqLZkJct0g5yuDP8UnLP3?= =?us-ascii?Q?Xvy35Ar0v4HgSg/uzYdhmg7kBh3DW6kJIE8mO0SdPlBGrWXPvT1UzQWrOQd3?= =?us-ascii?Q?iVJok4NAXxIHG/PjyiiMv03vLPQNB8JIiZ0e7CpIn98TZ8ciqlxa0b9IAye2?= =?us-ascii?Q?IIByub3qJZ/EsD7s3xv2bbvAfc8eK8IqslZ9WV7eCz6D2ZhAXBkBGXbxMmHW?= =?us-ascii?Q?GqTVkOFjCyOMfCyAVykcYDVcP82K7LBly+4ZJbjt2RTvJU0ELzLxXd4XX1yj?= =?us-ascii?Q?wuGtsbeUK9tCMA2juWQhWm4aatEeRKTAZN9xdQLc1nwn9LJEa40Btz975aTR?= =?us-ascii?Q?BsPW40+10mZI04LUnlreuXoKklPegCsRexm8FLgMnzhxstYHMtH0kMnSHjQ1?= =?us-ascii?Q?SbKKXtQM8XeUAgT9Gr/WnGoE6iFu7D9nMt9RV94o34nDaUIJB0MTLzP5GepQ?= =?us-ascii?Q?rXWx0VGNC7T2CJmSe59pxJPnD/xDLHwTmqYJFLiJCcJamhaK0XtQVe1ASOhh?= =?us-ascii?Q?3EJ9Cd2IRM8V3JSlMjvKLi4TErrnQ3YJM9pSyvdfYLATIC1ldSuVRNbSIplH?= =?us-ascii?Q?qkcqmfLT+O5Th1lfIobzn+OrU89vwNX2wRmQmOBaKtCeibmh7lBBmhQN9ldd?= =?us-ascii?Q?hkkv9sZof3tau8LUdx2krBr9UgmcbFSDbn72DOz99YvSCPGZRd0MxccYrh6I?= =?us-ascii?Q?tfTa1HB2LZPHY9aehA0HNM4AvfLxPQd9342UVCej0L87w9+CCLS3RdBCrwo/?= =?us-ascii?Q?uFOfa5fmJ8IFJ/C+LrkhFaUZilAcnDtsj5i3ON9R3dO8POGMzW+kW8hmB5VN?= =?us-ascii?Q?E3EMMObz0cuP81MoNj9WRy0c44EvxQqZssBGyhRTq76fP7oG7uvzG6Jap4MH?= =?us-ascii?Q?ONhO33ffYmmUIocbUj2JKAqkgzrWClRYTAM5qYS4zZqJgPG/dTL3nNoxA7DM?= =?us-ascii?Q?C3GQAMp0b+cQTawR+nYpcgXAiHJnU5sMOOrVfHvO8ZnUN3ctUujfYrV9NrZZ?= =?us-ascii?Q?eDdzdJJrHs52ZFl+ovb4ZytUwlybegLAZStAdlHk/gIaB+68bNxRgB7IIHd7?= =?us-ascii?Q?DHNmbasHAA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9951bcb3-befe-46c3-6193-08de78c4dcfe X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2026 01:33:24.9657 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wffh+Lor5OwP4v9+7nhSAjGWa+skgQm2jrLjnMPtzqYUogBnRQWlMCvkIFe8XjU9PjnlB8uCPeaGK83YSKPc7Iq0Vgk37z3D6k/ecUV6DrI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSQPR06MB7973 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772501646974139100 Content-Type: text/plain; charset="utf-8" The RX temporary buffer allocation manually aligned the size using: num + (4 - (num & 0x03)) Replace this with ROUND_UP(num, 4) for better readability and consistency with common QEMU coding style. No functional change. Signed-off-by: Jamin Lin Reviewed-by: Jithu Joseph --- hw/i3c/dw-i3c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index d742458129..3d8b95a14c 100644 --- a/hw/i3c/dw-i3c.c +++ b/hw/i3c/dw-i3c.c @@ -1282,7 +1282,7 @@ static uint16_t dw_i3c_rx(DWI3C *s, uint16_t num, boo= l is_i2c) * Allocate a temporary buffer to read data from the target. * Zero it and word-align it as well in case we're reading unaligned d= ata. */ - g_autofree uint8_t *data =3D g_new0(uint8_t, num + (4 - (num & 0x03))); + g_autofree uint8_t *data =3D g_new0(uint8_t, ROUND_UP(num, 4)); uint32_t *data32 =3D (uint32_t *)data; /* * 32-bits since the I3C API wants a 32-bit number, even though the --=20 2.43.0 From nobody Sat Apr 11 23:08:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772501670; cv=pass; d=zohomail.com; s=zohoarc; b=EuQwlS4Ti0oYg0QUvy7hjdnvJ6n94SRPOkywT4Melo7GGKnHuqEN9kv9OvvHYcaG2Uqxlun55FHBDRZvNzckf0HtK/YWvEQbdNQTkFT+BwQXJRxakqZljDYZttwb9puV8AxhDFOL+6hOOvYGJ4flMUlqWjIz5TwbshHpUfIoR2A= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772501670; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0Kntvg/V3aHOZQpayZFnF3ouGujiRPvjviQLqXow8U8=; b=f2b6gCENRwFRGthR4IsK30BWuIdvtC40N9eDE3j7C99WAYJShVe/uygpzb7hKuUeTGQHBOEk6a0zbqGg3/ImLX7JqIQTOeLHvtMYQqs0Y1PBqdvshF33WrVT+s/Ja19ZEV/teCeBsxH6+QSirKk7Maamr84GtWgVyRdQbVE7Tuo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772501670561628.3232623219253; Mon, 2 Mar 2026 17:34:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxEdm-0003UX-N2; Mon, 02 Mar 2026 20:33:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdk-0003Tw-9W for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:36 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdi-0002EW-Dw for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:35 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by OSQPR06MB7973.apcprd06.prod.outlook.com (2603:1096:604:429::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 01:33:26 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Tue, 3 Mar 2026 01:33:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cGshY6+ACzloDp76dKdWC3W/6nAcpKHjAHdu2oJcuYI7YLBoO4FF7KhHnGtaEq+dRVDNTc6+Mpt/dbp4dz1kFSdnrr4QxxhcuJPHcc4+QrSUKjI8VWN19P9g+nBrR680eCVymbPrEd5oo5gL6usmmRJRi6bWt6dHg1taQMAjI7FyORSN1gG9BV50/ACelj5fp9IUE7aFlgtJkeGlOSipzYFBrsILyD2WrfrfrLR1jQLonVVIMDbLCXUcZH5SbFLOJbZddN9Oed+fL739TvaknqAtX6HNzUggwHk2GkTaG4jQrQbKQdAnmxL8pMaXNE8K5vGGdavz5BOpg1NZsdDUNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Kntvg/V3aHOZQpayZFnF3ouGujiRPvjviQLqXow8U8=; b=nJtSsE2Xov2qPbAqKGPiXeQ4DKrTePgP/cbm45mpAbAXISsm5hlWaTAAblUZCfYyOkqw8FA8kfPaIwvIRdQNQtAZthAhhvC++Q1QKies+vmuQq3wJ8/QxGQgVNb7CbraXDUuCfjcEBGTM2WbUBNQBEPSRUSEoCKRU1PChTwSdJmJNghCKeswEXpB7iFcQsl+5VIS15nvrkPOjI9vnIXHKg4pIy540ENxJWvxaoCWiRDfbjpfSd1d5X5ZevXmW1leNJA+peYvuI4k2uJOh+gv3Z+WkQ8ralteeg/Hw0b1EEfQYm3D+o2/8d/7LzigQuThd8qc+lu8sRYWxDb0tIs9Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Kntvg/V3aHOZQpayZFnF3ouGujiRPvjviQLqXow8U8=; b=D8Xn3shCxJ5BYyBkGqiKLLv0Z3SaNN06OmSJrpFiGyWtIT1YZkUtCH/zDrUmg/+DFdLhePwYi1XmS4rPGsImIJMaVvHjil2wk/lpAVfvQLI7rShST61oyHuO008GQwofVVALZCkZpGTs/sMJld/o4Zll+NJba3SRPpD7qK8Pl+Cv+OZcI4795j+wTz7o1ZHoCIyJnp66lk82klPFiDrUOf3CP91GZG2ee20AJac9RteAZ1GhAbeoSR9s9WmL+W/bMXIPhg8hUrfo1aQed/ttofzGGuymazx+oSHi8mw0CRciVrehziTI+tHWpvoFnsZyRXdPonbHqJ3VjkExSgB59w== From: Jamin Lin To: "clg@kaod.org" , "jithu.joseph@oss.qualcomm.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen , "nabihestefan@google.com" , "komlodi@google.com" Subject: [PATCH v2 2/4] hw/i3c/mock-i3c-target: Set num_sent in TX callback to fix trace reporting Thread-Topic: [PATCH v2 2/4] hw/i3c/mock-i3c-target: Set num_sent in TX callback to fix trace reporting Thread-Index: AQHcqq27BCjm/UPI70axFquwN3Bi2g== Date: Tue, 3 Mar 2026 01:33:26 +0000 Message-ID: <20260303013322.1297499-3-jamin_lin@aspeedtech.com> References: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|OSQPR06MB7973:EE_ x-ms-office365-filtering-correlation-id: 81798e13-34eb-4b4b-379e-08de78c4de13 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021; x-microsoft-antispam-message-info: 04cseiBU6ouc2AF3qgmGY3nNreq81OxgNmTYQ+t16JM6lPCSwmkHUSLIRkh1fH5XsS1iOwrbwULVLhFDdK+j/ol3z0TvokjtVYSKNmkohCa8Dz/bK0QG/qtgGyc9JWiCHUXdwLyV7f11k86n2mxDbqrTijx7+Zma650GC4TTOHI8rieu8DVUOpUZYcWnd7sa9wmDXJBnjH6EuYmZ5sxRSvhomrTM0gDWKi6cj1dhnx6fptNqu2YkPL/8n1W53O6VROxaYj/jGaq4F4AlqBWLZHjHsoDJYub+a5xIcmp/SZGbC2SCzcslyB3tuXJZ0jrpmtV2Loxy1i547kHkct6soxeAijkcB9khJTNSZ8lfoMQXqaXHfovYuaYaeHD+BeDVVymxCjQdWSZZr6k87u0JEuszwVzmO3jd2QZDAoUakdlMEAPrWiTYPj97RKjkQvWotWTsmMfsEocljtwDLozl/9C6yNcmLpBSXFd96Fxbse8wcUy3OgCuK/K+iqsUU9qD0iJeoe2wZE1bx2YaoUTh7TA2tUhOFW7BFsIpsBcOb/VEZaLBanTPqt+WagUGbrkcxyflo9A6wYxnQ2+guXJGYhUMElxWiGW5XrBirZhzse0mLFc9BtQwI9T/jszTNIfQO8fwYLOVA5priEmlR7oPgygrIhbOi+YkwP5cN5PiI91RSbsBn2WXXBaD7uYwgWUr/EpmLcoZ5EGsXDzK7Y5idmr8hZgfbgbHM6v7xf/CpLqkv1N/vNrTGh/r3i2/vnfqc8D1cJ0fW9WbWJnTCgMfkzXHQxxj3AvZIe+QdAEy2uU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Skxe/QAmWjPCVLaLe9n/G0eFUol02z0PeWguSHAJBX5+jnEzksgRvnYGAsyL?= =?us-ascii?Q?2+3h1GzhV6/FEgLKz0IDwz+wbOHFRaNAb6SuW5ZJSwBioQaOv1n1FqHQWMnD?= =?us-ascii?Q?5GJrZPrHhOuzsCOKSUhoBalcguC3pS9essqIBoX7lvstEvy4zWGxuOCifvCb?= =?us-ascii?Q?cwn0YGAWyZ9SjgBVHaSoY8uMqIbZgPcw67emQsW9/eW4TmmQEVuzg9tXsQdm?= =?us-ascii?Q?dgErTsasQJXFMlAcd+lWShcG0B1Uo97XIXm7EHGbfDBxhfgP+GSJNQYdVdYN?= =?us-ascii?Q?0P97fjyieiGHEE54dOiR9fr6y+gjhP+mBk4OHUQ9DVSyMzaGA2Hn21ylVXGs?= =?us-ascii?Q?rPyAqd3JOYXH6maO6Oj5pwlH+ggpScngtAnXhomj9KCv1ONh9HUyv1Tt9MsU?= =?us-ascii?Q?oOmoSuTC2Jptr3cJtx1k8HVuYNmfGfsNeWeRagzZX0to0INLudGu54yIzmo2?= =?us-ascii?Q?viYmUEijE6VbLmtiWN6KAdADTbFccx/1mI3MNxlmwWIuOjwLLa2q9bOFNLu7?= =?us-ascii?Q?pIyPnoshf39iVuZmC+lg+ATeiD2zRsveDtrsvqK41eeSTClxUw8cZjOLhndM?= =?us-ascii?Q?cun6sInWAlGyoMVRvmJmQX9O51T9biy/yfUdyfHIMkgEc2gdePJsl7dwDZYa?= =?us-ascii?Q?Ql/J7I2mo7eMvp6f/3zbMbzMdG/JVvEEWL/hqrwwFGat1u18zVhIxrzgr9wq?= =?us-ascii?Q?JnR+G8er5/qsTWbnIWRl5kiEIKwQq7vC90GiNOlujb3fA7nuwMFLjZF7zAbi?= =?us-ascii?Q?wC++4JLusteVBoDrOtjZ37jew6Bs98cZPUnYxo6SPvIGsIJ1dHOK0I2FyROb?= =?us-ascii?Q?t+rBqnXckFoOdtBWZLlescXAE0o2jlMDbDcvKqPUusPKf76ywN9z+19ynmYZ?= =?us-ascii?Q?PurSpG8zGAXpfjxZZoX00XVYlotfA1NMa+Qw+N+p6w+8DqrKbHebCvs7L38Q?= =?us-ascii?Q?g/CuMtHiydomlRa+zZ+QjxfXizgHeYsId0WCKGN0XydPwfMKwlHHqpPtMmIp?= =?us-ascii?Q?DF9osGbee6FLLUl8aBSt57bQ5vMz9n2VKcQtXlFcW+tjwpN0oFL7lyQ29TAV?= =?us-ascii?Q?/ZVXFvigb137Koy7n4wrMcLMCPoWpO4ooXgnrxwJa19U1/ga3T+GGzrui+yt?= =?us-ascii?Q?E3XVuIEekkYa+Oya2jKhBKktXDSXccyUNihnORFD+0dcsyNc/wH6Wt75jYWT?= =?us-ascii?Q?mvy7lFW15A7U+wepkH73m94dmXQtrh0CO6bgsue5cf5Rxn50Cqk1Pe6PkkgC?= =?us-ascii?Q?/cfBK9HdWkIaP79X0IagF8lA+Ik2c+5U0A8TRNnTCfrcRhECfqwGKRl8Pn9L?= =?us-ascii?Q?8lVxfMj6RM/6tSPzxqsGfztla0b0fgbERVqw8Pc7lH2qxKB7QqF7QIEWG3bX?= =?us-ascii?Q?1IHi7x5Tb/QS7AmpRcTOgp1bETsKI35AwLqLzrHlbF4Y4AXfQ24hwxim42nX?= =?us-ascii?Q?bRM+Op0Bt4Acp4oNllurC4Ha22Q7tuMvc6J/1vjbUSphm6xSKShZu1zwzff1?= =?us-ascii?Q?pKxZKWCzXC9Z7jdqW2OSwEUC5fwsL8Tx9c1dEpRJeXFLbfkkfYdQ1uPCtm50?= =?us-ascii?Q?ysSRmTCmWqSFn/HxxSKPhtG7hTK6E4nsJiQxXiPSqeFlWNrdOqXc0hKj6Uuh?= =?us-ascii?Q?JF9lAUxyyWStEdYKeul9hZ2Bt6D+Bn4Om7uk1IfwjUvnITs9VnDlSykaYtcq?= =?us-ascii?Q?SzxMHRRKDsIjIBWTj0QCJ/JrYiElH1g8eCwiA5W5jZ5GHHKZw/NBjvpA4QM4?= =?us-ascii?Q?8HE/8Eu3uQ=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81798e13-34eb-4b4b-379e-08de78c4de13 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2026 01:33:26.7595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J1cexOQxly8lk9cuWav07C+jnFprYj2UVqRhpcEO4ihDwbhsgQ7FwlkubGjeupyLCslSZpQaaEgSdVi+oaNG4qjp/tioPQd7xXWh4vUnDxA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSQPR06MB7973 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772501672565139100 Content-Type: text/plain; charset="utf-8" mock_i3c_target_tx() did not update *num_sent before returning. Although some callers may not directly use this value, i3c_send() passes num_sent to trace_i3c_send(). If the target TX callback does not initialize *num_sent, the trace output may report an incorrect or uninitialized value, leading to confusing debugging information. For example, the following trace was observed: mock_i3c_target_tx I3C mock target write 0x12 i3c_send I3C send 0/1 bytes, ack=3D1 (expected 1/1 bytes) This happens because *num_sent was never set by the TX callback. Fix this by setting *num_sent in all return paths, including the IBI magic handling case, to accurately reflect the number of bytes consumed. Signed-off-by: Jamin Lin Reviewed-by: Jithu Joseph --- hw/i3c/mock-i3c-target.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i3c/mock-i3c-target.c b/hw/i3c/mock-i3c-target.c index 875cd7c7d0..b99709a08b 100644 --- a/hw/i3c/mock-i3c-target.c +++ b/hw/i3c/mock-i3c-target.c @@ -70,6 +70,7 @@ static int mock_i3c_target_tx(I3CTarget *i3c, const uint8= _t *data, =20 if (s->cfg.ibi_magic && num_to_send =3D=3D 1 && s->cfg.ibi_magic =3D= =3D *data) { mock_i3c_target_ibi_timer_start(s); + *num_sent =3D 1; return 0; } =20 @@ -86,6 +87,7 @@ static int mock_i3c_target_tx(I3CTarget *i3c, const uint8= _t *data, s->buf[s->p_buf] =3D data[i]; s->p_buf++; } + *num_sent =3D to_write; return ret; } =20 --=20 2.43.0 From nobody Sat Apr 11 23:08:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772501649; cv=pass; d=zohomail.com; s=zohoarc; b=XKEE/5LFDSFQAE52eYA/7jOiUGShQZSAaFEOV64Ns8eDXbq8yOcVKUe+3S9peYKJYc/Bw9+YuWL3aiLiBscKLEbHvP5eEFLNRLAyokbuHRLaG1ru9Nr0rRozOQoNESDjsYWdA9z5tYHaKT+ZSP4omJC6gGI5xEosv7z7ISVSklA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772501649; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UfvXYpJMFprno6++uMWrXCAq8fS4p6xt/nXKdJmcjPk=; b=ZoL0xju/Ziy3ags0FQzn5pf17POqtI+QxsN8fF8mGYeYqInsKmv8LGQEIaBVZdMsV6/99hzouXLdJx8d/2PLAO7PLegNwKAM/4btEOAdpr2GJ74BOhPqIqfOzJVZiFPk1Jx9CUbZQGoxXSoDobj7gaNEw86TYd26Gl7oJ4FGpSc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772501649641401.40578439778676; Mon, 2 Mar 2026 17:34:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxEdo-0003VX-SU; Mon, 02 Mar 2026 20:33:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdm-0003US-15 for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:38 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdk-0002EW-Mo for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:37 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by OSQPR06MB7973.apcprd06.prod.outlook.com (2603:1096:604:429::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 01:33:28 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Tue, 3 Mar 2026 01:33:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HaFUeZqPExAWqV4t02y0vLAmMAGVG9vYtthHY+wJ9cS2YxnNMKs8cdNIJMJlPZBH7as+ZxH3IY8IwcFiJiYRXkhM5lKjmTAyywZSY36NpwZb4BdGYYWUPq8u2rBKavtdzdPwpDSufT/2wxz5YmUGn8CXaQnqQfmN6YM9ZsFJJP9jSGAUq9j4QgTlWb2wLkP8YLilU96zUXHsWWVkn8YJSGQLyx8AiV9RC0gy6aGJ6qxY5lILU3Q77x4SwNR9QDvZOUXCGx/2WpiprnQXC92gCNG+SUKZsavbhPz5WijUlBz7NPwwq6EJ9G1PpLp+xkLYits5k+oUqQ0LiYiprLyVIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UfvXYpJMFprno6++uMWrXCAq8fS4p6xt/nXKdJmcjPk=; b=oX26a08B4Tcg7o8RYMZiT0g3m0VC0Itzj93FA/uU78yrLZ1FLu+8iRVPLDGXzbP/BLOAWhwSVpZWRBYNQfMyPKyjmGUq4z+mO61xX8r8UEE37FxIU5zxK4Mh6MrY+QUZCCPrb5b5Exok2gQ/rcGxhkhpyL9v+5dVbZp3ts65QBK5lziWCZltQlVsngyAmxOpI2JSkrSJaYsYn3163JyG5fV7VJj4+32GDhmOz+ot2iG16qiE2nHzCHuIoYYMdmdZnj+SwymiCgjTGZmsJJJ+r082+sIp4KuAJCk8nAYHgOFPIEK39FufsfYc21HpitSc91LkDwkrHPAHWxWFoGjrLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UfvXYpJMFprno6++uMWrXCAq8fS4p6xt/nXKdJmcjPk=; b=hPoILxION1Zvl3cATVA2pLvWtz7QHmdqvTHNrMUd3ACpZCw8+GR1yedGifSEyp9WmnQQ3hyJ+GJ7qtNYIw3oSqK+E2FWjVzetZp14Gr1vpZ1IOTbW1eHFz1XuBtvWSbrjjQKT07qdbV5yDgpVnXkpGtPjxnD2Sq81njCGbCrx3iRRiH26zH5j9eJo30TG86+60TVB/FYb87pOj0cDHcxjpQJF0SwfgWuhV+SwoR0OU++HdmDrFoCOZogeE7Tbhp2fStCw6INlAR9Jngp+Tzjlr8nLwzdGVWYSOMb7Yc0Ko2BnH3ngu3cTYB5ZAim6WPL1QaYkm5ccrGAkFJ2aU3qWQ== From: Jamin Lin To: "clg@kaod.org" , "jithu.joseph@oss.qualcomm.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen , "nabihestefan@google.com" , "komlodi@google.com" Subject: [PATCH v2 3/4] hw/i3c/core: Initialize num_sent in i3c_send_byte() Thread-Topic: [PATCH v2 3/4] hw/i3c/core: Initialize num_sent in i3c_send_byte() Thread-Index: AQHcqq28DaPG8eN+NEur5cHXdiUJGA== Date: Tue, 3 Mar 2026 01:33:28 +0000 Message-ID: <20260303013322.1297499-4-jamin_lin@aspeedtech.com> References: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|OSQPR06MB7973:EE_ x-ms-office365-filtering-correlation-id: f250d5bc-f17a-402f-ae55-08de78c4df04 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021; x-microsoft-antispam-message-info: 34IBotLWK/zIWL+U9C20WPsIai0lrjILJd4DngibNQ5YZlUBkbZ9GmRhnq44fQx7LyzY0Vq0yn45zBba6HgIRvYH5nj652yERBwxM4/o8gYNLxgOi2La/+toG2G47mODbcMml37p+JmdBVZh5VuClcxJrvYVHfyAOor/xn1ZT05yE91pAkfjqC9QSjMlCSKwwHIp79LgoZcWt7KDY3Oo1Py/T6LoFMvOYR8MxrmbT4+9di49BWEFvpAunhi9hV3CHnPyp0k+bFgmBwmzq9ssYU8L2/0nlc1HjjE1CYQzfw46IAsNocOFeYK9Xm7iD312Gm5Pxgaf679KKC1x9QPAw78yIT7kaZ4v6tlSsZ99zd31xkVtb+DLolhBFtaHH8ODxJ+DsPUsuLYAt1zcRhQY/TGr8Zgv4RuScmo4wAkU0pdHoMN6jC2dbGgbGlCtEwl92tBLvRcL+FxtOCgud3w6uqI2BwMGvEhyAz4mGpFcE1EJx8Sp6p/qsjqQ433I40+HJU/7EjWk0wG0gGd02oYire9dIqswqVIcUo3jb97N+q8UnGhR4fLOaYmMhILhYMiygdgzHvcE3TdKrkUc40OqFFnK24T3hTTepoRypo9JQUzyjj9O2U99UUdhEHyyOM9qG7jMDDL5auGeGz7jj2ftpy3IBmcuf4fjE0IQLIGnDELW59JFPD/B7JX9mmJgRkQTkvSqfoOpp5rp4jeW4IEWOxil8vPt8qcWBEvufeUIGiUvoFUVa8xzLIgScwwXZjfdLqB5gD189q4/tx5tAk1ullHceFSHk65Brac9Zl6KW6Q= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?90xAouxoJBWwbEza+IsoEOzVdPj9mgGZH3cxW/leqk/Kk04Gh/e+CQrJIqXB?= =?us-ascii?Q?i0cA9Dla6uWVDrQj58UMVGMRqMguYhE2PNHZOKIIw89xhe2fNLGxoSSEmzV7?= =?us-ascii?Q?83k15hyIemdzrWKogmv/ADNy6CfOeIuetyRojwdI85lqUKsMZh34bBlBUVUD?= =?us-ascii?Q?0VTR53bqO3RUUaEZJq9uIVC37FPzymJkh88aNbQratznayOMgrQsSwNfNq1j?= =?us-ascii?Q?a3ah6CVZC4tuchukmk0SxZ+8rxKBh0Zvdr9PCI3ZwuqIH01B6mQQBw3EKUoR?= =?us-ascii?Q?TaiPBRenfE+2/qm1Eia/QSAhAW5MR/Rs6L/jxJaeWmGbiIkuEKL3IeD5QR4t?= =?us-ascii?Q?DvIN+oauLN1imclJ8IFxA1QeqSKphoyLAdk6zjOxj0jyAZK4u/S8rey/Txnj?= =?us-ascii?Q?PGB0zv193ReoaxpOY1S56u0V4RkpkhzkzUU/i2Nf7NcmetfW4V4dpyH/PS+P?= =?us-ascii?Q?qHnlohX7r1pmbxLQ3Vz3eAo4xppIlPkJpI1cHVZukdVvBZ3XvjQg+/DdV+sj?= =?us-ascii?Q?e6lr7geaK/FGL/QvbN0/yfVD3OzI2kn0HDMEWi7bbIdZmdR1/cBkZqhXVjU9?= =?us-ascii?Q?Zg68amfUt1Q9K6uLC5leajhKXpf330bOI4IEvpwIQfRXzAIMsbtRiIKGPzhd?= =?us-ascii?Q?a/hW4eYBrHZv7UDnT3M8E3N2adPgUnRDdkO6vYu+VeOPAqVvmj4ZDApg0Pvj?= =?us-ascii?Q?SFCLFJuVI7OUXbUq9oVOuWQZv0Onth02fx13DcrAXqxDRy6fwZW0PXqBrmdx?= =?us-ascii?Q?EygLYb7gnwGuG+3WiCECBg5d0dP3EZVob82crXqGoZgIdhykevQt24Vy5r+z?= =?us-ascii?Q?NxlKK4uNCkJtp6A2M9niViP7vEiqfIV83i0DRM9h7uE6qkk9BY2IzvnDVDUu?= =?us-ascii?Q?mgo0C7TtL4RAtcMFtLM5h6IW2ko4d2wsgpjPY3IEO6H2fb7Emf5I0WmaDSkf?= =?us-ascii?Q?ViDt+hpB8p5oMS54i72GwZ0/PeWuLTxCrswLBOON5qR/bsmTpwHB5sC0J6G6?= =?us-ascii?Q?o14CdG6c9qxfEseZ3o5F40k4odYNNDY7o0g+bFPaTsWdWEu6PXWO++EqTEbu?= =?us-ascii?Q?DT9zFj/V6kuOXKXMEEGvH3638oFZvhKbSeusoBCz8o+EuaFAJhacALagXI6e?= =?us-ascii?Q?tNdhfcC6uv7/Xv6ek5nxqbB8zRLuqfJ9S02sbTDtnYxSvP2nRCUl9Vdo/8Gn?= =?us-ascii?Q?QtBQzxfT5uv7h5pbSy1QLi3qLz05Jo6YwUfQlU3jiXGj9cIMsoSq4TEcEhu2?= =?us-ascii?Q?63yo/rHoWdcNuMyxsA/YXvlaw0yPSBW/Sks3uonGT/LePSJdKFRds6aDPnD9?= =?us-ascii?Q?0T0CTtX2/OZKxYSqHLghFa0q58GfGPqSrpRUqCl2IhUVuDcaRMtxWo18fZb2?= =?us-ascii?Q?qMTKMIgi8g3R2tvwQFr+vAVAWCeRtGYZKzg8B6ncBO0etAv1wURFuwg1lt9r?= =?us-ascii?Q?NGkVMlUUeZkzyKmfKVIcPPQu8RPNh1Q85k+L7AA3oXODoDqF5SOhL4ijmNxU?= =?us-ascii?Q?MfJXfsZZyMrK7rx5+jjZ7SQVHvdLcv16PFJYqAG7JmejmtMOHb57VF57d1u1?= =?us-ascii?Q?oJ0au1deeJY9gyaonN76smqoNcXu2DPCzPO13rITf/q167Gf91hOGKACs/mm?= =?us-ascii?Q?KYAwxFsrI9narPnBg9/xVgA4rwZz5bo5NmerGbZpQ4xV+NLYWEduDxgaG2aW?= =?us-ascii?Q?56F25h0zAubaqarpVbwwHg7gp1ADHD/eMeWBSBZtLrleh4u1Sl7XI6lJfIEQ?= =?us-ascii?Q?ubF+nwxKTg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f250d5bc-f17a-402f-ae55-08de78c4df04 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2026 01:33:28.3696 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AlLoEhNUuZz6RqI+S2Po78iLKcXqrTBMDAe9U2yQUyO59/rblL0fyjX2z378MQQQSXl4omfi6naerDCuKNe+vljBVsW8HmH603gNAh8wilI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSQPR06MB7973 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772501652632158500 Content-Type: text/plain; charset="utf-8" i3c_send_byte() declared num_sent without initializing it before passing its address to i3c_send(). Although i3c_send_byte() itself ignores num_sent after the call, i3c_send() forwards it to trace_i3c_send(). If the target send callback does not set *num_sent, the trace may print an uninitialized value, leading to misleading or garbage output. Example concern from review: trace_i3c_send(*num_sent, num_to_send, ret =3D=3D 0); If *num_sent is not written by the callback, this trace can report an incorrect number of transmitted bytes. Initialize num_sent to 0 to ensure deterministic and predictable trace output, even if the callback fails to update it. Signed-off-by: Jamin Lin Reviewed-by: Jithu Joseph --- hw/i3c/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i3c/core.c b/hw/i3c/core.c index 0a266e00a2..168526003d 100644 --- a/hw/i3c/core.c +++ b/hw/i3c/core.c @@ -325,7 +325,7 @@ int i3c_send_byte(I3CBus *bus, uint8_t data) * Ignored, the caller can determine how many were sent based on if th= is was * ACKed/NACKed. */ - uint32_t num_sent; + uint32_t num_sent =3D 0; return i3c_send(bus, &data, 1, &num_sent); } =20 --=20 2.43.0 From nobody Sat Apr 11 23:08:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772501724; cv=pass; d=zohomail.com; s=zohoarc; b=f717lp55T5YjsKY+BoW3grqjTkEexuo1VKU9yL7PW9R/YViovGD8NM40Y03F3shySq7lnsPR4mJPiQDTtQO0sJwqgAmJjuEuVz2FaY8UuW7WfJfOBiJ4H9VSZNgXObuDl4JIls41vXSQRnMVkR5HqGiN1r3y+JSYS4ebgYvos0o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772501724; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LZXKZjP+hG9XQtVr1vvmgB/3u2Ai6OttUMu4KB68yKk=; b=IlTzABebZYAnBz5GtrTzVJhEyAoH+XCMiK8PZRs3DOEewu7b/qYNMSaOeQ/6DlL5KtCnUAIzispblKiqpcakGuWBP1KxG8Phcr+f1aQBYxmrxqftE3ZIBQjB6cDIHPJwTJtrBKbA3YqMq+o1ZA/kGbHpRiE91oEbvA1SVapGfx0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772501724097689.0135707214148; Mon, 2 Mar 2026 17:35:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxEdp-0003Vu-7O; Mon, 02 Mar 2026 20:33:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdn-0003VJ-Ru for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:39 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEdm-0002EW-Fd for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:33:39 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by OSQPR06MB7973.apcprd06.prod.outlook.com (2603:1096:604:429::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 01:33:29 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Tue, 3 Mar 2026 01:33:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VWp/h576C+rBChI+HOvARVWdpPhNzgwkUBWJt3LRzBg8VrN9JfvGXTVjOQJr9/nTjYpWArc/7ayI1skSwgacGlyPijM5CDxHkjUNGjrvv06xQox1CNFCiXFM4mRd2YWEfZL8yHF/LgsZf6PG240ha/Ri0TUw442EAq4GrpWDhIkLHxprK34Z4IVUIXEfdcD5uO9UzYU6F3AUjhSzaoMdr4YvpfNYZhoRuV7n3c6O77NEeIhGK2NLr+NuGlLFXRCPxcWj9qHr4Nqm+dh79BZEHxxnodsM+ZOBCXnCA7lONz05gARooqGUsfkmb/78wexW2kOWOjwseVlA8IbbQq61mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LZXKZjP+hG9XQtVr1vvmgB/3u2Ai6OttUMu4KB68yKk=; b=N5Tl9ueyg5vZIjtMKZGmdL8/iNMrDEriuPuM1IDr5uMimwAphiss3voNF8NAi8jQ77WMdlQozMt8TCvC8iV5PF4sxEtX/kwVhXBAgw+JC8LgFoVHHi4ZtbmREz+LRSVuf//7fuwFQwdJ5s83x+cmLYl7ZOo52lVpx5+Pgs33+JW6FbU+8T1oLcD/+ILm0h+YzfhMLJThf8cLnDowMFXA3TGi+3JaN8E1rVkBoxTjo2/mm2TBuGoMSG3JN1wFN+WQmIZ3+Hy55JBqfZWab0wAlrZqj0CLKqMsJzZ/LnJG/nxi8AzQPzndKttdcDSGsPr9VlU0ds1xdSIMkr2nzMbR0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LZXKZjP+hG9XQtVr1vvmgB/3u2Ai6OttUMu4KB68yKk=; b=UtowPmnqILuDR8/hOzOwKNtZ9DVClKtcDMAHXbDBrzBhvxRISPWYBRvbgAFEyDQz3T7P3FbaRBgfJ8lANRkf9fZfdabj/EnXssI+XlG0Z8qjDvxcH0nCAdewNaRwpEaeZ1Ihij9TUAtG+A8CxiTaI3DzjUJ2jZzQnjjWuOIOJF5j4CkBsl4C75zyxQyc/4YLdeiGZLSDzNAWFEkw4IrLFyzchQByzihKUVlt9lmz+gGqmJhQIEWX1gAZy6Q8djTB7zOn06NYEZA2FwRwU19UYWx/4H2UJCCabUj1IO+7x755NWAtiq+mEdvxdbW2HP1RZk9M3tG6o+0cZgmWWLJBtA== From: Jamin Lin To: "clg@kaod.org" , "jithu.joseph@oss.qualcomm.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen , "nabihestefan@google.com" , "komlodi@google.com" Subject: [PATCH v2 4/4] hw/i3c/mock-i3c-target: Simplify GETMRL byte extraction logic Thread-Topic: [PATCH v2 4/4] hw/i3c/mock-i3c-target: Simplify GETMRL byte extraction logic Thread-Index: AQHcqq29IgsU4JsGwU24jBozQSIIFg== Date: Tue, 3 Mar 2026 01:33:29 +0000 Message-ID: <20260303013322.1297499-5-jamin_lin@aspeedtech.com> References: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260303013322.1297499-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|OSQPR06MB7973:EE_ x-ms-office365-filtering-correlation-id: 2bd007e9-7eed-464f-bb3a-08de78c4dfec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021; x-microsoft-antispam-message-info: 20ZKPebvjQHeoPg471wjdTIyy4cOCERPVp9w5DONr5vRHgV/xPcVPJeg1EILq1cphPsxhE+FL+E4Q9RS7clL6p/R6Zr2owUBcNpybqkAjideXBT3hbXfHkgiJVqvO2a1xJGkkeBvqHDR6aob7RboDJmyI/WCwTOf1bKBwBSqXqF10A8YtASUbxU1H2us/6OWmmn5LhowDDbisLQxcsKF367g9K+N1jRJkc5ADv0TVkb0dkCr44qswWnVUrwUd3N/eyPrCN0+6KZvhtufnVdNQCi5JmN6nLRjn+f2CmoU9uxKyl/6VqEciSDzcqHkPHM1JvLFQ8FyvvZES9vAcFDfeGE5zc60NJRwnj2gth8/endALNOcJEJDHILethmYcEMuchmjnP8VeyQrftuJuj13mfOUQ47vpaorzLdwlAJjsQCPHjrz1geDB0bU9JGJ9892ItwsyQnrR0GgrHzTBnhycfv8DslpEm6kGw/WE6VryR5jqxjyIDu285aPwShDRSknny5FUx2C0ixN00O44jTp23Kq3E/gWg4EWyg25WdpDavssx8oeXEmIGucDx+Vxjya6DsbS+DqqCaEWNgAM6K5kp8414w6yelQA5hNgb0CBnFOTWk0MUh2Ilq5IgGX8bB8UHqUpC30YdiLZSJdsUY9l54GP/qQc2lWtMlNo8g9ApeGnLht7PY1lDT8kYgf/LzNhCElywDJp6ajvO4hasFRNFjSF/8ZgGuzA/ehGs8D1s/csjlEND2tO0BknhEdRhJp1CoNX0pX1tGYhPdgbcvqJFnPjup52B+YQYo4iSEeg2o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IhdO3ddmWUoRyiWAKJYEBZs4tnBQMWTxtlJ5hhyOSSEy9JRj2M51YTdt4wH7?= =?us-ascii?Q?WFKG2I7nGjCdNQ7bQOxL0VzgUW97EW31mQ37qTTZhhvDoFwpUC93ufICQLWT?= =?us-ascii?Q?vcY/v4YlztnfczNtnnCHfNwoSPriL/UFIcucQohHYgQq0/dQEuafQ+3P7taH?= =?us-ascii?Q?6D+XadRoK0Ldyj0SO5YOYCNlGvXZX+bTH17ypeoUSCvCwFBFwsCxaCEo/kJZ?= =?us-ascii?Q?9wukB1wn5Eww4Qj8HVI/+rf8Oj5gEIJCEE1I761+VNOrNJ97q7eQu2lbYWz+?= =?us-ascii?Q?2uYY6onGoXvnMPapNKtideGrr0hRoXdJfdhxAlIYIWeTeUyGTHBvZJsij3uQ?= =?us-ascii?Q?mx189BQX+LAlcKjbhGQRE9lDUQ90boa2yUtN5doJ7N4mpIeqt2bkXjUsI30M?= =?us-ascii?Q?pUZeX0iMenKXeHt1RlLWwe4waHkSSuoJmsGJIeUa7KAvtf0UeFgQ9SIDiI5j?= =?us-ascii?Q?gW5wrPNTAolN26KBFQ4xttNzPBBuplrGpi8x/zJEPNfQLwvtMyXoEn/OFv1h?= =?us-ascii?Q?OcZB+gcicD5a58gULJWIYkfpi9X93ICwUrBWDH1M3bk/GCExzIc1FdIc2512?= =?us-ascii?Q?5f/2dclCt8THHEdYk6Eho0B3td277xlF01RuUuFm283ZbpCZjushMVDwr4Gk?= =?us-ascii?Q?jlemeth7mLaN45lMQGdpLzAZsEj8tJ5m38U5WciH0u//F5eau4aS6LCAn1vt?= =?us-ascii?Q?qkL5LptzS1BtYCJmwoK9m2OCuhpbOUiZqmPGMP1of3jKmhq9CvNZGMHpU9rS?= =?us-ascii?Q?u8IdqAQdDAV3qMeQPCiqBQy/kDTJt7OvYJodOVMm7b3qWDZCbBOkYFjVQ5q3?= =?us-ascii?Q?CQGMFpUS5D1S9cv9C6XsubVIgviS+LYcqfKjGeJCWiwwxLgrZ47NdJQfcfkR?= =?us-ascii?Q?f6xQoT5chqrbU8k3E9Q/bdsF+CkwoucuBQwDVpySjWj7A9NS5KeQwCed3J8F?= =?us-ascii?Q?QeNesldhJ+x7E0doOs4qoyilJlhN1KBhLAsk+FDqCc0irbilkHZbuGiIIR4O?= =?us-ascii?Q?w5L8b6Mt/PO6eYuINNDTC0+FEjTkU4h5jTkgMZE2r0RvowftV86wnkFuLEWx?= =?us-ascii?Q?4yQdUXnaF0OuhGYmLd1+Hs0tapR++f7qkx8w2Xd8K0ErLfiMXuOINbh0GBAR?= =?us-ascii?Q?GJAsLAmPL9O9dNezX0o6mEMo0Pzxo9/oiHCPrgPYWSvCZlQzB9FaMih7Vv1+?= =?us-ascii?Q?unXcv/kpwmKxktlC4TJzFee/YtT1GMx/p9ToS/nkROtgnzZPiV+8C4AfURD3?= =?us-ascii?Q?5vDStThIqcyGY0mKQSH0cvuidYOehNiMTvz3yp+91oBv5Ig+JoxRKpJBzXP0?= =?us-ascii?Q?PYpTa7zcFwsathHgdLFuEMi74LBOT5gqLYeX+uobyiF83KC8oV/Fbyjk3lMB?= =?us-ascii?Q?dD6SWxW1mR2ha992yWFbaejtEXFM1PoRRwTZzmsk71U1KWtRqLiRT/J3A/4Y?= =?us-ascii?Q?2GMX0nO3zrlwtn8VXc+kF17aM5Cb6n+yex5Csqsqhe24nm+K5IzjM1qlrtan?= =?us-ascii?Q?ucZrc74SNChj08AxZVwPW46v1qgDVOGNgw54YB2SqzYSnpZs2ej7CZ18G8Do?= =?us-ascii?Q?QUHH9zCDb9Dc9QWB6zpU2z1qmIf8TFbOm83lC0WzjlVQ1usnXoHfg6x25CbQ?= =?us-ascii?Q?R54rytSdVlKX89B+Po8uqMrqbkTzIZJrSx1+bwdGnNf9rVhORFMJNEBuPpZ3?= =?us-ascii?Q?ej3yHRKDAC/y6VaOJORWCB0xhe3xtkhc+FNsLQWDvNrt3gyPZCGQj+D84InC?= =?us-ascii?Q?y3UvhUir4A=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd007e9-7eed-464f-bb3a-08de78c4dfec X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2026 01:33:29.8727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g8ypOyJxZ7eC/aS1bHF8dYr/Qq1mkQ5Bu5u3+c9aEpdLMIZdY+0xz0XXtG19OzWJPE0bXBdpldBST64bgzTJoFEcf9CHVlDF/TrxbNqnJqg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSQPR06MB7973 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772501726148158500 Content-Type: text/plain; charset="utf-8" The GETMRL handling logic extracted MSB/LSB bytes from s->cfg.buf_size using a mask-and-shift expression: (buf_size & (0xff00 >> (offset * 8))) >> (8 - (offset * 8)) While functionally correct, the expression is difficult to read and obscures the intent, which is simply to return a 16-bit value in MSB-first order. Replace the mask/shift formula with explicit MSB/LSB extraction: offset =3D=3D 0 -> buf_size >> 8 offset =3D=3D 1 -> buf_size & 0xff This makes the code clearer and easier to review without altering behavior or data ordering. No functional change. Signed-off-by: Jamin Lin Reviewed-by: Jithu Joseph --- hw/i3c/mock-i3c-target.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/i3c/mock-i3c-target.c b/hw/i3c/mock-i3c-target.c index b99709a08b..1ae2cf9e1d 100644 --- a/hw/i3c/mock-i3c-target.c +++ b/hw/i3c/mock-i3c-target.c @@ -146,9 +146,12 @@ static int mock_i3c_target_handle_ccc_read(I3CTarget *= i3c, uint8_t *data, if (s->ccc_byte_offset >=3D 2) { break; } - data[s->ccc_byte_offset] =3D (s->cfg.buf_size & - (0xff00 >> (s->ccc_byte_offset * 8= ))) >> - (8 - (s->ccc_byte_offset * 8)); + if (s->ccc_byte_offset =3D=3D 0) { + data[s->ccc_byte_offset] =3D (uint8_t)(s->cfg.buf_size >> = 8); + } else { + data[s->ccc_byte_offset] =3D (uint8_t)s->cfg.buf_size; + } + s->ccc_byte_offset++; *num_read =3D num_to_read; } --=20 2.43.0