From nobody Sun Apr 12 00:57:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772500172; cv=none; d=zohomail.com; s=zohoarc; b=PTY0bhOZjhM+piNvVV5P1UJyIcSypI2CN0hy3i+3gSDrcdKLlJgSmUN0PPqgR0xT/6ipUPB/NsMxM6UZrYd68dnZmFhj+3QfGpn8AaMJw37zHZ5GPCDZskji3fsomeM9T3hiIoTPWqoSZbI/oiXj/47tnDKOppNsTgMHX+Vb2To= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772500172; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tP5/W1kiTCmuQM9EHfOiY2ySSiL3wae69p6z7AYvXAU=; b=k8dIjRaJRqcxFqSTgH+rm+uk+26aB80wxYRWt0+68EPLc1QiO0Lcqm2jDZig+/gvdLr0yiZxYbFMMOIv/Sl/7kYsMBqj0tjow9/hXANVlCYdq0FbUvgDqwh2EbV/JpgpstDPhvWGVIeehvcw99UF6vhPhseG5zkFaknQp+CRatM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772500172786660.1631470039018; Mon, 2 Mar 2026 17:09:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxEFq-0000Fe-Tl; Mon, 02 Mar 2026 20:08:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxEFp-0000FA-8m for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:08:53 -0500 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxEFm-000725-CO for qemu-devel@nongnu.org; Mon, 02 Mar 2026 20:08:52 -0500 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-8273e0fb87aso2749181b3a.1 for ; Mon, 02 Mar 2026 17:08:49 -0800 (PST) Received: from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d94de6sm14484988b3a.24.2026.03.02.17.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 17:08:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772500129; x=1773104929; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tP5/W1kiTCmuQM9EHfOiY2ySSiL3wae69p6z7AYvXAU=; b=hb2ogS+pO9z+0l8/wyfshMu/jt0F9lk51jz7QhRJAMhVKM0aiFVUxFEzoeVVqqEXio Q1g1CdwgSGcitTD30NBVm59aAOTw/tBNbMpAQM5oePTgxs7q/ct33X9jg5JQ7+JomMmo 5o6uvFkkVJxkc7KetwYGghOQj27bfG4Dd6gQEqNQcVMVqdnzL9WGrIrE99gJSDwZH5bJ m6MX35yMAOCdirqobahKQO9DgwpBGAPv7k9GG4Tr32s3yAD8zkWjun6afOgKIo8Ca7Bg 9viE/JRtd6mQ778xTfAfzTJeG3xvQA17Zso0Uksmhf7KFpYUe77sAvqzxFZz9lV8cThu iymQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772500129; x=1773104929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tP5/W1kiTCmuQM9EHfOiY2ySSiL3wae69p6z7AYvXAU=; b=AUHmPxyQsbGqFfbDktAejspQCkCM31rCrsG8/qHcnaPAAAy0bA8QLTlK1b/YBL9f+L 2Sl1oXw2/7V85btKm2aqDLK87h4PTLLV5H63JeR4Hx3mBdihtGFMRwdvpAD5XrLtiK2n Py3b6O+mWTqkUvMP/FRPRZVIKrz+U6p9izOqMl76noLydtOFRVeyRVNnDnSnKOA+6BZP aY7uFAgzTFFfN2H5Y7LrU9JIe7qvsjlL0pCCX+pkk/50M0gYf6qwHTa5QmcA7lltNlXc aCGXMOHntV/F5J0j+7K8+sL5MVJUDK+rOagaU2B60nlHmgv+xB1LdfrHNpmMg0RxX/uR c5aQ== X-Gm-Message-State: AOJu0Yy1qiu/svZSOujEnebDFfd8pw7BbpsLgrQbDcAsaeantm2Qnmzn rrJW0ocwnl9mKpWI1rHRetTH/DdTrXN5b7U5FT34F//p2f4A9HVNuEaJlQTZyh4zPRwXLUhFouM R3PODHXA= X-Gm-Gg: ATEYQzw0AvCjkV7t9/cl160qWHbhbenBJEqkGJuNgjYE0NrvKKizn9X/9idB6eHWsKo 69Kk2cKK2b6lLeW+i8h5cxIereqPly/QjCYIy8e+Zb0wZfHMR7Eb7vHdyYrcM++Kqa51hqlJhz0 f7CerwbDkQD/aLE+iEns4DKTTjRYzNu8jtJjoUEIaj8sWqWhXfQ2R2OOXIwmaq32YuG/lM6Fx8+ aKMUgzBf5MjgPDiE7phSrWVmuRtYtzGfbvyj52Xj5ZX6B22+TRfiT++CNEc0E/d34L0y6RJ1tdF DzuJu5IMxYJO9kWqw9q5/GzFpuE15TOcNMwOQUVSupBE6mITm75egB/XuSM85RGiVfUxfYKm/Mm nI9L5GJ2OSIcPSyqoAYobb9uJgD9qH1W1KtGKOW0klJsc4JfKjgwVO2OVv21MHh9VtJwu2EIRd4 PDVTMw9S0cy1ecCW/lcUg9wbheQTGG2g== X-Received: by 2002:a05:6a00:f8d:b0:824:3cf6:3fb4 with SMTP id d2e1a72fcca58-8274da11634mr10406730b3a.32.1772500128905; Mon, 02 Mar 2026 17:08:48 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jim.macarthur@linaro.org Subject: [PATCH v3 4/7] tcg: Expand missing rotri with extract2 Date: Tue, 3 Mar 2026 12:08:29 +1100 Message-ID: <20260303010833.1115741-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260303010833.1115741-1-richard.henderson@linaro.org> References: <20260303010833.1115741-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772500173157158500 Content-Type: text/plain; charset="utf-8" Use extract2 to implement rotri. To make this easier, redefine rotli in terms of rotri, rather than the reverse. Reviewed-by: Jim MacArthur Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tcg/tcg-op.c | 52 ++++++++++++++++++++++++---------------------------- 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index fc2254f54a..13a56d89fa 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -826,23 +826,12 @@ void tcg_gen_rotl_i32(TCGv_i32 ret, TCGv_i32 arg1, TC= Gv_i32 arg2) void tcg_gen_rotli_i32(TCGv_i32 ret, TCGv_i32 arg1, int32_t arg2) { tcg_debug_assert(arg2 >=3D 0 && arg2 < 32); - /* some cases can be optimized here */ if (arg2 =3D=3D 0) { tcg_gen_mov_i32(ret, arg1); } else if (tcg_op_supported(INDEX_op_rotl, TCG_TYPE_I32, 0)) { - TCGv_i32 t0 =3D tcg_constant_i32(arg2); - tcg_gen_op3_i32(INDEX_op_rotl, ret, arg1, t0); - } else if (tcg_op_supported(INDEX_op_rotr, TCG_TYPE_I32, 0)) { - TCGv_i32 t0 =3D tcg_constant_i32(32 - arg2); - tcg_gen_op3_i32(INDEX_op_rotr, ret, arg1, t0); + tcg_gen_op3_i32(INDEX_op_rotl, ret, arg1, tcg_constant_i32(arg2)); } else { - TCGv_i32 t0 =3D tcg_temp_ebb_new_i32(); - TCGv_i32 t1 =3D tcg_temp_ebb_new_i32(); - tcg_gen_shli_i32(t0, arg1, arg2); - tcg_gen_shri_i32(t1, arg1, 32 - arg2); - tcg_gen_or_i32(ret, t0, t1); - tcg_temp_free_i32(t0); - tcg_temp_free_i32(t1); + tcg_gen_rotri_i32(ret, arg1, -arg2 & 31); } } =20 @@ -870,7 +859,16 @@ void tcg_gen_rotr_i32(TCGv_i32 ret, TCGv_i32 arg1, TCG= v_i32 arg2) void tcg_gen_rotri_i32(TCGv_i32 ret, TCGv_i32 arg1, int32_t arg2) { tcg_debug_assert(arg2 >=3D 0 && arg2 < 32); - tcg_gen_rotli_i32(ret, arg1, -arg2 & 31); + if (arg2 =3D=3D 0) { + tcg_gen_mov_i32(ret, arg1); + } else if (tcg_op_supported(INDEX_op_rotr, TCG_TYPE_I32, 0)) { + tcg_gen_op3_i32(INDEX_op_rotr, ret, arg1, tcg_constant_i32(arg2)); + } else if (tcg_op_supported(INDEX_op_rotl, TCG_TYPE_I32, 0)) { + tcg_gen_op3_i32(INDEX_op_rotl, ret, arg1, tcg_constant_i32(32 - ar= g2)); + } else { + /* Do not recurse with the rotri simplification. */ + tcg_gen_op4i_i32(INDEX_op_extract2, ret, arg1, arg1, arg2); + } } =20 void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2, @@ -2042,23 +2040,12 @@ void tcg_gen_rotl_i64(TCGv_i64 ret, TCGv_i64 arg1, = TCGv_i64 arg2) void tcg_gen_rotli_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2) { tcg_debug_assert(arg2 >=3D 0 && arg2 < 64); - /* some cases can be optimized here */ if (arg2 =3D=3D 0) { tcg_gen_mov_i64(ret, arg1); } else if (tcg_op_supported(INDEX_op_rotl, TCG_TYPE_I64, 0)) { - TCGv_i64 t0 =3D tcg_constant_i64(arg2); - tcg_gen_op3_i64(INDEX_op_rotl, ret, arg1, t0); - } else if (tcg_op_supported(INDEX_op_rotr, TCG_TYPE_I64, 0)) { - TCGv_i64 t0 =3D tcg_constant_i64(64 - arg2); - tcg_gen_op3_i64(INDEX_op_rotr, ret, arg1, t0); + tcg_gen_op3_i64(INDEX_op_rotl, ret, arg1, tcg_constant_i64(arg2)); } else { - TCGv_i64 t0 =3D tcg_temp_ebb_new_i64(); - TCGv_i64 t1 =3D tcg_temp_ebb_new_i64(); - tcg_gen_shli_i64(t0, arg1, arg2); - tcg_gen_shri_i64(t1, arg1, 64 - arg2); - tcg_gen_or_i64(ret, t0, t1); - tcg_temp_free_i64(t0); - tcg_temp_free_i64(t1); + tcg_gen_rotri_i64(ret, arg1, -arg2 & 63); } } =20 @@ -2086,7 +2073,16 @@ void tcg_gen_rotr_i64(TCGv_i64 ret, TCGv_i64 arg1, T= CGv_i64 arg2) void tcg_gen_rotri_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2) { tcg_debug_assert(arg2 >=3D 0 && arg2 < 64); - tcg_gen_rotli_i64(ret, arg1, -arg2 & 63); + if (arg2 =3D=3D 0) { + tcg_gen_mov_i64(ret, arg1); + } else if (tcg_op_supported(INDEX_op_rotr, TCG_TYPE_I64, 0)) { + tcg_gen_op3_i64(INDEX_op_rotr, ret, arg1, tcg_constant_i64(arg2)); + } else if (tcg_op_supported(INDEX_op_rotl, TCG_TYPE_I64, 0)) { + tcg_gen_op3_i64(INDEX_op_rotl, ret, arg1, tcg_constant_i64(64 - ar= g2)); + } else { + /* Do not recurse with the rotri simplification. */ + tcg_gen_op4i_i64(INDEX_op_extract2, ret, arg1, arg1, arg2); + } } =20 void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2, --=20 2.43.0