From nobody Sun Apr 12 00:56:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772489064; cv=none; d=zohomail.com; s=zohoarc; b=fPiNrmB++LuZPwptnkW3f4aJMxbk+U4+rh5pSAv+98NdqrTUZAG8UxPhi9Yaj7KgDGnMZ8UzopsoYvGS1/4y5O+2Jhjg9uJrcRY7t4dQj70GHONp9L6zwUjqu/oGnHUAW7CCkEygsDlRpdUzf4ZoBKWIs3nAY6aKv/Sl8Jw6h/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772489064; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I3pSiajhTDR+3+VSpc4ntxNFFZn7kZ6nNzxA+ROJWxI=; b=UnL7CcOayNNypCXxsXPhlG6n7TrntsWXtuCPOoJhosqAFyCrUVkdziwbQwonovC9V05rM61LUBGkLHo/V9xEaINiKyvgP89W3OARLhTOP5u/9278nWoWeZTs2DW2gotsw12gh2ChGzR1k/Iv9dz8A1/k52oG4cd8XvFzAoStjv4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772489064558878.8628150401485; Mon, 2 Mar 2026 14:04:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxBMJ-0000Sj-BX; Mon, 02 Mar 2026 17:03:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxBMI-0000RZ-0y for qemu-devel@nongnu.org; Mon, 02 Mar 2026 17:03:22 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxBMG-0001Ar-A0 for qemu-devel@nongnu.org; Mon, 02 Mar 2026 17:03:21 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-4375d4fb4d4so3620958f8f.0 for ; Mon, 02 Mar 2026 14:03:19 -0800 (PST) Received: from Provence.localdomain (dynamic-2a02-3100-2e0b-4800-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:2e0b:4800:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c765c38sm29308102f8f.31.2026.03.02.14.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 14:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772488999; x=1773093799; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I3pSiajhTDR+3+VSpc4ntxNFFZn7kZ6nNzxA+ROJWxI=; b=TWV+lkWdY1I69pyTximCnHHM8006+JsBcXcSRraKI1v0xHKzbpEql4K/wS17w3z2wP 0kj1dLAd6j8Yd4uX9z7AfHcaOld3CCi+V8npL7ZvO5FXjNOjr3/2ujcNYb93qVaOHRaF F1JoDsMYagszyQ/SwA2ZSOY8G9Xkd0hTd8ndxVSXOybzxByUFqQcto1lYR+g962uyQyL VLK3HKYWhL4SwaPlDcdPCGJK/qqiCBB3tfpMbwtBqTID44agRsyXzfbaHvHVHWA+5Fe3 /L+vR00EWTcKsoglL2mxvR7Plt94HzeeTGoxiXgG2B2fKs1sGKqtA/QCgMW4FAcIHWvE v0SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772488999; x=1773093799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I3pSiajhTDR+3+VSpc4ntxNFFZn7kZ6nNzxA+ROJWxI=; b=NMXrEzEB1oiYjPvA6HKXpO0JL7zY6uuiEcJDl9gimZIUmPdzwZBYcN3UkfTnLprkLx GGDr/HYU8p9WY9chWhQzLElwA8pZSiNUkofAw6gva7ACjCC1IemA558u9T0bq689/cby Abdg50RECP+kN9cc5vMV1vFh8BYDg7xy2biCU897bBNjt013OR3YRIZh5DdYUPOBSntu mKykAJmBZ+8+lFF7ym6ilTDAbC+ADFU6QEIm7L4OeL94lOWkWI032F1ZkZ8lm3OHRDN1 POtRQ80RRGAKmS1MQE5KeNRnwCWP5DfMliGRMwboGQF1PsLaprXxFs1tYliSyRKBo1Bu /g9Q== X-Gm-Message-State: AOJu0Yx7vkcyESYd/zln6ybzioDzll/Dgc4yrZ0C2j7Q7Ivcg9W6dCLq xIkPCxh9LB+h1FwsENmPlxqzfowke8S5DDd6zIefJlc7arLtBCauX12Ety0EBA== X-Gm-Gg: ATEYQzyEVBaLTpIa0PU4AgqiP9xIyHMzXx5d8d4sJVIM3aTAVYZbbq0obvF31Ajx4A+ xn/FCTM6iGNAigg0ddMTcgCUeyZ72J9Wl2g9nCXfqFMG4C4y8mz81cEJsHk7TVd3WeS7kylMlIM kn2Fxx4HHV8LvupziGHa5iFKI+8trGFKn7irqBk01sKT4ypoN3PX3LiE/CYkLtrkFLuUtJ5LLuE eRzh7Z0r0FLp/nOgdMphXOz+DrtTicnRlYYsP0fi11d06Ee14jvD1ZnmbU/31cOdqBs7WMe3c0y +v89nXGBcSeh0mV0E19o01BrfWiSdZLet3j3+snzjXdQ3YObqcsFvgpNy/2M4pg7FG2VBLKVyZE DGU5iDuq/P3EXWmFqlmPZTSvRRSBwTMXVYIvU6vtm11htHqdyQzbIHifX9YF39rxqfrOKyzlLhL Wzans8oHLBsOXtLbY2ssfIJQb90i3OGFrVXC0UU4LCm4JmUHOVbxCtN5WqyM/xDbf7oCqs1kg5k X2+GsfVJuwnKFOGRzx9E4/cyJCaC/4dXmgvtvPukUJ2439kyeb/HOsnww== X-Received: by 2002:a05:6000:2502:b0:439:abcd:b2f6 with SMTP id ffacd0b85a97d-439abcdb576mr15242115f8f.27.1772488998506; Mon, 02 Mar 2026 14:03:18 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , qemu-arm@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Helge Deller , Andrew Jeffery , Richard Henderson , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Steven Lee , Mark Cave-Ayland , Jamin Lin , Joel Stanley , Troy Lee , Bernhard Beschow Subject: [PATCH 12/12] hw/char/serial: Plug into reset framework Date: Mon, 2 Mar 2026 23:02:54 +0100 Message-ID: <20260302220254.1166849-13-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260302220254.1166849-1-shentey@gmail.com> References: <20260302220254.1166849-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=shentey@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772489067164139100 Content-Type: text/plain; charset="utf-8" Now that SerialState inherits from SysBusDevice we can take advantage of having the reset method called by the bus hierarchy rather than having to plug and unplug it manually. Signed-off-by: Bernhard Beschow --- hw/char/serial.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index c58337bd20..c4537e5764 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -31,7 +31,6 @@ #include "chardev/char-serial.h" #include "qapi/error.h" #include "qemu/timer.h" -#include "system/reset.h" #include "system/runstate.h" #include "qemu/error-report.h" #include "trace.h" @@ -853,9 +852,9 @@ const VMStateDescription vmstate_serial =3D { } }; =20 -static void serial_reset(void *opaque) +static void serial_reset(DeviceState *dev) { - SerialState *s =3D opaque; + SerialState *s =3D SERIAL(dev); =20 if (s->watch_tag > 0) { g_source_remove(s->watch_tag); @@ -928,7 +927,6 @@ static void serial_realize(DeviceState *dev, Error **er= rp) s->modem_status_poll =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, (QEMUTimerCB= *) serial_update_msl, s); =20 s->fifo_timeout_timer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, (QEMUTimerC= B *) fifo_timeout_int, s); - qemu_register_reset(serial_reset, s); =20 qemu_chr_fe_set_handlers(&s->chr, serial_can_receive1, serial_receive1, serial_event, serial_be_change, s, NULL, true= ); @@ -951,8 +949,6 @@ static void serial_unrealize(DeviceState *dev) =20 fifo8_destroy(&s->recv_fifo); fifo8_destroy(&s->xmit_fifo); - - qemu_unregister_reset(serial_reset, s); } =20 const MemoryRegionOps serial_io_ops =3D { @@ -982,6 +978,7 @@ static void serial_class_init(ObjectClass *klass, const= void *data) dc->user_creatable =3D false; dc->realize =3D serial_realize; dc->unrealize =3D serial_unrealize; + device_class_set_legacy_reset(dc, serial_reset); device_class_set_props(dc, serial_properties); } =20 --=20 2.53.0