From nobody Sun Apr 12 00:56:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772489094996951.1324184423115; Mon, 2 Mar 2026 14:04:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vxBMG-0000Qq-Um; Mon, 02 Mar 2026 17:03:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vxBMF-0000Pz-7S for qemu-devel@nongnu.org; Mon, 02 Mar 2026 17:03:19 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vxBMD-0001A6-Ka for qemu-devel@nongnu.org; Mon, 02 Mar 2026 17:03:18 -0500 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-4398c7083d7so4338526f8f.3 for ; Mon, 02 Mar 2026 14:03:17 -0800 (PST) Received: from Provence.localdomain (dynamic-2a02-3100-2e0b-4800-0219-99ff-feb2-2458.310.pool.telefonica.de. [2a02:3100:2e0b:4800:219:99ff:feb2:2458]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c765c38sm29308102f8f.31.2026.03.02.14.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 14:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772488996; x=1773093796; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a0q3doKdbgb3JqnYROywKi9R6evoTwQ/dQN4VyRTwQg=; b=mTd3OmAW8D/ZqpsCAZPnYTwG1TeJW/uRFTOZLhCnp1BJ+EcrMDR7vpyA6ZSpG+2cv9 m9gsIWrT2gdiLWJfB+N1yLNm2f8YXyBKNhBWvzyzC481bPZDmSmvdOJvXHJf1AqstmQM Vddf6iUbQrP7UdgwxjAC74urVmFsgRok9UNxc020nFdncnMkpj4JLJ7qXbQQM8U3tvO8 UX4anh2JAYZt8Vz/2l9eV8d3H/UOD0iu3/H2Us6y+v3fa8LkFNzfmmtZYv8QFJ9+q1or eILmH6oKvR5q43AGHcOTYQLjl6emvrq0nSiip1eHXFIdtzn5qJRc1Z2seNprprOs9F1k s22Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772488996; x=1773093796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=a0q3doKdbgb3JqnYROywKi9R6evoTwQ/dQN4VyRTwQg=; b=kYZiuqjZXjYYUxQU47dfHQJH0lsZBYSMdh4AsDUjBKYTbuz6gv+zvGzkA9ZEdT8tXT 0ZQQYEBe/Q4yPhP+IYNu7Gg5lkICtSkedxryfhExev7M2TDwePe4bD7HOMh/NKci52z3 ZU2czxY3m6No4UVG4zU2BoeaaNZQRqEPiyBLQNFc/5Ta3Rml6nCwxJ7vI7GGjsk4/M3H fBz3XB0h5CKDEnmaym1NDUzfU9MqZGhj1SEj085Ja5l6v8mpOK7TUTlTdGKjWdW/OkBq KP1gh/AqfDQJtZeQgD8FDsINTRpmVmbee6hlLj5OmtgjHaVhO3Wt8NoWOosidZBoTq7+ 7zug== X-Gm-Message-State: AOJu0YxidOhx5kh6tRw+513iaw/034yeRy+dRRxr60tyWMdznPpASbf3 W6hqGrKl+WGO5pnoZcfO1A6wiI0RvBh0ACpf3q8OZsa8D5lzNMfaytCoKHqfEw== X-Gm-Gg: ATEYQzyB4QJJa2omsZze7CYINGU1/Z6MqeXU7fERKsq+2ayaNccmCn7V80m6r4fuy+i D8ycZQCnUEacGHE49VOyBxpv1ZhVwwQihlI7e3yfT2M+gUtOlDXw8HVrf8k1kE48Cl6igtw/ypx qBug9nNKBtbTUu0ADrnHrZ82i7gUF403IpaPi2qV8gEk80RNJVpC7n0TtMObtqql31TrPyBqYdA 33mnvZg/q48KHZWZBqs+pvpyf5L2J9V5oHyLtucO4c3AGlm1yk+FSZ+GDoub7CY1oOs0yqWcvsq Q6+7PIYFRB82RHUuSmVhmS4D+BGkbpQA/2nlpQEMXws7961ogbfHCqtjtpE5/lmGRcqgheRC83m HVaPkfPg4CndixZHEImVJLTPpz0fiO5S7nyzisv7XZ9OZt+RIKxQdW2inTcD1Kvd2ED4Mbsma7p QScgc5WXtnLOwDGLDWkUGPuy47h5kIUpY1svATt937p5IV4Al3HcOsx5gAaAtOMeTAcnZ1wXtTj fQkiGlhngQ4CF8vMGEv2OAoCxA7JTYtyO76YUlsU2yqtac= X-Received: by 2002:a05:6000:2dc5:b0:439:b858:1d28 with SMTP id ffacd0b85a97d-439b8581e08mr7408633f8f.26.1772488995816; Mon, 02 Mar 2026 14:03:15 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , qemu-arm@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Helge Deller , Andrew Jeffery , Richard Henderson , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Steven Lee , Mark Cave-Ayland , Jamin Lin , Joel Stanley , Troy Lee , Bernhard Beschow Subject: [PATCH 10/12] hw/arm/aspeed_ast27x0-{ssp, tsp}: Do not access SerialMM internals directly Date: Mon, 2 Mar 2026 23:02:52 +0100 Message-ID: <20260302220254.1166849-11-shentey@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260302220254.1166849-1-shentey@gmail.com> References: <20260302220254.1166849-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=shentey@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772489096083158500 Content-Type: text/plain; charset="utf-8" SerialMM inherits from SysBusDevice and exposes the memory region by means of sysbus_mmio_get_region(). Use that in order to avoid accessing implementation details of SerialMM. Signed-off-by: Bernhard Beschow Reviewed-by: Jamin Lin Reviewed-by: Peter Maydell --- hw/arm/aspeed_ast27x0-ssp.c | 7 ++++--- hw/arm/aspeed_ast27x0-tsp.c | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/arm/aspeed_ast27x0-ssp.c b/hw/arm/aspeed_ast27x0-ssp.c index 9b12ba6743..8b84300e0f 100644 --- a/hw/arm/aspeed_ast27x0-ssp.c +++ b/hw/arm/aspeed_ast27x0-ssp.c @@ -149,6 +149,7 @@ static void aspeed_soc_ast27x0ssp_realize(DeviceState *= dev_soc, Error **errp) AspeedCoprocessorState *s =3D ASPEED_COPROCESSOR(dev_soc); AspeedCoprocessorClass *sc =3D ASPEED_COPROCESSOR_GET_CLASS(s); DeviceState *armv7m; + MemoryRegion *mr; g_autofree char *sdram_name =3D NULL; int i; =20 @@ -230,9 +231,9 @@ static void aspeed_soc_ast27x0ssp_realize(DeviceState *= dev_soc, Error **errp) } =20 /* UART */ - memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias", - &s->uart->serial.io, 0, - memory_region_size(&s->uart->serial.io)); + mr =3D sysbus_mmio_get_region(SYS_BUS_DEVICE(s->uart), 0); + memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias", mr, = 0, + memory_region_size(mr)); memory_region_add_subregion(s->memory, sc->memmap[s->uart_dev], &s->uart_alias); /* diff --git a/hw/arm/aspeed_ast27x0-tsp.c b/hw/arm/aspeed_ast27x0-tsp.c index e39d1dc171..e7c7b74491 100644 --- a/hw/arm/aspeed_ast27x0-tsp.c +++ b/hw/arm/aspeed_ast27x0-tsp.c @@ -149,6 +149,7 @@ static void aspeed_soc_ast27x0tsp_realize(DeviceState *= dev_soc, Error **errp) AspeedCoprocessorState *s =3D ASPEED_COPROCESSOR(dev_soc); AspeedCoprocessorClass *sc =3D ASPEED_COPROCESSOR_GET_CLASS(s); DeviceState *armv7m; + MemoryRegion *mr; g_autofree char *sdram_name =3D NULL; int i; =20 @@ -230,9 +231,9 @@ static void aspeed_soc_ast27x0tsp_realize(DeviceState *= dev_soc, Error **errp) } =20 /* UART */ - memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias", - &s->uart->serial.io, 0, - memory_region_size(&s->uart->serial.io)); + mr =3D sysbus_mmio_get_region(SYS_BUS_DEVICE(s->uart), 0); + memory_region_init_alias(&s->uart_alias, OBJECT(s), "uart.alias", mr, = 0, + memory_region_size(mr)); memory_region_add_subregion(s->memory, sc->memmap[s->uart_dev], &s->uart_alias); /* --=20 2.53.0