From nobody Sun Apr 12 00:55:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1772463709; cv=pass; d=zohomail.com; s=zohoarc; b=Jw53g6jAEgp3o6rur1tWwC6NOS81X1FyGDDlRAnIq8Lm9dAYFCeFgfLMLPL75CMvq5hgXKXeFnrAEwt54QII2N5+tOmji32AyudwCHGtzQeokL9fGIveai41hHNhKIuSzHjxpvZzrdsx3SSqwE6GaguhRKbj0T1HbrQ1w7DfU7M= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772463709; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C6bVJ5uFMUnYseJrdFu6UyXmpjkVTiLLY8DT2cYl7iM=; b=jFDCgUS/6vBu0f+gzlSu6o13mTKjIMVYS235kAUQ9FzHEPalxRwiq/bBOlzVTMfUrWGXpqGb6KXcyEX+Lf8gHzCrcYsHie72aKCWuTOSlO5jVYC1VKnXdCzCvMQXSNug9bb5s2141YxvLYRkrbFGOFHa7hc1TSHZtpcAoU2c9IM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772463709345722.9495097857765; Mon, 2 Mar 2026 07:01:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vx4m1-0004WG-Ek; Mon, 02 Mar 2026 10:01:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vx4lU-0004FN-ME for qemu-devel@nongnu.org; Mon, 02 Mar 2026 10:00:57 -0500 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vx4lR-00042O-6Z for qemu-devel@nongnu.org; Mon, 02 Mar 2026 10:00:55 -0500 Received: by mx.zohomail.com with SMTPS id 1772463627488906.8360510487804; Mon, 2 Mar 2026 07:00:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772463628; cv=none; d=zohomail.com; s=zohoarc; b=mk9BlPwQppN/o9h0hQmgIvM0vuKdmun6VPkewbm4IO2iZBypAed0+fnUFNutZ9D3/Ow+rkKnIL/vK7tv1Y+vqzVckHWrj2yq7Sg1q4+mERHZ2JtGRiTTtT75u+XLY7q3DVI10fW5o4oR7euB9YuRiR6sv/GuQCOLqFD0RLmRQr8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772463628; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=C6bVJ5uFMUnYseJrdFu6UyXmpjkVTiLLY8DT2cYl7iM=; b=T8l/cmRMly33tr7d7t17qyNKPYlt9PygKdWRC5e1KqRAC7i8KrsYrrx2NecczltflCedTT3rnA9rIhtw3bY9EonCNFM8iBVzAtoMZQfkJPb4DVrSx0BnIKU7+DPvwXrAvs7CEU0jfOVjCA0Zd0l11iKrMETkP5ATQVtvGq0VT7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1772463628; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=C6bVJ5uFMUnYseJrdFu6UyXmpjkVTiLLY8DT2cYl7iM=; b=bUnGOmAL37AxbGIE/z2qQedBNWxodippHN2eaxSfIazLDH+S7zha9jERFZkyIsxd 1HmnWoQFMqnG4/4RqG3nHgGgD4jw1E+PUl8OcuZvU6jY76s8qbtMqDaH47zePyU3UCA snvP5TNa6LkZCshMgI+Kznvx3tgf63kbhOOvSH0k= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [PATCH v21 03/18] ui/egl: Don't change bound GL context when creating new context Date: Mon, 2 Mar 2026 17:59:05 +0300 Message-ID: <20260302145920.735423-4-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260302145920.735423-1-dmitry.osipenko@collabora.com> References: <20260302145920.735423-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.968, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.495, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1772463710333158500 Content-Type: text/plain; charset="utf-8" Don't change bound GL context when creating new GL context for consistency with behavior expected by virglrenderer that assumes context-creation doesn= 't switch context. eglCreateContext() doesn't require GL context to be bound when it's invoked. Update qemu_egl_create_context() to spawn GL sub-contexts from a common parent GL context instead of a currently-bound context. Signed-off-by: Dmitry Osipenko --- ui/dbus.c | 2 -- ui/egl-context.c | 3 +-- ui/egl-headless.c | 2 -- ui/gtk-egl.c | 4 ---- ui/spice-display.c | 2 -- 5 files changed, 1 insertion(+), 12 deletions(-) diff --git a/ui/dbus.c b/ui/dbus.c index 905ee6fea71b..750a064e3fbf 100644 --- a/ui/dbus.c +++ b/ui/dbus.c @@ -47,8 +47,6 @@ static DBusDisplay *dbus_display; static QEMUGLContext dbus_create_context(DisplayGLCtx *dgc, QEMUGLParams *params) { - eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, EGL_NO_SURFACE, - qemu_egl_rn_ctx); return qemu_egl_create_context(dgc, params); } =20 diff --git a/ui/egl-context.c b/ui/egl-context.c index aed3e3ba1f3f..f9a998768beb 100644 --- a/ui/egl-context.c +++ b/ui/egl-context.c @@ -19,8 +19,7 @@ QEMUGLContext qemu_egl_create_context(DisplayGLCtx *dgc, }; bool gles =3D (qemu_egl_mode =3D=3D DISPLAY_GL_MODE_ES); =20 - ctx =3D eglCreateContext(qemu_egl_display, qemu_egl_config, - eglGetCurrentContext(), + ctx =3D eglCreateContext(qemu_egl_display, qemu_egl_config, qemu_egl_rn= _ctx, gles ? ctx_att_gles : ctx_att_core); return ctx; } diff --git a/ui/egl-headless.c b/ui/egl-headless.c index 1f6b845500dd..19955792ac95 100644 --- a/ui/egl-headless.c +++ b/ui/egl-headless.c @@ -42,8 +42,6 @@ static void egl_gfx_switch(DisplayChangeListener *dcl, static QEMUGLContext egl_create_context(DisplayGLCtx *dgc, QEMUGLParams *params) { - eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, EGL_NO_SURFACE, - qemu_egl_rn_ctx); return qemu_egl_create_context(dgc, params); } =20 diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index 0dbb429958e5..6b3519419039 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -217,10 +217,6 @@ void gd_egl_switch(DisplayChangeListener *dcl, QEMUGLContext gd_egl_create_context(DisplayGLCtx *dgc, QEMUGLParams *params) { - VirtualConsole *vc =3D container_of(dgc, VirtualConsole, gfx.dgc); - - eglMakeCurrent(qemu_egl_display, vc->gfx.esurface, - vc->gfx.esurface, vc->gfx.ectx); return qemu_egl_create_context(dgc, params); } =20 diff --git a/ui/spice-display.c b/ui/spice-display.c index 28399f8a8174..ae0f771c2a38 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -1033,8 +1033,6 @@ static void spice_gl_switch(DisplayChangeListener *dc= l, static QEMUGLContext qemu_spice_gl_create_context(DisplayGLCtx *dgc, QEMUGLParams *params) { - eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, EGL_NO_SURFACE, - qemu_egl_rn_ctx); return qemu_egl_create_context(dgc, params); } =20 --=20 2.52.0