From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443452; cv=none; d=zohomail.com; s=zohoarc; b=WnltmkVQ9OiqjGpwk1h1Z8HDKDJ0s1ByGjaJhnjmi85q4ME8BDyDMo5tvcXrQ/do+nucfRIczk2Fl7mdIskwBthe1tddWxAIOM8BkZC29Q3knuo0pX/QYM9YkTDcJh35qUe9qcM2BpLCmiCMHiop7cvPPq8tgrtAOp7TOzKuPKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443452; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wljGdEyS4Z9nZiKech0RsOezG0RP3oczbwrNM7h6IQs=; b=U+ZEE2aST8ZIeKo1nA2EabS39kY9vZjFwZrXZ3+RhuYrpWerUMEegv0gQkPJ/edaM2BXHh6zDhIjqmmE2qjAdq3BFGgg9LfiGuu0bgiVGvhqSq0w7bVgnuB1OrcU26JHgazPF+l+cU3/cgtasdzNv7nkLLFcoGf6dghaIquT+08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443452684669.3197428091886; Mon, 2 Mar 2026 01:24:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU3-0001H5-0V; Mon, 02 Mar 2026 04:22:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU0-0001F6-Ps for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:32 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzTy-0007fG-R0 for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:32 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-48069a48629so46114655e9.0 for ; Mon, 02 Mar 2026 01:22:30 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443348; x=1773048148; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wljGdEyS4Z9nZiKech0RsOezG0RP3oczbwrNM7h6IQs=; b=QKE8jOb1LK56HESk1k/u2NCagJ6uueaZDW1zAJUW/EYqbqQcNTcA0VBzEe7RaEQwkz IPwrRu1wpGb4zBa2TTuvQRWxNhhfuKWdLAd4dgCg7QOiE1XgP1L92EJhI1ur1bvKXUCu A/elhuYeon2iLQ/1twBIV9mGeOchHBjfKIVlDMZq841TxbLHW3XwOTDkWS6HidBeDKfG 7xP1wwBxjmOriSr8pt/LQMel3AP0OTmMxtDAKINxUsfIjTCZJiRegpmXoB913dzIimMU 8riogaUrpPDKd8oZPkuPuWkFQ9Ye53dXjyK8lKfergDlgZHRjoDuDuOSoUPaOSQJ8pXn MZMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443348; x=1773048148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wljGdEyS4Z9nZiKech0RsOezG0RP3oczbwrNM7h6IQs=; b=XrCGfn+STVxOLz2n1v7tsdnzRdQY4XsF/0JaNdivF8MDJCXVzgPBOwAu3X2Zny5moi U5wOa3MtU5TyRG7sd3Oiqf32XjybzEIsdKf5LpaDIquL+DP5oYdDs4/0mQi7L2m8Vkao HJfknGZPUcKqOoVgiZzKrgcXUvwE2oJlPASOu93Q1R6BPKAwwgRBwcgNHGNlVV2Fpy0q goA8PaaCj2fJoArDO5c6oQQZ2D+qMiNuvSMCNbPOpkIxrDLV6aTagKrZVZXKipjx3yqC wQlk+RLoUJHPvP0yctP/y3hYqEX5AWvwbfwpq7hR89Ou+3hDJu0aJvXfaSMLkLgR4Zmd l67g== X-Forwarded-Encrypted: i=1; AJvYcCUoEYAHyLSE8dw2EnpKiOm86cOQqI4AsbAeLqx81Z9lJbIDgFXG1jiGghfE68sEBedAqlAIYdiiMEBe@nongnu.org X-Gm-Message-State: AOJu0Yyb6GeH+1fKMMHSAoGja4AZc1FU+XZmgZEf08WEJexifhZgh0Wi 8BD83biisRNcp7wI4c/Wo/fq/m02hMYzAGpIBg8y/lHS/LHd3HHMCZYTGCGLer/JmT0= X-Gm-Gg: ATEYQzxePUexqKdNFDriz6IomLF6OqkhIO7J7Pja5cyp74lkXR/RWsKSwzDQx2I4fPw QTNepIO0QUGZp10vuRT53/BY+v7KuS2UYgVE78XRXnPguqdhfPrHZC27czPNUOxGBtdp51EmH+J FDD/SM9kJwj6qC2S073uHdkrQChyfMSUThZX4iQ4CRxHrvtGxrEfAasu0vnsfmi+bdW8XDEAL1Q Z3aZixK+dAGaWEarKa00v7+EXH/iPyrYSUi3QXOerr6vsYeJeRzrgDBY+OdzW6zmnMTw9R61QXa FDIO61TXUU8tlr7Efftv3lYsE0cQnMMb8zBvVjkqgYEoFsEy6jzoSkyvDXld1qwSLzadWp5rOUw 7lapZe1msFvF640bXOU7mtttdX0G5pvooURRGPHzdoTh43CchVYE2j05O+/9832w7wja2rtkYdc vesdzGdMpBxJpASEQ/9RorwlF2DMMk5QbHOFUxb5sWhDHR2yVnzyDp7ahoDDQTzQi6Mp9TZJdhG 8FuurX4hsu87r9kCgDCjnRSPZ5Q+to= X-Received: by 2002:a05:600c:4fd4:b0:483:43d8:8d68 with SMTP id 5b1f17b1804b1-483c9c191d0mr188677755e9.28.1772443348335; Mon, 02 Mar 2026 01:22:28 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 1/9] scripts: Move lsan_suppressions.txt out of oss-fuzz subdir Date: Mon, 2 Mar 2026 09:22:17 +0000 Message-ID: <20260302092225.4088227-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443453575158500 Content-Type: text/plain; charset="utf-8" The oss-fuzz code uses an lsan_suppressions file to suppress certain leak-sanitizer cases that are known issues or not our code's bug. This is useful more widely than just for the fuzzer harness: if you want to build QEMU with the leak sanitizer enabled and run 'make check' then you will want to suppress some bogus leak reports. Move the file up a directory. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: Yodel Eldar --- v2: just move the file so we keep git log --follow happy; fix up reference in tests/docker/test-fuzz --- .gitlab-ci.d/buildtest.yml | 2 +- scripts/{oss-fuzz =3D> }/lsan_suppressions.txt | 0 tests/docker/test-fuzz | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename scripts/{oss-fuzz =3D> }/lsan_suppressions.txt (100%) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 1b656b9eb0..7548057c54 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -626,7 +626,7 @@ build-oss-fuzz: IMAGE: fedora script: - mkdir build-oss-fuzz - - export LSAN_OPTIONS=3Dsuppressions=3Dscripts/oss-fuzz/lsan_suppressi= ons.txt + - export LSAN_OPTIONS=3Dsuppressions=3Dscripts/lsan_suppressions.txt - CC=3D"clang" CXX=3D"clang++" CFLAGS=3D"-fsanitize=3Daddress" ./scripts/oss-fuzz/build.sh - export ASAN_OPTIONS=3D"fast_unwind_on_malloc=3D0" diff --git a/scripts/oss-fuzz/lsan_suppressions.txt b/scripts/lsan_suppress= ions.txt similarity index 100% rename from scripts/oss-fuzz/lsan_suppressions.txt rename to scripts/lsan_suppressions.txt diff --git a/tests/docker/test-fuzz b/tests/docker/test-fuzz index 7e506ae1f6..d2bdc8afba 100755 --- a/tests/docker/test-fuzz +++ b/tests/docker/test-fuzz @@ -18,7 +18,7 @@ cd "$BUILD_DIR" cp -a $QEMU_SRC . cd src mkdir build-oss-fuzz -export LSAN_OPTIONS=3Dsuppressions=3Dscripts/oss-fuzz/lsan_suppressions.txt +export LSAN_OPTIONS=3Dsuppressions=3Dscripts/lsan_suppressions.txt env CC=3D"clang" CXX=3D"clang++" CFLAGS=3D"-fsanitize=3Daddress" ./scripts= /oss-fuzz/build.sh export ASAN_OPTIONS=3D"fast_unwind_on_malloc=3D0" for fuzzer in $(find ./build-oss-fuzz/DEST_DIR/ -executable -type f | grep= -v slirp); do --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443423; cv=none; d=zohomail.com; s=zohoarc; b=H+TLliYlid+vKnoIe6b7NFvncItoGRbC4ElBJfHaCt5K54lK9p59Zq3Gdeps2EJXKv2ShEVAI/9176Lqz0g9IWJJL2LSRNlX14rycKOQvMbJ/y4oC1XF0uwVoBwnKsLIw1kpOxYYwv9ZB0aDYONh3RhvjduPb4LWEhxbyzhZk10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443423; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+M9u9CAKdsyvMMBdW8vER7FZNjwEryhm9BW6q3wRlRA=; b=frDg3TU72DKDFkE3FxLEF7kc29zD5cZXagaGRNxizDYcch3Ge+U1HekxHU2G4E2SawXeUYgK9R8ZMgIkJvGnV5DM/bHftEmkGEUTRbcVmlU0dX+R41cV4R8+kMCqvXmjxmDmFfjUQ93LddwisDOv5a1JxcHhyVcr0BsrQV1xLek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443423391663.2833362107389; Mon, 2 Mar 2026 01:23:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU2-0001GX-OH; Mon, 02 Mar 2026 04:22:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU1-0001FX-2d for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:33 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzTz-0007fW-8V for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:32 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so48226695e9.2 for ; Mon, 02 Mar 2026 01:22:30 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443349; x=1773048149; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+M9u9CAKdsyvMMBdW8vER7FZNjwEryhm9BW6q3wRlRA=; b=cHC1YHCgzKHn/Za5LvmsmqfiepA+/i/wnGS0f0/kNzoBq6OkqNYosK9xa3l6ga0vm9 vC7xoNYFiHX1v4Fbjjs2SwIousqJh/7MV8fHE6OejqsOny8x1+UwCDZr03XOfHNCYnzt j3kgmpF45DBWn+o5FAz+YPZXFx+HHeTtfJapIlNoLdAqbrovjnx1nnZo+kYOoj8PK9HW +TVdcQ6E4csX8zykluP4EsEMlNTFaDGr50GB6Z0nQ3FczK62gBd+fsOg1O+UslGJ3Atj Bl0KcC4ukdUzUUtOKZ/YUGnc/0HBsbITyLpBfQqyQ38Lu7iAM2+oPNlFzCKjCiXDCT8w BljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443349; x=1773048149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+M9u9CAKdsyvMMBdW8vER7FZNjwEryhm9BW6q3wRlRA=; b=T5giebuMah1od2nINvJoeJC9Xi1bCkiek45QWshn8kV19JZJPtPbRh2yBIBTNppvTt ywHuTqlgw1ogiT0s+Cz2DQenbWKVl0vT/4BK9tgQhwKv8zEbUaOhaG+DoX4KnRoa/7gT 68aSu5XDNPxREJ/+m/ZnhMKofZ55+xMcxRjsxtXceUwelsJEqzXkeQu7gutfFYglVA/+ yeJGZwnPu/ygGkTzGR0ke30KKZK129sJ3I+qDS+q02y6DJNWKrmfHt0BNeRxxDS9VCnS LogDfl2RtMmjQwRpaxtU681lGHcfgVFsm2nzpD1LNhuxrrR6dnUvottkUY5ZH2iRCaiK X9ZQ== X-Forwarded-Encrypted: i=1; AJvYcCWaFQlb7lofFXh7HJJqLwX6C/n8WxPw14HGHaZRF3wgt1n/LDQdCpRvvdIv/UAjC9jrKJc4M1OWlJpU@nongnu.org X-Gm-Message-State: AOJu0Yw72+JMOsN6aid/Kage7Xu6ld7uURwt2LhSOCV1I0KP4AF3aV9n Cac4K4t6eraiW+QFv2v/TBM4cjyy3sYCQglm3dgVkbSH+7QeXNxCgDSawnjY1cVFSrg= X-Gm-Gg: ATEYQzxZyZgCRAG7F9RjdNcY/tVVBolGhc6mZj0uAabH6ySSXtmoRn2f5bu/2J5o2B1 +O5u4Swofi29/McRneo2ck4Z3x47LvhAJDgbvXnAWMqQoNWHMABrOMs9nY88qSCcXeUdWlFI0GO VhEWiyP1iC9Tdkxs9OBIrxSfywvyZWWFPVPhDtFdVDeMepgVsNLXIQ9bt6DeCFsOznU6nojblz3 exRmzaA3vMAbd3+DTsaWX+kYj4dceZRPyKv2dsdbC2Jgoe9MUUXc5fmvgx+nybceWlBzS6nIcFN HsyjbMVTlOdGU7lcm1b3Wf3Cmj3hs+GNjhYbEhGw1fkbKP5YrHOcCtIZDbRPXXGyzTDKenc7Z+1 EiGVsbNgGNXPA34s0GtPMWFi4jmEijPNG9zdzqCv/0fSlpXEy04WF1hJJa3mSeEP0MX9SJD+xZp Bb/wLtihyQXWZVMCAerBBTEiiDt3GPWaPRqSb61fs/C1Km3DNQVAQLwF4ctzqR3rW0JgWqDekdp LIk/Bugc9t49i8cvRA9VGd7Ikpil0M= X-Received: by 2002:a05:600c:c490:b0:479:1b0f:dfff with SMTP id 5b1f17b1804b1-483c9bb1fb0mr191573935e9.10.1772443349417; Mon, 02 Mar 2026 01:22:29 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 2/9] scripts/lsan_suppressions.txt: Add more leaks Date: Mon, 2 Mar 2026 09:22:18 +0000 Message-ID: <20260302092225.4088227-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443426039158500 Content-Type: text/plain; charset="utf-8" Running "make check" with the clang leak sanitizer reveals some leak reports which are either not our problem or else not a leak which is worth our time to fix. Add some suppressions for these. While we're touching the file, add the usual SPDX header and a comment explaining how to use it. Reviewed-by: Fabiano Rosas Signed-off-by: Peter Maydell --- v2: header comment moved here from patch 1; dropped walk_path suppression since Fabiano has a fix for it --- scripts/lsan_suppressions.txt | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/scripts/lsan_suppressions.txt b/scripts/lsan_suppressions.txt index 7d90c280d0..f88bbab18b 100644 --- a/scripts/lsan_suppressions.txt +++ b/scripts/lsan_suppressions.txt @@ -1,5 +1,26 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +# This is a set of suppressions for LeakSanitizer; you can use it by setti= ng +# LSAN_OPTIONS=3D"suppressions=3D/path/to/scripts/lsan_suppressions.txt" +# when running a QEMU built with the leak-sanitizer. + # The tcmalloc on Fedora37 confuses things leak:/lib64/libtcmalloc_minimal.so.4 =20 # libxkbcommon also leaks in qemu-keymap leak:/lib64/libxkbcommon.so.0 + +# g_set_user_dirs() deliberately leaks the previous cached g_get_user_* +# values. This is documented in upstream glib's valgrind-format +# suppression file: +# https://github.com/GNOME/glib/blob/main/tools/glib.supp +# This avoids false positive leak reports for the qga-ssh-test. +leak:g_set_user_dirs + +# qemu_irq_intercept_in is only used by the qtest harness, and +# its API inherently involves a leak. +# While we could keep track of the old IRQ data structure +# in order to free it, it doesn't seem very important to fix +# since it is only used by the qtest test harness. +# Just ignore the leak, at least for the moment. +leak:qemu_irq_intercept_in --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443495; cv=none; d=zohomail.com; s=zohoarc; b=iyTxlNevLeFa26/Ra2s5AVl9Q6+xnKKiRbDt2K6dA2Ch2VeITAZSihYLhiZpuOVM58xiJnHugkEBjLLsD3lEMGIbWMfh4YvOn8+7OC85GqfsfeNxIw/Duk8tb953abeHe2bclm3dG+qaYIAjyYlulOakLkk5G7bPJTlYQMWR0CQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443495; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JrSDkpRuA4wc4OTpcBM2xlfnE+hqoQxnobPtJeyezk4=; b=B5D77DzhFwxg8G6WKplkToJppGbVj1vOC3VPrEUZuKMYuSYDuRRzWiuA6EPCI5HAriHgw1SbSzULR6asFaZ0hqIZkEtfA7JP6egrlKazL2x/NElleIZSax/FvwZx2ihj42b4P5481fdK5mG67HWZ3a2FepQc5AzLIs6fBpyDAbY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443495266134.69693342886694; Mon, 2 Mar 2026 01:24:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU4-0001IT-NM; Mon, 02 Mar 2026 04:22:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU1-0001G4-So for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:33 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzU0-0007fl-D9 for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:33 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-483abed83b6so34038435e9.0 for ; Mon, 02 Mar 2026 01:22:32 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443351; x=1773048151; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JrSDkpRuA4wc4OTpcBM2xlfnE+hqoQxnobPtJeyezk4=; b=kBojzAfv68NBqTaHsmVq607+IaF90hj+cRZ9P5clKDbC7Nr9qyIGDUp8zQLygXrqLr LpSCzt36gBo6+tPCwfrYNrk1bMfyp7S1ciJzvJq2YwdP948HkQ52MlxiNi5Dviv+r1pA MGpM9ntclLrkJu+VD2QmuszdQlEXBZAhfLg4xO6R3JkW7fG8U3KA22m6gIcygvkCd22b EJES07VDDF88sAyOtJLrV2dL1fPvrwSPUim0ugLpmPNIaPBK+I+W0lTzFCx8qXlD+XU9 RnhLdzIfyf+MWvfXX9OluJTthkQfho7kKeGcLPuh7C6UhNi3m8rp7HCLxoirZ6P0ZeD1 mQCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443351; x=1773048151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JrSDkpRuA4wc4OTpcBM2xlfnE+hqoQxnobPtJeyezk4=; b=qUhCK/YKFjq1i7ds1bzCESpjGXMLuiAbRgo44+td+ZnlIFmrgc/vKiBo5F48e/blJM TiYBx4ETPhgEK84NSBi4jLiJDSk/xIWHU0zjEW1pxiQDKXrRI1yutwOFyQ8f4T2ngt5y iqvPFR5r1Sj3SbAbJwS0cMljP6VhADZIvDjadT+X22q+Gmo88pzkgJjH/vgboi1ZggFP CzToqKRcqoLeQUbCjvdp4dDu6kfrAroaTFe7Wb5HYvKUdThemW3tt9pB9JXS28aTKixk HsyAtybJ2ZHcLGb8MHRRAMvZEn2FTcomyI5rfKvvq+yYmlap2vlk7R+hMwkibC1FSeCE XDYA== X-Forwarded-Encrypted: i=1; AJvYcCXDO/E/mg14KqoLdUvQm9yy8/ctf/QnHJf/Gd/hwC+ho1aE5uRltnYIAQ/jQ2/Jn/uoNc1qerIceG2c@nongnu.org X-Gm-Message-State: AOJu0Yw8snWfKYIwEHhub1ZTyBI0oEV6FDWlpCwk5SW18Dl9+tgMkiQz GR+ljBHpWWO++rS74jIrNkX2ae20ZaBd2xVWXianifVAQne8lUbsYFjYqu66hYMc5XA= X-Gm-Gg: ATEYQzzgFPveA4hNL1F46HFldzGh1ZOZobFRSZjOqzzp8GJ00/koJocsC3vrlYSddKh 2E8Ple6KK3evaeH3KzEfidpvXY9IGcIMJw5Ac4tLyyrfTPqXN5MovId88VPhLGPcaBWX5HI0oDK Vrcz5GUdGl3VCO0MHYMJ8aPAEJKFoEKj7UBa3xo4fC5WsdvSJR8UumcRGKwmNLi04OPAFN/GHAY NCTWB+PMBDNcl/RzQ7Uoi9sh+WaUr+rX9eK4bmGCMxvRRFbsZ+7FK0SfR/8f32xyZPy6alD3WcY kOz9GiimarOwUGp/eO1H0BOdSGcPwJ5J+UQnBipcF/HtaLVUwxph6QkjNFe2drUGzcKHOo8LEMy 9K0nMEdld3lNzFibetoGUdQEvpX5cIAQ0kxAc1SNcilOOCJGQOlmlAEaiWGXbU2RDHrZrkA6AKb pwkcgib1K1MnMCFHuVCUxc1WELkmaNU5QtB5rAGRBcuT9Za9WSS/srjaUyOvTcgiubaMCmMFgH7 bdlo7/4HEwmHj88DsgYqCn2JdmUZhByKNJGFBfyzg== X-Received: by 2002:a05:600c:c174:b0:477:73e9:dbe7 with SMTP id 5b1f17b1804b1-483c9c0bcdamr202694715e9.35.1772443350535; Mon, 02 Mar 2026 01:22:30 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 3/9] hw/arm/aspeed_gpio: Don't leak string in aspeed_gpio_init() Date: Mon, 2 Mar 2026 09:22:19 +0000 Message-ID: <20260302092225.4088227-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443495831158500 We allocate the string for the GPIO property name, but never free it. Use g_autofree to avoid this. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Peter Maydell --- hw/gpio/aspeed_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index d9237d4360..7d0f87e90c 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -1488,7 +1488,7 @@ static void aspeed_gpio_init(Object *obj) } =20 for (int i =3D 0; i < agc->nr_gpio_sets; i++) { - char *name =3D g_strdup_printf("gpio-set[%d]", i); + g_autofree char *name =3D g_strdup_printf("gpio-set[%d]", i); object_property_add(obj, name, "uint32", aspeed_gpio_get_set, aspeed_gpio_set_set, NULL, NULL); } --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443481; cv=none; d=zohomail.com; s=zohoarc; b=HtwWO5VVQ/4boA2oCQicat9lhp/RNEnf8xhRzHWyFVstQiolS7hlkKr+tm+ZY+snz3oMPZcqZF/6Fvvy5ComkEMex33h5/5hhna7GDxf3M4DaRX2e5rI1vjiJsaABTezd5dB5ALeEqKKd/Mv4VMRY67+40xIwLHMnd/ZnCiLlEs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443481; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QgoB5HfDRfRQ2Ou/Ss9qWoCChifI8a9FD/ElPyWHfHg=; b=eNrwFjphJiaUSKFccjhgt3UMZFH2+8qco53Hh6cOi/UtP1kkcXdwygscDLA5nJBxHu3UgR7NrymTs8D9cmDmjc1LxIhX2yVqYqXmI1AOMLyP61iC+V4zk9Opzvw93zYuvLlBIoy5/cVZCFmADEhrn5bIbB3aZ35Juo6Xo989Fm4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443481190811.8826130452504; Mon, 2 Mar 2026 01:24:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU5-0001JC-9s; Mon, 02 Mar 2026 04:22:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU2-0001Gk-Pt for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:34 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzU1-0007g7-6c for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:34 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4837f27cf2dso37026255e9.2 for ; Mon, 02 Mar 2026 01:22:32 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443352; x=1773048152; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QgoB5HfDRfRQ2Ou/Ss9qWoCChifI8a9FD/ElPyWHfHg=; b=E/euRnZcW/JfUEOUWU67vA30NnJde6NE4ILOQMQF1ziyLYGLXTlXFjDYV4JLHvGmlK p4R3MKh56Ro2J3wpnGVW3e3Is1thN509Dsb17pkct2SOcIt+5tsmue35zAsW4ZbLyAKy xyUpNMtw5WxjcJeg0TdYcflKr66iG21XKs4hzM3yCWFq/uXIgMqS7VB6VQtMal6sFzlg /1KRzSi3/xjr3uj5PeKvnni5FlU97Gc40EzM0zDUMXzj2gK2PRe3qRNZptZ792cdrmF3 y4XMLRmu5aM0GEjmLGTvM5jFE6HnL82NikWIfMUghQBolJG6+3RKDLJNc7ZgLxdEi93M IOFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443352; x=1773048152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QgoB5HfDRfRQ2Ou/Ss9qWoCChifI8a9FD/ElPyWHfHg=; b=jZDwWYJD4CdRkZNO0Xd0g9mN0GzUVBiZryZ94ORD20XOIM1nGU1D43lWOP0oP3UaPR Du2YO2rSv1v76+ZZc0WZZFbCi7jxtAsRjEOnbDMfG1szNVPlhn3x/2Ucjwp5gH9bJBPA gheh0DpH8uoVgbP+KcG/+6ebkoI6AH9HmYyM2JjTI02DqhrdN2/QF3IR2HYpmDPX4JN/ X7jMciHVjiO5XJjUfiHhQLJTj/Hfvde+6cEv8Ku6k9KlY+oxVtrVFuXvhDW7DPXWukV5 ovHl5yvxDwCvDROVaPMekouX9zGpv/8JSQad1h0ecjBaPmy/htvxdXg6h+Ad7ievM8bb tgmQ== X-Forwarded-Encrypted: i=1; AJvYcCVhO5pPmsCG2VfdyP+yLBANTocMkUiLXbyu6vwi6rRWm0gxj9cqFX/3k4Bw+kqLwWZNaeyEyW00DQFn@nongnu.org X-Gm-Message-State: AOJu0Yx2w/+pl6Xox/gY7kmy41JHQEWv/HaY6WKwfx4HLUv3cuDRT6Ig RiabAg+7YgStwgdQu+mzBM132I2u91eCjCmxqwUWcHbkcL/2Z0EYnepjuUzJw8u9bBk= X-Gm-Gg: ATEYQzymsI87wIiL7u0a5gU60Dxhp6RvNdstqU11TV2EpJBUo7vQLxQlsAu+Pshf+SD hlE9y6+k4DdTPQ3AAv6Q2qt7t+0MUp7a7caMDovgUBg6zYMwKP548QuhXloqgiGRxpQrwVlyFCO /TtOxUgh4bwasCV6yfKN4iOHCDkd0A6MN2x/k1/q2UnxhRuKFebIjjnOCSU57WeWMKp8+X0TTE+ mxGXHk5xeqytvjSifW8ynxenExL42HLuNjmr6hwfLofMyCmQJxvRWsd4bPDZbBkxKi51Vop4srU aK7akjb6mBcvSBlsGQR4KY9phA/k3T0tx8lwZ5V8p2Lv5R4k9fbIxkkaMW5GxZ6WLYzHax0Bk/g M+h29yGo9EPJtcmM6VWsTkYj09tSPV6F7fNg5DxcbSIEo+oN1O6uWzJkxtJxPXogG3+MkFQXqkq Wpv/BlJc9U7FrdaDNgHOlW74pIeE+DUZrPez1diqBGL5XgSB75lD8mqUJe1+EXhldok537OVBRH qZyCwCKMlUaXvUJtXQbGrSJXhIBQrQ= X-Received: by 2002:a05:600c:548a:b0:47e:e20e:bb9c with SMTP id 5b1f17b1804b1-483c9bdb16emr183788885e9.8.1772443351719; Mon, 02 Mar 2026 01:22:31 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 4/9] tests/qtest/iommu-smmuv3-test: Free QPCIDevice Date: Mon, 2 Mar 2026 09:22:20 +0000 Message-ID: <20260302092225.4088227-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443506882158500 Content-Type: text/plain; charset="utf-8" The QPCIDevice we get via qpci_device_foreach() is allocated memory, and we need to g_free() it after use. This fixes asan leaks like this: Direct leak of 64 byte(s) in 1 object(s) allocated from: #0 0x622a5f16913d in calloc (/home/pm215/qemu/build/arm-clang/tests/qte= st/iommu-smmuv3-test+0x1d413d) (BuildId: bc598be1f4ad6d1a9a600c55aeef36108b= db6a04) #1 0x73ee41c0f771 in g_malloc0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+= 0x63771) (BuildId: 116e142b9b52c8a4dfd403e759e71ab8f95d8bb3) #2 0x622a5f1d4cec in qpci_device_find /home/pm215/qemu/build/arm-clang/= ../../tests/qtest/libqos/pci.c:82:11 #3 0x622a5f1d4cec in qpci_device_foreach /home/pm215/qemu/build/arm-cla= ng/../../tests/qtest/libqos/pci.c:34:19 #4 0x622a5f23cc73 in setup_qtest_pci_device /home/pm215/qemu/build/arm-= clang/../../tests/qtest/iommu-smmuv3-test.c:45:5 #5 0x622a5f23cc73 in run_smmuv3_translation /home/pm215/qemu/build/arm-= clang/../../tests/qtest/iommu-smmuv3-test.c:74:11 Reviewed-by: Fabiano Rosas Signed-off-by: Peter Maydell --- tests/qtest/iommu-smmuv3-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/iommu-smmuv3-test.c b/tests/qtest/iommu-smmuv3-tes= t.c index cced49a9b6..dae9821b92 100644 --- a/tests/qtest/iommu-smmuv3-test.c +++ b/tests/qtest/iommu-smmuv3-test.c @@ -77,6 +77,7 @@ static void run_smmuv3_translation(const QSMMUTestConfig = *cfg) g_test_message("### SMMUv3 translation mode=3D%d sec_sid=3D%d ###", cfg->trans_mode, cfg->sec_sid); qsmmu_run_translation_case(qts, dev, bar, VIRT_SMMU_BASE, cfg); + g_free(dev); qtest_quit(qts); } =20 --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443423; cv=none; d=zohomail.com; s=zohoarc; b=jjwNTti9I8j+d+ggUFW+VgLVdfCcBXi2bSO5rfTXsC2N7Jzmdv7XQgkVTuxkkbQhpdxdNU1MxWnRstaPCzBz0+Q3QhYeZUy4RS6YaeGl/iWEQPsEhonP9tbyPFRih0d5vHGuie+OojOXjdRHH3V8alGgZf5wbUGHzsOhnWsEGIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443423; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Z+3TwwE4Ry7HQNnRAPzA+rv+0UHWjy6QT3dO96fhVFI=; b=JM8IUs74duQnLDXEwEVbNpY3oAWk4SgBOaVXFEPJmXpPhaDrIIewukBFuK8wubexqYdL75S1UyAUnu0nAHOYrBE5KQ2wRdD+7gF7qaQD9615Ixrwf2pqA9s3ENBSk3lXxKhtOxM9yMxjjQAD8RXBZAtP4neDMzO+BrN273AOy5E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443423272687.1811961359643; Mon, 2 Mar 2026 01:23:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU6-0001Kc-Id; Mon, 02 Mar 2026 04:22:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU4-0001IY-TU for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:36 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzU3-0007h7-BS for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:36 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-48372efa020so34757915e9.2 for ; Mon, 02 Mar 2026 01:22:34 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443353; x=1773048153; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z+3TwwE4Ry7HQNnRAPzA+rv+0UHWjy6QT3dO96fhVFI=; b=gYVvjDkmPXVnt9J1wiq7izI4WgKf9TAdb4Pend0FL7VpBFA2dNLByanUO1i0UvoFjt 4EOxNRiJkhZ0feLf1zoaQ6N716CLhivXwX5gDUClzPqJaY1MfHksuT+DgmMCZb/D6Lm+ MNmfryQpKZe0/kY16z6Q6fN5wEoNfwevc7lkuFlZwh9MKqMJZvknAHzkbZJjxs7Uexwj 5xr1Cf2aQLeEFDKhma3PEqmBn4MJh+aOmG1+rg4jCkCqLlKCgpCasTVs5FpS7FO/r2hb zgwxVByXQY+dKXCeB5FdftxUQePooSBYpONSmKUTVzD1lacH/S2bPzGfcLBP5Y/u4Rbw xG4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443353; x=1773048153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z+3TwwE4Ry7HQNnRAPzA+rv+0UHWjy6QT3dO96fhVFI=; b=qMtWiVEz/TtwF6MyjgYerPfPdv6EbUfIEdnCBZ/mFEkCLHrcvr4d/Cfnn4NLkaNCA5 PFoOujSkBGPTNtVoCmQUjMxqoTl1foHV0MYvaPTDeKbyEHDUhzIwwjfBPrfK2F0P4AS1 qPEUd/HLeOumKmvDnu2+WgsuoZOWKeMmOZTmuVw+gceOgtLBJ+Yxs4TDieo5wll6HH6T u3QXNZG800tdCW91UkEACF0dJoB1kMYxxHRdAp2l+D0EgvlWaIcF9F+F1HFVbqYgb6Jt 6pVgL2UkFQ+PwCPPj4XzLTCOOXNVkV9Z5Us89DMQTC2k7DDFGkrSQyfVkbiLrI+xA+HG Yp2w== X-Forwarded-Encrypted: i=1; AJvYcCW0Ewm1zpJcfAUFMFfB5gahczHLJYhhZlLIA2wjqwBkrYLk7Ejyo04DGEKWu3uNm45YZI+OdNTXkuxJ@nongnu.org X-Gm-Message-State: AOJu0YwB6JRQ0eJSMPwOi2YOUVSqbrfK4UVgilN/WUsUILmYHVo0NSLT mD6jfv15HRy/VcCJqvBb5ipk1vg+8bEkOgbhaR6g45sRKE34pKSAQdsLEYOaYv+lvZA= X-Gm-Gg: ATEYQzx0CKKRHNWZVf2ehWPsAt41M0aahEao7RC299mL9jkmq2/KYGwd5eQRp8BFndl caqQanMk8loa5o9U/YpA3le3zPHENskAHvQysTq6JWWXHFHN4e0/xZQtHkJ0URUfyVtYL7MjGVK lTWkGe/us+8hmLWn229hIU/er9X89VzahGjzoR/C4EyuimFq7XchX/6XozBS5gghaXYTDexfn7f EhZ0a48I3jfOuL0rGS0cJf1V21BeP2TdZGqLXUaN9vVA3LL8g3/Hn5MiqXV6XWsIlC0qnhuyf4u ueQOdN4T61dsytqa8NoDm3j7wEHDQDQ/85LyCfvHU8zeSLkP/t9fCuNxNSX3afFTlUbtYUpFN/X cD2ArGDx/yxhyuUHE/Us0/OK25Q2nucbpE2sfLQ4s6/sl7yvR9+NXqAZZGIfZlwy3uZ+svYgTsC GeY8wK+VIPPUuzb0coyGCy27ELHa/ziw5eJDoXdmDJ+THma3uMxtH1Z4pQwCmAeudxfaJrMj7LB EDGjXhta06sI80Ht8Zc52crgx1X89w= X-Received: by 2002:a05:600c:4e89:b0:483:129e:b573 with SMTP id 5b1f17b1804b1-483c9bfb85bmr196468005e9.18.1772443353142; Mon, 02 Mar 2026 01:22:33 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 5/9] chardev: Fix QIOChannel refcount Date: Mon, 2 Mar 2026 09:22:21 +0000 Message-ID: <20260302092225.4088227-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443426146158501 From: Fabiano Rosas The IOWatchPoll holds a reference to the iochannel while the "child" source (iwp->src) is removed from the context and freed. Freeing the source leads to the iochannel being also freed at qio_channel_fd_source_finalize(). Later, io_watch_poll_prepare() tries to create another source with the same iochannel and hits an use after free: =3D=3D8241=3D=3DERROR: AddressSanitizer: heap-use-after-free on address 0x5= 14000000040 READ of size 8 at 0x514000000040 thread T2 #0 0x561c2d272fcd in object_get_class ../qom/object.c:1043:17 #1 0x561c2d338f84 in QIO_CHANNEL_GET_CLASS include/io/channel.h:29:1 #2 0x561c2d33b26f in qio_channel_create_watch ../io/channel.c:388:30 #3 0x561c2d2f0993 in io_watch_poll_prepare ../chardev/char-io.c:65:20 ... 0x514000000040 is located 0 bytes inside of 392-byte region [0x514000000040= ,0x5140000001c8) freed by thread T2 here: #0 0x561c2d2319a5 in free #1 0x7fb2c0926638 in g_free #2 0x561c2d276507 in object_finalize ../qom/object.c:734:9 #3 0x561c2d271d0d in object_unref ../qom/object.c:1231:9 #4 0x561c2d32ef1d in qio_channel_fd_source_finalize ../io/channel-watc= h.c:95:5 #5 0x7fb2c091d124 in g_source_unref_internal ../glib/gmain.c:2298 #6 0x561c2d2f0b6c in io_watch_poll_prepare ../chardev/char-io.c:71:9 ... previously allocated by thread T3 (connect) here: #0 0x561c2d231c69 in malloc #1 0x7fb2c0926518 in g_malloc #2 0x561c2d27246e in object_new_with_type ../qom/object.c:767:15 #3 0x561c2d272530 in object_new ../qom/object.c:789:12 #4 0x561c2d320193 in qio_channel_socket_new ../io/channel-socket.c:64:= 31 #5 0x561c2d308013 in tcp_chr_connect_client_async ../chardev/char-sock= et.c:1181:12 #6 0x561c2d3002e7 in qmp_chardev_open_socket_client ../chardev/char-so= cket.c:1281:9 ... Fix the issue by incrementing the iochannel reference count when the IOWatchPoll takes a reference and decrementing when it is finalized. Signed-off-by: Fabiano Rosas Reviewed-by: Daniel P. Berrang=C3=A9 [PMM: rebased] Signed-off-by: Peter Maydell --- chardev/char-io.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/chardev/char-io.c b/chardev/char-io.c index beac5cd245..0e5ba316ed 100644 --- a/chardev/char-io.c +++ b/chardev/char-io.c @@ -88,6 +88,9 @@ static gboolean io_watch_poll_dispatch(GSource *source, G= SourceFunc callback, static void io_watch_poll_finalize(GSource *source) { IOWatchPoll *iwp =3D io_watch_poll_from_source(source); + + object_unref(OBJECT(iwp->ioc)); + if (iwp->src) { g_source_destroy(iwp->src); g_source_unref(iwp->src); @@ -117,6 +120,8 @@ GSource *io_add_watch_poll(Chardev *chr, iwp->fd_can_read =3D fd_can_read; iwp->opaque =3D user_data; iwp->ioc =3D ioc; + object_ref(OBJECT(iwp->ioc)); + iwp->fd_read =3D (GSourceFunc) fd_read; iwp->src =3D NULL; iwp->context =3D context; --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443496; cv=none; d=zohomail.com; s=zohoarc; b=clLMVzdefEzR50x5EtaujCVUf6BaQ8aDtHYEicy9JJTikjY6bP4S1KLYNV0oQ44k5fb+tW8IW8z4E8M7OWIYnO+i4ReK30kjlWib3tLGa8+tDeB2Tl48tvZV20EwsU8DX6P2wJehkytWnW6DFl559X2qqIuyVhPD8dZAfaHLLWw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443496; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HlEaot0Az2g5Lcmwus88Zh0yOjbHLCxHpraQxrLX9JA=; b=iQPFByGIs1vdm4QrsxNXaEmqVtZXDytI21YmEysRc8UL0tyO7MPViqc0/LJnx+5geK4zjx/iJHuG+igG34GEUW5Q//mZAARc/oAGLURxgx7RxGaAOmUxy++ofwBFPLTX3slWrGmp0j9wqPFcEaYcA+E+6aJRx75JAuIY99fKEw4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443496159174.3234175206735; Mon, 2 Mar 2026 01:24:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU7-0001Ks-6o; Mon, 02 Mar 2026 04:22:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU5-0001Je-QH for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:37 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzU3-0007hf-Ot for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:37 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48370174e18so23233225e9.2 for ; Mon, 02 Mar 2026 01:22:35 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443354; x=1773048154; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HlEaot0Az2g5Lcmwus88Zh0yOjbHLCxHpraQxrLX9JA=; b=ZQgDHMUEjPYCMV/vN4gcsHqFzVFlocxIrLpFaoJe1U1As+cwSDZJyOmDVlNZqxD9TY vFAX6od6mwUAlQLJOkeuDPOXAVg8iYA8V/LzVEIAn2M0Wf1q+Lgjc6dzgzMOWr5ZAYSu vfG2SNtTKUgB6Ugpsu7yBrdqA7weBQxkEnSvestEeUeSxhoc30A382jXWqBNWNizxY8H PEuokdsuzPlORbuH0gwTkBFJ/p71t8CPCsluWdu0OmOONBunozwnPe6GHECZA4sm8DaY T3GNKFrcM06hzFtIpVIt1t2S3BeJ63hpQXa2ay6a0vV+SnQg0g6MextZ93/dFBxgYeeY qxoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443354; x=1773048154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HlEaot0Az2g5Lcmwus88Zh0yOjbHLCxHpraQxrLX9JA=; b=neTGxJhRZ2dGsNI+u0X4Qhwqz8C/uRbfpt63/IXg7C/OHD2r4tNN6870YdzJ2HYjKc +K0FukJr7m08WxwPUAUpeHl134c+x9F5JN5tveaZ2yebt+A/nIT9Gd4aHWRJpEjl65aR kJ7m+3PdtUrViIf2fhhf8n3e5P6dZYPQkwr2WuwZQ4pNftO+L2MyAjuWgVlDKNhmKV7B ENzWBqi5YpUgwgw+Yl7LBSxeA6n+/0pvvuzv3qYyb46TFwyNpgNilX6oBen+8eHVjxN6 wZuzAMuSEiI+7tboA5DBuda1vMJIGGVT6H6BznM1vh0n2q7KE1g50U30p+sTHY1vPBL/ FEcQ== X-Forwarded-Encrypted: i=1; AJvYcCUTsrfDuPwID+624SGg32U7YF7dDbVp8a0baih29qhp1mpJzONi1UssdPADSOiGuTiiznSfDgbERYMQ@nongnu.org X-Gm-Message-State: AOJu0YzDQaKEKClOGWlRbKnaWVU0x8t5gQFGjDQKgIxOq672CSNNdAJq e5GFCY4ykMFl3fecx3qVZAATGZX1gsUoqAf5HFbhE9mJ0CTMRAxCClaFNxGeIFfBvj0= X-Gm-Gg: ATEYQzxCr4k8i4nPYWt8ntrNqmTDWXJ/xk/f7C2IwlQj9Vc6o8Alhj/H2f7nOs+kpjW bVv37eIub2Y68ObHvErO/QUto3/RrTB/QyGNLi16eMCBPCv8BJsqgCzIf2oTreIVVfos3wa3Y6Z z6RDn9O2WkZra7dse8WjgH7OLFUSUO7vwGR5OF3yHz0YQh5vUkPHbmkdITI0xMBDydXfDgHx0mp AE8YmivI/E7s6yR/c//8LRi/P05x2w70FE0OGHQsecYoiQFYGCM4qa7dyuziaBG0pea5c6L7h6f OwtGecNnOb3aTgr1MBhpe9vpiOJA/OGwdaWA2ntPzRNzKioG4dKZvoEqzvqlQR3vgI3rKY9FcYJ a3kDpXaFPqdoOImvoliMmjFfvEqh9zqeuBvtSs/xADoYheLm5aOy3fEHXtwVlG1cTO74ng99/TO aunXLlb1QdJMhVfOE13vIb3GfIl3IOMWBL0ZfCo9A2IuG2abddvJZZOzVTYz/b9iWVkn35aJJ56 TParigtfaq1VEx+0tBQrnOfpEXCNWM= X-Received: by 2002:a05:600c:6488:b0:480:1c69:9d36 with SMTP id 5b1f17b1804b1-483c9bbc297mr214797835e9.17.1772443354251; Mon, 02 Mar 2026 01:22:34 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 6/9] chardev: Don't attempt to unregister yank function more than once Date: Mon, 2 Mar 2026 09:22:22 +0000 Message-ID: <20260302092225.4088227-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443497731158500 From: Fabiano Rosas tcp_chr_free_connection() can be called multiple times in succession, in which case the yank function will get as argument a NULL s->sioc that has been cleared by the previous tcp_chr_free_connection() call. This leads to an abort() at yank_unregister_function(). #0 __GI_raise (sig=3D6) at ../sysdeps/unix/sysv/linux/raise.c:51 #1 __GI_abort () at abort.c:79 #2 qtest_check_status (s=3D0x513000005600) at ../tests/qtest/libqtest.c:2= 09 #3 qtest_wait_qemu (s=3D0x513000005600) at ../tests/qtest/libqtest.c:273 #4 qtest_kill_qemu (s=3D0x513000005600) at ../tests/qtest/libqtest.c:285 #5 kill_qemu_hook_func (s=3D0x513000005600) at ../tests/qtest/libqtest.c:= 294 #6 g_hook_list_invoke (hook_list=3D0x55ea9cc750c0 , may_recur= se=3D0) at ../glib/ghook.c:534 #7 sigabrt_handler (signo=3D6) at ../tests/qtest/libqtest.c:299 #8 #9 __GI_raise (sig=3D6) at ../sysdeps/unix/sysv/linux/raise.c:51 #10 __GI_abort () at abort.c:79 #11 yank_unregister_function (instance=3D0x7fb26f2ea9a0, func=3D0x55ea9bcc0a10 , opaque=3D0x0) at ../util/yank.c:151 #12 tcp_chr_free_connection (chr=3D0x51300000ffc0) at ../chardev/char-sock= et.c:385 #13 tcp_chr_disconnect_locked (chr=3D0x51300000ffc0) at ../chardev/char-so= cket.c:477 #14 tcp_chr_disconnect (chr=3D0x51300000ffc0) at ../chardev/char-socket.c:= 495 #15 tcp_chr_hup (channel=3D0x514000000040, cond=3DG_IO_HUP, opaque=3D0x513= 00000ffc0) at ../chardev/char-socket.c:536 #16 qio_channel_fd_source_dispatch (source=3D0x50c0000b5fc0, callback=3D0x= 55ea9bcd6770 , user_data=3D0x51300000ffc0) at ../io/channel-watch.c:84 #17 g_main_dispatch (context=3D0x50f000000040) at ../glib/gmain.c:3381 #18 g_main_context_dispatch (context=3Dcontext@entry=3D0x50f000000040) at = ../glib/gmain.c:4099 #19 g_main_context_iterate (context=3D0x50f000000040, block=3Dblock@entry= =3D1, dispatch=3Ddispatch@entry=3D1, self=3D) at ../glib/gmain.c:4175 #20 g_main_loop_run (loop=3D0x502000055690) at ../glib/gmain.c:4373 Commit ebae6477dc ("chardev: check if the chardev is registered for yanking") seems to have encountered a similar issue, but checking s->registered_yank is not a complete solution because that flag pertains to the yank instance, not to each individual function. Skip the yank_unregister_function() in case s->sioc is already NULL, which indicates the last yank function was already removed. Signed-off-by: Fabiano Rosas Reviewed-by: Daniel P. Berrang=C3=A9 [PMM: rebased] Signed-off-by: Peter Maydell --- chardev/char-socket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 5adeb90865..4e82915cf1 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -370,7 +370,8 @@ static void tcp_chr_free_connection(Chardev *chr) =20 tcp_chr_set_msgfds(chr, NULL, 0); remove_fd_in_watch(chr); - if (s->registered_yank && + + if (s->registered_yank && s->sioc && (s->state =3D=3D TCP_CHARDEV_STATE_CONNECTING || s->state =3D=3D TCP_CHARDEV_STATE_CONNECTED)) { yank_unregister_function(CHARDEV_YANK_INSTANCE(chr->label), --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443479; cv=none; d=zohomail.com; s=zohoarc; b=ddx6AYACvG/tiqo2pauPvIg66gw7m1GiQF8ox/HiqXkVOMet8VsPW+gypfLQV0J5pcg8B78AxyRrEWRdkMBJOKFNzMfTlUjXdUiiiJXw9MBvYHf2bjo5KQv9gEQzTETkc60GxeWmkPHKszRTl5zKLnN+IwsOme674BXsd+CCK1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443479; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XvpDgdF204oqNvD9LAg+6U4IK6hUPz8IBO7coI28nAM=; b=lRF0/nhGEFaB7Kg6eQYkit/Nlm7fnnrqTLfqladj5eClwOwuHCU/RsF35NmoNd65aeWgVPgmgBOjP1v7d42NazWRFLjsVzSpcJ9+GAoirJtCYe5cZp9gYkYXkNRAVKKJeUwgMkza45zrMpW2+kZb5t/RhlwEY+SqC3p0msBY9AA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443479005539.3438933938726; Mon, 2 Mar 2026 01:24:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU8-0001Ly-Pw; Mon, 02 Mar 2026 04:22:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU7-0001Kh-1C for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:39 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzU5-0007i0-8h for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:38 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-483bd7354efso57145575e9.2 for ; Mon, 02 Mar 2026 01:22:36 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443355; x=1773048155; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XvpDgdF204oqNvD9LAg+6U4IK6hUPz8IBO7coI28nAM=; b=p1poQJtzZ53Wz/z5JhnBfLiyioRCICH7NRRfljHAYdbLSjkUklueh64j4YdG4uPbzJ IzupAVWj/XVfbuAd0IUc7nL+TTbhzK77gdAPOxMD9ixm6+R0hTlAA3nRFulqbTdBNT4p Vg4a855tXOld6pwYuK9Th8p+XqiCUXSBnnt+WO/R+QqIb3Tjul4SJg8/h8NInLo22/Hx kIj8bBE6yoEsK0x2epFB4i5s6plUMxuul8Ky4ZBUzLEmnPkBIec9tO+FMX88Zs3v0Cu+ aInFAS6vflWrW0kh/YejnyyT1wOyr2lq7eWj4rE8/3UUl5eq15WRSTrTpJlGkom+q9BD CaNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443355; x=1773048155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XvpDgdF204oqNvD9LAg+6U4IK6hUPz8IBO7coI28nAM=; b=xCfb6gScpMXuL9auSjdaxRPaOdbEFh1wr1MpM/ALH16CqIjqDLrNb6/jXPxA7xle/B CmKxDIpKFRpF09d+FbUuj6PZIxJSGHJJl5VOx7ya/NSpZFUY79xzoe+fFP2RHbejHeMT JtxZzkTHsYv9wStZMJrqJo04a0/L5fy+MjxkDrSuONGzsyqus34nnGY8ZSqp2e4+WB3M 65wqnHciuaszeem7cZacRE7IpEjVycXPlrg6J0HeU2DHShedTjvl+r/s0t+i+6zrZ61c qEVeDhZPu4Wk4HBDHnIPZ6gX/5I5SM9NN02qnfOyMUkCHr3vT2pzpWJ8XPsDDQ0ENPL+ YhWw== X-Forwarded-Encrypted: i=1; AJvYcCX0DzJJM06V3lgxgFBsGY2HgyLijDS8kKrNMrtq9wnHyAqcnI02R+cF4MhwEqThvVt5V/HAC8ybBHgS@nongnu.org X-Gm-Message-State: AOJu0YyZVIqh839eLEkjPX8roQ5Ik+W31EFt7DB368LsuLbgs2UWQOgK rUia6KVxE5PStEPlXAgMkHfReLIalYopQ9MdVqBFVlVqU1EM396HidDlktyIAvnLWLk= X-Gm-Gg: ATEYQzxwVtYuCFg3Iv8MOOwybIeuvPQ9IcA5phRwnRSUOnZ8c9I2kHT7QcfxcAz9RUS QuoCIpdsXrhd7xcS/ryP2qdbIBUKoCEY0Erk8xvtZdCEexpf8XsTPSw7X6QBuq2UAYh6y+PSVer 47YmRE1PDv+YG1y4rV/aAr6B2So/ANVj6R3vJ95/edhhzeFzKITzKcwmWCAhXZ54jC9kPh1xcHw GL9RqHvuVYfQwfcEDscH+tYXNVcaodS93poTnuyW/ybvxOvRJYjEI81CEgy2uyiLyD0FRohaax8 neFL3nQVjSA+WCKVO9Ril/N76FF8Rd+7LjEnjm8CDc2P/whIYtM5xx4bSLXmYFduxLy60mr6y2F Q4wdUkQXdbcyHF6SCC3HST9p2nzsgv3eo8txJ/nIQiFRcUr/DTRuue/BO3lR+n2yRMs3eTcT5Wt 7VdxfBWlGmmqZO+qMI2ccsH/0fVZRTKCFomGV2GQ+hKYF1wWlmGm6rnJaQ3vqMLVsG4SlM9S4IJ tMnfG2qi+rjCjQ+KuaLQWLWpULs9M0= X-Received: by 2002:a05:600c:4e56:b0:477:5cc6:7e44 with SMTP id 5b1f17b1804b1-483c9b9eaddmr206430225e9.11.1772443355359; Mon, 02 Mar 2026 01:22:35 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 7/9] chardev: Consolidate yank registration Date: Mon, 2 Mar 2026 09:22:23 +0000 Message-ID: <20260302092225.4088227-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443479882158500 From: Fabiano Rosas There's currently five places where the yank function is being registered and they all come right before tcp_chr_new_client(). Fold them into it. Signed-off-by: Fabiano Rosas Reviewed-by: Daniel P. Berrang=C3=A9 [PMM: rebased] Signed-off-by: Peter Maydell --- chardev/char-socket.c | 31 ++++++------------------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 4e82915cf1..e064b105c5 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -905,6 +905,12 @@ static int tcp_chr_new_client(Chardev *chr, QIOChannel= Socket *sioc) s->sioc =3D sioc; object_ref(OBJECT(sioc)); =20 + if (s->registered_yank) { + yank_register_function(CHARDEV_YANK_INSTANCE(chr->label), + char_socket_yank_iochannel, + QIO_CHANNEL(sioc)); + } + if (s->do_nodelay) { qio_channel_set_delay(s->ioc, false); } @@ -943,11 +949,6 @@ static int tcp_chr_add_client(Chardev *chr, int fd) } tcp_chr_change_state(s, TCP_CHARDEV_STATE_CONNECTING); tcp_chr_set_client_ioc_name(chr, sioc); - if (s->registered_yank) { - yank_register_function(CHARDEV_YANK_INSTANCE(chr->label), - char_socket_yank_iochannel, - QIO_CHANNEL(sioc)); - } ret =3D tcp_chr_new_client(chr, sioc); object_unref(OBJECT(sioc)); return ret; @@ -962,11 +963,6 @@ static void tcp_chr_accept(QIONetListener *listener, =20 tcp_chr_change_state(s, TCP_CHARDEV_STATE_CONNECTING); tcp_chr_set_client_ioc_name(chr, cioc); - if (s->registered_yank) { - yank_register_function(CHARDEV_YANK_INSTANCE(chr->label), - char_socket_yank_iochannel, - QIO_CHANNEL(cioc)); - } tcp_chr_new_client(chr, cioc); } =20 @@ -982,11 +978,6 @@ static int tcp_chr_connect_client_sync(Chardev *chr, E= rror **errp) object_unref(OBJECT(sioc)); return -1; } - if (s->registered_yank) { - yank_register_function(CHARDEV_YANK_INSTANCE(chr->label), - char_socket_yank_iochannel, - QIO_CHANNEL(sioc)); - } tcp_chr_new_client(chr, sioc); object_unref(OBJECT(sioc)); return 0; @@ -1002,11 +993,6 @@ static void tcp_chr_accept_server_sync(Chardev *chr) tcp_chr_change_state(s, TCP_CHARDEV_STATE_CONNECTING); sioc =3D qio_net_listener_wait_client(s->listener); tcp_chr_set_client_ioc_name(chr, sioc); - if (s->registered_yank) { - yank_register_function(CHARDEV_YANK_INSTANCE(chr->label), - char_socket_yank_iochannel, - QIO_CHANNEL(sioc)); - } tcp_chr_new_client(chr, sioc); object_unref(OBJECT(sioc)); } @@ -1180,11 +1166,6 @@ static void tcp_chr_connect_client_async(Chardev *ch= r) tcp_chr_change_state(s, TCP_CHARDEV_STATE_CONNECTING); sioc =3D qio_channel_socket_new(); tcp_chr_set_client_ioc_name(chr, sioc); - if (s->registered_yank) { - yank_register_function(CHARDEV_YANK_INSTANCE(chr->label), - char_socket_yank_iochannel, - QIO_CHANNEL(sioc)); - } /* * Normally code would use the qio_channel_socket_connect_async * method which uses a QIOTask + qio_task_set_error internally --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443429; cv=none; d=zohomail.com; s=zohoarc; b=Ut0Xllyk8gP5SEDytu+uVQWkKtToCBswKbNzn4+EtNPcZ49sUIy0PAls4nEP+kos0+FZPV3OB8TWmW2734edZo7Q+6trwC5Z03PjoChWTGYJwrW9We6qp+AeeWkb9rAvmYptNTrFbeh7hUPe9QxFwvNPJTWZlu2hdMnxTyoS9nU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443429; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gxlGmMADfBkDj23qA/r1rspF51lHVkOiqdCHs5z6fO0=; b=bPTRfWayRCAgnR63rHoDr7B3gmMZEt6BleV3tbuuV9j5Qz34u3Wt8M1A6Mr0cIisZijS5mzcmR6k8SY6hzJeQwSCut2Zq6UsbheoNqwvrhEDA9uiCykYoahHs8ccYqdNsrGf/ZS9TPcPjzrhyeAMsucmnHbeuvBsg8YClloDOTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443429208628.6008694028352; Mon, 2 Mar 2026 01:23:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU9-0001MN-8F; Mon, 02 Mar 2026 04:22:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU7-0001LF-D9 for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:39 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzU5-0007ib-Rc for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:39 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so47251365e9.1 for ; Mon, 02 Mar 2026 01:22:37 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443356; x=1773048156; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gxlGmMADfBkDj23qA/r1rspF51lHVkOiqdCHs5z6fO0=; b=PsXE9euLDwt8maLDX4x8bwfRkqzlrvyKjK2nRV2u6VtSo7+7VYx0TL/7axrYRKbESn m4bLA/gzOcehb+ZsGusHSgMBVC0CV9nRrgVJhcOAfsjov5qXGqEyHLO4bMwlwBugRF0D 6kW58zBChsyqUw+IDOuie3AAIGcvRPRb/J1naeFL6Gjb9ClGSfqwn6qil5u27bB16SiP S35SM217gaei0vwp3OIUR9BdC0oHLcFHaIA5lgQwvZuKbMfpWADKccWEHG3vXgxGCO6c A7cw+QXSuFzu1ftyXj9vr5kx2mMCHOHLgZLCVz+H3r/+ZU9Gnpu/RNV+QpZLUk/4IJym 1LEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443356; x=1773048156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gxlGmMADfBkDj23qA/r1rspF51lHVkOiqdCHs5z6fO0=; b=lYZvwCw/e+/CVo2W4dHPx2KDwzr7yy0r7UIiBsg0STGYWAGLUayqyCtUUZGmxGwgpo w5fj7o9/7L7rQgK/aGk1UTyIjG9e7ytRCkym8eXNw42073NReSwsQYWJZbVl+3Hr6lr/ 8P+aRTOaaPmyBtbp3V/6yJWZu/vJNtgdqDzk0RVU8zos6La74FqDb1KwO5E/JpTnBOV1 K0eLGcUuzeaO95Je5NP0LldY2XtAFZQENS2PYHayHdbXltnIOt5H1wNsu+KLwNvJBzK3 55bHBqs1BFgK/O599rLNWPFqAS14YyeXf9AmXP/7netra3s5T5TvLRZ5VSzedzlLmeDg siBw== X-Forwarded-Encrypted: i=1; AJvYcCV/Y+zg1TENoB5bQL3QTEySqeZGmipFfJrh/Mbs94IsEiDa5QrBqTU6rNmBIs18aFPNW0UTWXfXpES5@nongnu.org X-Gm-Message-State: AOJu0Yx7AUH32yMODPIxqOTYpcIy+X9H84sSw44YoUvt8MR7+RV3oRHT l1cJDMxD1Dp9m9U1e8NXulLMFgd94NXBjFppHm1ob1yA1YGiyiqNMdBu+gRMwDIq5n9mN0Q0KXc RZhoi X-Gm-Gg: ATEYQzxtZ+5NHjr9BJybST1c5ZuOH5TwToGmTCAEBJTfoYvRK6kyYyi3HwscWFdErvw ZPEAJjazJKcYjLdsaWviBhspyPZnWs0OeyytmbLKBIyTXYRjQzwUQfDrbGUXyY8F5+vRXifn0GW +9Ta2Vs6Cq8idWp18lAQDHsuYErKE49ux7vtXwOKf4zLtB5rcrM4pthDsO3XCQ9N6F1L50rNw1f 0fnQtZcbuk79O5sdKtjgbqQYlA3RNUZ1dC+LUYZxVJTK61ved50iLQwaRe0IWOlNWCIk+ZqWBUl xmsfat7Rzny8ipOvgLAPRhoYBP8kysjXhDNOnd4rAPRqvkizJHB3qr8qBdnKAgqM5IW5xa/7zOn moGO/44ZypfGMIOHHdXPCqD2q1m34Zb+MHx8YPTZPAOFSxin5uB9/tYWlemk34Fs20t/iPROoeq TlcHY3lP/TJ78evRe+gmMJ3A0y+DrY04vS1ZMkgb67b/I94G+Ns6XlLNdjZMAWRKohkN+SfDtuF fyUnlhh+HBuC+4jEavxeuidS2XlVwL7aT3BgmHE7Q== X-Received: by 2002:a05:600c:46c4:b0:483:b505:9db4 with SMTP id 5b1f17b1804b1-483c9c0f1d1mr198756705e9.31.1772443356398; Mon, 02 Mar 2026 01:22:36 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 8/9] tests/qtest/test-x86-cpuid-compat: Free allocated memory Date: Mon, 2 Mar 2026 09:22:24 +0000 Message-ID: <20260302092225.4088227-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443429677158500 Content-Type: text/plain; charset="utf-8" From: Fabiano Rosas Free the test arguments after test execution. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- tests/qtest/test-x86-cpuid-compat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qtest/test-x86-cpuid-compat.c b/tests/qtest/test-x86-cpu= id-compat.c index 5e0547e81b..b2d884054a 100644 --- a/tests/qtest/test-x86-cpuid-compat.c +++ b/tests/qtest/test-x86-cpuid-compat.c @@ -65,6 +65,8 @@ static void test_cpuid_prop(const void *data) =20 qobject_unref(value); g_free(path); + g_free((void *)args->cmdline); + g_free((void *)data); } =20 static void add_cpuid_test(const char *name, const char *cpu, @@ -161,6 +163,8 @@ static void test_feature_flag(const void *data) qobject_unref(present); qobject_unref(filtered); g_free(path); + g_free((void *)args->cmdline); + g_free((void *)data); } =20 /* --=20 2.43.0 From nobody Sat Apr 11 23:08:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772443423; cv=none; d=zohomail.com; s=zohoarc; b=MZZc5m64av7gafuyjuVOZIQ3/mwNlzOVZWQ1aNTlhkz0DAKDYVFr+Tbzz50MhpTPIIfS3eXELzZis+evLX/l6aP16WbysY7tev+/eicJka64m5Ey535MD6InolZL2euHVGC3y395rm0J9Gy1c8VCFQNai19vhk+Y4GuqUN43wg4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772443423; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xPzZvA7hCzZLz+L4Z4vE/U1LgCbyw+GynXi7hkQL8S8=; b=Vv30ENjQEXu0/DNDytcMTcP6DuDj0jk58OB64VHTy4Klnyrip1CEuGwWG3ygyzPCIXjSIwUITO8fAX9VGX3CgxeO+xWMwGxUo3ASSryBPNLkg+mO7ZhdNZNkmSdbNOnui8A3FI4EevR25KeeUEpn8+Q1OupxfdWV2yebY3Iw9Dw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772443423271108.87272386902441; Mon, 2 Mar 2026 01:23:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwzU9-0001NZ-Ra; Mon, 02 Mar 2026 04:22:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwzU8-0001M0-RJ for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:40 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vwzU7-0007j8-28 for qemu-devel@nongnu.org; Mon, 02 Mar 2026 04:22:40 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48375f10628so28123545e9.1 for ; Mon, 02 Mar 2026 01:22:38 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm129435305e9.14.2026.03.02.01.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772443357; x=1773048157; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xPzZvA7hCzZLz+L4Z4vE/U1LgCbyw+GynXi7hkQL8S8=; b=b+5IpLzJDDrkb9O9NCKv+kz+QINY2QQVzI2ff79+OFdsH8eP5eA8z7+3ueBQPuV2Th wFaM3slG6i2M0O3p37q086MaFWrDx1S9wXFnpc5fhiMnUUi5EEqVr9AzFSyyKBAd/j8W +CYAB6cW/kl3+itrq64p2ZGGhKRGklLu97Yg8pOxZnV3YnkDb+kltojSkFl+7cYpn/8c 9Zc6/j2VybtaEYzR4ew9Rf5rb22PohdNLCDNWCb5UfSMVPzRuP4jN8MtVi/ISKXS6uXO rvz7jNWAL6S1Ni8YBeIYHLYjPFwSZZ/vyN6MUN/1V5KN+ZUhZs/TZSev8uEAhrFYLkmt 34rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772443357; x=1773048157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xPzZvA7hCzZLz+L4Z4vE/U1LgCbyw+GynXi7hkQL8S8=; b=TjawB4dq9O3gilgq9crFAUGXNreIX3UIzgQkPxegaYVKOlbQkiEFuXpeRaTq0cxdSN rAOVTRxChVMg9hQLd06LyRQRMQiMBTP1joXSWSPsFKM3b4COC4FLznaiW4Lcb41oWgoP ekkmTb98IN1YxV+uBKgSV5r4nZDGTg19Z3JfdIui3Jd/UADPpJAtQsB+tVfWqn/qhQKX xPO6rKZsJ1i0Vmuu5ZeMHVo0mCBmcZpBuioKspwRkYp2p89eigeH4s9+GkjVAdoNuaNV QFE7kMEmB50fHt3arZwcy9ZdD3D9scBwsIaVRvqdiVrLlTqFBA3sGnrSlz3l94AgblHv 19GQ== X-Forwarded-Encrypted: i=1; AJvYcCWVMRjV2EfxTv40Ls1rlFYEIs750RyhQPboQT7AYE8rZv6T6NNIEKuNWDJr/QQANMrOhXZ/vozbMhlD@nongnu.org X-Gm-Message-State: AOJu0YzVbI4uRizY8/njJcg4VucZg82HZOTn5ZEDO90G1NGLJwxffAhp nBbB6B4Vv3cQM5xClMb9IzIsJR3K6KC0dSySPVv/ZN4d1kZhya3v5w7TGpGIO6LuC+w= X-Gm-Gg: ATEYQzz332Llr7L2J4sXIcTVTIfWH2hOvNRMzug9YTn1GdvxRkaNCK1Z37CvO8kGy79 ZtKtR2DS9B0v/vm5YCrgx+ojMfqTVWIL5PdrZ81XO9A6DC94Wh31qEPndqxgNBUV5Y2Na4NB8zI bDvIJ7WACFJ1RVBehplYSZy+d40v/xgHq1XRHOOGhLZLEw0Xyq4liHk7kdPH+yNnilpOwh9ODiM SbAac3P8i+KFDjJ9tYNsCqwNCkoYCy9nGjM8wUKkFq9Kz7yqi1F6cPApTGDXBfnhxjLEWwOpEIo YazU6m+4hTZbU6R9ZQNhIQQRerj73fGnoHjwI1csTqE2IOeeiVf44Kl1dHWxcTBNu5H5OBx7/0z 91juTfJIp1BvCm6ArTF6jqujYa36kBetWSEsxaGGwrhCV2nt0y/H22bAsooopwh4ERPL9hI5liC 5Hk7DfvJraswvmYDpCc/nWACO7f531H43S+FmXHr670h2ilF1+m4qZHqmeaTUqf/pDyyrRXEeRG ZXjWuNytFrgvyNrr/MeScp2i9+y1rI= X-Received: by 2002:a05:600c:3486:b0:480:1e40:3d2 with SMTP id 5b1f17b1804b1-483c9bedadcmr202855155e9.29.1772443357479; Mon, 02 Mar 2026 01:22:37 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Fabiano Rosas , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Alexander Bulekov , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Yodel Eldar , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v2 9/9] tests/qtest/qos-test: Plug a couple of leaks Date: Mon, 2 Mar 2026 09:22:25 +0000 Message-ID: <20260302092225.4088227-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260302092225.4088227-1-peter.maydell@linaro.org> References: <20260302092225.4088227-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772443426085158500 Content-Type: text/plain; charset="utf-8" From: Fabiano Rosas The walk_path() function of qos-test.c, which walks the graph and adds tests to the test suite uses GLib's g_test_add_data_func_full() function: g_test_add_data_func_full (const char *testpath, gpointer test_data, GTestDataFunc test_func, GDestroyNotify data_free_func) Despite GLib's documentation stating that @data_free_func is a destructor for @test_data, this is not the case. The destructor is supposed to be paired with a constructor, which GLib only accepts via g_test_create_case(). Providing externally allocated data plus a destructor function only works if the test is guaranteed to execute, otherwise the test_data is never deallocated. Due to how subprocessess are implemented in qos-test, each test gets added twice and an extra test gets added per subprocess. In a regular run, the extra subprocess will not be executed and in a single test run (-p), none of the other tests will be executed (+1 per subprocess), leaking 'path_vec' and 'subprocess_path'. Fix this by storing all the path vectors in a list and freeing them all at the end of the program (including subprocess invocations) and moving the allocation of 'subprocess_path' into run_one_subprocess(). While here add some documentation explaining why the graph needs to be walked twice and tests re-added. Signed-off-by: Fabiano Rosas [PMM: rebased; rewrote the comment in main() a bit to account for the if (g_test_subprocess()) block it was previously inside no longer being present. ] Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- tests/qtest/qos-test.c | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c index 00f39f33f6..50fa0ceef3 100644 --- a/tests/qtest/qos-test.c +++ b/tests/qtest/qos-test.c @@ -31,6 +31,7 @@ #include "libqos/qos_external.h" =20 static char *old_path; +static GSList *path_vecs; =20 =20 /** @@ -182,11 +183,16 @@ static void run_one_test(const void *arg) =20 static void subprocess_run_one_test(const void *arg) { - const gchar *path =3D arg; - g_test_trap_subprocess(path, 180 * G_USEC_PER_SEC, + char **path_vec =3D (char **) arg; + gchar *path =3D g_strjoinv("/", path_vec + 1); + gchar *subprocess_path =3D g_strdup_printf("/%s/subprocess", path); + + g_test_trap_subprocess(subprocess_path, 180 * G_USEC_PER_SEC, G_TEST_SUBPROCESS_INHERIT_STDOUT | G_TEST_SUBPROCESS_INHERIT_STDERR); g_test_trap_assert_passed(); + g_free(path); + g_free(subprocess_path); } =20 static void destroy_pathv(void *arg) @@ -238,6 +244,7 @@ static void walk_path(QOSGraphNode *orig_path, int len) GString *cmd_line =3D g_string_new(""); GString *cmd_line2 =3D g_string_new(""); =20 + path_vecs =3D g_slist_append(path_vecs, path_vec); path =3D qos_graph_get_node(node_name); /* root */ node_name =3D qos_graph_edge_get_dest(path->path_edge); /* machine nam= e */ =20 @@ -297,15 +304,15 @@ static void walk_path(QOSGraphNode *orig_path, int le= n) path_vec[0] =3D g_string_free(cmd_line, false); =20 if (path->u.test.subprocess) { - gchar *subprocess_path =3D g_strdup_printf("/%s/%s/subprocess", - qtest_get_arch(), path_st= r); - qtest_add_data_func_full(path_str, subprocess_path, - subprocess_run_one_test, g_free); - g_test_add_data_func_full(subprocess_path, path_vec, - run_one_test, destroy_pathv); + gchar *subprocess_path =3D g_strdup_printf("%s/%s", path_str, + "subprocess"); + + qtest_add_data_func(path_str, path_vec, subprocess_run_one_test); + qtest_add_data_func(subprocess_path, path_vec, run_one_test); + + g_free(subprocess_path); } else { - qtest_add_data_func_full(path_str, path_vec, - run_one_test, destroy_pathv); + qtest_add_data_func(path_str, path_vec, run_one_test); } =20 g_free(path_str); @@ -340,6 +347,14 @@ int main(int argc, char **argv, char** envp) module_call_init(MODULE_INIT_LIBQOS); qos_set_machines_devices_available(); =20 + /* + * Even if this invocation was done to run a single test in a + * subprocess (i.e. g_test_subprocess() is true), gtester doesn't + * expose the test name, so w still need to execute the whole + * thing as normal, including walking the QOS graph to add all + * the tests, in order for g_test_run() to find the one /subprocess + * test that it is going to execute. + */ qos_graph_foreach_test_path(walk_path); if (g_test_verbose()) { qos_dump_graph(); @@ -348,5 +363,6 @@ int main(int argc, char **argv, char** envp) qtest_end(); qos_graph_destroy(); g_free(old_path); + g_slist_free_full(path_vecs, (GDestroyNotify)destroy_pathv); return 0; } --=20 2.43.0