From nobody Sun Apr 12 00:56:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772441388; cv=none; d=zohomail.com; s=zohoarc; b=OL0u3cXTsyDmBDdy+mtJepJyWmEQALf+T/6vcDObTWDRQxo4ZQZ8U1228sosNSGQXRDK403Mxoj5zI9nuYWka1QBrw3xlkBqnRMdI/ZrYeXDIQflNip/zgEiou92+/9Q8SMJ9UECdbmEYz+5WqRALNPJ6KMgIICtTka6HrAeFDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772441388; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xmxuLXSQjpx8FYdfBKGNckzov1k818273nQJiPB8cgA=; b=hBHPEpbXXqMStlJ9NETTHvo0sQ0OGCLouBsJi34r3VUULhd61OBWhKqqgD8ymHNPi+oeE07jSMPe1Z0hyVgwOHRR460zdkrBx1l6vT4Hi5ttm+W4WRsNZRf7Ysmk5x6eMqUdouGlzqkfGcb6Qa9NLYTornjuTAaAI0SUgXUeM4U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772441388090304.7235805068092; Mon, 2 Mar 2026 00:49:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwyxv-0003h4-Ku; Mon, 02 Mar 2026 03:49:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwyx7-0003J9-DX for qemu-devel@nongnu.org; Mon, 02 Mar 2026 03:48:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwyx5-0002F8-MJ for qemu-devel@nongnu.org; Mon, 02 Mar 2026 03:48:33 -0500 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-Dzw9ACeIMhmX_iWRf4Qsrg-1; Mon, 02 Mar 2026 03:48:30 -0500 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-439b6c9766aso741884f8f.0 for ; Mon, 02 Mar 2026 00:48:29 -0800 (PST) Received: from [192.168.10.48] ([151.95.144.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b503425asm7957466f8f.25.2026.03.02.00.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 00:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772441311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xmxuLXSQjpx8FYdfBKGNckzov1k818273nQJiPB8cgA=; b=KXGxohiR3aymXsaT8YvyHXpgOkZW00KOdcLaFHs3YNcD+dbpO+UYQUTavZIDqN35dGJG9H eh5D4sW7X6HZzoTjQ/4pUj/Ro3ToPhsRb3TZGujYMFhNlSbYu77Bmtkab8aWuI2/Tlz1Nz SLOs+wPGlpqQ8iYz8+7sh+yzAR1mLRE= X-MC-Unique: Dzw9ACeIMhmX_iWRf4Qsrg-1 X-Mimecast-MFC-AGG-ID: Dzw9ACeIMhmX_iWRf4Qsrg_1772441309 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772441307; x=1773046107; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xmxuLXSQjpx8FYdfBKGNckzov1k818273nQJiPB8cgA=; b=EjBIBZodECUVhJg2pwrvjjIQR35JcilCfsI4GC9DbowXIQid8fwOoJ1NRBPSs2LSMe sutungkccWzOnWg7Gg7PSK6wNTnXMm/KPawBWMfraqaIGCNU/d4uSaJI1I5zUW/UfmDv Dt/2CbP0wN5Ld6ShszVimtYri6d34txFanpmyNaXvxUDCSOBo5EGEKDag1BVZvWHM7ON R+GIoXyR4Hj+TVy6UvXm+p7n72+/f+Iz8CqzSpMk0S7R0b4HNhOCveneLL7PNgpHIQ9s vyucnYZ984dWIWlsbGp0MydxpTkE/jbW0msudvoVB6TK0hu3tRm0Tr/MSF9s/rpyW6L9 x6Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772441307; x=1773046107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xmxuLXSQjpx8FYdfBKGNckzov1k818273nQJiPB8cgA=; b=Vi/I4LV8sPVSobOn3+4rD4cH9WyXd4jchUibPWIM4zFNN3pZD0n8sOr1XYNPg+kASI 13gO8KCINlwCe2Peh9pzISsqsV3ivK0rJZ9/eExkoQ5+DK7eTwa257ZSoNkflhOHWB14 XYRFGAgwlFWLqNWt0pjV9s9A4D0yLr+4CR/uJR3m4Hx0Fif62NDHz//hk6zTZUSFMS8K 0eQ70fNwFzQ4VDa0YmrkxwHNqbEaqs0bJ7IfxWpE+0ixTeTiG6R2Lx6ch6qxqKistKSv dEsGbUWhnFZeyPVhqd+vUFtrX14iDLTLdq1E+UQ9J80iycw5YUgb3KvYPa5vL0nvLWh5 r9cA== X-Gm-Message-State: AOJu0YzNCZm7tAVJn6tSwaYWWc1agA5ULjlggsI+h38QX6gNxjKErxrr /5PGRY2qEozLXq/cPFYNdkXVa8YO1EHqPGT7bd0LP1lmLWgT+DeV3+/4LGup4MgmtDBQFht3yGm I59hvdjFkbBV8TJVwPz2Q1Strqjk3r5SPFEYaGiD2i7LFS2cWGbqa4VeEm/+migGiupodfyNfsG 87bXHA1fI9+9SoHBcI44X2aDH2hO9ysyBs3mwZJcwm X-Gm-Gg: ATEYQzzIxWydeTrCQavHP+92C9GfYqsedvJsWAWJSXfTGspPYMWRXGVFBdnyeYAEWjL fwFQopyRiZLFpKu/bRyH5OShxWwhXDoeL8+dIrBc3BVIodroqlwuIu9IbT2UhTADRArsVb5dtnO 75NB8FUSC2li+BsJKK4m7KOGoT1xE2S7n0wYieQlA/qLQsoJajEhOqsF68JztNiBqfdYPBX8vzT RGVEW8KHtyzCWtn+H25yUlrDYpJvT/oPslXDVpQR1sHapmTI3Bo1VL3Z73X/pBzyTgfJougGwWY ZnNExdj5jHGeS8d+V31ZhBu957AOD2jOqr3FdN2E43/1XrOQ2oS1suHRykdcX5QmNgcLAVS67iF XfP45Ee39/HGd+FAjck9FFCLRJtFk3tAFVJqhdT097iYI3jECU0RieqxBhBOZRMazTbT3q4AWRE zFnkkwkTm2yM5ZzWaJxXS8g+cR5Qg= X-Received: by 2002:a05:6000:2902:b0:439:b265:6c61 with SMTP id ffacd0b85a97d-439b2656dd5mr7466967f8f.12.1772441307367; Mon, 02 Mar 2026 00:48:27 -0800 (PST) X-Received: by 2002:a05:6000:2902:b0:439:b265:6c61 with SMTP id ffacd0b85a97d-439b2656dd5mr7466917f8f.12.1772441306755; Mon, 02 Mar 2026 00:48:26 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Ani Sinha , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 081/102] ui: drop spice-protocol < 0.14.3 support Date: Mon, 2 Mar 2026 09:47:27 +0100 Message-ID: <20260302084749.474955-15-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260302084338.473368-1-pbonzini@redhat.com> References: <20260302084338.473368-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.012, RCVD_IN_VALIDITY_RPBL_BLOCKED=1.188, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772441388850158500 From: Marc-Andr=C3=A9 Lureau According to repology, all our supported distributions have 0.14.3. Signed-off-by: Marc-Andr=C3=A9 Lureau Link: https://lore.kernel.org/r/20260211-cleanups-v1-7-e63c96572389@redhat.= com Signed-off-by: Paolo Bonzini --- meson.build | 2 +- ui/vdagent.c | 18 ------------------ 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/meson.build b/meson.build index 11f83cf05c4..f67f8668bd8 100644 --- a/meson.build +++ b/meson.build @@ -1325,7 +1325,7 @@ endif =20 spice_protocol =3D not_found if not get_option('spice_protocol').auto() or have_system - spice_protocol =3D dependency('spice-protocol', version: '>=3D0.14.0', + spice_protocol =3D dependency('spice-protocol', version: '>=3D0.14.3', required: get_option('spice_protocol'), method: 'pkg-config') endif diff --git a/ui/vdagent.c b/ui/vdagent.c index 7ff0861f3e9..5a5e4bf6818 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -17,14 +17,6 @@ =20 #include "spice/vd_agent.h" =20 -#define CHECK_SPICE_PROTOCOL_VERSION(major, minor, micro) \ - (CONFIG_SPICE_PROTOCOL_MAJOR > (major) || \ - (CONFIG_SPICE_PROTOCOL_MAJOR =3D=3D (major) && \ - CONFIG_SPICE_PROTOCOL_MINOR > (minor)) || \ - (CONFIG_SPICE_PROTOCOL_MAJOR =3D=3D (major) && \ - CONFIG_SPICE_PROTOCOL_MINOR =3D=3D (minor) && \ - CONFIG_SPICE_PROTOCOL_MICRO >=3D (micro))) - #define VDAGENT_BUFFER_LIMIT (1 * MiB) #define VDAGENT_MOUSE_DEFAULT true #define VDAGENT_CLIPBOARD_DEFAULT false @@ -87,10 +79,8 @@ static const char *cap_name[] =3D { [VD_AGENT_CAP_FILE_XFER_DISABLED] =3D "file-xfer-disabled", [VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS] =3D "file-xfer-detailed-= errors", [VD_AGENT_CAP_GRAPHICS_DEVICE_INFO] =3D "graphics-device-inf= o", -#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 1) [VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB] =3D "clipboard-no-releas= e-on-regrab", [VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL] =3D "clipboard-grab-seri= al", -#endif }; =20 static const char *msg_name[] =3D { @@ -125,9 +115,7 @@ static const char *type_name[] =3D { [VD_AGENT_CLIPBOARD_IMAGE_BMP] =3D "bmp", [VD_AGENT_CLIPBOARD_IMAGE_TIFF] =3D "tiff", [VD_AGENT_CLIPBOARD_IMAGE_JPG] =3D "jpg", -#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 3) [VD_AGENT_CLIPBOARD_FILE_LIST] =3D "files", -#endif }; =20 #define GET_NAME(_m, _v) \ @@ -197,9 +185,7 @@ static void vdagent_send_caps(VDAgentChardev *vd, bool = request) if (vd->clipboard) { caps->caps[0] |=3D (1 << VD_AGENT_CAP_CLIPBOARD_BY_DEMAND); caps->caps[0] |=3D (1 << VD_AGENT_CAP_CLIPBOARD_SELECTION); -#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 1) caps->caps[0] |=3D (1 << VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL); -#endif } =20 caps->request =3D request; @@ -318,11 +304,7 @@ static bool have_selection(VDAgentChardev *vd) =20 static bool have_clipboard_serial(VDAgentChardev *vd) { -#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 1) return vd->caps & (1 << VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL); -#else - return false; -#endif } =20 static uint32_t type_qemu_to_vdagent(enum QemuClipboardType type) --=20 2.53.0