From nobody Mon Mar 2 08:44:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772422046; cv=pass; d=zohomail.com; s=zohoarc; b=T3+4tCWHQQjgF7/mBcG9X+V2Z3EtUCQ8dZ39Ri2R6vTQD2YmbrSytqXxi5CpW2xtm1ksTH2lZ9yzAe9kiEMvNlnP04Kn3pAYxJ6zUyFB+f4KHGi++zkR00zNJY2fepUraD+1AfqEjdjcKFk8FmrP0t97VdC62Hf3fJ5AmF+DyHY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772422046; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zpT2YXlK0KnFZUNVVEL2ArRhUhDXHdBC74aSJztU0cE=; b=kfS29X2ruhX2lCZC2HXqvb/jPX8l9UwTkqzeIBiU1nsojG8NqqqYrBlhSOW9DOO3gPxOvrO7wpo/Dr45plZuEWhWNxcltZz0LNGCtjl2jV4DW6xAimbAE/GFJ15GcpWTWmVM25sjdR7zJjXYprnmctIktDZpzpWzow2ExgN4nQg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177242204614197.37584153508271; Sun, 1 Mar 2026 19:27:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwtvi-0005pe-BR; Sun, 01 Mar 2026 22:26:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtvd-0005p4-Oe for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:41 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtvb-00008k-VJ for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:41 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by KL1PR06MB6791.apcprd06.prod.outlook.com (2603:1096:820:ff::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.18; Mon, 2 Mar 2026 03:26:30 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Mon, 2 Mar 2026 03:26:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZdkNwWgV3zlWDTYT7l8WWBYbC/ejHPldLtNl5tM5piIDK0mXphlaIxyKp6x9RjlhDDDUhf+iQ1GPU5OQbIz6Zu8r2O5dxxjx8tcxkjO/E55CTXulTj0p1VEud9Au6fqXfOZqdndEa1FLBZyPzyTKc4K59llZfE2s7HZGRtbrMSJtYde+WcybdW8SUfAMO13kKupCP50SQINO18Atxw7vTES79HGcRKlckhrP83w+fiDDAk3R72ff22EphZ7+RVJ2uWq8ovTbmz+iv+D7eWYwK4w6+o08rNAJNmoImmtGsLe8z+eXput9uVrRCE7Q1XG9qNEJ89Srel5WKorUhM7HpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zpT2YXlK0KnFZUNVVEL2ArRhUhDXHdBC74aSJztU0cE=; b=bTIfpwDijRRi46dljn/ZGJGSPw/v0aJqqpMx0PVZHluWGynqcIc2wB7PRYZuuR7vVD950wNZoFpGU6cUgiQ6zQaOJtSiUchzCZCdkcshs3P0zlrqFqYU5AU3+if+Ul8s9hHwWG2YcpLeDHMqjiFIvl35L03xCGFZU7N5AT3R54gI6yox5IFaJZlQYRlosrsx1sZPRLEP8dY2QJpIeNZI2dCWU3Hsk1dfuB3Z/5ZUH9pAoCSsUskUydLUaxcpNts8y8m8q2QjejWMOcUhqYDhpQA1pi04YzfHfRxy8UkToFGBs9X6eFQqJJICt9kBkOEWHl+UJawHzY04krZeqy15hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zpT2YXlK0KnFZUNVVEL2ArRhUhDXHdBC74aSJztU0cE=; b=ivJgK8QpsuJuMHjy4OuIVsaCLVI5YuNz3bxRsfB288+TR0NUZii8CbxNE+vh91L54Ghh9lz0Gjkrhs0EzNc0Ys+yBm/hLQNrUaQa/izi6o7DKbMX2foP/ilRgXMlth6OjOZabKz9l1QgtnblwQcO+KM6+l1wO8t8mI7OormC72BzAclhcBeAEezoe2JrrIaksrpi/m7U49TACGlS3XnSHDEDeRpftr+4NlTds0u++u/XrZ1tneMF7lKNa3eY5L1hpnApGcRoUctr2urlEjlU9N5aFqCf5j2fpnxR/UcCRjt7uXOfi05/9yMb7b4yO99c69f5Hyz8XS+MeDdOUxPnOw== From: Jamin Lin To: "jithu.joseph@oss.qualcomm.com" , "clg@kaod.org" , "nabihestefan@google.com" , "komlodi@google.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen Subject: [PATCH v1 1/4] hw/i3c/dw-i3c: Use ROUND_UP() for RX buffer allocation alignment Thread-Topic: [PATCH v1 1/4] hw/i3c/dw-i3c: Use ROUND_UP() for RX buffer allocation alignment Thread-Index: AQHcqfRcZwVZPRWID025fGkeQr+UQA== Date: Mon, 2 Mar 2026 03:26:29 +0000 Message-ID: <20260302032626.1974743-2-jamin_lin@aspeedtech.com> References: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|KL1PR06MB6791:EE_ x-ms-office365-filtering-correlation-id: 85445b39-5d59-496f-675b-08de780b7e8f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700021; x-microsoft-antispam-message-info: gR7MS2XI9WR7RgLZzG1lmrDV9qPPI5rDeIlETQAjASoVxmXXKkEwmvcTWvp18/BLVObTPNuWnhBQ9YGSW3ajSiGYBFO2tfabsk+N4bI2WXcHgU4aKQYF+6qmGgh9+lZE5jLdZAbS4Gj0Rnu1cuEFQknvKw90fEQypw+mZI+O1j9109+ZKsEh79M4bp40vy0EblsmOTUPPxepTovRbF+n4J0EeaV3nGyyky5FkitKDGAPSkrP1bNREHcX30aS3w2qzldqG2BEtfExbMIab9NCPz3E7dqB6ryuhdYU7np97KKmUEW9hGsv3OwYdA/AiXXfBGKbxAo0zPLLdyGvoImx/GMcy2Sha0gNf/5+2tv1//2DbFYN4tkOtjArmBFO2n0tsdeVTi337V7wQJb68cENCFWfau3GcXz0ojp8Y/e0Tkort/QdfT6JwDtcbOhd5AUX+P/ckt3doMnRANVsMOubd7wIGWfksPvSlSYXNBt5AroSntXfGTYDcTva9XKwHxzwwK0AqbDPaju2ZMHiiPc8+y0Lop7CoI0a+jDGDgifzZCXCOjSuOtOOBRFuWBmuCLyECRH5IZTWwibYGS8RBG90txsHdPKYKiEbZv+aP3YaaIEAtLPJ7ngrAf24RjXfXWQC6Swex78YOyn+jOtle1WEbe19/k4e2LWls4jJKVm7Et+HBEYbYrKX7hcq//ug93YajZHSCYfbaD/nMbEOLDTL/niWRe/AiyaAjMxYg3xWuYvG9TN74sEzb/mMz9WELIyy+CAYTL84vbS3mvAYSfOuPm1Wadl5TtQ3x5soMDwayo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w5x8LuNEnCbOdLpyx3PiyrSIULvN5VVqZDSM0+0IO223mgKtsTrG+QNdRDKd?= =?us-ascii?Q?t33hyMWr64PcKpv8SgI95gMsjobIeuHzYbzYICjAUmr6uDrEwdCnMkHBTrb3?= =?us-ascii?Q?RMGLiVe9l5FicSab9+dMcyg9wAGVBOqAghFfBDuGk//7j6EXzyKd0QMWi/d9?= =?us-ascii?Q?dBNf5LBRmAexSsmW0wiEPJ+LbAbtKnDesOBcOcb+BzamBku5Mc0KRHzstxtc?= =?us-ascii?Q?GCQq/nBoBTyLpjdSYKiIGQ3WUbjphP1TGMjTVbfrgFuYi0ykTsOkeYRnvdsy?= =?us-ascii?Q?vvLQfnwP8JToNa7vF9CQZ3ljB3pway1qDLPVNTwgJiHr0tOL/Iid+K2z1WlS?= =?us-ascii?Q?666Jy3sjhIwfgta36BCLFm9lpx6UyzFYczXjaAttcvhHDRoVMjZnbfBLv0UV?= =?us-ascii?Q?9FghFYWfaKLHMnSYymyfdbWvEqieVG9Y+PEuB7cd4UpLGK2yZ05XSKvV/kuR?= =?us-ascii?Q?zSxCu3PqQIiNb5HjSF3pcS6V3RCd1MptG3MUxH/KmOUqNvStAfEI/CXnqzhS?= =?us-ascii?Q?t0aeBEkx7HID4g3zLuqg+aT9q1GGda0Va3p1d4OOAy+ePYHLJZjlWpwVkoa8?= =?us-ascii?Q?QSwzRj8hGSMeuHb+zFf81gvFDRbFm8Q4kNNXceaVJ2/svcbSGIZ+e+fF1xFn?= =?us-ascii?Q?GLLYqDftdplq2NALgYFDPo9uPcZBzaltVWEZXpL+ifi5i5XJ6OBjQGPbok21?= =?us-ascii?Q?08t3A+iVFYScbOmsAUgCLeIvcE7p2PzpxuR0b5ev4ICyNxDsU5mF0b2zwFVI?= =?us-ascii?Q?lE3I1uYHyeMD9HKpV9RMLM3gI9zsws9JBndSXDiBdZQRAUJ3iOP4Ehay49rU?= =?us-ascii?Q?TjsEnlZ8HJ3hZJOdVY8px5fc9utHKj8gaPy88kwS8oc6Vl6Atvrylh2EYxSX?= =?us-ascii?Q?C1jXSiR5AU9BKZWffWooKyjN5k3xzZpwylexnfzaezCzfZa5mKsTdEIDwEhy?= =?us-ascii?Q?l6GDbktp9ZpMomB2hfodNDF2/2Dof6ZPdc+4EGxMlrKrATdFne+vtWeW/GZ0?= =?us-ascii?Q?CBYW0uUrz9KZBFd15ZGaxdpRctccN8z0Ij/ZxxUXxjUMJ347uZA1HbdNSuzY?= =?us-ascii?Q?i5BVINab4HSyzJnO5PiK5oS9fsaJ5DV7yfE1YbugVKa9GDLFkqIzxTw/xPJh?= =?us-ascii?Q?FqcyceJbnPVADDDYoib+jmZJLDLv51As13dKRBZUzN69U+CraVBpEjXS0g60?= =?us-ascii?Q?bykbgsod/vQEaHsQddgslGLm8Lsi46Qmawcj/kayS2KIJrH2GvbvSP616VKs?= =?us-ascii?Q?9VQjdyxM7WD+Fb5uD7PGab+A8Fdwi0fQz3wx+mZawND4xC2AY2sHsDnV6vyW?= =?us-ascii?Q?kI/sGsoGlfnc9X/V+EtP64Va46oKsBlFe8i+tbJM3H+FmrfyjzetIvDbMqzV?= =?us-ascii?Q?Z4zxSrpSCov55m5KcjHvRTgrVrfNsyGRenXYDvO7b9Ev7N7ucA6+pmsJaraR?= =?us-ascii?Q?3W3KuSdXMEM3RQG0R+b4ibQr1NzCmwQxk2r2uK0GTCumUfM1U4Fg4lrjHBv0?= =?us-ascii?Q?zP5P7A5Kq4BhSCFv/svzTeUWSbYaAMKXG04zNbXwJQqOKn+eCwpZrA4Juu27?= =?us-ascii?Q?lse2azgQSU/IQ//lKrtmMmh/qmbaYOLZkH4NgfFU8V4FT0uitc5Sg8Bkeikm?= =?us-ascii?Q?OjCruIVrq2GPuTUGGUYp0devtGjF9hNy/pcP89LLdZvGOZK79VL8apOucciV?= =?us-ascii?Q?z4V2t1IapFlOqnPIBKYyjgHlBRjueLZpDvInTto8D7GfosRurl2wk/HLfLzJ?= =?us-ascii?Q?iWWUuCirMA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85445b39-5d59-496f-675b-08de780b7e8f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2026 03:26:29.5924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dxptN1SZYYtk7WZRPPWidZWMN3dM4k348KSdW4T9wBDlQCLSupMI3ZKcldEP8cK+KKbgpr55rGcmBfyd0uVZJtdeTcuv1qdmpmp4mJXdVDQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6791 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772422047119158500 Content-Type: text/plain; charset="utf-8" The RX temporary buffer allocation manually aligned the size using: num + (4 - (num & 0x03)) Replace this with ROUND_UP(num, 4) for better readability and consistency with common QEMU coding style. No functional change. Signed-off-by: Jamin Lin --- hw/i3c/dw-i3c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index d742458129..3d8b95a14c 100644 --- a/hw/i3c/dw-i3c.c +++ b/hw/i3c/dw-i3c.c @@ -1282,7 +1282,7 @@ static uint16_t dw_i3c_rx(DWI3C *s, uint16_t num, boo= l is_i2c) * Allocate a temporary buffer to read data from the target. * Zero it and word-align it as well in case we're reading unaligned d= ata. */ - g_autofree uint8_t *data =3D g_new0(uint8_t, num + (4 - (num & 0x03))); + g_autofree uint8_t *data =3D g_new0(uint8_t, ROUND_UP(num, 4)); uint32_t *data32 =3D (uint32_t *)data; /* * 32-bits since the I3C API wants a 32-bit number, even though the --=20 2.43.0 From nobody Mon Mar 2 08:44:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772422040; cv=pass; d=zohomail.com; s=zohoarc; b=QygrRc1cEVC0B74UJvm5r8BNsVphszH1IHa68BrYPd7Wvsz4CDaqFry9TG56SaA/Aj/Se2dF108FjttCA0Z2dJdYcm6PgGO972EAY69jG/sRnwXKbkEFqGtizWYdHaougEUuuLPIyXnb2zNdKHoYJjCYH63YkrrR+WcNz2uFzeg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772422040; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5Zky49kl4za6IIxpcfwVCkPGJ48G2ldq8lWhOs2v+c0=; b=TY1TjmrO7ncXxBOj0ch2UGxt/gLijaIOnOg1IQBQBwrgPooPezotbbViE1Et+NOyX7AGYRd0HJbvZuC+i0q4zRTQC9hPS8iG2sUmrdg1MWQpWHcI9hOa/XIkmzhDi91f4AdcdQiG9AYo3vttQrkyFPkVVj8V8H4X8D75x+KMqek= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772422040841310.03193102613784; Sun, 1 Mar 2026 19:27:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwtvj-0005qP-DJ; Sun, 01 Mar 2026 22:26:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtvg-0005pt-Nr for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:46 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtve-00008k-B5 for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:43 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by KL1PR06MB6791.apcprd06.prod.outlook.com (2603:1096:820:ff::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.18; Mon, 2 Mar 2026 03:26:31 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Mon, 2 Mar 2026 03:26:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vrbFb4UoXrKTTwTgA0TrFiGy/tMiih27U4IlMe5n9CkRMblqZ15D1rWMtC4SqPMnccS2v/KuyKe5QEy9dY5QTeAMgfC1Cf7rgiCWFXVKal/RfjvOhiM7YTZa0iXgbDFBsI5+9qhVDa0C0WzH+YDErbMOGebQu0rVmh4y2+YRDSz0k/tX1LMtT9wrDJrcvm3hcKAle/d6IBTGZGVh3pcmiu5iaQ2qnsTISEIGg9iMZfXEPc5GN7mM1kveTk89+lvf6ziwvjoD8Yd2RtZZTsQjjJ2haa7WljmTqxxpopjeLYyWzco42rVV6qXce2VyWuAgt2NtpAju4RzlQ9hJbrdynQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Zky49kl4za6IIxpcfwVCkPGJ48G2ldq8lWhOs2v+c0=; b=BbXNC4aHS4CihPCq8WxC3mu7vfi0MVS9/PS8crwnLDcjoCHbO0ASMrN1tt7AVRWzRLalyOXlyLdabai6epn0M84ns7eJ8CSgiuN3dRqOdgsh3aSS7TtZ4z6wzXoxgugOhaDRUm9WrdEZLqPDZD9Jx+ljjddpSjghvr+NvAOkTZGzQzEoxx8I6s7ttAzd5eM/TuUyvd0BwZC0NI1c4apM1KYdbMumfMcfNrTyvw29hiGmHGYbvNpOXAvNZNBF3fI9i6RbCkXTgH8n0R53L6HrfvMQyajnyE5mpePcguhPvAl7Lgmrjjf0DZAYykm2pHHjsdFd74vcDhaAt4t93U06Vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Zky49kl4za6IIxpcfwVCkPGJ48G2ldq8lWhOs2v+c0=; b=mIHwYItn2Fj7co/+CV43QuocT7DtzqogXc2qJ1ycFyKtMxREbptb+zN60e0Bs2jSluZ1jSbiBxYxGuG8Xau3fNb8Vbg1aTXs4pIjKVa4ZqH9rPxHpa7qQk/asEPYPSRzwhDPKyaiJ030PG4NBtrbXj7KCfBC2zsUFR8VW4xtY7LFIGMddcR11TgrKiZtvDZ/Jtexyy0uFTS9GEFuLeAyYncN5Ge56YOUXbe4L5pwHA+9v/cZUUrHU35dysofFvBFhY1LYjaPKfO6/EOnajJFFOUEG0PFQl6n/zcyVuPiV0sz+iCTcrRcOoZ77VgIuAZJMS3Qt8j6XVR69iKSrwCZ9g== From: Jamin Lin To: "jithu.joseph@oss.qualcomm.com" , "clg@kaod.org" , "nabihestefan@google.com" , "komlodi@google.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen Subject: [PATCH v1 2/4] hw/i3c/mock-i3c-target: Set num_sent in TX callback to fix trace reporting Thread-Topic: [PATCH v1 2/4] hw/i3c/mock-i3c-target: Set num_sent in TX callback to fix trace reporting Thread-Index: AQHcqfRda5+Mn5Kj5UOjIHS9/+O4zA== Date: Mon, 2 Mar 2026 03:26:31 +0000 Message-ID: <20260302032626.1974743-3-jamin_lin@aspeedtech.com> References: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|KL1PR06MB6791:EE_ x-ms-office365-filtering-correlation-id: 8ffc17b8-c452-4c8a-244b-08de780b7fb1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700021; x-microsoft-antispam-message-info: ehWsG2KvTCk9FE0Y/hdaFccNEAiC/9tj8T1hrpYMWt2aTo3Flz3y/e2xBPO0jNhddDr3BG3hgySrblcsa1yWrusmwgpmkurwaZKiua0SR8dGNVlK2M7QdcIG+yjsC7QWKX938ImfaAbg5d0zsvMbZzrfGharcbYoyEEo3ha/ZWXVHLEhK/WzJJrBtNdWsBF+KXva4Lpgorgv5gZfUkBn/Vz2lMOkvgUYi+6WVOxxdRHtC4XlKyH3Y5gHDbTmJnEE2y2wHyjqbg6fgKq/z+rlJ4fZik5UG7VfMm7do+Nl0Ih4dDdTgayAxxMkqHLdKptJmppV/ksAITQByImyhM3nJMQYNFxPjgJq4jsfCEiMjSL3dVRZxS5xyzj5MIfRAHW3ZXBK3pABK+FFC1f70+5pR5yPBZU+klG3n/G8jLVycH8z5j4SmDeqTXWkvYXOY0w2rvZg2XRZPdxFfU/SYmzYJKQT4/yIOmVov9TNQ1IFz3JTZnu4SxIzmcUqA2cYIYHfjpoZiNZPdYdToRtN2YJW+ZWCaeNW/DHrmOWq2MOkgiJcfZS7aqXopMpbnF/niciotm5bMoMjrQwz+HINbhSPVfKku+6Bn0+55dbtXgRUkTHmQO1Sr9mwynkzSSkSwRCPuFQh6PNtY4kRVJAWceIGUvyOgvVnyu5V3lhSR3WjbWDDuz3m5JCQcH8/eEZxTSMvfqHllS5UZMenSZ9kqe5LADamJ7JT7BbwBkcmzvO0z0y0vRMJR+7ffrfKihopJFxoRSRmVA9OdqPR/cH0CkrZhLyjZOSh2gAVXEg4mgFSW88= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pRLCP39b/ZB22WXrRkGsuVJPhUbfHuh0YeYpayYG6Ea1rcKliHhu3oiOJS17?= =?us-ascii?Q?f0IToOpEZWvdUujX+yRkivCKILfVPe/lsPKbMYPvi8lg74o48fLvWpPVbi5u?= =?us-ascii?Q?+xGr+1ReHFKIuDrCGCp7WedcgI1TL5Dgxrahg/tKAdcJBsgPfvm5ZvqL4UNq?= =?us-ascii?Q?s286f09Y057MDFM4xNsV1cz40dZevRCxaK0kGhcQzzYJHMwXyw4Q53EJBXLl?= =?us-ascii?Q?Y3FvxvrMl5qJSxgpKD5wEauSka3sN45hym2vD0lwhT/u45mNcRnSfpc06k2G?= =?us-ascii?Q?Cho9ACphH7WPLXuf+njPBJfdgZhpGShz2O6zvoECul1k46RslrbSgQA6yWPW?= =?us-ascii?Q?jc+J3EQlKgPddLZZe4NFa4j1xu2BLD7oyXk5X32nS58HtUknoYjXgI0QQ0e4?= =?us-ascii?Q?bNc9jw/gkygSrvfuXE6obrZt9gO0UEzpnBEtQFTiDe6EriGW9TmM4TUkYPDa?= =?us-ascii?Q?pVKy32yT2fxtQoUABTc0QNK1HbxqmageN+hNda41YbfMpK1Js1Cvp9gpZXkg?= =?us-ascii?Q?/vylaQ31ngN4unf6NxnFKuLeHAF3+TJBw0rDbU8njVPOVXqe8V6cHZRu8bJU?= =?us-ascii?Q?w5jw/vZ0w185OL+ReWjwkcphDLgSKFOWObT7uky9pgtKiC3eOMcSDW8lsVij?= =?us-ascii?Q?H3N6VaiSs2GACynIo0R40qUbae5ThcgES3XaHlOT9+KAiNCUUXCsUBD09JIe?= =?us-ascii?Q?06dLRWfx9fs0w30Qo+uYOUaZCkLjB5aXEEM4k9DexrpaMN7tTe+Ma6lzN6VT?= =?us-ascii?Q?JDU1WlpMAgbpVUBafHYQzoYjtt8seTuIdo81YJ71Wj7w3z3QqhdKU90XXL/i?= =?us-ascii?Q?E5J2Api48uMC3P3RJ1q9zDwTjK3cG9vKbS1yJEstLWM9YDpkN7UZDKguA+n2?= =?us-ascii?Q?3h6zRY08w4ZQOOIVqcchXqlP4ggUgzV6IhccOhhdz27FjXGdmMGvszJBtDmp?= =?us-ascii?Q?3/IfxXBOiJX3IF/5xCoBieqKBHEHEYym9Si4//+/CpL1Dahnfz8dDc9M/7n/?= =?us-ascii?Q?DzT/Jh+OxwbyYw4UobFPCg5RFg2Y8WSZEsLO2QLCE4fN7u6qHG5gsw5p8F/v?= =?us-ascii?Q?Uon2fCew4dQCTYuVeOIRHd/VjRYaJxYzf15GRRVIyWS7zIp6bnVn7koufM7K?= =?us-ascii?Q?9BrDQEmKg/thauz22prNeMicphz4vp3vGQ+ZUIzeXz301x60wC63dGetuYg0?= =?us-ascii?Q?6Hb/TWzHPN1QntD/ZR7dJs/K6el6PTwwRP6xFVrZjccirARBfMNxznedPMaJ?= =?us-ascii?Q?WMm2Aul9Cs0FCto/2eHv/Ci09fHEOHE2NZ6mXxR6ZkvA/Gc+agOLG7TYRmCf?= =?us-ascii?Q?Im6vIRgfv9JhoyYCkJP2Ljx/YrbaY16h1pVcCt1zGdd9h6ZRdl6Aa5iizFSn?= =?us-ascii?Q?ArtNlCYTTCVMNzFufGUDAkul1TA94D+XNhTfLbIIWvOdT4KN85LxoUJVEuue?= =?us-ascii?Q?yxJAeN9GHN4/RBQVfSXkYcAR5B0nkoYCxxEfs3IplPrdlP3xENhyfkHgjaPC?= =?us-ascii?Q?2YyyQUsf1BzKb7nq5/IBNSdziAZLIXswnzw3DgengkhlhcY/OhAo/LvG/gRC?= =?us-ascii?Q?whwqzpox0CFnBuv9h1rmbgaRT0Fw7gUC5OrLfAVhtlTKfX7e+P0S1sw7uDz0?= =?us-ascii?Q?l6usmxxzjTdCoZg1+McxLaybh+FOuVFqVF+iZ/0snKcxiFAqSI1LDSULTbE3?= =?us-ascii?Q?5Uf1TLDKdSUpiFrEMkg+HvlednyP9pEhtAe4tw05ZiVbK/c2Q6v2VN5hXNf3?= =?us-ascii?Q?u638NWibkg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ffc17b8-c452-4c8a-244b-08de780b7fb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2026 03:26:31.5225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9r3iHNJx9BQR/KEMSp3NEeLZJ9reFWtxpy+VIG/Re/b3YGfbPBA1X4W/1eqcqEQ3Mnat7vrq3BxmbVraG3TkUxwa4kE7eobEINAwFRdDRxw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6791 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772422041470158500 Content-Type: text/plain; charset="utf-8" mock_i3c_target_tx() did not update *num_sent before returning. Although some callers may not directly use this value, i3c_send() passes num_sent to trace_i3c_send(). If the target TX callback does not initialize *num_sent, the trace output may report an incorrect or uninitialized value, leading to confusing debugging information. For example, the following trace was observed: mock_i3c_target_tx I3C mock target write 0x12 i3c_send I3C send 0/1 bytes, ack=3D1 (expected 1/1 bytes) This happens because *num_sent was never set by the TX callback. Fix this by setting: *num_sent =3D to_write; so that the actual number of transmitted bytes is correctly propagated back to i3c_send() and reflected in trace output. Signed-off-by: Jamin Lin --- hw/i3c/mock-i3c-target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i3c/mock-i3c-target.c b/hw/i3c/mock-i3c-target.c index 875cd7c7d0..5c913ee49b 100644 --- a/hw/i3c/mock-i3c-target.c +++ b/hw/i3c/mock-i3c-target.c @@ -86,6 +86,7 @@ static int mock_i3c_target_tx(I3CTarget *i3c, const uint8= _t *data, s->buf[s->p_buf] =3D data[i]; s->p_buf++; } + *num_sent =3D to_write; return ret; } =20 --=20 2.43.0 From nobody Mon Mar 2 08:44:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772422015; cv=pass; d=zohomail.com; s=zohoarc; b=hL1vNA1KfQ02z3vETBKYCAkf2kmBtl6lUCD5Qisjj3vgYdwMcG1oCUnuhc4/oD4SmlhXhQKLS+AQ5J88NPGvJlLYsl/8rfT6EIe16dVXOW6QSWnJrRbBa3DVCY8AZIRdaSalBTFAg44SVSbD7fV577pjM3Y6vgprtu/H/jEPAKI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772422015; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tfPOyJ7rwGhSpbCThZcKuYFglX31pHQDzhA+Wa3Qbbc=; b=Ds1mPAtDn0cSQeoO/GyeyEJu3Ad0zUteqgH9ycutAO2QfIaRzyuW5P2Y+1wgyonOaywq49kC2biJF6v5WN1FhEbFJlcFqA28yrK4tinAi7RDKLC7lJPRva5LlFgFvMgPvosKK3wdCXuP8a2X1dKcoa8VDQsf5MEK72RIRGiwHww= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772422014727269.3103247774392; Sun, 1 Mar 2026 19:26:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwtvj-0005qR-Fi; Sun, 01 Mar 2026 22:26:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtvi-0005q8-LV for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:46 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtvh-00008k-Bd for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:46 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by KL1PR06MB6791.apcprd06.prod.outlook.com (2603:1096:820:ff::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.18; Mon, 2 Mar 2026 03:26:33 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Mon, 2 Mar 2026 03:26:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fkOM5TLAh3Jsbb6ldtj3V6KQkQpF84OQGBLbCJiVSQECbrcq5BFdCiXF3ag8mL9OlkG33gJ0Ok2FhIzbhX2h/St8Sv3uDzJ+p6INNFGYS8bWWf5Ee6ahx5AspP0/wwQaRzFgs+fzD9YdxN4PfqGnnrrdL2VeT5ANh/Xr4EBvTtTXOAwUxrcWnfYBtBNahIGo27HBhR8VyY8HTDtag0tW6DEL5i2omApaEE7SUXd05yGTvPbMY0qdCY+ei0nuTzoD+FCy/tkWRdU5qpLNxbvMxXjuo2UAqZl8ddwqZGHGjWyfmaA8Mmzxx56KfIjYLZ9x2L7gwSGwU64SnTekLQsXtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfPOyJ7rwGhSpbCThZcKuYFglX31pHQDzhA+Wa3Qbbc=; b=rxLdLilyqz6tf/MUFbYfJwl4amwK0smaEf9q6zEhx+TXZL5hWYCElmBTMG37962UzzJpxGKyz+kTEkr5iEARHD5OSjN7yeXV4gC31SCNMFFAVhnyxFCIQhundVqRcNj3soTbsx72S/mg/UpYFGPQIlfE0IavklOqgpw85q6jCraj+y3R6IUSwqDnu8WA+4fmJoS7rGDyG2NIMJZdwo+l/95wnLtyF6oZiWD6+sfDufgO6/yX4PvsQ8aLOnczbCBdkR8KWOqfc8mIOJPAr9DG/5qh6CgdUOtwcCRQlLje8gMOHB8WR4gGpDJpLccL5bSFCXye61sWOORM9TsF4Ux7/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tfPOyJ7rwGhSpbCThZcKuYFglX31pHQDzhA+Wa3Qbbc=; b=JFgM1PrJV0F2VSTLTumghAXWdaPpE7cQ6+JOr2UeuyvgKz7G518J8fhLvV+8DQVkNgo+5pxyp5KOLrJ4crsG3DQytLXBMkRhd78WYSyNuAoPcKBs54+WGMsjqwECefiy+ZF0ZqHzML0CQRCn1pgAv7KYhkxUKJVvh1m99nPe3iJQQ/NqwSlqQPNhQeYJUCVz8gmp0GuXwsNfvrcNJ5laUBtYNim3BVrqna+02tpb8uV7fz+OAYRYoYV5bth7lJsEs1bcG8+W7eKrrJAnRuuFm0cHdEXyHvLgu4jwgDa6/k6Mdx85bkF/im6lK0WbEOyOmNhXg2UiE5nyddXBjRuerA== From: Jamin Lin To: "jithu.joseph@oss.qualcomm.com" , "clg@kaod.org" , "nabihestefan@google.com" , "komlodi@google.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen Subject: [PATCH v1 3/4] hw/i3c/core: Initialize num_sent in i3c_send_byte() Thread-Topic: [PATCH v1 3/4] hw/i3c/core: Initialize num_sent in i3c_send_byte() Thread-Index: AQHcqfReXknTiWVv/0O869EwyzNeeg== Date: Mon, 2 Mar 2026 03:26:33 +0000 Message-ID: <20260302032626.1974743-4-jamin_lin@aspeedtech.com> References: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|KL1PR06MB6791:EE_ x-ms-office365-filtering-correlation-id: ef0fc2c6-ae26-4465-1dac-08de780b80e6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700021; x-microsoft-antispam-message-info: 0/qmBqnISRYkFAxk75qdF5McoagOMzOwbZlFFnW83YN+hWffncib1vrKhD91lGmfflzSLtdRb3pgT8pcf5RJkHvoElkp1r29VjqLSIv7cYb8gU5fRQY1nUAoty0rF3BjdhWUz9QoMSgCX186s0Yz8WVoIlHk4E/Ad8Y4atCi/b1MFfYizMNqlpAnkpa8Gtfvofh3pvNxzrORS7PvUXoKLaltrX/PA4XDTMYbqEtzBvr354+OtR4O8c5l0OGn6rgRCtF7HTbldjRvsXRTCiHapeVhLGhhwHmPKy7IfYCqoZR7nxjH71/1rJlucQXMy9y3ekMoXlZDE/igd34Pjdy9vun2gkh8HpVFZJtygO7mUb8Mbv4lIP8HvcAJw8v5WwkqxvljC1L4x6IHkvkht4EoIbb1Z+q6+67JVEz2zZRXitPz2FXvbn2gqX5UnAterYJzCx6AiPbgp9wyUV5eWuB0rQU97F1urHQF3fwQkWw0kYyQq9VXfD6UKhAi/dOFogBM2/pr1lQhoNAX5U8UxCaM4qwIKIWqrXAyz3rBBYkBzzvKOePFUrAdjQWLJGopVEc1REiSov1SmH2tV8hG+OvGLyMXsyMrJaIRbN5XGiHiftZDWTYTRA4IEXJACn3mTOqO37Hgz7U+edYnouZrgspHW9f4cIDQkH0Tq0bXh4MBd8lvSrtHPPO81bI+T/DslCjzA4C9W82zM7UFqwNv7kThk2rdut7mSBBV8xnD3F07KYrG4hKY7U6RdQRRAptivlYXQUIv6Yek5L83U/OmVxPC4hDI2b+T9JbyWb+9ArXNwoo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DUJXmBr9klQGCfPwKnNe+5djIGyesQrSxbMF6x0XGLqQctWBKNimATbHUY7N?= =?us-ascii?Q?k2JpnvNmeaAKGh/zOuQvq97IGBdmYADpaqSB1rJEX4r95vcB4LKU9yqrkm7/?= =?us-ascii?Q?yhDMxjqVgGoZ3B7sKRt2VQ7HuKlDeWvrsogZMyzZszCaT4f3E8cyb3iLRmDG?= =?us-ascii?Q?ArnsCvFZFU9urFUY3muc4ZoOeUwSc+R2l+vHyBfPboB6faMIb1I3dQOlh7lA?= =?us-ascii?Q?i80j6Clr7xALA05y6ZautH4WUSlNcL6KQpdjsU6VwOXxlbOMePNUMlcwjbo8?= =?us-ascii?Q?HZbxNSxYCrPm/pIdkfgaxgIgz/7zyH0cQ+5R/mrwHNloqMTXIcjLbYcS/e8N?= =?us-ascii?Q?V0SwM06uQcU7kJr4PIa5Xf5BbSG5SUnJ8pcU9npOUz1IJGCXaLon3A7tYIts?= =?us-ascii?Q?YuI44uAbVFt2F+bIooFQzq0uT67afa+BqeMsTdfgV4i1ne3An8oNLeDn0DUl?= =?us-ascii?Q?w4xiWu7mf0CnIXBCKYoPrJzxsH458R7DMlEmJMmaPo6tVaMgm6DuP9tkxw/p?= =?us-ascii?Q?zOEP3QpgtCLH+LYQ2/ov6aB2szSdM151HoQrhhJeolxhn4NSbRfbNfulayMI?= =?us-ascii?Q?aN+OuJJbjroMRDre2aCfFXm+vs2I+cNGH79C5cQkcrZmOiH4cQqV4Iktbkjq?= =?us-ascii?Q?YlJQUZa5CuZZacLsIwCIQzCnjv0jjsH37o6C5T/KwqqjunpwLeU8+uwe/ivz?= =?us-ascii?Q?FxJSCwUMl4L7hG20RoT7eRnA6NJedNpK1/go4Ke5F7bd52WhDUfpv9qdXz55?= =?us-ascii?Q?7ZOV71g0bLObxefFnSOjpKi7mGhUHbQwUYJYCGZx/CfxzXUbE1H0gd/vtOTj?= =?us-ascii?Q?1UEZqqDK1OTOyQbiKKpfqruuYIB+TPZdjR+dCmuP2ANqAT6DizX5OoTFeTVw?= =?us-ascii?Q?IshIUTiw4tVOnZHdmT1ts12Sv0JcS42HLzU2tIFU90C0ZmpqMqSiWnlIXvq1?= =?us-ascii?Q?OJMZYhm6fmQcm40trTmqWZQ9JIyWdrCUF9AiamHt6EmHHaVUZk9zC1n/K5uk?= =?us-ascii?Q?b1/wXo18EA6gqKwl9GTM1NsOpgg8gK0RQdc3eQAOCBWcYPkO5OjYEVivy9Es?= =?us-ascii?Q?TR4CuRMmR57zmoCnirWFirt0wshCjeuz5jdWbCEcwxjx77cxYtiZ4QswDuNA?= =?us-ascii?Q?4MlxggUBdr+NHXLi6ublR/Diu0/YSfJTK1GWJnEQuAU7EbNxSLscxeHfFrrO?= =?us-ascii?Q?YDb3JqJ4jAcu504iH1fJAXq087UXkYYSAs1UOhSxnuem4hO8IVIzXSn7HeAU?= =?us-ascii?Q?zSFdIVQBOvlYzooGuskFhxtO/pVcyFOfEYprPS2ygZhbtrTk3pmtjaVVyNg5?= =?us-ascii?Q?CfVchUCMpnfgU0YMNZq5GH88xO+L4zrSszJhmda5GXfrX2WtLKP5zSk0rH2i?= =?us-ascii?Q?lDB+Hyo1h/VKtbitWJ/JhSbj1KlKoAmEhtWfPdhSKHIdHfR7tN6MSI+5oQS9?= =?us-ascii?Q?RwvFAs3Rp/xnOnhRgjpFgOMxMPP6XPEhM/2GwfgUBAE2iBHU+sY50zV3Ja8T?= =?us-ascii?Q?qPeEJ6NSnHc1qtugBa6j+Prde6L1TXOVdUY7UdTRsxmIqHttk+csRsgwGIIL?= =?us-ascii?Q?B8noTG4iqs+5tpg8jvPwB+ZLh7M5VJXRbwILUKNB+KwCKKJBbEOA+8nRMv1a?= =?us-ascii?Q?2+ltN2cBwFTpbRcS+O5Mz7vyjjFbDkwAWWi0MAEcjI+GwwR1tjs1vabBHo9K?= =?us-ascii?Q?9CvPuKoaBs1zy6Xux5oKKJ9PoQEwqOFmBpzzegTfYr5IT1/kkhhpgEu2VL3z?= =?us-ascii?Q?vbRdwwX/eA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef0fc2c6-ae26-4465-1dac-08de780b80e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2026 03:26:33.4754 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EKFU1f3zLPheexlLzAW9SQLULRcb3dzXI4+1d3N2c298UVfLt+Cy2bOHpWjNphuphf/Txs1WIriW0+GmI0rtkSpnjVB6uEDUyXlJzJy+/h0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6791 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772422017784158500 Content-Type: text/plain; charset="utf-8" i3c_send_byte() declared num_sent without initializing it before passing its address to i3c_send(). Although i3c_send_byte() itself ignores num_sent after the call, i3c_send() forwards it to trace_i3c_send(). If the target send callback does not set *num_sent, the trace may print an uninitialized value, leading to misleading or garbage output. Example concern from review: trace_i3c_send(*num_sent, num_to_send, ret =3D=3D 0); If *num_sent is not written by the callback, this trace can report an incorrect number of transmitted bytes. Initialize num_sent to 0 to ensure deterministic and predictable trace output, even if the callback fails to update it. Signed-off-by: Jamin Lin --- hw/i3c/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i3c/core.c b/hw/i3c/core.c index 0a266e00a2..168526003d 100644 --- a/hw/i3c/core.c +++ b/hw/i3c/core.c @@ -325,7 +325,7 @@ int i3c_send_byte(I3CBus *bus, uint8_t data) * Ignored, the caller can determine how many were sent based on if th= is was * ACKed/NACKed. */ - uint32_t num_sent; + uint32_t num_sent =3D 0; return i3c_send(bus, &data, 1, &num_sent); } =20 --=20 2.43.0 From nobody Mon Mar 2 08:44:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1772422014; cv=pass; d=zohomail.com; s=zohoarc; b=CGcxc6cy7yyhIxqok4hTnGO8TFE63+bUQ5kE9n18BJn8pSQ6uBcrMemPCwsV3fsYt5pTPXNsza+JxPA9MGvr8V1MdWu1OL3QLxjC3X5iCh4A9oKA6asHMmCbNmKBgJJj5uX+JvB1KAZ9bM7tlC+a2HS4DI8zMC1dQqyRSGIHC2Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772422014; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tvEJGeOvlf2VS3EdrA9TayxlYmmfvYAFY34/RXZCbzE=; b=YiwYbgGMoR93dXoNAJA/wkc3XoXhVkhXZelX9jVdUv1tg02sH3LyXq/pd7OkxEivWGv8WrkFQafXEVstjHMXKtEvd5Z1CyqxSN5gonkz2ONJXW6s9/WwjSQBzvbXQMZgVgvIY7mXGvQAzKY8Ds00wfs67jjyvzZ3ufY1tKT5s+c= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772422014496487.99029575799057; Sun, 1 Mar 2026 19:26:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vwtvo-0005rN-0p; Sun, 01 Mar 2026 22:26:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtvk-0005qy-R9 for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:48 -0500 Received: from mail-japanwestazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c406::3] helo=OS8PR02CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vwtvj-00008k-EM for qemu-devel@nongnu.org; Sun, 01 Mar 2026 22:26:48 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by KL1PR06MB6791.apcprd06.prod.outlook.com (2603:1096:820:ff::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.18; Mon, 2 Mar 2026 03:26:35 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9654.020; Mon, 2 Mar 2026 03:26:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tUOyF119OYni7hPQPcUrid0QMs2Po8yMOFhazG1jisCiePWhYqV7zn4bor1tbDWiT77NvzEbYQ8wvrF5rTr4iDLhoaM9UkpoQCWFNXVTBKaxrZL2JLdyGpDFeQcp+BS8G8D3ecKnofyblDrIGDDWEEj8u4MHPYPTnKnfv3dSc4pyDj/I03EdWsy2sxo4TNUyLCTFXrYMZqUXBw9zCX/hIxUnAYyZZAc/YQr8HVA0oLv3Db2LGwLWu8PNsKiMZNvcZcK+zTKlYunmnJCsf1R//ugL3YB5DWl66cGFSntjuj2WpIvizwZnHyi5pYhC+Qc/8cLpFl2tBmo7l/YxJ9ZcEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvEJGeOvlf2VS3EdrA9TayxlYmmfvYAFY34/RXZCbzE=; b=xH93NFV6olIvu293A8eBDyw7u85T4Zjkc4ZCtwf7q9rdQTBP4vs3TUmJi7ZjQE7X8qWaxNTyp038KoO9bz6JhstLlUxo8gPY73XFhi3DGPJI05z2k0UBkduUmBczUK1K1PH3w5TH7HMiI2h0qZvOPWFlmL1kbicU3Zn4xGqsiU6hFBn23bDu2mJ1slz6AxQD/zFbpTQc4ejbNiWK/DSBbCKpkFO8O0x4RY/j/0m7LgDCjRflBOUTr/W5RFnZNd2KZb2AkNPAh3jojZgecQnK6+I4Mu71EgB2T35guJbexxu+0LzIWgSyr4KbgHFYEtBe+x88o6WQcMLuY8fdDSep7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvEJGeOvlf2VS3EdrA9TayxlYmmfvYAFY34/RXZCbzE=; b=bC9fSaM30dzj/RU/EDXP09mMo1mfUliKh0KKUMWEf1AOv/PKvp+4lnPDyATh6q6xr0+qMreSka7e2EhhsmRUknHbhm6GZw0V1Da8j2ga+Oax1MCNApGU3mEjqt2Azn79ELS8gIIgzWgMbrsFw4UGm3Tt0m5rC3NmogLgeKaAp7nmjSO90ij9BKXUZvSjkK8plQ+oMQFweETHLhmtAZhsHhgQ5R2vITpllSs95nycg80CmpplEt1nqITVMaB8TGrBK/llD4rY/b0Wn9+a1mwD9KQmvw4SUJdvj3OHkQnVHcbnTUzbG5uODi+ecW+PmsrI/NdDXqmFThvHC/uYDXhcoQ== From: Jamin Lin To: "jithu.joseph@oss.qualcomm.com" , "clg@kaod.org" , "nabihestefan@google.com" , "komlodi@google.com" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen Subject: [PATCH v1 4/4] hw/i3c/mock-i3c-target: Simplify GETMRL byte extraction logic Thread-Topic: [PATCH v1 4/4] hw/i3c/mock-i3c-target: Simplify GETMRL byte extraction logic Thread-Index: AQHcqfRfKoShnH+haEGXVD3kCfcONA== Date: Mon, 2 Mar 2026 03:26:35 +0000 Message-ID: <20260302032626.1974743-5-jamin_lin@aspeedtech.com> References: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260302032626.1974743-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|KL1PR06MB6791:EE_ x-ms-office365-filtering-correlation-id: fa538ae7-cc80-4e0c-d369-08de780b81f6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700021; x-microsoft-antispam-message-info: YCIvSIXkLZNc/JlrDUp38GKnokYGZyB3LYbLmSip693ldkrMG/OnNgmwGkZ+S61X4vS5ghGrNkTBq7g06XuOBJSAha3jzXk7t6y9tpiKItmxtTafVH0DVnHmS3YfqH6zhYWcISz4UMZpkIkAOiEoYmxIx4QzzvLiMLywJOdMfi70Lf8LJoBFF0lfXaiJaRR05NH83Zwt+zvPVLL8etu4T4ffgSneGwBucwGzAbwZlO8TN1FnLgTsGJI6RGej+I2aA8lWalB6RR0YrnuKpDzgQDuYizeeH/VnwCFsMxio7J5Ox6WBUyXr7XfHm45gGEumrhAJ6smLWaGr/AjwgX8+RUYNwOQiSu2hf7qYeIGhktBEZLCmHLiyYontB8duiKq4RVYjgi9nSMOprC+ZxvHaOTNl5w2TSb6zltVqwYIzzdd4sFVWmlP389iluHNdZWJx/WtNGuoLsb+yDjFlFM+wH8g3TXByhRIblpZv7RyxIUT0INIp6SmdfyJMbX0IUJ/3q+r3d7JX2cs30jnJXIhN5xh4zYqGQiBVdMlPAM1R56aqfuVjZS6Yd+eEF9puJYdq3NFJF4I954Aa1QHUfUxCuODL43ycymrFmBnnOcq9cmVTkNGuQvWPd7XGyaurWzJfU8NVZNr6IpHw3iisvoLO0a4Q7MEtOpXNedUimV9PvuaocjPxvRVwawqsOtUOkliy4z85LbbBR5plcp+Vdu7OwEa+YXa16SwrplbL0CxyeEVDhx9FGwDH2MxaAgIwKzMUQJ5gGzJUUDEF5T2QolHHcHZDd4fl8c/XQBW7H6pUNG4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3JNZaq+b2yEKbepk4pBdjZEbMHzZCyVWa5AHMoGisscpKlripqU76QaT2rI+?= =?us-ascii?Q?paw3uNj7/24oxFmCaSD2kK817YS+MsJYyMHLKY7e76aLs6BPHQhjmvEUVfmK?= =?us-ascii?Q?HUcOpxT/7AzDBuNAYDnZdmMPIRbmLBbyrT1Y0Erh2AO8G5rvJAqcIj3SO0ot?= =?us-ascii?Q?OpuBRCeacaLYLygh3Pc/8xzLhFnfXECL3+YGBMpM0bZGse40BS9nTC1I7fCq?= =?us-ascii?Q?oSDlBol/Hwh6gr+S6RwxBRfqTg9NdMjv36lOJ54SX37Km1k0wudg67X1277v?= =?us-ascii?Q?+MYihIXUQOv681KUJKEaAtjh1T39VppD/x0a01OOuKRn4kSFZRssJ54FGpwe?= =?us-ascii?Q?IjKW/d86yJcYN1CMy3De5ssCx7yn00d/E/0QgqSQQFsUVXCGnHUEOqG1wpcs?= =?us-ascii?Q?+PHwfJyxJ1edpZbNLPm0FCmH7L46Ex4E0WeTIY4663BM6TZmaM6KCwgTDu36?= =?us-ascii?Q?vhxMaNRt9KRKnobHXy0XusoUTmGjVSFYVSmmLxSXt+jrL/dUIIWcVMdBwEmO?= =?us-ascii?Q?YzkBIFUfvaqamEA0sAkgHrdWpNRbehN92K/cDPEezbE+oPdcIPVUw4xTB1M0?= =?us-ascii?Q?XIHmTkOd/rSgTjiH72BDIlLZD6Sa6/cww0pMr8Wq1TXlazx0eT5k+yMFU9CI?= =?us-ascii?Q?zyg+G31Y48d14MoT4jN3lnIUTiU62O+CA4KsP0m8/9gZYnPM3MDB9SXxPeBs?= =?us-ascii?Q?pAdtjo5vXn8qZM9tytFmE0EgKr8LdND/KvJcaeRBnKFPDpvxEPlk0kMvGG+i?= =?us-ascii?Q?36yiXQ62RRVze1PcW1rqeWhDSIvlkYFROkmenE8WODuJzbvEK/D5Sh8br2u2?= =?us-ascii?Q?8/2IC4gefuKS2+MZLPI//hED2XDNhaSsU2a4bQeV1m2Jblyf5Sp1wfKi5yWW?= =?us-ascii?Q?d0HItC/U71WUAyow7Nq+VnqxwY5uT1XLUg9SQetkiFucjvU5QBFYohkZmeS4?= =?us-ascii?Q?LlxKmqH1/y1i9gJZh7427tKlirKFFzdE1sfggb6pOWlGz1Mcieb+dNL7WZr5?= =?us-ascii?Q?p4tEdxrDhDdhnUzJIqPGg2Sgepc3vgwjMM4PleKcdwKNfZ8OPrSx57AuSHh+?= =?us-ascii?Q?NIqvGttWXcPT6Gx5+4aUQkcneJDHugxhDTG3SJ5kd+288QdJ4lJJR7EuEyls?= =?us-ascii?Q?OGi06YgQXZMSgS4Jd6x0KB2uuO0FQFnVfXrYgNX5gExRlLMUkF/c2nPwanZa?= =?us-ascii?Q?mEfrArm6zIsOP39050fFSCFgMRwYGrNjKUHvv6+3bTJfmzCgl3Uq4lxyyPak?= =?us-ascii?Q?wtXYkmADpUVSDHfYqOBnfThimMtkgYIJ0Y/+0w8wPgxRc4aNkX6Y5AOJ7FVY?= =?us-ascii?Q?2GXWPAHOH+7yFK2PRRSN2LvepoCZWpSWA0FVlZckxTxw08WNzya9LqpJ2YL1?= =?us-ascii?Q?axsi/oBhQFZLX4DE4wePWlp6llFDtj2P7qmM1Kmi5dli76WwEcoYUzPDIdmK?= =?us-ascii?Q?ShlbfC+2wbO4rZ6UHiLUQczJNbB4Lo2gBt2QwKqomBI2sZ9/LSVEk1nQ4uN2?= =?us-ascii?Q?WZRdJbD9I+Ao02A7A/fI5kfml1YkfTYgIEdxbA6d50sI4V8GKgU3TiE4rJqI?= =?us-ascii?Q?i3PBmkNIzYCwRDc/UjjaDcjAoFvORVyHh87wvgbHdiq4vn5K11eRf0ubUWp2?= =?us-ascii?Q?kziVBlHuY0hh5Hrh0tu64lW/kCk+D8Yf/EaSGz4elaRHrdfQbryOenoR6eJ4?= =?us-ascii?Q?LtMuPyHFXdgmTf1OtJ2mB4QUJaG85XByvG2FcHn6WVLaLaknBdLKz/vel6Pc?= =?us-ascii?Q?06mKqLDkNA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa538ae7-cc80-4e0c-d369-08de780b81f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2026 03:26:35.3516 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rIKNx37EV3kC7Wsnl60RycIY0Ih2wCN0EKHuSddHqcyhINN+sMHfKMAT+GWTsKXAFIaHyNG7MFL3bF9j00D0ESdVBKZK0KgXU3v+sKzymgE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6791 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c406::3; envelope-from=jamin_lin@aspeedtech.com; helo=OS8PR02CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1772422017789158500 Content-Type: text/plain; charset="utf-8" The GETMRL handling logic extracted MSB/LSB bytes from s->cfg.buf_size using a mask-and-shift expression: (buf_size & (0xff00 >> (offset * 8))) >> (8 - (offset * 8)) While functionally correct, the expression is difficult to read and obscures the intent, which is simply to return a 16-bit value in MSB-first order. Replace the mask/shift formula with explicit MSB/LSB extraction: offset =3D=3D 0 -> buf_size >> 8 offset =3D=3D 1 -> buf_size & 0xff This makes the code clearer and easier to review without altering behavior or data ordering. No functional change. Signed-off-by: Jamin Lin --- hw/i3c/mock-i3c-target.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/i3c/mock-i3c-target.c b/hw/i3c/mock-i3c-target.c index 5c913ee49b..845c173427 100644 --- a/hw/i3c/mock-i3c-target.c +++ b/hw/i3c/mock-i3c-target.c @@ -145,9 +145,12 @@ static int mock_i3c_target_handle_ccc_read(I3CTarget *= i3c, uint8_t *data, if (s->ccc_byte_offset >=3D 2) { break; } - data[s->ccc_byte_offset] =3D (s->cfg.buf_size & - (0xff00 >> (s->ccc_byte_offset * 8= ))) >> - (8 - (s->ccc_byte_offset * 8)); + if (s->ccc_byte_offset =3D=3D 0) { + data[s->ccc_byte_offset] =3D (uint8_t)(s->cfg.buf_size >> = 8); + } else { + data[s->ccc_byte_offset] =3D (uint8_t)s->cfg.buf_size; + } + s->ccc_byte_offset++; *num_read =3D num_to_read; } --=20 2.43.0