From nobody Mon Mar 2 10:13:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1772128642; cv=none; d=zohomail.com; s=zohoarc; b=N17dCy75rpOMSeC2vIIEeJvXfb/lp4F/bZV5hMePT0m5OyxGB+GV5eP6A8vj1g5ASKxN2841BjltsHAwMlq1kvZ0PTVB/gUNAl9MLtuGZjIGUbS0Fn6k+0RKXM2FGOpBqVy5hQRW4qXfzIdWOSj6KAfbNlOdsp1UpfjjFYhW3VI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772128642; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VULc4I47qnB/aEbsYNXu0BHGq7e6dxcofayMYitg7Is=; b=jnfsoezQnlZNgcYypk8IlHOPUiDLZ1TC3xGLEdYGCQUzmPuL46kGG86NC4Q/sXnKeyPhXmB9Ja6G8M8x8KX0KnoO08BPiQB5NU9/i11P+Z5dqLjLeoLIF1RXykEeWrivpqkbTemzqW/OrNGbmcYeZqG6z4vjhgcOjb0mYk3r4PQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772128642039516.2896649787191; Thu, 26 Feb 2026 09:57:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvfbv-0001td-61; Thu, 26 Feb 2026 12:57:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvfbr-0001tH-Gu for qemu-devel@nongnu.org; Thu, 26 Feb 2026 12:57:11 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vvfbn-0001K5-Eh for qemu-devel@nongnu.org; Thu, 26 Feb 2026 12:57:10 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-482f454be5bso21903695e9.0 for ; Thu, 26 Feb 2026 09:57:03 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd702e7bsm179257525e9.5.2026.02.26.09.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 09:57:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772128622; x=1772733422; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VULc4I47qnB/aEbsYNXu0BHGq7e6dxcofayMYitg7Is=; b=gfBs2j5XkKUxUibonm+EpGUuV0dqepe6SE320l4jcpb0mnaVznexsTdj+K70n5l//1 uO8c8otqPuWKZb5LKnoF/4OcDgBZDYig1UToDjYTL1vULt1ZJfBJGM1rAoQ91MijOEwy RniNhxeV0ySO7tMEJA5AGEE3YEfnxot59unwVA683VCpRWyhWMKAAJ6cQlad21lQQ1nx txwpwLLWrQZ5ER7UpE6BxNuO376r/7OBfi3P9WVQmN3U1dABRf8hfytGiUj9RcjKnTlz 2BPkYYdaqYnVkRr1fc+jZtAy8KuagfZfTpp3RbsV3Fin+Ps9yh3LKGBBNUOvPwJVrDoy RaCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772128622; x=1772733422; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VULc4I47qnB/aEbsYNXu0BHGq7e6dxcofayMYitg7Is=; b=pxpeZIja+wcBS4hqfvCY7EbJp59DPF89yf0+k82AOdtdI77IrjPks9R/GwDkTwEH1u aWdTC0qDmdCiC0t4BevS+o3jzTm8Vlym4WOltp1HmPZey729X03lBiS0NHUc6Ap7PiMo 14dWhP6WHaEq4Qcbd5eroLsc+WaFSuiZ0+PNg2s5H49ydvFH818x1hgVTiTCqbRFJQHR gaTXBhQiUV62kkCmoY4TbOLnQPTqQ4WWmvXjIzqrp6hM6+Kah10AqQz3/avnD/nnOuEH q0y6Q0HywY0KLIDgPQrSNfTldh0kW3aQTb/v1rdmSaQe7TpN2lGBTAYh1RJonnF+LZMG Fzrw== X-Gm-Message-State: AOJu0Yy70EhwVpez+TId0D8ZJD32XoIMoXyWBwuOoSuXdcvYp8Ar3K8n CqLNPeNbb6etyQI+6Wi3wXQpOoEM3zwReb5CicY7CBQinULpuFoEX9H/NFtmouyf/q/71UV4g1r z0mYo X-Gm-Gg: ATEYQzwMQsPECALa+o7jZpCdf4PPI68NvDoKNQTPkc/URgfHE8gWpX4/EiqwWIXOnb/ PPjT1v4g+jl8NKR66gBzeNFUtGNK5pc+FRb555bmpDSjEOT8Hi2M1LGOFD+eSHQ2GBZfBay5N6u PiDAPYAi7ZDobSQcjRfsWbYBj1fFnoQ2tRfyUnG7hQgbDX/ptlb4GrR9hygLzjDhBI+3zJYCIEl JfjA+qvHfuaQLAGzgs5lppGxMl7i4GYhv+WZThc7Bfp/Ddr0jG9lis7v8YYBL4AxMsn1T0cro1M +LyfcGQNSnaQ3czdLBNnBmG2aFcNUY3ViAtDXGGwgVM8yeB4U68RsJwe+TGqWhviboNDfdAIzJX qdiyAftEh/U7bcVzZAgWzEzSGvBJ/hRedyatYB2bhJADH/NpbDO0VZ0C9YCqCYz9BFEjav0zCgX +nbiz6UYLpYCOD/6IiuupxhmI7ggOvcJmq/dsLpWjBdunngVOTSoIM1pS37gamfVfCZtEnGOiLz oavbhcP6tKRU78bY5HKWjcooraFJ8k= X-Received: by 2002:a05:600c:8b71:b0:483:7ea3:3de3 with SMTP id 5b1f17b1804b1-483c33c3606mr66284865e9.2.1772128622006; Thu, 26 Feb 2026 09:57:02 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Laurent Vivier , Paolo Bonzini Subject: [PATCH] system/qtest: Support comments in input commands Date: Thu, 26 Feb 2026 17:57:00 +0000 Message-ID: <20260226175700.1319767-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1772128642306158500 Content-Type: text/plain; charset="utf-8" Allow the qtest input to include comment lines, which start with '#'. This allows writing an input file for qtest which includes commentary, like this: # set up TCR in bank 0 write 0x1001000e 2 0 # TCR TXEN write 0x10010000 2 1 which can make hand-writing or annotating reproduce cases a bit more convenient. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- system/qtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/system/qtest.c b/system/qtest.c index e42b83ce67..cf90cd53ad 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -71,6 +71,7 @@ static void *qtest_server_send_opaque; * * Extra ASCII space characters in command inputs are permitted and ignore= d. * Lines containing only spaces are permitted and ignored. + * Lines that start with a '#' character (comments) are permitted and igno= red. * * Valid requests * ^^^^^^^^^^^^^^ @@ -370,8 +371,8 @@ static void qtest_process_command(CharFrontend *chr, gc= har **words) fprintf(qtest_log_fp, "\n"); } =20 - if (!command) { - /* Input line was blank: ignore it */ + if (!command || command[0] =3D=3D '#') { + /* Input line was blank or a comment: ignore it */ return; } =20 --=20 2.43.0