From nobody Sat Apr 11 06:11:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772075817; cv=none; d=zohomail.com; s=zohoarc; b=S4yEJ16bwzoyPZO0LpKJInH1nBtbfTmT2gHhonA7MG48z68r6KXqdD4lAEeSeDtQUv21JeYO11KnS/6Hlk0nJ1eRCFHHpZiikD0IbFWvVHWpPIhNNztTVHAvsx/3Tyk18BdYjh0e8bYGtR8hfYp2yzyqvWmidi+UGzImvD475Do= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772075817; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TpAKj43cib22IuMyJbqH1W6yTVANl6eh+qWhnRWv5WI=; b=WlCMQsL8R9DlWxw0VFG75+70DK3LvcQfLJD+yqTbXhvjznvW8dFMzWtldhjJnZqouc2jBWOHy9KvCn7WzL5BQmp+kEUtPnUwNsDea17KQpP90ciTeiEpPDBWnPJtuFf/dtLmtfu0YiWXTNwTJ4hI8vXH4pK7p+SJPbgmpvDGntw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772075817406618.4679342139442; Wed, 25 Feb 2026 19:16:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvRrr-0003bk-DX; Wed, 25 Feb 2026 22:16:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvRrp-0003bL-M9 for qemu-devel@nongnu.org; Wed, 25 Feb 2026 22:16:45 -0500 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vvRro-0004h0-Al for qemu-devel@nongnu.org; Wed, 25 Feb 2026 22:16:45 -0500 Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-8c6f21c2d81so32881085a.2 for ; Wed, 25 Feb 2026 19:16:43 -0800 (PST) Received: from localhost.localdomain ([207.98.184.46]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899c715af1fsm7376156d6.1.2026.02.25.19.16.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 25 Feb 2026 19:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772075803; x=1772680603; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TpAKj43cib22IuMyJbqH1W6yTVANl6eh+qWhnRWv5WI=; b=iyOpp+FXJ+3rBKZINiC0Ko9DAQafNu2E6vAIREr0/eQMOyxN3wYNcE3D7PzFpUUo1a waCQYjLquAp4uTCLCIdOl7jku3aNF6nsQDl2MScK0UdVfQcJ+/QFBnBVOGZaGarmfhex CtKca06XTIJozhH4OLHHGcAT7LFNEgbDp6gLoA/IQw+erMIMMG+ve+Be+8EsG633dz6B c9lpCIAoeJsfbCQyI8/iBOlMTjWTzsHPowonywfSfERarJinwFqVTlTUVi1brskymk4z 3HGnNP73SqRAXOD/R7ZcelFay0bO4ugSLsfCDkJXDMCRmPg35cpHktDYK9KjttAtIWfT 4s5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772075803; x=1772680603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TpAKj43cib22IuMyJbqH1W6yTVANl6eh+qWhnRWv5WI=; b=GkJ4t56lc92z0C48JHFsD93xZC1vq6IjL9fgXlfkf4nvt4qAdXnfIfHeT3p7vJOhK2 THAZSynm9ZYfNs/IahLbWj0LSV0SFr0kKP0/zbgYgKofOt56Gs4kYR+qRO2VS2Zo+Qcg ldFWC+xexi7UZSTPKszp9zcn588ZHqmJYRUOiijaNSBhTH6ftvPzra7EqmT7woUuPfg/ OTZJ9yuj0XWDo6tkYTKUP/nuPfQr+/km+aGV6BPLflbnLIX2SLJTI1KZ9nmd2/LiuM6z NW+VHY41p7MjAxhJY6Uz40W5pS38rfEk3tmBB923vLByYVj4uwFS3JVqQ1d9lqiQJWD2 2wGg== X-Gm-Message-State: AOJu0YzXB9/0n4d3Nfsvst6MA4l/RIDGn9GrGexR7fnCqDIP7MVf5G8V mI89G15CsBdpwBjv8FsVeHt5eCCTeYTz7oj5GblyOOtpA5laF3OHP80nwFI9nQ== X-Gm-Gg: ATEYQzxeYcWxOsBZSlNWIgbfaWU/9cK/3wG/1dViqqhIiAe+UIj3DWuJMUaxXdeiEhp owv5HPYh4DFJB0IoB7P6IXFcq7tTZw706c5raHIa/aDAKBzL9TTSdddnZntqokmEWWy1N4ZlpgU A7S7a9muzrfecJdEirJlR3GGa/4v8FYZCaeltwxVaPEUSpPvHU6MRBOVNruXeEGbajHuW9gh6pw GAPOqJl6PFFi77xBHHWFxzh62zgfNnTrs8UQi6hrz0cggEFF0/EGFMTbprMgmCGtM8QvDPbvjEC A/XYihxmOPeZ1W89DBTiHVfXJ2PIqB63kap/XD7cmyMuw7dicR+SgeC7xkKfl/YGuelK6YF2s6J SozYn8lTJ3gZbnHxUupn9MbbUANoQdNp49EgTJ4TENoRCccsSo4BPm3+tZSWONN8Af4JwjPuLkD SIJE5nhAIA+0kYTWtaDBUkU9NKA/FA2rk0mHmL9ETdsTpHV/u84+E= X-Received: by 2002:a05:620a:4607:b0:8c9:f996:81f2 with SMTP id af79cd13be357-8cbc1102522mr79916085a.17.1772075802989; Wed, 25 Feb 2026 19:16:42 -0800 (PST) From: David Hamilton To: qemu-devel@nongnu.org Cc: David Hamilton Subject: [PATCH v3 2/2] hw/misc/ivshmem-pci: Check error after setup_interrupt() in process_msg_connect() Date: Wed, 25 Feb 2026 22:16:33 -0500 Message-ID: <20260226031633.12369-3-dahamilt0@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260226031633.12369-1-dahamilt0@gmail.com> References: <20260226031633.12369-1-dahamilt0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=dahamilt0@gmail.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772075818007158500 Content-Type: text/plain; charset="utf-8" setup_interrupt() can fail and report via errp, but process_msg_connect() was ignoring the error and continuing to ivshmem_add_eventfd(). Check the bool return to avoid operating on a vector whose interrupt setup failed. Resolves the TODO comment at the call site. Signed-off-by: David Hamilton --- hw/misc/ivshmem-pci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem-pci.c b/hw/misc/ivshmem-pci.c index c987eebb98..147e8223bb 100644 --- a/hw/misc/ivshmem-pci.c +++ b/hw/misc/ivshmem-pci.c @@ -553,8 +553,10 @@ static void process_msg_connect(IVShmemState *s, uint1= 6_t posn, int fd, } =20 if (posn =3D=3D s->vm_id) { - setup_interrupt(s, vector, errp); - /* TODO do we need to handle the error? */ + if (!setup_interrupt(s, vector, errp)) { + close(fd); + return; + } } =20 if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) { --=20 2.50.1 (Apple Git-155)