From nobody Sun Apr 12 06:08:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772021639; cv=none; d=zohomail.com; s=zohoarc; b=PoRFw5ioGOakKmUyzFeUSVh72QSleS5WeDR571Sn/6wdSBPZQafaQ6frIqdsTdSQ/ZIqA05jJN9t9vXXkS+WJHl9ToCpQjivOtkMqx7ayeDwXS3KWTeiTktcVDTpDI8M5Puwkh+z86w4QkPRfirEWkRWAXsaZ9qAHG8D9Ky0STM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772021639; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TSYA1Q4q/L6p22kNI5axX3mj2bIY09wz5eUmq35S9i8=; b=YPswvRZyk4lEwcxMNI6tzs++k5bT8TwnUs8lDpTua3D/hz+OE9irV03Ca2knYGQJXYAlYsUJ7p4j4KH07q6Mtfsr4TCuZAAwh4Qpy5jhTTT5Umj93o0xJ0iHkKOjyhKzPDDKp2Bwmxg/DK4an1mua9OjeIkCYIiCOYTgZ2hVC6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772021639633380.63885048975135; Wed, 25 Feb 2026 04:13:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvDlp-0006z0-0p; Wed, 25 Feb 2026 07:13:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvDll-0006yV-Gn for qemu-devel@nongnu.org; Wed, 25 Feb 2026 07:13:33 -0500 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vvDlj-0005V8-Qz for qemu-devel@nongnu.org; Wed, 25 Feb 2026 07:13:33 -0500 Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-897002b7576so89060156d6.3 for ; Wed, 25 Feb 2026 04:13:31 -0800 (PST) Received: from localhost.localdomain ([207.98.184.46]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8997e77aedasm115830606d6.53.2026.02.25.04.13.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 25 Feb 2026 04:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772021610; x=1772626410; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TSYA1Q4q/L6p22kNI5axX3mj2bIY09wz5eUmq35S9i8=; b=QnM5teLsRFPLNNb/6V8Xu8IGzMuoBRbIEp5OQn8EgpADp3DGs6ZzrJyzo7UAo8lCcQ indFSa+zW4POBrGjNvrTyLJiFaK5X8/qtmYbiEVqHVp9bfA3d8DKTz+V36MRGPg3sVMP A4OLeiF2VAVx9BGpqXmxkhc4bjG31RTBbX9QQhtSr+QpWScXlOFng+n1jJ9q6fOw0DB6 9c48VMHgIjEbMN+zbVF7jVwcWj769d708f9/xcYkG5Dmy6lhZ3NznQFjmTqMze66khgj iOUiAclcGOQ1BKnsnyfVMcWBjWz4dGH1dZ2MdtJOqkW8Onezj6VRKJWrKE6S73rSaizZ UnrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772021610; x=1772626410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TSYA1Q4q/L6p22kNI5axX3mj2bIY09wz5eUmq35S9i8=; b=q/q8IvOWzCl02K+OgDBv0XrM/ZexkRyrIgCekcE6UWDFbClKLM2u5yNwxrP8HrNxLp phQANug5olcFcxG1HSYdQr9WLJXmyXpU6AYFj2JgkOrFCNC+M9ET7GjRs8MraiISdScO 1k3zz48PTWat+U39Mz0HEq50QxxBV2gTgMJfhqMY9ftRAJuImbQwYtMlagiexTrMspZ0 8lpNpE3H22ct4i/WZZB2Ig1PmkSxeJjJwEVRq8R6C2ovTX01ytK9b7IMq3nD6JEsdxXh br/ZWX0SomFZyXbHkWObG+tJELUGIJCj81yA+JHd8027B/Nv7LtlFYQ9ZhQB+56BE6uD ZC+A== X-Gm-Message-State: AOJu0YzkvSFAaHgyAzRFqD9rfgazfpE/ujMKeY2q8bJAAWayanU6fdej Z4D862NO88UI1GsYCtQIDvFXHHyewKCm8Wn0stOpVigiIX6VDBWCQ/s3hpqJCA== X-Gm-Gg: ATEYQzzFBB7wKqeKFGiG3WAy8paH0lO2qsDN+TJ9N7/cP9AQctea2eGI4Z7xtYWw4AM SOytiy+Lofd/XryPfWHPkbHOIcDXCzRrMX87prHCO1xQLtHdN5oLckEhMoDfVXf67I841eHDUBi CXrhSCLmhK3bn4Y1j+lTOYHO9a9owUaATAiKqczTvGpX02AJPwhQLSlX/P9x37yqKcva8mLtZYr ERXepWelzaZCFIhsTo74R+JbLy250C2IvgeG9U5ncqyKxqPcoWxdmJI+KSmLGHO0fDSyMUyEBmK zVfOhsvyZTYZCS/jhfycIQROLA14jKdj4q2xwE2z/wLkhsgq++EWiXISAqH/swt1CjsbUjilWwM UDsAWiGXRmIY0WA0ToiwPImcm004bTwuMrreC3bEYpTd8aZhmqaRPIrZCaBKruowrtViaaEJTW7 ZS3N2jgjjrlmtOol8OjoPE8iQfhOu3on/nUcqwQRhvN34zK/HSLGQ= X-Received: by 2002:a05:6214:5099:b0:899:befc:5eae with SMTP id 6a1803df08f44-899befc6cedmr5927466d6.11.1772021610270; Wed, 25 Feb 2026 04:13:30 -0800 (PST) From: David Hamilton To: qemu-devel@nongnu.org Cc: David Hamilton Subject: [PATCH v2 1/2] hw/misc/ivshmem-pci: Handle error from kvm_irqchip_add_irqfd_notifier_gsi() Date: Wed, 25 Feb 2026 07:13:22 -0500 Message-ID: <20260225121323.5395-2-dahamilt0@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260225121323.5395-1-dahamilt0@gmail.com> References: <20260225121323.5395-1-dahamilt0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::f2f; envelope-from=dahamilt0@gmail.com; helo=mail-qv1-xf2f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772021640366158500 Content-Type: text/plain; charset="utf-8" The return value of kvm_irqchip_add_irqfd_notifier_gsi() was being ignored. Propagate the error to the caller via errp. Also change setup_interrupt() to return bool to follow QEMU error handling conventions, making error checks at call sites simpler. Resolves the TODO comment at the call site. Signed-off-by: David Hamilton Reviewed-by: Markus Armbruster --- hw/misc/ivshmem-pci.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem-pci.c b/hw/misc/ivshmem-pci.c index a3a43f53bd..c987eebb98 100644 --- a/hw/misc/ivshmem-pci.c +++ b/hw/misc/ivshmem-pci.c @@ -442,13 +442,14 @@ static void ivshmem_add_kvm_msi_virq(IVShmemState *s,= int vector, s->msi_vectors[vector].pdev =3D pdev; } =20 -static void setup_interrupt(IVShmemState *s, int vector, Error **errp) +static bool setup_interrupt(IVShmemState *s, int vector, Error **errp) { EventNotifier *n =3D &s->peers[s->vm_id].eventfds[vector]; bool with_irqfd =3D kvm_msi_via_irqfd_enabled() && ivshmem_has_feature(s, IVSHMEM_MSI); PCIDevice *pdev =3D PCI_DEVICE(s); Error *err =3D NULL; + int ret; =20 IVSHMEM_DPRINTF("setting up interrupt for vector: %d\n", vector); =20 @@ -460,18 +461,22 @@ static void setup_interrupt(IVShmemState *s, int vect= or, Error **errp) ivshmem_add_kvm_msi_virq(s, vector, &err); if (err) { error_propagate(errp, err); - return; + return false; } =20 if (!msix_is_masked(pdev, vector)) { - kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, n, NULL, + ret =3D kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, n, NULL, s->msi_vectors[vector].virq= ); - /* TODO handle error */ + if (ret < 0) { + error_setg(errp, "Failed to configure irqfd notifier"); + return false; + } } } else { /* it will be delayed until msix is enabled, in write_config */ IVSHMEM_DPRINTF("with irqfd, delayed until msix enabled\n"); } + return true; } =20 static void process_msg_shmem(IVShmemState *s, int fd, Error **errp) --=20 2.50.1 (Apple Git-155)